)]}'
{"cinder/volume/drivers/hitachi/hbsd_basiclib.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f05bfee975412a4641eb06bf808aaf4e99382c56","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        super(FileLock, self).__init__(name)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def __enter__(self):"},{"line_number":201,"context_line":"        if not os.access(self.path, os.W_OK):"},{"line_number":202,"context_line":"            msg \u003d output_err(633, file\u003dself.path)"},{"line_number":203,"context_line":"            raise exception.HBSDError(message\u003dmsg)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b48da6d4","line":201,"updated":"2015-07-02 19:07:30.000000000","message":"Why is this check necessary at all?\n\nI think the answer here is to not depend on internal details of InterProcessLock...\n\nIf you can\u0027t write to it, won\u0027t the acquire() below fail?","commit_id":"46a1b9c6058a6017708fa2029523e5706cff4ff2"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"1bb9b60d7550671524fcac2ea0c070a39a4304a1","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        super(FileLock, self).__init__(name)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def __enter__(self):"},{"line_number":201,"context_line":"        if not os.access(self.path, os.W_OK):"},{"line_number":202,"context_line":"            msg \u003d output_err(633, file\u003dself.path)"},{"line_number":203,"context_line":"            raise exception.HBSDError(message\u003dmsg)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_6a8cfdd9","line":201,"in_reply_to":"ba3cc151_b48da6d4","updated":"2015-07-03 12:06:12.000000000","message":"I think you\u0027re right. I tested here, even removing this comparison, the error is raised if lock file is not accessible. Done","commit_id":"46a1b9c6058a6017708fa2029523e5706cff4ff2"}]}