)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2a4921df3cd2549ec787f868e6a57d67dfba8f36","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Diem Tran \u003cdiem.tran@oracle.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-01 21:23:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix PEP 476 and debug format messages of Oracle ZFSSA Cinder drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Handles the PEP 476 by opting out certificate verification."},{"line_number":10,"context_line":"* Fix debug format messages in restclient.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_a710f300","line":7,"updated":"2015-07-03 15:29:08.000000000","message":"Summary line should be limited to 50 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"c21ef71122ecd610b3a97c22c35883862d47797f"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"fc4ee6462a77665a25bbe54876b40a9aceb18c82","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Diem Tran \u003cdiem.tran@oracle.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-01 21:23:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix PEP 476 and debug format messages of Oracle ZFSSA Cinder drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Handles the PEP 476 by opting out certificate verification."},{"line_number":10,"context_line":"* Fix debug format messages in restclient.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_6e1db50e","line":7,"in_reply_to":"ba3cc151_a710f300","updated":"2015-07-06 15:41:05.000000000","message":"Done","commit_id":"c21ef71122ecd610b3a97c22c35883862d47797f"}],"cinder/volume/drivers/zfssa/restclient.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2a4921df3cd2549ec787f868e6a57d67dfba8f36","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"            break"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        if response and \\"},{"line_number":330,"context_line":"            response.getcode() \u003d\u003d http_client.SERVICE_UNAVAILABLE and \\"},{"line_number":331,"context_line":"                retry \u003e\u003d maxreqretries:"},{"line_number":332,"context_line":"            raise RestClientError(response.getcode(), name\u003d\"ERR_HTTPError\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_47ea47dc","line":329,"updated":"2015-07-03 15:29:08.000000000","message":"Please wrap the if statement conditionals in () to avoid using \\ for line continuation.","commit_id":"c21ef71122ecd610b3a97c22c35883862d47797f"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"fc4ee6462a77665a25bbe54876b40a9aceb18c82","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"            break"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        if response and \\"},{"line_number":330,"context_line":"            response.getcode() \u003d\u003d http_client.SERVICE_UNAVAILABLE and \\"},{"line_number":331,"context_line":"                retry \u003e\u003d maxreqretries:"},{"line_number":332,"context_line":"            raise RestClientError(response.getcode(), name\u003d\"ERR_HTTPError\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_ce8e4127","line":329,"in_reply_to":"ba3cc151_47ea47dc","updated":"2015-07-06 15:41:05.000000000","message":"Done","commit_id":"c21ef71122ecd610b3a97c22c35883862d47797f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"71dac50fa425543a168533dda4a42c383d23935f","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        retry \u003d 0"},{"line_number":271,"context_line":"        response \u003d None"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027Request: %s %s\u0027, request, zfssaurl)"},{"line_number":274,"context_line":"        LOG.debug(\u0027Out headers: %s\u0027, out_hdrs)"},{"line_number":275,"context_line":"        if body and body !\u003d \u0027\u0027:"},{"line_number":276,"context_line":"            LOG.debug(\u0027Body: %s\u0027, body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_d09daa5a","line":273,"updated":"2015-08-03 15:31:58.000000000","message":"Please use named interpolation instead of positional.\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-translated-messages","commit_id":"1d5b7d179e74701c85e294a0422fac960b4daf24"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"986f321f5ebfaa4014d6fd34990b2fb1e8f81af0","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        retry \u003d 0"},{"line_number":271,"context_line":"        response \u003d None"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027Request: %s %s\u0027, request, zfssaurl)"},{"line_number":274,"context_line":"        LOG.debug(\u0027Out headers: %s\u0027, out_hdrs)"},{"line_number":275,"context_line":"        if body and body !\u003d \u0027\u0027:"},{"line_number":276,"context_line":"            LOG.debug(\u0027Body: %s\u0027, body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_9a114eaf","line":273,"in_reply_to":"1a4dcd0f_b6c1e730","updated":"2015-08-04 12:15:03.000000000","message":"Agree with xing-yang and Sean McGinnis, it\u0027s saying very clearly in the link xing-yang provided.","commit_id":"1d5b7d179e74701c85e294a0422fac960b4daf24"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"7cf771d20c63631c24ee4a1cecb54a1603bdc9e1","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        retry \u003d 0"},{"line_number":271,"context_line":"        response \u003d None"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027Request: %s %s\u0027, request, zfssaurl)"},{"line_number":274,"context_line":"        LOG.debug(\u0027Out headers: %s\u0027, out_hdrs)"},{"line_number":275,"context_line":"        if body and body !\u003d \u0027\u0027:"},{"line_number":276,"context_line":"            LOG.debug(\u0027Body: %s\u0027, body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_9fc4ce5f","line":273,"in_reply_to":"1a4dcd0f_b6c1e730","updated":"2015-08-04 15:54:30.000000000","message":"Fixed in patchset 5. Thank you!","commit_id":"1d5b7d179e74701c85e294a0422fac960b4daf24"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"b643b6f694937bfb6c17b4dd021d892b9e670188","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        retry \u003d 0"},{"line_number":271,"context_line":"        response \u003d None"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027Request: %s %s\u0027, request, zfssaurl)"},{"line_number":274,"context_line":"        LOG.debug(\u0027Out headers: %s\u0027, out_hdrs)"},{"line_number":275,"context_line":"        if body and body !\u003d \u0027\u0027:"},{"line_number":276,"context_line":"            LOG.debug(\u0027Body: %s\u0027, body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_d0ecca91","line":273,"in_reply_to":"1a4dcd0f_d09daa5a","updated":"2015-08-03 15:47:45.000000000","message":"Thank you for the comment. \nThe guidelines only apply to translated messages. I don\u0027t think debug messages are translated, hence no need to make it named interpolation.","commit_id":"1d5b7d179e74701c85e294a0422fac960b4daf24"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dbbec5ff81df10cadbe5f57b6ca89d9b2dc16423","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        retry \u003d 0"},{"line_number":271,"context_line":"        response \u003d None"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027Request: %s %s\u0027, request, zfssaurl)"},{"line_number":274,"context_line":"        LOG.debug(\u0027Out headers: %s\u0027, out_hdrs)"},{"line_number":275,"context_line":"        if body and body !\u003d \u0027\u0027:"},{"line_number":276,"context_line":"            LOG.debug(\u0027Body: %s\u0027, body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_b6c1e730","line":273,"in_reply_to":"1a4dcd0f_d0ecca91","updated":"2015-08-03 22:22:19.000000000","message":"The intent of naming is not for anything related to translation. Any time there is more than one formatting variable (and often even when there is one) you should use named variables to make sure it\u0027s clear where the intended position should be.","commit_id":"1d5b7d179e74701c85e294a0422fac960b4daf24"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"54a4e29de7c2b5a2b6dae080626e29ed5f0ee0b3","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        retry \u003d 0"},{"line_number":271,"context_line":"        response \u003d None"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027Request: %(request)s %(url)s\u0027,"},{"line_number":274,"context_line":"                  {\u0027request\u0027: request, \u0027url\u0027: zfssaurl})"},{"line_number":275,"context_line":"        LOG.debug(\u0027Out headers: %s\u0027, out_hdrs)"},{"line_number":276,"context_line":"        if body and body !\u003d \u0027\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_4fce745b","line":273,"updated":"2015-08-05 07:58:23.000000000","message":"Add a stop \u0027.\u0027 in the end.","commit_id":"814cbb8a937e2a01f2c8814dd032c0f12baa6fd4"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"0fd72a1669031d5d77fcdc42f9240ca49f0d72d2","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        retry \u003d 0"},{"line_number":271,"context_line":"        response \u003d None"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027Request: %(request)s %(url)s\u0027,"},{"line_number":274,"context_line":"                  {\u0027request\u0027: request, \u0027url\u0027: zfssaurl})"},{"line_number":275,"context_line":"        LOG.debug(\u0027Out headers: %s\u0027, out_hdrs)"},{"line_number":276,"context_line":"        if body and body !\u003d \u0027\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_80daf44a","line":273,"in_reply_to":"1a4dcd0f_4fce745b","updated":"2015-08-05 15:07:40.000000000","message":"Hi Vincent,\nI\u0027m not sure why a stopper \u0027.\u0027 is needed. Could you please point me to a guidelines that requires this?","commit_id":"814cbb8a937e2a01f2c8814dd032c0f12baa6fd4"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"54a4e29de7c2b5a2b6dae080626e29ed5f0ee0b3","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027Request: %(request)s %(url)s\u0027,"},{"line_number":274,"context_line":"                  {\u0027request\u0027: request, \u0027url\u0027: zfssaurl})"},{"line_number":275,"context_line":"        LOG.debug(\u0027Out headers: %s\u0027, out_hdrs)"},{"line_number":276,"context_line":"        if body and body !\u003d \u0027\u0027:"},{"line_number":277,"context_line":"            LOG.debug(\u0027Body: %s\u0027, body)"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_efdc2014","line":275,"updated":"2015-08-05 07:58:23.000000000","message":"Add a stop \u0027.\u0027 in the end.","commit_id":"814cbb8a937e2a01f2c8814dd032c0f12baa6fd4"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"54a4e29de7c2b5a2b6dae080626e29ed5f0ee0b3","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                  {\u0027request\u0027: request, \u0027url\u0027: zfssaurl})"},{"line_number":275,"context_line":"        LOG.debug(\u0027Out headers: %s\u0027, out_hdrs)"},{"line_number":276,"context_line":"        if body and body !\u003d \u0027\u0027:"},{"line_number":277,"context_line":"            LOG.debug(\u0027Body: %s\u0027, body)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        context \u003d None"},{"line_number":280,"context_line":"        if hasattr(ssl, \u0027_create_unverified_context\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_cf1604a7","line":277,"updated":"2015-08-05 07:58:23.000000000","message":"Add a stop \u0027.\u0027 in the end.","commit_id":"814cbb8a937e2a01f2c8814dd032c0f12baa6fd4"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"54a4e29de7c2b5a2b6dae080626e29ed5f0ee0b3","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                                                      timeout\u003dself.timeout)"},{"line_number":294,"context_line":"            except urllib.error.HTTPError as err:"},{"line_number":295,"context_line":"                if err.code \u003d\u003d http_client.NOT_FOUND:"},{"line_number":296,"context_line":"                    LOG.debug(\u0027REST Not Found: %s\u0027, err.code)"},{"line_number":297,"context_line":"                else:"},{"line_number":298,"context_line":"                    LOG.error(_LE(\u0027REST Not Available: %s\u0027), err.code)"},{"line_number":299,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_0f462cbf","line":296,"updated":"2015-08-05 07:58:23.000000000","message":"Add a stop \u0027.\u0027 in the end.","commit_id":"814cbb8a937e2a01f2c8814dd032c0f12baa6fd4"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"54a4e29de7c2b5a2b6dae080626e29ed5f0ee0b3","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                if err.code \u003d\u003d http_client.NOT_FOUND:"},{"line_number":296,"context_line":"                    LOG.debug(\u0027REST Not Found: %s\u0027, err.code)"},{"line_number":297,"context_line":"                else:"},{"line_number":298,"context_line":"                    LOG.error(_LE(\u0027REST Not Available: %s\u0027), err.code)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"                if err.code \u003d\u003d http_client.SERVICE_UNAVAILABLE and \\"},{"line_number":301,"context_line":"                   retry \u003c maxreqretries:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_ef4ae0c4","line":298,"updated":"2015-08-05 07:58:23.000000000","message":"Add a stop \u0027.\u0027 in the end.","commit_id":"814cbb8a937e2a01f2c8814dd032c0f12baa6fd4"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"54a4e29de7c2b5a2b6dae080626e29ed5f0ee0b3","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                return RestResult(err\u003derr)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"            except urllib.error.URLError as err:"},{"line_number":325,"context_line":"                LOG.error(_LE(\u0027URLError: %s\u0027), err.reason)"},{"line_number":326,"context_line":"                raise RestClientError(-1, name\u003d\"ERR_URLError\","},{"line_number":327,"context_line":"                                      message\u003derr.reason)"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_8f10fca9","line":325,"updated":"2015-08-05 07:58:23.000000000","message":"Add a stop \u0027.\u0027 in the end.","commit_id":"814cbb8a937e2a01f2c8814dd032c0f12baa6fd4"}]}