)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1ffc3932185ea69fad97a600de53a3344b5af258","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adds manage/unmanage methods for HNAS drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements the support for the manage and unmanage features in HDS"},{"line_number":10,"context_line":"HNAS drivers (NFS and ISCSI)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint hnas-manage-unmanage"},{"line_number":13,"context_line":"Change-Id: Ic222b8009a064824775aafb8713b4ddde38678f6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a4dcd0f_60f2b171","line":10,"updated":"2015-08-09 07:37:33.000000000","message":"Add a \".\" at the EOL.","commit_id":"38f5279eb250522a4366c549f666b854a7884dbd"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7c53a65df85fdc974f4df6b31a8b2093dc777b1f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adds manage/unmanage methods for HNAS drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements the support for the manage and unmanage features in HDS"},{"line_number":10,"context_line":"HNAS drivers (NFS and ISCSI)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint hnas-manage-unmanage"},{"line_number":13,"context_line":"Change-Id: Ic222b8009a064824775aafb8713b4ddde38678f6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1a4dcd0f_2237a8b1","line":10,"in_reply_to":"1a4dcd0f_60f2b171","updated":"2015-08-10 14:34:41.000000000","message":"Done","commit_id":"38f5279eb250522a4366c549f666b854a7884dbd"}],"cinder/tests/unit/test_hitachi_hnas_backend.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"dbd7cd3f52c7884ab3d4e24bb9b893b791de7c2f","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                                                  \"supervisor\","},{"line_number":496,"context_line":"                                                  \"supervisor\", \"fs01-husvm\","},{"line_number":497,"context_line":"                                                  \"test_lun\")"},{"line_number":498,"context_line":"        self.assertEqual(HNAS_RESULT23, out)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    @mock.patch.object(hnas_backend.HnasBackend, \u0027run_cmd\u0027,"},{"line_number":501,"context_line":"                       side_effect\u003dm_run_cmd)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_def49a88","line":498,"updated":"2015-07-21 03:14:44.000000000","message":"m_run_cmd called or not?\nassert_called_once_with?","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":495,"context_line":"                                                  \"supervisor\","},{"line_number":496,"context_line":"                                                  \"supervisor\", \"fs01-husvm\","},{"line_number":497,"context_line":"                                                  \"test_lun\")"},{"line_number":498,"context_line":"        self.assertEqual(HNAS_RESULT23, out)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    @mock.patch.object(hnas_backend.HnasBackend, \u0027run_cmd\u0027,"},{"line_number":501,"context_line":"                       side_effect\u003dm_run_cmd)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_a5214bfd","line":498,"in_reply_to":"3a50d1a3_def49a88","updated":"2015-07-24 12:21:50.000000000","message":"Made some changes in the code and added the verification assert_called_once_with","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"dbd7cd3f52c7884ab3d4e24bb9b893b791de7c2f","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                                \"supervisor\", \"fs01-husvm\","},{"line_number":506,"context_line":"                                                \"vol_test\","},{"line_number":507,"context_line":"                                                \"new_vol_test\")"},{"line_number":508,"context_line":"        self.assertEqual(HNAS_RESULT24, out)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_5e2f2af6","line":508,"updated":"2015-07-21 03:14:44.000000000","message":"assert_called_once_with? m_run_cmd?","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                                \"supervisor\", \"fs01-husvm\","},{"line_number":506,"context_line":"                                                \"vol_test\","},{"line_number":507,"context_line":"                                                \"new_vol_test\")"},{"line_number":508,"context_line":"        self.assertEqual(HNAS_RESULT24, out)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_458727d7","line":508,"in_reply_to":"3a50d1a3_5e2f2af6","updated":"2015-07-24 12:21:50.000000000","message":"Same as above","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"2f03282dc92b4cc06011ed141e1e314293a29a74","unresolved":false,"context_lines":[{"line_number":194,"context_line":"HNAS_RESULT20 \u003d \"Target does not exist.\""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"HNAS_RESULT21 \u003d \"Target created successfully.\""},{"line_number":197,"context_line":"HNAS_RESULT22 \u003d \"Current selected file system: HNAS-iSCSI-TEST, number(32)\""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"HNAS_RESULT23 \u003d \"Name   : volume-test \\n\\"},{"line_number":200,"context_line":"Comment:                              \\n\\"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_207f5616","line":197,"updated":"2015-08-05 18:20:17.000000000","message":"EOL \".\"","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"8b118e5712030b02405e7c3f9596b7b3a1273c43","unresolved":false,"context_lines":[{"line_number":194,"context_line":"HNAS_RESULT20 \u003d \"Target does not exist.\""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"HNAS_RESULT21 \u003d \"Target created successfully.\""},{"line_number":197,"context_line":"HNAS_RESULT22 \u003d \"Current selected file system: HNAS-iSCSI-TEST, number(32)\""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"HNAS_RESULT23 \u003d \"Name   : volume-test \\n\\"},{"line_number":200,"context_line":"Comment:                              \\n\\"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_6607b618","line":197,"in_reply_to":"1a4dcd0f_207f5616","updated":"2015-08-05 18:50:47.000000000","message":"Done","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"2f03282dc92b4cc06011ed141e1e314293a29a74","unresolved":false,"context_lines":[{"line_number":204,"context_line":"File System Mounted : YES             \\n\\"},{"line_number":205,"context_line":"Logical Unit Mounted: No\""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"HNAS_RESULT24 \u003d \"Logical unit modified successfully\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"HNAS_RESULT22 \u003d \"Failed to establish SSC connection\""},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_407ce21e","line":207,"updated":"2015-08-05 18:20:17.000000000","message":"EOL \".\"","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"8b118e5712030b02405e7c3f9596b7b3a1273c43","unresolved":false,"context_lines":[{"line_number":204,"context_line":"File System Mounted : YES             \\n\\"},{"line_number":205,"context_line":"Logical Unit Mounted: No\""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"HNAS_RESULT24 \u003d \"Logical unit modified successfully\""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"HNAS_RESULT22 \u003d \"Failed to establish SSC connection\""},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_a6285e87","line":207,"in_reply_to":"1a4dcd0f_407ce21e","updated":"2015-08-05 18:50:47.000000000","message":"Done","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"}],"cinder/tests/unit/test_hitachi_hnas_iscsi.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"1578b4cb40a18de64c1e0e7c81ef45856fea467c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"               Size   : 20 GB                      \\n\\"},{"line_number":119,"context_line":"               File System : manage_iscsi_test     \\n\\"},{"line_number":120,"context_line":"               File System Mounted : Yes           \\n\\"},{"line_number":121,"context_line":"               Logical Unit Mounted: Yes\""},{"line_number":122,"context_line":"        return out"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def deleteVolume(self, name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_3470b6a3","line":121,"updated":"2015-07-02 19:16:59.000000000","message":"How about to declare the backend outputs in the begining of the file (link is done in test_hitachi_hnas_backend.py)??\nHNAS_RESULT01\u003d ...","commit_id":"e7c746210af92ed5e1275f9a7b77b50dffc81039"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"dbd7cd3f52c7884ab3d4e24bb9b893b791de7c2f","unresolved":false,"context_lines":[{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        out \u003d self.driver.manage_existing(vol, existing_vol_ref)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        self.assertEqual(version, out)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_3e133eba","line":456,"updated":"2015-07-21 03:14:44.000000000","message":"m_get_extra_specs\nassert_called_once_with?","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        out \u003d self.driver.manage_existing(vol, existing_vol_ref)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        self.assertEqual(version, out)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_e5f99381","line":456,"in_reply_to":"3a50d1a3_3e133eba","updated":"2015-07-24 12:21:50.000000000","message":"Done","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"}],"cinder/tests/unit/test_hitachi_hnas_nfs.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"dbd7cd3f52c7884ab3d4e24bb9b893b791de7c2f","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                                          \u0027service_label\u0027: \u0027silver\u0027}"},{"line_number":328,"context_line":"        self.driver._mounted_shares \u003d [\u0027172.17.39.133:/cinder\u0027]"},{"line_number":329,"context_line":"        existing_vol_ref \u003d {\u0027source-name\u0027: \u0027172.17.39.133:/cinder/volume-test\u0027}"},{"line_number":330,"context_line":"        self.stubs.Set(self.driver, \u0027_execute\u0027, mock.Mock())"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        out \u003d self.driver.manage_existing(vol, existing_vol_ref)"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_3e61fe39","line":330,"updated":"2015-07-21 03:14:44.000000000","message":"Use with mock.patch.object instead.\n\nPer all the mock methods, please check if they are called or not with\nassert_called_once_with, etc.","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                                          \u0027service_label\u0027: \u0027silver\u0027}"},{"line_number":328,"context_line":"        self.driver._mounted_shares \u003d [\u0027172.17.39.133:/cinder\u0027]"},{"line_number":329,"context_line":"        existing_vol_ref \u003d {\u0027source-name\u0027: \u0027172.17.39.133:/cinder/volume-test\u0027}"},{"line_number":330,"context_line":"        self.stubs.Set(self.driver, \u0027_execute\u0027, mock.Mock())"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        out \u003d self.driver.manage_existing(vol, existing_vol_ref)"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_a248f6b3","line":330,"in_reply_to":"3a50d1a3_3e61fe39","updated":"2015-07-24 12:21:50.000000000","message":"Done","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"dbd7cd3f52c7884ab3d4e24bb9b893b791de7c2f","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        out \u003d self.driver.manage_existing_get_size(vol, existing_vol_ref)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        self.assertEqual(vol[\u0027size\u0027], out)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def test_unmanage(self):"},{"line_number":356,"context_line":"        self.stubs.Set(self.driver, \u0027_execute\u0027, mock.Mock())"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_fe5ab682","line":353,"updated":"2015-07-21 03:14:44.000000000","message":"Per all the mock methods, please check if they are called or not with assert_called_once_with, etc.","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        out \u003d self.driver.manage_existing_get_size(vol, existing_vol_ref)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        self.assertEqual(vol[\u0027size\u0027], out)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def test_unmanage(self):"},{"line_number":356,"context_line":"        self.stubs.Set(self.driver, \u0027_execute\u0027, mock.Mock())"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_7d54cfc8","line":353,"in_reply_to":"3a50d1a3_fe5ab682","updated":"2015-07-24 12:21:50.000000000","message":"Done","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"2f03282dc92b4cc06011ed141e1e314293a29a74","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def test_get_pool(self, m_ext_spec):"},{"line_number":312,"context_line":"        vol \u003d _VOLUME.copy()"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        self.assertEqual(self.driver.get_pool(vol), \u0027silver\u0027)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":317,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, return_value\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_a0b846c9","line":314,"updated":"2015-08-05 18:20:17.000000000","message":"Please change it to assertEqual(expected, actual)","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"8b118e5712030b02405e7c3f9596b7b3a1273c43","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    def test_get_pool(self, m_ext_spec):"},{"line_number":312,"context_line":"        vol \u003d _VOLUME.copy()"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        self.assertEqual(self.driver.get_pool(vol), \u0027silver\u0027)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"    @mock.patch.object(volume_types, \u0027get_volume_type_extra_specs\u0027)"},{"line_number":317,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, return_value\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_068cb27d","line":314,"in_reply_to":"1a4dcd0f_a0b846c9","updated":"2015-08-05 18:50:47.000000000","message":"Done","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"}],"cinder/utils.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a4541f581f82fe9debfb8bd233043e0bc3db08fe","unresolved":false,"context_lines":[{"line_number":844,"context_line":"    \"\"\""},{"line_number":845,"context_line":"    result \u003d socket.getaddrinfo(hostname, None)[0]"},{"line_number":846,"context_line":"    (family, socktype, proto, canonname, sockaddr) \u003d result"},{"line_number":847,"context_line":"    LOG.debug(\u0027Asked to resolve hostname %(host)s and got IP %(ip)s\u0027,"},{"line_number":848,"context_line":"              {\u0027host\u0027: hostname, \u0027ip\u0027: sockaddr[0]})"},{"line_number":849,"context_line":"    return sockaddr[0]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_2383fbcd","line":847,"updated":"2015-07-07 21:09:56.000000000","message":"\u0027.\u0027 at EOL","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7eacd7b588a9e91c458570e878f91a2af6d5e73c","unresolved":false,"context_lines":[{"line_number":844,"context_line":"    \"\"\""},{"line_number":845,"context_line":"    result \u003d socket.getaddrinfo(hostname, None)[0]"},{"line_number":846,"context_line":"    (family, socktype, proto, canonname, sockaddr) \u003d result"},{"line_number":847,"context_line":"    LOG.debug(\u0027Asked to resolve hostname %(host)s and got IP %(ip)s\u0027,"},{"line_number":848,"context_line":"              {\u0027host\u0027: hostname, \u0027ip\u0027: sockaddr[0]})"},{"line_number":849,"context_line":"    return sockaddr[0]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_829c210f","line":847,"in_reply_to":"ba3cc151_2383fbcd","updated":"2015-07-08 13:03:04.000000000","message":"Done","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"2f03282dc92b4cc06011ed141e1e314293a29a74","unresolved":false,"context_lines":[{"line_number":966,"context_line":"    \"\"\"Resolves host name to IP address."},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    Resolves a Host name (my.data.point.com) to an IP address (10.12.143.11)."},{"line_number":969,"context_line":"    This routine works if passed in hostname is already an IP address: the"},{"line_number":970,"context_line":"    same IP address ends up coming back. This permits calling into here"},{"line_number":971,"context_line":"    without first making sure it is not an IP formatted string."},{"line_number":972,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_00f81a48","line":969,"updated":"2015-08-05 18:20:17.000000000","message":"Is \":\" mis-placed?","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"8b118e5712030b02405e7c3f9596b7b3a1273c43","unresolved":false,"context_lines":[{"line_number":966,"context_line":"    \"\"\"Resolves host name to IP address."},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    Resolves a Host name (my.data.point.com) to an IP address (10.12.143.11)."},{"line_number":969,"context_line":"    This routine works if passed in hostname is already an IP address: the"},{"line_number":970,"context_line":"    same IP address ends up coming back. This permits calling into here"},{"line_number":971,"context_line":"    without first making sure it is not an IP formatted string."},{"line_number":972,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_267f6e16","line":969,"in_reply_to":"1a4dcd0f_00f81a48","updated":"2015-08-05 18:50:47.000000000","message":"Done","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"2f03282dc92b4cc06011ed141e1e314293a29a74","unresolved":false,"context_lines":[{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    Resolves a Host name (my.data.point.com) to an IP address (10.12.143.11)."},{"line_number":969,"context_line":"    This routine works if passed in hostname is already an IP address: the"},{"line_number":970,"context_line":"    same IP address ends up coming back. This permits calling into here"},{"line_number":971,"context_line":"    without first making sure it is not an IP formatted string."},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"    :param hostname:  Host name to resolve"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_a0be0663","line":970,"updated":"2015-08-05 18:20:17.000000000","message":"Suggesting sentence restructuring.","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"8b118e5712030b02405e7c3f9596b7b3a1273c43","unresolved":false,"context_lines":[{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    Resolves a Host name (my.data.point.com) to an IP address (10.12.143.11)."},{"line_number":969,"context_line":"    This routine works if passed in hostname is already an IP address: the"},{"line_number":970,"context_line":"    same IP address ends up coming back. This permits calling into here"},{"line_number":971,"context_line":"    without first making sure it is not an IP formatted string."},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"    :param hostname:  Host name to resolve"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_86852208","line":970,"in_reply_to":"1a4dcd0f_a0be0663","updated":"2015-08-05 18:50:47.000000000","message":"Done","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"}],"cinder/volume/drivers/hitachi/hnas_backend.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"1578b4cb40a18de64c1e0e7c81ef45856fea467c","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        else:"},{"line_number":667,"context_line":"            return \"\""},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def get_existing_lu_info(self, cmd, ip0, user, pw, fslabel, lun):"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        evs \u003d self._get_evs(cmd, ip0, user, pw, fslabel)"},{"line_number":672,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_0e0b257e","line":669,"updated":"2015-07-02 19:16:59.000000000","message":"Document the parameters used in the function, like other functions in the file.","commit_id":"e7c746210af92ed5e1275f9a7b77b50dffc81039"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"1578b4cb40a18de64c1e0e7c81ef45856fea467c","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def get_existing_lu_info(self, cmd, ip0, user, pw, fslabel, lun):"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        evs \u003d self._get_evs(cmd, ip0, user, pw, fslabel)"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        out, err \u003d self.run_cmd(cmd, ip0, user, pw, \"console-context\", \"--evs\","},{"line_number":674,"context_line":"                                evs, \u0027selectfs\u0027, fslabel)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_eef6018e","line":671,"updated":"2015-07-02 19:16:59.000000000","message":"You don\u0027t need these blank lines, they are only neded if you want to group some logic block.","commit_id":"e7c746210af92ed5e1275f9a7b77b50dffc81039"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"1578b4cb40a18de64c1e0e7c81ef45856fea467c","unresolved":false,"context_lines":[{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        out, err \u003d self.run_cmd(cmd, ip0, user, pw, \"console-context\", \"--evs\","},{"line_number":674,"context_line":"                                evs, \u0027selectfs\u0027, fslabel)"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"        out, err \u003d self.run_cmd(cmd, ip0, user, pw, \"console-context\", \"--evs\","},{"line_number":677,"context_line":"                                evs, \u0027iscsi-lu\u0027, \u0027list\u0027, lun)"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_8ef17597","line":675,"updated":"2015-07-02 19:16:59.000000000","message":"here...","commit_id":"e7c746210af92ed5e1275f9a7b77b50dffc81039"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"1578b4cb40a18de64c1e0e7c81ef45856fea467c","unresolved":false,"context_lines":[{"line_number":679,"context_line":"        return out"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"    def rename_existing_volume(self, cmd, ip0, user, pw, fslabel,"},{"line_number":682,"context_line":"                               new_name, vol_name):"},{"line_number":683,"context_line":"        evs \u003d self._get_evs(cmd, ip0, user, pw, fslabel)"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"        out, err \u003d self.run_cmd(cmd, ip0, user, pw, \"console-context\", \"--evs\","}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_ee24c10d","line":682,"updated":"2015-07-02 19:16:59.000000000","message":"Docstring","commit_id":"e7c746210af92ed5e1275f9a7b77b50dffc81039"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"1578b4cb40a18de64c1e0e7c81ef45856fea467c","unresolved":false,"context_lines":[{"line_number":684,"context_line":""},{"line_number":685,"context_line":"        out, err \u003d self.run_cmd(cmd, ip0, user, pw, \"console-context\", \"--evs\","},{"line_number":686,"context_line":"                                evs, \"selectfs\", fslabel)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        out, err \u003d self.run_cmd(cmd, ip0, user, pw, \"console-context\", \"--evs\","},{"line_number":689,"context_line":"                                evs, \"iscsi-lu\", \"mod\", \"-n\", new_name,"},{"line_number":690,"context_line":"                                vol_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_8e1f35b6","line":687,"updated":"2015-07-02 19:16:59.000000000","message":"blank line","commit_id":"e7c746210af92ed5e1275f9a7b77b50dffc81039"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"1578b4cb40a18de64c1e0e7c81ef45856fea467c","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                                new_name):"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        evs \u003d self._get_evs(cmd, ip0, user, pw, fslabel)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        out, err \u003d self.run_cmd(cmd, ip0, user, pw, \"console-context\", \"--evs\","},{"line_number":700,"context_line":"                                evs, \"selectfs\", fslabel)"},{"line_number":701,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_4985a757","line":698,"updated":"2015-07-02 19:16:59.000000000","message":"blank lines","commit_id":"e7c746210af92ed5e1275f9a7b77b50dffc81039"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"15af87ac6d5650165e3a81af1109f38a41a7fb29","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            return \"\""},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def get_existing_lu_info(self, cmd, ip0, user, pw, fslabel, lun):"},{"line_number":670,"context_line":"        \"\"\"Returns the information for the specified Logical Unit."},{"line_number":671,"context_line":"        :param ip0: string IP address of controller"},{"line_number":672,"context_line":"        :param user: string user authentication for array"},{"line_number":673,"context_line":"        :param pw: string password authentication for array"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_83f15503","line":670,"updated":"2015-07-09 06:52:18.000000000","message":"leave a blank line","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7b8f089ea134a2d6cbde6f9a263638a93bcff547","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            return \"\""},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def get_existing_lu_info(self, cmd, ip0, user, pw, fslabel, lun):"},{"line_number":670,"context_line":"        \"\"\"Returns the information for the specified Logical Unit."},{"line_number":671,"context_line":"        :param ip0: string IP address of controller"},{"line_number":672,"context_line":"        :param user: string user authentication for array"},{"line_number":673,"context_line":"        :param pw: string password authentication for array"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_c8496a34","line":670,"in_reply_to":"ba3cc151_83f15503","updated":"2015-07-10 13:50:10.000000000","message":"Done","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"15af87ac6d5650165e3a81af1109f38a41a7fb29","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def get_existing_lu_info(self, cmd, ip0, user, pw, fslabel, lun):"},{"line_number":670,"context_line":"        \"\"\"Returns the information for the specified Logical Unit."},{"line_number":671,"context_line":"        :param ip0: string IP address of controller"},{"line_number":672,"context_line":"        :param user: string user authentication for array"},{"line_number":673,"context_line":"        :param pw: string password authentication for array"},{"line_number":674,"context_line":"        :param fslabel: label of the file system"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_23e1692a","line":671,"updated":"2015-07-09 06:52:18.000000000","message":"better add cmd.","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7b8f089ea134a2d6cbde6f9a263638a93bcff547","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def get_existing_lu_info(self, cmd, ip0, user, pw, fslabel, lun):"},{"line_number":670,"context_line":"        \"\"\"Returns the information for the specified Logical Unit."},{"line_number":671,"context_line":"        :param ip0: string IP address of controller"},{"line_number":672,"context_line":"        :param user: string user authentication for array"},{"line_number":673,"context_line":"        :param pw: string password authentication for array"},{"line_number":674,"context_line":"        :param fslabel: label of the file system"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_485c7af0","line":671,"in_reply_to":"ba3cc151_23e1692a","updated":"2015-07-10 13:50:10.000000000","message":"Done","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"15af87ac6d5650165e3a81af1109f38a41a7fb29","unresolved":false,"context_lines":[{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def rename_existing_lu(self, cmd, ip0, user, pw, fslabel,"},{"line_number":687,"context_line":"                           new_name, vol_name):"},{"line_number":688,"context_line":"        \"\"\"Returns the information for the specified Logical Unit."},{"line_number":689,"context_line":"        :param ip0: string IP address of controller"},{"line_number":690,"context_line":"        :param user: string user authentication for array"},{"line_number":691,"context_line":"        :param pw: string password authentication for array"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_a3f499f0","line":688,"updated":"2015-07-09 06:52:18.000000000","message":"blank line.","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7b8f089ea134a2d6cbde6f9a263638a93bcff547","unresolved":false,"context_lines":[{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def rename_existing_lu(self, cmd, ip0, user, pw, fslabel,"},{"line_number":687,"context_line":"                           new_name, vol_name):"},{"line_number":688,"context_line":"        \"\"\"Returns the information for the specified Logical Unit."},{"line_number":689,"context_line":"        :param ip0: string IP address of controller"},{"line_number":690,"context_line":"        :param user: string user authentication for array"},{"line_number":691,"context_line":"        :param pw: string password authentication for array"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_c8708a76","line":688,"in_reply_to":"ba3cc151_a3f499f0","updated":"2015-07-10 13:50:10.000000000","message":"Done","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"15af87ac6d5650165e3a81af1109f38a41a7fb29","unresolved":false,"context_lines":[{"line_number":686,"context_line":"    def rename_existing_lu(self, cmd, ip0, user, pw, fslabel,"},{"line_number":687,"context_line":"                           new_name, vol_name):"},{"line_number":688,"context_line":"        \"\"\"Returns the information for the specified Logical Unit."},{"line_number":689,"context_line":"        :param ip0: string IP address of controller"},{"line_number":690,"context_line":"        :param user: string user authentication for array"},{"line_number":691,"context_line":"        :param pw: string password authentication for array"},{"line_number":692,"context_line":"        :param fslabel: label of the file system"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_83c875a9","line":689,"updated":"2015-07-09 06:52:18.000000000","message":"add cmd","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7b8f089ea134a2d6cbde6f9a263638a93bcff547","unresolved":false,"context_lines":[{"line_number":686,"context_line":"    def rename_existing_lu(self, cmd, ip0, user, pw, fslabel,"},{"line_number":687,"context_line":"                           new_name, vol_name):"},{"line_number":688,"context_line":"        \"\"\"Returns the information for the specified Logical Unit."},{"line_number":689,"context_line":"        :param ip0: string IP address of controller"},{"line_number":690,"context_line":"        :param user: string user authentication for array"},{"line_number":691,"context_line":"        :param pw: string password authentication for array"},{"line_number":692,"context_line":"        :param fslabel: label of the file system"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_886a8280","line":689,"in_reply_to":"ba3cc151_83c875a9","updated":"2015-07-10 13:50:10.000000000","message":"Done","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"}],"cinder/volume/drivers/hitachi/hnas_iscsi.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a4541f581f82fe9debfb8bd233043e0bc3db08fe","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        if self.config[\u0027services\u0027][pool_from_vol_type][\u0027hdp\u0027] !\u003d fs_label:"},{"line_number":748,"context_line":"            msg \u003d (_(\"Failed to manage existing volume because the pool of \""},{"line_number":749,"context_line":"                   \"the volume type chosen does not match the file system \""},{"line_number":750,"context_line":"                     \"passed in the volume reference\"),"},{"line_number":751,"context_line":"                   {\u0027File System passed\u0027: fs_label,"},{"line_number":752,"context_line":"                   \u0027File System for volume type\u0027:"},{"line_number":753,"context_line":"                    self.config[\u0027services\u0027][pool_from_vol_type][\u0027hdp\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_c3724f11","line":750,"updated":"2015-07-07 21:09:56.000000000","message":"\u0027.\u0027 at EOL","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7eacd7b588a9e91c458570e878f91a2af6d5e73c","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        if self.config[\u0027services\u0027][pool_from_vol_type][\u0027hdp\u0027] !\u003d fs_label:"},{"line_number":748,"context_line":"            msg \u003d (_(\"Failed to manage existing volume because the pool of \""},{"line_number":749,"context_line":"                   \"the volume type chosen does not match the file system \""},{"line_number":750,"context_line":"                     \"passed in the volume reference\"),"},{"line_number":751,"context_line":"                   {\u0027File System passed\u0027: fs_label,"},{"line_number":752,"context_line":"                   \u0027File System for volume type\u0027:"},{"line_number":753,"context_line":"                    self.config[\u0027services\u0027][pool_from_vol_type][\u0027hdp\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_623ebd29","line":750,"in_reply_to":"ba3cc151_c3724f11","updated":"2015-07-08 13:03:04.000000000","message":"Done","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a4541f581f82fe9debfb8bd233043e0bc3db08fe","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        if pool_from_host !\u003d pool_from_vol_type:"},{"line_number":757,"context_line":"            msg \u003d (_(\"Failed to manage existing volume because the pool of \""},{"line_number":758,"context_line":"                   \"the volume type chosen does not match the pool of \""},{"line_number":759,"context_line":"                     \"the host\"),"},{"line_number":760,"context_line":"                   {\u0027Pool of the volume type\u0027: pool_from_vol_type,"},{"line_number":761,"context_line":"                   \u0027Pool of the host\u0027: pool_from_host})"},{"line_number":762,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_235a1b84","line":759,"updated":"2015-07-07 21:09:56.000000000","message":"\u0027.\u0027 at EOL","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7eacd7b588a9e91c458570e878f91a2af6d5e73c","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        if pool_from_host !\u003d pool_from_vol_type:"},{"line_number":757,"context_line":"            msg \u003d (_(\"Failed to manage existing volume because the pool of \""},{"line_number":758,"context_line":"                   \"the volume type chosen does not match the pool of \""},{"line_number":759,"context_line":"                     \"the host\"),"},{"line_number":760,"context_line":"                   {\u0027Pool of the volume type\u0027: pool_from_vol_type,"},{"line_number":761,"context_line":"                   \u0027Pool of the host\u0027: pool_from_host})"},{"line_number":762,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_224435b5","line":759,"in_reply_to":"ba3cc151_235a1b84","updated":"2015-07-08 13:03:04.000000000","message":"Done","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a4541f581f82fe9debfb8bd233043e0bc3db08fe","unresolved":false,"context_lines":[{"line_number":829,"context_line":"        ref_name \u003d existing_vol_ref[\u0027source-name\u0027]"},{"line_number":830,"context_line":"        fs_label, vol_name \u003d self._get_info_from_vol_ref(ref_name)"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        LOG.debug(\"Asked to manage ISCSI volume %(vol)s, with vol ref %(ref)s\","},{"line_number":833,"context_line":"                  {\u0027vol\u0027: volume[\u0027id\u0027],"},{"line_number":834,"context_line":"                   \u0027ref\u0027: existing_vol_ref[\u0027source-name\u0027]})"},{"line_number":835,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_435ddf77","line":832,"updated":"2015-07-07 21:09:56.000000000","message":"\u0027.\u0027 at EOL","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7eacd7b588a9e91c458570e878f91a2af6d5e73c","unresolved":false,"context_lines":[{"line_number":829,"context_line":"        ref_name \u003d existing_vol_ref[\u0027source-name\u0027]"},{"line_number":830,"context_line":"        fs_label, vol_name \u003d self._get_info_from_vol_ref(ref_name)"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        LOG.debug(\"Asked to manage ISCSI volume %(vol)s, with vol ref %(ref)s\","},{"line_number":833,"context_line":"                  {\u0027vol\u0027: volume[\u0027id\u0027],"},{"line_number":834,"context_line":"                   \u0027ref\u0027: existing_vol_ref[\u0027source-name\u0027]})"},{"line_number":835,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_82574159","line":832,"in_reply_to":"ba3cc151_435ddf77","updated":"2015-07-08 13:03:04.000000000","message":"Done","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a4541f581f82fe9debfb8bd233043e0bc3db08fe","unresolved":false,"context_lines":[{"line_number":872,"context_line":"                                         volume[\u0027name\u0027])"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        LOG.info(_LI(\"Cinder ISCSI volume with current path \\\"%(path)s\\\" is \""},{"line_number":875,"context_line":"                     \"no longer being managed. The new name is %(unm)s\"),"},{"line_number":876,"context_line":"                 {\u0027path\u0027: vol_path, \u0027unm\u0027: new_name})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_0350375d","line":875,"updated":"2015-07-07 21:09:56.000000000","message":"\u0027.\u0027 at EOL","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7eacd7b588a9e91c458570e878f91a2af6d5e73c","unresolved":false,"context_lines":[{"line_number":872,"context_line":"                                         volume[\u0027name\u0027])"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":"        LOG.info(_LI(\"Cinder ISCSI volume with current path \\\"%(path)s\\\" is \""},{"line_number":875,"context_line":"                     \"no longer being managed. The new name is %(unm)s\"),"},{"line_number":876,"context_line":"                 {\u0027path\u0027: vol_path, \u0027unm\u0027: new_name})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_62da3dea","line":875,"in_reply_to":"ba3cc151_0350375d","updated":"2015-07-08 13:03:04.000000000","message":"Done","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"15af87ac6d5650165e3a81af1109f38a41a7fb29","unresolved":false,"context_lines":[{"line_number":39,"context_line":"iSCSI_OPTS \u003d [cfg.StrOpt(\u0027hds_hnas_iscsi_config_file\u0027,"},{"line_number":40,"context_line":"                         default\u003d\u0027/opt/hds/hnas/cinder_iscsi_conf.xml\u0027,"},{"line_number":41,"context_line":"                         help\u003d\u0027Configuration file for HDS iSCSI \u0027"},{"line_number":42,"context_line":"                              \u0027cinder plugin\u0027)]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"CONF \u003d cfg.CONF"},{"line_number":45,"context_line":"CONF.register_opts(iSCSI_OPTS)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_a37d796e","line":42,"updated":"2015-07-09 06:52:18.000000000","message":"\".\" EOL.","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7b8f089ea134a2d6cbde6f9a263638a93bcff547","unresolved":false,"context_lines":[{"line_number":39,"context_line":"iSCSI_OPTS \u003d [cfg.StrOpt(\u0027hds_hnas_iscsi_config_file\u0027,"},{"line_number":40,"context_line":"                         default\u003d\u0027/opt/hds/hnas/cinder_iscsi_conf.xml\u0027,"},{"line_number":41,"context_line":"                         help\u003d\u0027Configuration file for HDS iSCSI \u0027"},{"line_number":42,"context_line":"                              \u0027cinder plugin\u0027)]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"CONF \u003d cfg.CONF"},{"line_number":45,"context_line":"CONF.register_opts(iSCSI_OPTS)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_6dd63029","line":42,"in_reply_to":"ba3cc151_a37d796e","updated":"2015-07-10 13:50:10.000000000","message":"Done","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"dbd7cd3f52c7884ab3d4e24bb9b893b791de7c2f","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            svc_ip \u003d self.config[\u0027services\u0027][svc][\u0027iscsi_ip\u0027]"},{"line_number":403,"context_line":"            if svc_ip in iscsi_info.keys():"},{"line_number":404,"context_line":"                LOG.info(_LI(\"iSCSI portal found for service: %s\"), svc_ip)"},{"line_number":405,"context_line":"                self.config[\u0027services\u0027][svc][\u0027port\u0027] \u003d \\"},{"line_number":406,"context_line":"                    iscsi_info[svc_ip][\u0027port\u0027]"},{"line_number":407,"context_line":"                self.config[\u0027services\u0027][svc][\u0027ctl\u0027] \u003d \\"},{"line_number":408,"context_line":"                    iscsi_info[svc_ip][\u0027ctl\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_dec6da48","line":405,"updated":"2015-07-21 03:14:44.000000000","message":"use () to replace \\","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":402,"context_line":"            svc_ip \u003d self.config[\u0027services\u0027][svc][\u0027iscsi_ip\u0027]"},{"line_number":403,"context_line":"            if svc_ip in iscsi_info.keys():"},{"line_number":404,"context_line":"                LOG.info(_LI(\"iSCSI portal found for service: %s\"), svc_ip)"},{"line_number":405,"context_line":"                self.config[\u0027services\u0027][svc][\u0027port\u0027] \u003d \\"},{"line_number":406,"context_line":"                    iscsi_info[svc_ip][\u0027port\u0027]"},{"line_number":407,"context_line":"                self.config[\u0027services\u0027][svc][\u0027ctl\u0027] \u003d \\"},{"line_number":408,"context_line":"                    iscsi_info[svc_ip][\u0027ctl\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_52bd3d00","line":405,"in_reply_to":"3a50d1a3_dec6da48","updated":"2015-07-24 12:21:50.000000000","message":"Done","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"dbd7cd3f52c7884ab3d4e24bb9b893b791de7c2f","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                LOG.info(_LI(\"iSCSI portal found for service: %s\"), svc_ip)"},{"line_number":405,"context_line":"                self.config[\u0027services\u0027][svc][\u0027port\u0027] \u003d \\"},{"line_number":406,"context_line":"                    iscsi_info[svc_ip][\u0027port\u0027]"},{"line_number":407,"context_line":"                self.config[\u0027services\u0027][svc][\u0027ctl\u0027] \u003d \\"},{"line_number":408,"context_line":"                    iscsi_info[svc_ip][\u0027ctl\u0027]"},{"line_number":409,"context_line":"                self.config[\u0027services\u0027][svc][\u0027iscsi_port\u0027] \u003d \\"},{"line_number":410,"context_line":"                    iscsi_info[svc_ip][\u0027iscsi_port\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_1eb442cf","line":407,"updated":"2015-07-21 03:14:44.000000000","message":"use () to replace \\","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                LOG.info(_LI(\"iSCSI portal found for service: %s\"), svc_ip)"},{"line_number":405,"context_line":"                self.config[\u0027services\u0027][svc][\u0027port\u0027] \u003d \\"},{"line_number":406,"context_line":"                    iscsi_info[svc_ip][\u0027port\u0027]"},{"line_number":407,"context_line":"                self.config[\u0027services\u0027][svc][\u0027ctl\u0027] \u003d \\"},{"line_number":408,"context_line":"                    iscsi_info[svc_ip][\u0027ctl\u0027]"},{"line_number":409,"context_line":"                self.config[\u0027services\u0027][svc][\u0027iscsi_port\u0027] \u003d \\"},{"line_number":410,"context_line":"                    iscsi_info[svc_ip][\u0027iscsi_port\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_123a5599","line":407,"in_reply_to":"3a50d1a3_1eb442cf","updated":"2015-07-24 12:21:50.000000000","message":"Done","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"dbd7cd3f52c7884ab3d4e24bb9b893b791de7c2f","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                    iscsi_info[svc_ip][\u0027port\u0027]"},{"line_number":407,"context_line":"                self.config[\u0027services\u0027][svc][\u0027ctl\u0027] \u003d \\"},{"line_number":408,"context_line":"                    iscsi_info[svc_ip][\u0027ctl\u0027]"},{"line_number":409,"context_line":"                self.config[\u0027services\u0027][svc][\u0027iscsi_port\u0027] \u003d \\"},{"line_number":410,"context_line":"                    iscsi_info[svc_ip][\u0027iscsi_port\u0027]"},{"line_number":411,"context_line":"            else:  # config iscsi address not found on device!"},{"line_number":412,"context_line":"                LOG.error(_LE(\"iSCSI portal not found \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_becbce52","line":409,"updated":"2015-07-21 03:14:44.000000000","message":"use () to replace \\","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                    iscsi_info[svc_ip][\u0027port\u0027]"},{"line_number":407,"context_line":"                self.config[\u0027services\u0027][svc][\u0027ctl\u0027] \u003d \\"},{"line_number":408,"context_line":"                    iscsi_info[svc_ip][\u0027ctl\u0027]"},{"line_number":409,"context_line":"                self.config[\u0027services\u0027][svc][\u0027iscsi_port\u0027] \u003d \\"},{"line_number":410,"context_line":"                    iscsi_info[svc_ip][\u0027iscsi_port\u0027]"},{"line_number":411,"context_line":"            else:  # config iscsi address not found on device!"},{"line_number":412,"context_line":"                LOG.error(_LE(\"iSCSI portal not found \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_f242490e","line":409,"in_reply_to":"3a50d1a3_becbce52","updated":"2015-07-24 12:21:50.000000000","message":"Done","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"dbd7cd3f52c7884ab3d4e24bb9b893b791de7c2f","unresolved":false,"context_lines":[{"line_number":725,"context_line":"           for the volume type matches the pool for the host passed."},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"           :param volume: Reference to the volume"},{"line_number":728,"context_line":"           :param fs_label: Label of the file system"},{"line_number":729,"context_line":"        \"\"\""},{"line_number":730,"context_line":"        pool_from_vol_type \u003d self.get_pool(volume)"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_7edc6612","line":728,"updated":"2015-07-21 03:14:44.000000000","message":"Follow the style of the method manage_existing for the identations.","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"af153bbbea9546f3fa04a79f1c519bbf353b6066","unresolved":false,"context_lines":[{"line_number":725,"context_line":"           for the volume type matches the pool for the host passed."},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"           :param volume: Reference to the volume"},{"line_number":728,"context_line":"           :param fs_label: Label of the file system"},{"line_number":729,"context_line":"        \"\"\""},{"line_number":730,"context_line":"        pool_from_vol_type \u003d self.get_pool(volume)"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_42060887","line":728,"updated":"2015-07-22 16:30:14.000000000","message":"Yes. The lines after \"Checks if the file...\" don\u0027t need to be indented further.","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":725,"context_line":"           for the volume type matches the pool for the host passed."},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"           :param volume: Reference to the volume"},{"line_number":728,"context_line":"           :param fs_label: Label of the file system"},{"line_number":729,"context_line":"        \"\"\""},{"line_number":730,"context_line":"        pool_from_vol_type \u003d self.get_pool(volume)"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_bd8c97da","line":728,"in_reply_to":"3a50d1a3_42060887","updated":"2015-07-24 12:21:50.000000000","message":"Done","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":725,"context_line":"           for the volume type matches the pool for the host passed."},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"           :param volume: Reference to the volume"},{"line_number":728,"context_line":"           :param fs_label: Label of the file system"},{"line_number":729,"context_line":"        \"\"\""},{"line_number":730,"context_line":"        pool_from_vol_type \u003d self.get_pool(volume)"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_dd8723b3","line":728,"in_reply_to":"3a50d1a3_7edc6612","updated":"2015-07-24 12:21:50.000000000","message":"Done","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"dbd7cd3f52c7884ab3d4e24bb9b893b791de7c2f","unresolved":false,"context_lines":[{"line_number":841,"context_line":"           will be made to notify the Admin that the volume is no longer being"},{"line_number":842,"context_line":"           managed."},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"           :param volume: Cinder volume to unmanage"},{"line_number":845,"context_line":"        \"\"\""},{"line_number":846,"context_line":"        svc \u003d self._get_service(volume)"},{"line_number":847,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_9ed7f2ec","line":844,"updated":"2015-07-21 03:14:44.000000000","message":"Follow the style of the method manage_existing for the identations.","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"af153bbbea9546f3fa04a79f1c519bbf353b6066","unresolved":false,"context_lines":[{"line_number":841,"context_line":"           will be made to notify the Admin that the volume is no longer being"},{"line_number":842,"context_line":"           managed."},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"           :param volume: Cinder volume to unmanage"},{"line_number":845,"context_line":"        \"\"\""},{"line_number":846,"context_line":"        svc \u003d self._get_service(volume)"},{"line_number":847,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_02332063","line":844,"updated":"2015-07-22 16:30:14.000000000","message":"The lines after \"Removes the specified\" don\u0027t need to be indented further either.","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":841,"context_line":"           will be made to notify the Admin that the volume is no longer being"},{"line_number":842,"context_line":"           managed."},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"           :param volume: Cinder volume to unmanage"},{"line_number":845,"context_line":"        \"\"\""},{"line_number":846,"context_line":"        svc \u003d self._get_service(volume)"},{"line_number":847,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_5dc233ea","line":844,"in_reply_to":"3a50d1a3_02332063","updated":"2015-07-24 12:21:50.000000000","message":"Done","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":841,"context_line":"           will be made to notify the Admin that the volume is no longer being"},{"line_number":842,"context_line":"           managed."},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"           :param volume: Cinder volume to unmanage"},{"line_number":845,"context_line":"        \"\"\""},{"line_number":846,"context_line":"        svc \u003d self._get_service(volume)"},{"line_number":847,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_3dbf2762","line":844,"in_reply_to":"3a50d1a3_9ed7f2ec","updated":"2015-07-24 12:21:50.000000000","message":"Done","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ec37b61ee61f8fc3f398ba4eef470915f79ea777","unresolved":false,"context_lines":[{"line_number":734,"context_line":"                return metadata[\u0027service_label\u0027]"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def _check_pool_and_fs(self, volume, fs_label):"},{"line_number":737,"context_line":"        \"\"\"Checks if the file system for the volume-type chosen matches the"},{"line_number":738,"context_line":"           one passed in the volume reference. Also, checks if the pool"},{"line_number":739,"context_line":"           for the volume type matches the pool for the host passed."},{"line_number":740,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_4c0574c0","line":737,"updated":"2015-08-03 23:20:18.000000000","message":"Please have a one line summary followed by a blank line, then the details.\n\nhttp://docs.openstack.org/developer/hacking/#docstrings","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"e62404b0e3714d98ce2f4b6cef3524574a7820e4","unresolved":false,"context_lines":[{"line_number":734,"context_line":"                return metadata[\u0027service_label\u0027]"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def _check_pool_and_fs(self, volume, fs_label):"},{"line_number":737,"context_line":"        \"\"\"Checks if the file system for the volume-type chosen matches the"},{"line_number":738,"context_line":"           one passed in the volume reference. Also, checks if the pool"},{"line_number":739,"context_line":"           for the volume type matches the pool for the host passed."},{"line_number":740,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_fa909297","line":737,"in_reply_to":"1a4dcd0f_4c0574c0","updated":"2015-08-05 13:13:37.000000000","message":"Done","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ec37b61ee61f8fc3f398ba4eef470915f79ea777","unresolved":false,"context_lines":[{"line_number":763,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch(reason\u003dmsg)"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def _get_info_from_vol_ref(self, vol_ref):"},{"line_number":766,"context_line":"        \"\"\"Returns the information (File system and volume name) taken from"},{"line_number":767,"context_line":"        the volume reference"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"        :param vol_ref: Existing volume to take under management"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_0c0f6ce2","line":766,"updated":"2015-08-03 23:20:18.000000000","message":"Same.","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"e62404b0e3714d98ce2f4b6cef3524574a7820e4","unresolved":false,"context_lines":[{"line_number":763,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch(reason\u003dmsg)"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def _get_info_from_vol_ref(self, vol_ref):"},{"line_number":766,"context_line":"        \"\"\"Returns the information (File system and volume name) taken from"},{"line_number":767,"context_line":"        the volume reference"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"        :param vol_ref: Existing volume to take under management"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_5ae50607","line":766,"in_reply_to":"1a4dcd0f_0c0f6ce2","updated":"2015-08-05 13:13:37.000000000","message":"Done","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ec37b61ee61f8fc3f398ba4eef470915f79ea777","unresolved":false,"context_lines":[{"line_number":850,"context_line":"        return {\u0027provider_location\u0027: lun}"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"    def unmanage(self, volume):"},{"line_number":853,"context_line":"        \"\"\"Removes the specified volume from Cinder management."},{"line_number":854,"context_line":"           Does not delete the underlying backend storage object. A log entry"},{"line_number":855,"context_line":"           will be made to notify the Admin that the volume is no longer being"},{"line_number":856,"context_line":"           managed."}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_ecf6c0d6","line":853,"updated":"2015-08-03 23:20:18.000000000","message":"Same.","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"e62404b0e3714d98ce2f4b6cef3524574a7820e4","unresolved":false,"context_lines":[{"line_number":850,"context_line":"        return {\u0027provider_location\u0027: lun}"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"    def unmanage(self, volume):"},{"line_number":853,"context_line":"        \"\"\"Removes the specified volume from Cinder management."},{"line_number":854,"context_line":"           Does not delete the underlying backend storage object. A log entry"},{"line_number":855,"context_line":"           will be made to notify the Admin that the volume is no longer being"},{"line_number":856,"context_line":"           managed."}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_1d3218f2","line":853,"in_reply_to":"1a4dcd0f_ecf6c0d6","updated":"2015-08-05 13:13:37.000000000","message":"Done","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ec37b61ee61f8fc3f398ba4eef470915f79ea777","unresolved":false,"context_lines":[{"line_number":868,"context_line":"                                     self.config[\u0027password\u0027], svc[4], new_name,"},{"line_number":869,"context_line":"                                     volume[\u0027name\u0027])"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"        LOG.error(_LE(\"Cinder ISCSI volume with current path \\\"%(path)s\\\" is \""},{"line_number":872,"context_line":"                      \"no longer being managed. The new name is %(unm)s.\"),"},{"line_number":873,"context_line":"                  {\u0027path\u0027: vol_path, \u0027unm\u0027: new_name})"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_ac00b8ab","line":871,"updated":"2015-08-03 23:20:18.000000000","message":"Change outer quotes to single quotes to avoid needing to escape the quotes around %(path)s.","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"e62404b0e3714d98ce2f4b6cef3524574a7820e4","unresolved":false,"context_lines":[{"line_number":868,"context_line":"                                     self.config[\u0027password\u0027], svc[4], new_name,"},{"line_number":869,"context_line":"                                     volume[\u0027name\u0027])"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"        LOG.error(_LE(\"Cinder ISCSI volume with current path \\\"%(path)s\\\" is \""},{"line_number":872,"context_line":"                      \"no longer being managed. The new name is %(unm)s.\"),"},{"line_number":873,"context_line":"                  {\u0027path\u0027: vol_path, \u0027unm\u0027: new_name})"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_507ac725","line":871,"in_reply_to":"1a4dcd0f_ac00b8ab","updated":"2015-08-05 13:13:37.000000000","message":"Done","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"2f03282dc92b4cc06011ed141e1e314293a29a74","unresolved":false,"context_lines":[{"line_number":797,"context_line":"        fs_label, vol_name \u003d self._get_info_from_vol_ref(ref_name)"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        LOG.debug(\"File System: %(fs_label)s \""},{"line_number":800,"context_line":"                  \"Volume name: %(vol_name)s\","},{"line_number":801,"context_line":"                  {\u0027fs_label\u0027: fs_label, \u0027vol_name\u0027: vol_name})"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        lu_info \u003d self.bend.get_existing_lu_info(self.config[\u0027hnas_cmd\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_43138c5b","line":800,"updated":"2015-08-05 18:20:17.000000000","message":"EOL \".\"","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"8b118e5712030b02405e7c3f9596b7b3a1273c43","unresolved":false,"context_lines":[{"line_number":797,"context_line":"        fs_label, vol_name \u003d self._get_info_from_vol_ref(ref_name)"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        LOG.debug(\"File System: %(fs_label)s \""},{"line_number":800,"context_line":"                  \"Volume name: %(vol_name)s\","},{"line_number":801,"context_line":"                  {\u0027fs_label\u0027: fs_label, \u0027vol_name\u0027: vol_name})"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        lu_info \u003d self.bend.get_existing_lu_info(self.config[\u0027hnas_cmd\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_e61e66ba","line":800,"in_reply_to":"1a4dcd0f_43138c5b","updated":"2015-08-05 18:50:47.000000000","message":"Done","commit_id":"5be98a787c3301f62a5b4f59164bd909b14c009b"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1ffc3932185ea69fad97a600de53a3344b5af258","unresolved":false,"context_lines":[{"line_number":734,"context_line":"                return metadata[\u0027service_label\u0027]"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def _check_pool_and_fs(self, volume, fs_label):"},{"line_number":737,"context_line":"        \"\"\"Validation of the pool and filesystem"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        Checks if the file system for the volume-type chosen matches the"},{"line_number":740,"context_line":"        one passed in the volume reference. Also, checks if the pool"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a4dcd0f_009e4d07","line":737,"updated":"2015-08-09 07:37:33.000000000","message":"Add a \".\" at the EOL.","commit_id":"38f5279eb250522a4366c549f666b854a7884dbd"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7c53a65df85fdc974f4df6b31a8b2093dc777b1f","unresolved":false,"context_lines":[{"line_number":734,"context_line":"                return metadata[\u0027service_label\u0027]"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def _check_pool_and_fs(self, volume, fs_label):"},{"line_number":737,"context_line":"        \"\"\"Validation of the pool and filesystem"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"        Checks if the file system for the volume-type chosen matches the"},{"line_number":740,"context_line":"        one passed in the volume reference. Also, checks if the pool"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a4dcd0f_22600835","line":737,"in_reply_to":"1a4dcd0f_009e4d07","updated":"2015-08-10 14:34:41.000000000","message":"Done","commit_id":"38f5279eb250522a4366c549f666b854a7884dbd"}],"cinder/volume/drivers/hitachi/hnas_nfs.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a4541f581f82fe9debfb8bd233043e0bc3db08fe","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                vol_full_path \u003d os.path.join(nfs_mount, file_path)"},{"line_number":637,"context_line":"                if os.path.isfile(vol_full_path):"},{"line_number":638,"context_line":"                    LOG.debug(\"Found share %(share)s and vol %(path)s on \""},{"line_number":639,"context_line":"                              \"mount %(mnt)s\","},{"line_number":640,"context_line":"                              {\u0027share\u0027: nfs_share, \u0027path\u0027: file_path,"},{"line_number":641,"context_line":"                               \u0027mnt\u0027: nfs_mount})"},{"line_number":642,"context_line":"                    return nfs_share, nfs_mount, file_path"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_43d4ffbb","line":639,"updated":"2015-07-07 21:09:56.000000000","message":"\u0027.\u0027 at EOL","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7eacd7b588a9e91c458570e878f91a2af6d5e73c","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                vol_full_path \u003d os.path.join(nfs_mount, file_path)"},{"line_number":637,"context_line":"                if os.path.isfile(vol_full_path):"},{"line_number":638,"context_line":"                    LOG.debug(\"Found share %(share)s and vol %(path)s on \""},{"line_number":639,"context_line":"                              \"mount %(mnt)s\","},{"line_number":640,"context_line":"                              {\u0027share\u0027: nfs_share, \u0027path\u0027: file_path,"},{"line_number":641,"context_line":"                               \u0027mnt\u0027: nfs_mount})"},{"line_number":642,"context_line":"                    return nfs_share, nfs_mount, file_path"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_2250b5d3","line":639,"in_reply_to":"ba3cc151_43d4ffbb","updated":"2015-07-08 13:03:04.000000000","message":"Done","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a4541f581f82fe9debfb8bd233043e0bc3db08fe","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        (nfs_share, nfs_mount, vol_path) \u003d \\"},{"line_number":668,"context_line":"            self._get_share_mount_and_vol_from_vol_ref(existing_vol_ref)"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        LOG.debug(\"Asked to manage NFS volume %(vol)s, with vol ref %(ref)s\","},{"line_number":671,"context_line":"                  {\u0027vol\u0027: volume[\u0027id\u0027],"},{"line_number":672,"context_line":"                   \u0027ref\u0027: existing_vol_ref[\u0027source-name\u0027]})"},{"line_number":673,"context_line":"        self._check_pool_and_share(volume, nfs_share)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_03d7d7bf","line":670,"updated":"2015-07-07 21:09:56.000000000","message":"\u0027.\u0027 at EOL","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7eacd7b588a9e91c458570e878f91a2af6d5e73c","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        (nfs_share, nfs_mount, vol_path) \u003d \\"},{"line_number":668,"context_line":"            self._get_share_mount_and_vol_from_vol_ref(existing_vol_ref)"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"        LOG.debug(\"Asked to manage NFS volume %(vol)s, with vol ref %(ref)s\","},{"line_number":671,"context_line":"                  {\u0027vol\u0027: volume[\u0027id\u0027],"},{"line_number":672,"context_line":"                   \u0027ref\u0027: existing_vol_ref[\u0027source-name\u0027]})"},{"line_number":673,"context_line":"        self._check_pool_and_share(volume, nfs_share)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_c25f89e3","line":670,"in_reply_to":"ba3cc151_03d7d7bf","updated":"2015-07-08 13:03:04.000000000","message":"Done","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a4541f581f82fe9debfb8bd233043e0bc3db08fe","unresolved":false,"context_lines":[{"line_number":680,"context_line":"            try:"},{"line_number":681,"context_line":"                self._execute(\"mv\", src_vol, dst_vol, run_as_root\u003dFalse,"},{"line_number":682,"context_line":"                              check_exit_code\u003dTrue)"},{"line_number":683,"context_line":"                LOG.debug(\"Setting newly managed Cinder volume name to %s\","},{"line_number":684,"context_line":"                          volume[\u0027name\u0027])"},{"line_number":685,"context_line":"                self._set_rw_permissions_for_all(dst_vol)"},{"line_number":686,"context_line":"            except (OSError, processutils.ProcessExecutionError) as err:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_a3e5cba8","line":683,"updated":"2015-07-07 21:09:56.000000000","message":"\u0027.\u0027 at EOL","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7eacd7b588a9e91c458570e878f91a2af6d5e73c","unresolved":false,"context_lines":[{"line_number":680,"context_line":"            try:"},{"line_number":681,"context_line":"                self._execute(\"mv\", src_vol, dst_vol, run_as_root\u003dFalse,"},{"line_number":682,"context_line":"                              check_exit_code\u003dTrue)"},{"line_number":683,"context_line":"                LOG.debug(\"Setting newly managed Cinder volume name to %s\","},{"line_number":684,"context_line":"                          volume[\u0027name\u0027])"},{"line_number":685,"context_line":"                self._set_rw_permissions_for_all(dst_vol)"},{"line_number":686,"context_line":"            except (OSError, processutils.ProcessExecutionError) as err:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_a25a85f0","line":683,"in_reply_to":"ba3cc151_a3e5cba8","updated":"2015-07-08 13:03:04.000000000","message":"Done","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a4541f581f82fe9debfb8bd233043e0bc3db08fe","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        if self.config[\u0027services\u0027][pool_from_vol_type][\u0027hdp\u0027] !\u003d nfs_share:"},{"line_number":705,"context_line":"            msg \u003d (_(\"Failed to manage existing volume because the pool of \""},{"line_number":706,"context_line":"                   \"the volume type chosen does not match the NFS share \""},{"line_number":707,"context_line":"                     \"passed in the volume reference\"),"},{"line_number":708,"context_line":"                   {\u0027Share passed\u0027: nfs_share,"},{"line_number":709,"context_line":"                    \u0027Share for volume type\u0027:"},{"line_number":710,"context_line":"                    self.config[\u0027services\u0027][pool_from_vol_type][\u0027hdp\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_63eee38c","line":707,"updated":"2015-07-07 21:09:56.000000000","message":"\u0027.\u0027 at EOL","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7eacd7b588a9e91c458570e878f91a2af6d5e73c","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        if self.config[\u0027services\u0027][pool_from_vol_type][\u0027hdp\u0027] !\u003d nfs_share:"},{"line_number":705,"context_line":"            msg \u003d (_(\"Failed to manage existing volume because the pool of \""},{"line_number":706,"context_line":"                   \"the volume type chosen does not match the NFS share \""},{"line_number":707,"context_line":"                     \"passed in the volume reference\"),"},{"line_number":708,"context_line":"                   {\u0027Share passed\u0027: nfs_share,"},{"line_number":709,"context_line":"                    \u0027Share for volume type\u0027:"},{"line_number":710,"context_line":"                    self.config[\u0027services\u0027][pool_from_vol_type][\u0027hdp\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_4274d966","line":707,"in_reply_to":"ba3cc151_63eee38c","updated":"2015-07-08 13:03:04.000000000","message":"Done","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a4541f581f82fe9debfb8bd233043e0bc3db08fe","unresolved":false,"context_lines":[{"line_number":713,"context_line":"        if pool_from_host !\u003d pool_from_vol_type:"},{"line_number":714,"context_line":"            msg \u003d (_(\"Failed to manage existing volume because the pool of \""},{"line_number":715,"context_line":"                     \"the volume type chosen does not match the pool of \""},{"line_number":716,"context_line":"                     \"the host\"),"},{"line_number":717,"context_line":"                   {\u0027Pool of the volume type\u0027: pool_from_vol_type,"},{"line_number":718,"context_line":"                   \u0027Pool of the host\u0027: pool_from_host})"},{"line_number":719,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_03fef737","line":716,"updated":"2015-07-07 21:09:56.000000000","message":"\u0027.\u0027 at EOL","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7eacd7b588a9e91c458570e878f91a2af6d5e73c","unresolved":false,"context_lines":[{"line_number":713,"context_line":"        if pool_from_host !\u003d pool_from_vol_type:"},{"line_number":714,"context_line":"            msg \u003d (_(\"Failed to manage existing volume because the pool of \""},{"line_number":715,"context_line":"                     \"the volume type chosen does not match the pool of \""},{"line_number":716,"context_line":"                     \"the host\"),"},{"line_number":717,"context_line":"                   {\u0027Pool of the volume type\u0027: pool_from_vol_type,"},{"line_number":718,"context_line":"                   \u0027Pool of the host\u0027: pool_from_host})"},{"line_number":719,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_6271dd75","line":716,"in_reply_to":"ba3cc151_03fef737","updated":"2015-07-08 13:03:04.000000000","message":"Done","commit_id":"606f591f69662ccbd42a42d21df2c45426a69ae9"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"15af87ac6d5650165e3a81af1109f38a41a7fb29","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        return {\u0027provider_location\u0027: volume[\u0027provider_location\u0027]}"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _convert_vol_ref_share_name_to_share_ip(self, vol_ref):"},{"line_number":581,"context_line":"        \"\"\"Converts the share point name to an IP address"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        The volume reference may have a DNS name portion in the share name."},{"line_number":584,"context_line":"        Convert that to an IP address and then restore the entire path."}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_e3a061f6","line":581,"updated":"2015-07-09 06:52:18.000000000","message":"\".\" EOL.","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7b8f089ea134a2d6cbde6f9a263638a93bcff547","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        return {\u0027provider_location\u0027: volume[\u0027provider_location\u0027]}"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _convert_vol_ref_share_name_to_share_ip(self, vol_ref):"},{"line_number":581,"context_line":"        \"\"\"Converts the share point name to an IP address"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        The volume reference may have a DNS name portion in the share name."},{"line_number":584,"context_line":"        Convert that to an IP address and then restore the entire path."}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_92a86f22","line":581,"in_reply_to":"ba3cc151_e3a061f6","updated":"2015-07-10 13:50:10.000000000","message":"Done","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"15af87ac6d5650165e3a81af1109f38a41a7fb29","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        return vol_ref_share"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def _get_share_mount_and_vol_from_vol_ref(self, vol_ref):"},{"line_number":601,"context_line":"        \"\"\"Get the NFS share, the NFS mount, and the volume from reference"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        Determine the NFS share point, the NFS mount point, and the volume"},{"line_number":604,"context_line":"        (with possible path) from the given volume reference. Raise exception"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0361c5d2","line":601,"updated":"2015-07-09 06:52:18.000000000","message":"\".\" EOL.","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7b8f089ea134a2d6cbde6f9a263638a93bcff547","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        return vol_ref_share"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def _get_share_mount_and_vol_from_vol_ref(self, vol_ref):"},{"line_number":601,"context_line":"        \"\"\"Get the NFS share, the NFS mount, and the volume from reference"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"        Determine the NFS share point, the NFS mount point, and the volume"},{"line_number":604,"context_line":"        (with possible path) from the given volume reference. Raise exception"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_72660b2b","line":601,"in_reply_to":"ba3cc151_0361c5d2","updated":"2015-07-10 13:50:10.000000000","message":"Done","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"15af87ac6d5650165e3a81af1109f38a41a7fb29","unresolved":false,"context_lines":[{"line_number":695,"context_line":"    def _check_pool_and_share(self, volume, nfs_share):"},{"line_number":696,"context_line":"        \"\"\"Checks if the NFS share for the volume-type chosen matches the"},{"line_number":697,"context_line":"           one passed in the volume reference. Also, checks if the pool"},{"line_number":698,"context_line":"           for the volume type matches the pool for the host passed."},{"line_number":699,"context_line":"        \"\"\""},{"line_number":700,"context_line":"        pool_from_vol_type \u003d self.get_pool(volume)"},{"line_number":701,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_c8f3fc71","line":698,"updated":"2015-07-09 06:52:18.000000000","message":"The method _get_share_mount_and_vol_from_vol_ref has the style you need to follow.\n\nOne line as a brief intro.\nand then detailed descriptions.","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7b8f089ea134a2d6cbde6f9a263638a93bcff547","unresolved":false,"context_lines":[{"line_number":695,"context_line":"    def _check_pool_and_share(self, volume, nfs_share):"},{"line_number":696,"context_line":"        \"\"\"Checks if the NFS share for the volume-type chosen matches the"},{"line_number":697,"context_line":"           one passed in the volume reference. Also, checks if the pool"},{"line_number":698,"context_line":"           for the volume type matches the pool for the host passed."},{"line_number":699,"context_line":"        \"\"\""},{"line_number":700,"context_line":"        pool_from_vol_type \u003d self.get_pool(volume)"},{"line_number":701,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_126bfff2","line":698,"in_reply_to":"ba3cc151_c8f3fc71","updated":"2015-07-10 13:50:10.000000000","message":"Done","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"15af87ac6d5650165e3a81af1109f38a41a7fb29","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        return vol_size"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    def unmanage(self, volume):"},{"line_number":754,"context_line":"        \"\"\"Removes the specified volume from Cinder management."},{"line_number":755,"context_line":"           Does not delete the underlying backend storage object. A log entry"},{"line_number":756,"context_line":"           will be made to notify the Admin that the volume is no longer being"},{"line_number":757,"context_line":"           managed."}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_48d92cf2","line":754,"updated":"2015-07-09 06:52:18.000000000","message":"Leave an empty line here and watch the indentation.\n\nThe method _get_share_mount_and_vol_from_vol_ref has the style you need to follow.","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"7b8f089ea134a2d6cbde6f9a263638a93bcff547","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        return vol_size"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    def unmanage(self, volume):"},{"line_number":754,"context_line":"        \"\"\"Removes the specified volume from Cinder management."},{"line_number":755,"context_line":"           Does not delete the underlying backend storage object. A log entry"},{"line_number":756,"context_line":"           will be made to notify the Admin that the volume is no longer being"},{"line_number":757,"context_line":"           managed."}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_d27597cc","line":754,"in_reply_to":"ba3cc151_48d92cf2","updated":"2015-07-10 13:50:10.000000000","message":"Done","commit_id":"8c565c601ff7e85478abaaa46bd214e22b6b1207"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"dbd7cd3f52c7884ab3d4e24bb9b893b791de7c2f","unresolved":false,"context_lines":[{"line_number":780,"context_line":"                         \"no longer being managed.\"), {\u0027cr\u0027: new_path})"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        except (OSError, ValueError):"},{"line_number":783,"context_line":"            LOG.info(_LI(\"The NFS Volume \\\"%(cr)s\\\" does not exist.\"),"},{"line_number":784,"context_line":"                     {\u0027cr\u0027: new_path})"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_9ea9327e","line":783,"updated":"2015-07-21 03:14:44.000000000","message":"Don\u0027t we need to use _LE?","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a5c69131becb0204bbf2c0793aafd538eeb88aca","unresolved":false,"context_lines":[{"line_number":780,"context_line":"                         \"no longer being managed.\"), {\u0027cr\u0027: new_path})"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        except (OSError, ValueError):"},{"line_number":783,"context_line":"            LOG.info(_LI(\"The NFS Volume \\\"%(cr)s\\\" does not exist.\"),"},{"line_number":784,"context_line":"                     {\u0027cr\u0027: new_path})"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_f2a00944","line":783,"in_reply_to":"3a50d1a3_9ea9327e","updated":"2015-07-24 12:21:50.000000000","message":"Done","commit_id":"1e4b6665a5e30100705ae564080a4f2639f4cd10"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ec37b61ee61f8fc3f398ba4eef470915f79ea777","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            vol_ref_name)"},{"line_number":628,"context_line":"        for nfs_share in self._mounted_shares:"},{"line_number":629,"context_line":"            cfg_share \u003d self._convert_vol_ref_share_name_to_share_ip(nfs_share)"},{"line_number":630,"context_line":"            (orig_share, work_share, file_path) \u003d \\"},{"line_number":631,"context_line":"                vol_ref_share.partition(cfg_share)"},{"line_number":632,"context_line":"            if work_share \u003d\u003d cfg_share:"},{"line_number":633,"context_line":"                file_path \u003d file_path[1:]  # strip off leading path divider"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_2c2b4832","line":630,"updated":"2015-08-03 23:20:18.000000000","message":"Please reformat to avoid using \\ for line continuation.","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"e62404b0e3714d98ce2f4b6cef3524574a7820e4","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            vol_ref_name)"},{"line_number":628,"context_line":"        for nfs_share in self._mounted_shares:"},{"line_number":629,"context_line":"            cfg_share \u003d self._convert_vol_ref_share_name_to_share_ip(nfs_share)"},{"line_number":630,"context_line":"            (orig_share, work_share, file_path) \u003d \\"},{"line_number":631,"context_line":"                vol_ref_share.partition(cfg_share)"},{"line_number":632,"context_line":"            if work_share \u003d\u003d cfg_share:"},{"line_number":633,"context_line":"                file_path \u003d file_path[1:]  # strip off leading path divider"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_f3dbdd19","line":630,"in_reply_to":"1a4dcd0f_2c2b4832","updated":"2015-08-05 13:13:37.000000000","message":"Done","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ec37b61ee61f8fc3f398ba4eef470915f79ea777","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        \"\"\""},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"        # Attempt to find NFS share, NFS mount, and volume path from vol_ref."},{"line_number":668,"context_line":"        (nfs_share, nfs_mount, vol_path) \u003d \\"},{"line_number":669,"context_line":"            self._get_share_mount_and_vol_from_vol_ref(existing_vol_ref)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        LOG.debug(\"Asked to manage NFS volume %(vol)s, with vol ref %(ref)s.\","}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_6cd87054","line":668,"updated":"2015-08-03 23:20:18.000000000","message":"Same.","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"e62404b0e3714d98ce2f4b6cef3524574a7820e4","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        \"\"\""},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"        # Attempt to find NFS share, NFS mount, and volume path from vol_ref."},{"line_number":668,"context_line":"        (nfs_share, nfs_mount, vol_path) \u003d \\"},{"line_number":669,"context_line":"            self._get_share_mount_and_vol_from_vol_ref(existing_vol_ref)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        LOG.debug(\"Asked to manage NFS volume %(vol)s, with vol ref %(ref)s.\","}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_f320bdf9","line":668,"in_reply_to":"1a4dcd0f_6cd87054","updated":"2015-08-05 13:13:37.000000000","message":"Done","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ec37b61ee61f8fc3f398ba4eef470915f79ea777","unresolved":false,"context_lines":[{"line_number":689,"context_line":"                                   \"because rename operation failed:\""},{"line_number":690,"context_line":"                                   \" Error msg: %(msg)s.\"),"},{"line_number":691,"context_line":"                                 {\u0027name\u0027: existing_vol_ref[\u0027source-name\u0027],"},{"line_number":692,"context_line":"                                  \u0027msg\u0027: err})"},{"line_number":693,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexception_msg)"},{"line_number":694,"context_line":"        return {\u0027provider_location\u0027: nfs_share}"},{"line_number":695,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_8cf13cd0","line":692,"updated":"2015-08-03 23:20:18.000000000","message":"Wrap err in six.text_type() to avoid errors if the exception contains unicode characters.","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"e62404b0e3714d98ce2f4b6cef3524574a7820e4","unresolved":false,"context_lines":[{"line_number":689,"context_line":"                                   \"because rename operation failed:\""},{"line_number":690,"context_line":"                                   \" Error msg: %(msg)s.\"),"},{"line_number":691,"context_line":"                                 {\u0027name\u0027: existing_vol_ref[\u0027source-name\u0027],"},{"line_number":692,"context_line":"                                  \u0027msg\u0027: err})"},{"line_number":693,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexception_msg)"},{"line_number":694,"context_line":"        return {\u0027provider_location\u0027: nfs_share}"},{"line_number":695,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_93a4d957","line":692,"in_reply_to":"1a4dcd0f_8cf13cd0","updated":"2015-08-05 13:13:37.000000000","message":"Done","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ec37b61ee61f8fc3f398ba4eef470915f79ea777","unresolved":false,"context_lines":[{"line_number":777,"context_line":"            self._execute(\"mv\", vol_path, new_path,"},{"line_number":778,"context_line":"                          run_as_root\u003dFalse, check_exit_code\u003dTrue)"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"            LOG.info(_LI(\"Cinder NFS volume with current path \\\"%(cr)s\\\" is \""},{"line_number":781,"context_line":"                         \"no longer being managed.\"), {\u0027cr\u0027: new_path})"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        except (OSError, ValueError):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_acc5185c","line":780,"updated":"2015-08-03 23:20:18.000000000","message":"Use different inner or outer quotes to avoid needing to escape them in the string.","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"e62404b0e3714d98ce2f4b6cef3524574a7820e4","unresolved":false,"context_lines":[{"line_number":777,"context_line":"            self._execute(\"mv\", vol_path, new_path,"},{"line_number":778,"context_line":"                          run_as_root\u003dFalse, check_exit_code\u003dTrue)"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"            LOG.info(_LI(\"Cinder NFS volume with current path \\\"%(cr)s\\\" is \""},{"line_number":781,"context_line":"                         \"no longer being managed.\"), {\u0027cr\u0027: new_path})"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"        except (OSError, ValueError):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a4dcd0f_337865c4","line":780,"in_reply_to":"1a4dcd0f_acc5185c","updated":"2015-08-05 13:13:37.000000000","message":"Done","commit_id":"d1288be54e835790886c4a212ef496fc0f81794e"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"3b2b572e5d4ab4c11823b3dde949468dd5dea7f2","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                          volume[\u0027name\u0027])"},{"line_number":687,"context_line":"                self._set_rw_permissions_for_all(dst_vol)"},{"line_number":688,"context_line":"            except (OSError, processutils.ProcessExecutionError) as err:"},{"line_number":689,"context_line":"                exception_msg \u003d (_(\"Failed to manage existing volume %(name)s,\""},{"line_number":690,"context_line":"                                   \"because rename operation failed:\""},{"line_number":691,"context_line":"                                   \" Error msg: %(msg)s.\"),"},{"line_number":692,"context_line":"                                 {\u0027name\u0027: existing_vol_ref[\u0027source-name\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a4dcd0f_74652eb3","line":689,"updated":"2015-08-05 14:13:32.000000000","message":"need a blank space","commit_id":"304eec32922a78e22902698d08523629f7cb64c9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"985903bb2b16ace447d01b04f439f953aa92db65","unresolved":false,"context_lines":[{"line_number":686,"context_line":"                          volume[\u0027name\u0027])"},{"line_number":687,"context_line":"                self._set_rw_permissions_for_all(dst_vol)"},{"line_number":688,"context_line":"            except (OSError, processutils.ProcessExecutionError) as err:"},{"line_number":689,"context_line":"                exception_msg \u003d (_(\"Failed to manage existing volume %(name)s,\""},{"line_number":690,"context_line":"                                   \"because rename operation failed:\""},{"line_number":691,"context_line":"                                   \" Error msg: %(msg)s.\"),"},{"line_number":692,"context_line":"                                 {\u0027name\u0027: existing_vol_ref[\u0027source-name\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a4dcd0f_74f52e55","line":689,"in_reply_to":"1a4dcd0f_74652eb3","updated":"2015-08-05 14:21:24.000000000","message":"Done","commit_id":"304eec32922a78e22902698d08523629f7cb64c9"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"3b2b572e5d4ab4c11823b3dde949468dd5dea7f2","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                         \"no longer being managed.\"), {\u0027cr\u0027: new_path})"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"        except (OSError, ValueError):"},{"line_number":785,"context_line":"            LOG.info(_LI(\"The NFS Volume %(cr)s does not exist.\"),"},{"line_number":786,"context_line":"                     {\u0027cr\u0027: new_path})"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a4dcd0f_d4d0c221","line":785,"updated":"2015-08-05 14:13:32.000000000","message":"error level ?","commit_id":"304eec32922a78e22902698d08523629f7cb64c9"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"985903bb2b16ace447d01b04f439f953aa92db65","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                         \"no longer being managed.\"), {\u0027cr\u0027: new_path})"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"        except (OSError, ValueError):"},{"line_number":785,"context_line":"            LOG.info(_LI(\"The NFS Volume %(cr)s does not exist.\"),"},{"line_number":786,"context_line":"                     {\u0027cr\u0027: new_path})"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a4dcd0f_34a2464c","line":785,"in_reply_to":"1a4dcd0f_d4d0c221","updated":"2015-08-05 14:21:24.000000000","message":"Done","commit_id":"304eec32922a78e22902698d08523629f7cb64c9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"84c1ab69dd6fc0d040f0b289751bb466de02cdf3","unresolved":false,"context_lines":[{"line_number":628,"context_line":"            vol_ref_name)"},{"line_number":629,"context_line":"        for nfs_share in self._mounted_shares:"},{"line_number":630,"context_line":"            cfg_share \u003d self._convert_vol_ref_share_name_to_share_ip(nfs_share)"},{"line_number":631,"context_line":"            (orig_share, work_share,"},{"line_number":632,"context_line":"             file_path) \u003d vol_ref_share.partition(cfg_share)"},{"line_number":633,"context_line":"            if work_share \u003d\u003d cfg_share:"},{"line_number":634,"context_line":"                file_path \u003d file_path[1:]  # strip off leading path divider"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a4dcd0f_51235258","line":631,"updated":"2015-08-11 18:59:59.000000000","message":"orig_share doesn\u0027t appear to be used anywhere. Convention is to name it _ to denote that it is not intended to be used. If you need to do another update it might be good to change that to make it clear.","commit_id":"6e09f300cb3c98cdd0cc2a07d2629e8be7b0c652"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"84c1ab69dd6fc0d040f0b289751bb466de02cdf3","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        \"\"\""},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"        # Attempt to find NFS share, NFS mount, and volume path from vol_ref."},{"line_number":738,"context_line":"        (nfs_share, nfs_mount, vol_path"},{"line_number":739,"context_line":"         ) \u003d self._get_share_mount_and_vol_from_vol_ref(existing_vol_ref)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a4dcd0f_51da724c","line":738,"updated":"2015-08-11 18:59:59.000000000","message":"nfs_share doesn\u0027t appear to be used either.","commit_id":"6e09f300cb3c98cdd0cc2a07d2629e8be7b0c652"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"750252090a7ecbdd6d42c02395b0b5ccc1b247c6","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        # First strip out share and convert to IP format."},{"line_number":595,"context_line":"        share_split \u003d vol_ref.split(\u0027:\u0027)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        vol_ref_share_ip \u003d cutils.resolve_hostname(share_split[0])"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        # Now place back into volume reference."},{"line_number":600,"context_line":"        vol_ref_share \u003d vol_ref_share_ip + \u0027:\u0027 + share_split[1]"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a4dcd0f_6e0da4e7","line":597,"updated":"2015-08-14 16:36:42.000000000","message":"You aren\u0027t catching a hostname that can\u0027t be found","commit_id":"568b9a1f4b863abbfd130961f372c6eab6c44446"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"0f8e205abec63ed815136502d6cb37a6a0e1fdd7","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        # First strip out share and convert to IP format."},{"line_number":595,"context_line":"        share_split \u003d vol_ref.split(\u0027:\u0027)"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        vol_ref_share_ip \u003d cutils.resolve_hostname(share_split[0])"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        # Now place back into volume reference."},{"line_number":600,"context_line":"        vol_ref_share \u003d vol_ref_share_ip + \u0027:\u0027 + share_split[1]"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa1b9901_5d1d1965","line":597,"in_reply_to":"1a4dcd0f_6e0da4e7","updated":"2015-08-17 18:22:10.000000000","message":"Done","commit_id":"568b9a1f4b863abbfd130961f372c6eab6c44446"}]}