)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2ed7cfcc96407daca824b451bb3b72a99304b27d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We store volume size in GB so it\u0027s confusing to receive volume size"},{"line_number":10,"context_line":"param in MB in volume_utils.copy_volume method\u0027s param. This patch fixes"},{"line_number":11,"context_line":"it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1457238"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I796d79a8a65df41f8f2b43345c04d2a87f8cf8a8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_e3d68826","line":12,"updated":"2015-07-07 14:06:03.000000000","message":"I feel like it should be mentioned that you removed a lot of the conversions to make things more simple. Talk more about the approach so your changes are a bit clearer.","commit_id":"35a0ee8964dc7e1ae26d84fb929de98f0b1ae492"}],"cinder/image/image_utils.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"bb889fc251d9e9446fa51c84d6e076793f38d4cf","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            LOG.debug(\u0027Copying image from %(tmp)s to volume %(dest)s - \u0027"},{"line_number":276,"context_line":"                      \u0027size: %(size)s\u0027, {\u0027tmp\u0027: tmp, \u0027dest\u0027: dest,"},{"line_number":277,"context_line":"                                         \u0027size\u0027: image_meta[\u0027size\u0027]})"},{"line_number":278,"context_line":"            image_size \u003d image_meta[\u0027size\u0027]"},{"line_number":279,"context_line":"            volume_utils.copy_volume(tmp, dest, image_size, blocksize)"},{"line_number":280,"context_line":"            return"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_a392fdf4","line":278,"updated":"2015-07-06 13:24:39.000000000","message":"don\u0027t you still need to do the conversion on this?  I mean, because the image_meta[\u0027size\u0027] from Glance is in bytes, so you need to do / units.Gi no?","commit_id":"3e32ed1543bb5c6a89563c36fd21f13e26f0d011"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e569a5118aad695d8ea4c7286f413bf1ca40900e","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            LOG.debug(\u0027Copying image from %(tmp)s to volume %(dest)s - \u0027"},{"line_number":276,"context_line":"                      \u0027size: %(size)s\u0027, {\u0027tmp\u0027: tmp, \u0027dest\u0027: dest,"},{"line_number":277,"context_line":"                                         \u0027size\u0027: image_meta[\u0027size\u0027]})"},{"line_number":278,"context_line":"            image_size \u003d image_meta[\u0027size\u0027]"},{"line_number":279,"context_line":"            volume_utils.copy_volume(tmp, dest, image_size, blocksize)"},{"line_number":280,"context_line":"            return"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_06c73746","line":278,"in_reply_to":"ba3cc151_a392fdf4","updated":"2015-07-06 13:38:46.000000000","message":"You\u0027re right, John. I broke this method and unit test for it","commit_id":"3e32ed1543bb5c6a89563c36fd21f13e26f0d011"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6821d5862e61903d753b6bccd05d073b0b970ada","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            LOG.debug(\u0027Copying image from %(tmp)s to volume %(dest)s - \u0027"},{"line_number":276,"context_line":"                      \u0027size: %(size)s\u0027, {\u0027tmp\u0027: tmp, \u0027dest\u0027: dest,"},{"line_number":277,"context_line":"                                         \u0027size\u0027: image_meta[\u0027size\u0027]})"},{"line_number":278,"context_line":"            image_size \u003d image_meta[\u0027size\u0027]"},{"line_number":279,"context_line":"            volume_utils.copy_volume(tmp, dest, image_size, blocksize)"},{"line_number":280,"context_line":"            return"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_299207a0","line":278,"updated":"2015-07-07 17:47:12.000000000","message":"Before we were converting this to M from bytes.  Now it\u0027s passing bytes to copy_volume, which takes GB?\n\nThis is why I was pointing out earlier that sensible code just uses bytes... it\u0027s easier.","commit_id":"35a0ee8964dc7e1ae26d84fb929de98f0b1ae492"}]}