)]}'
{"cinder/objects/snapshot.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"3a3ee67ad6ebbda9efb65957ba56843f65bbef85","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \u0027provider_id\u0027: fields.UUIDField(nullable\u003dTrue),"},{"line_number":59,"context_line":"        \u0027metadata\u0027: fields.DictOfStringsField(),"},{"line_number":60,"context_line":"        \u0027provider_auth\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        \u0027volume\u0027: fields.ObjectField(\u0027Volume\u0027, nullable\u003dTrue),"},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_799147f0","line":61,"updated":"2015-07-09 15:02:47.000000000","message":"So what is this going to go if run against a DB that hasn\u0027t been migrated yet?","commit_id":"ace523fce0b89f6536d20cc955a4d2846972889a"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"dc542c7be18f38e0558090441ed628309ae2655d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \u0027provider_id\u0027: fields.UUIDField(nullable\u003dTrue),"},{"line_number":59,"context_line":"        \u0027metadata\u0027: fields.DictOfStringsField(),"},{"line_number":60,"context_line":"        \u0027provider_auth\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        \u0027volume\u0027: fields.ObjectField(\u0027Volume\u0027, nullable\u003dTrue),"},{"line_number":63,"context_line":"    }"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_44749734","line":61,"in_reply_to":"ba3cc151_799147f0","updated":"2015-07-09 16:06:15.000000000","message":"If user is running liberty, DB should have already been migrated. I don\u0027t think we can support this feature if DB is left un-migrated.  I am not aware that we can do that for other features that are dependent on DB change.","commit_id":"ace523fce0b89f6536d20cc955a4d2846972889a"}],"cinder/volume/driver.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"fbf13aeb758fb9bfa26d1c90b19eb7403cb4128e","unresolved":false,"context_lines":[{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def backup_volume(self, context, backup, backup_service, orig_status):"},{"line_number":777,"context_line":"        \"\"\"Create a new backup from an existing volume.\"\"\""},{"line_number":778,"context_line":"        if self.backup_use_temp_snapshot():"},{"line_number":779,"context_line":"            self._backup_volume_temp_snapshot(context, backup,"},{"line_number":780,"context_line":"                                              backup_service, orig_status)"},{"line_number":781,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_78168aa8","line":778,"updated":"2015-07-14 13:23:21.000000000","message":"What sense in this if backup_use_temp_snapshot() always returns False?","commit_id":"ef0b29e58e7d735203050cba98ce2e915bf95586"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9bd773ec8f491b0d8ef55ce8348a5ad52cc51cfb","unresolved":false,"context_lines":[{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def backup_volume(self, context, backup, backup_service, orig_status):"},{"line_number":777,"context_line":"        \"\"\"Create a new backup from an existing volume.\"\"\""},{"line_number":778,"context_line":"        if self.backup_use_temp_snapshot():"},{"line_number":779,"context_line":"            self._backup_volume_temp_snapshot(context, backup,"},{"line_number":780,"context_line":"                                              backup_service, orig_status)"},{"line_number":781,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_1af5cd55","line":778,"in_reply_to":"9a41bdd9_78168aa8","updated":"2015-07-15 03:40:34.000000000","message":"Some drivers will return False and some will return True.  So it is not always returning False.  For drivers that can attach snapshot, they should return True.","commit_id":"ef0b29e58e7d735203050cba98ce2e915bf95586"}]}