)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c40b518f58f3ecba2834791122f04992cf805cc5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The zfssa driver doesn\u0027t handle cases where a volume may not"},{"line_number":10,"context_line":"exist on the backend when a delete call is sent.  The result"},{"line_number":11,"context_line":"is a stack-trace in the logs, sometimes a crash of the service"},{"line_number":12,"context_line":"and an inability to clean up volumes from Cinders perspective."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch doesn\u0027t address the root cause of the issue, but"},{"line_number":15,"context_line":"it does handle the case more gracefully by catching the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_003d342a","line":12,"updated":"2015-07-09 09:17:03.000000000","message":"s/Cinders/Cinder\u0027s","commit_id":"e8c1f85ae628cb9861866714ba6272a0d97b6fc6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"a847ef64ce98f96c03ed55f9ab2cfe1ec49d86d3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The zfssa driver doesn\u0027t handle cases where a volume may not"},{"line_number":10,"context_line":"exist on the backend when a delete call is sent.  The result"},{"line_number":11,"context_line":"is a stack-trace in the logs, sometimes a crash of the service"},{"line_number":12,"context_line":"and an inability to clean up volumes from Cinders perspective."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch doesn\u0027t address the root cause of the issue, but"},{"line_number":15,"context_line":"it does handle the case more gracefully by catching the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_96d3da5f","line":12,"in_reply_to":"ba3cc151_003d342a","updated":"2015-07-15 15:04:32.000000000","message":"Done","commit_id":"e8c1f85ae628cb9861866714ba6272a0d97b6fc6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c40b518f58f3ecba2834791122f04992cf805cc5","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch doesn\u0027t address the root cause of the issue, but"},{"line_number":15,"context_line":"it does handle the case more gracefully by catching the"},{"line_number":16,"context_line":"exception, logging and error and returning."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This way the volume can be cleaned up on the Cinder side and"},{"line_number":19,"context_line":"the operator still has an indication that something went wrong."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_c042ecaa","line":16,"updated":"2015-07-09 09:17:03.000000000","message":"s/and/an","commit_id":"e8c1f85ae628cb9861866714ba6272a0d97b6fc6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"a847ef64ce98f96c03ed55f9ab2cfe1ec49d86d3","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch doesn\u0027t address the root cause of the issue, but"},{"line_number":15,"context_line":"it does handle the case more gracefully by catching the"},{"line_number":16,"context_line":"exception, logging and error and returning."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This way the volume can be cleaned up on the Cinder side and"},{"line_number":19,"context_line":"the operator still has an indication that something went wrong."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_76f5f6ea","line":16,"in_reply_to":"ba3cc151_c042ecaa","updated":"2015-07-15 15:04:32.000000000","message":"Done","commit_id":"e8c1f85ae628cb9861866714ba6272a0d97b6fc6"}],"cinder/volume/drivers/zfssa/zfssaiscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3965189b909e59fac18f5c4dcae679b49dd063b6","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            lun2del \u003d self.zfssa.get_lun(lcfg.zfssa_pool,"},{"line_number":252,"context_line":"                                         lcfg.zfssa_project,"},{"line_number":253,"context_line":"                                         volume[\u0027name\u0027])"},{"line_number":254,"context_line":"        except exception.VolumeBackendAPIException as ex:"},{"line_number":255,"context_line":"            # NOTE(jdg): This will log an error and continue"},{"line_number":256,"context_line":"            # if for some reason the volume no longer exists"},{"line_number":257,"context_line":"            # on the backend"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_4e2402c4","line":254,"updated":"2015-07-08 13:54:08.000000000","message":"Should this raise if it doesn\u0027t match \u0027Error Getting Volume\u0027?","commit_id":"e8c1f85ae628cb9861866714ba6272a0d97b6fc6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c40b518f58f3ecba2834791122f04992cf805cc5","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            lun2del \u003d self.zfssa.get_lun(lcfg.zfssa_pool,"},{"line_number":252,"context_line":"                                         lcfg.zfssa_project,"},{"line_number":253,"context_line":"                                         volume[\u0027name\u0027])"},{"line_number":254,"context_line":"        except exception.VolumeBackendAPIException as ex:"},{"line_number":255,"context_line":"            # NOTE(jdg): This will log an error and continue"},{"line_number":256,"context_line":"            # if for some reason the volume no longer exists"},{"line_number":257,"context_line":"            # on the backend"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_83d5ce43","line":254,"in_reply_to":"ba3cc151_4e2402c4","updated":"2015-07-09 09:17:03.000000000","message":"Sean, there\u0027s no need for that, that\u0027s the only case where VolumeBackendAPIException will happen in get_lun.","commit_id":"e8c1f85ae628cb9861866714ba6272a0d97b6fc6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c40b518f58f3ecba2834791122f04992cf805cc5","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            # on the backend"},{"line_number":258,"context_line":"            if \u0027Error Getting Volume\u0027 in ex.message:"},{"line_number":259,"context_line":"                LOG.error(_LE(\"Volume ID %s was not found on \""},{"line_number":260,"context_line":"                              \"on the zfssa device while attempting \""},{"line_number":261,"context_line":"                              \"delete_volume operation!\"), volume[\u0027id\u0027])"},{"line_number":262,"context_line":"                return"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_405b3c86","line":260,"updated":"2015-07-09 09:17:03.000000000","message":"s/on//  \u003d\u003d\u003e on is repeated from previous line\n\nWhy the exclamation at the end?  It\u0027s already logged as an error and I think we usually don\u0027t use exclamation marks in error messages.","commit_id":"e8c1f85ae628cb9861866714ba6272a0d97b6fc6"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"927657286d2ad75ae7940b7c57b90a6df9ceabe1","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            # on the backend"},{"line_number":258,"context_line":"            if \u0027Error Getting Volume\u0027 in ex.message:"},{"line_number":259,"context_line":"                LOG.error(_LE(\"Volume ID %s was not found on \""},{"line_number":260,"context_line":"                              \"on the zfssa device while attempting \""},{"line_number":261,"context_line":"                              \"delete_volume operation!\"), volume[\u0027id\u0027])"},{"line_number":262,"context_line":"                return"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_dc09572c","line":260,"in_reply_to":"ba3cc151_405b3c86","updated":"2015-07-09 17:52:06.000000000","message":"+1","commit_id":"e8c1f85ae628cb9861866714ba6272a0d97b6fc6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"a847ef64ce98f96c03ed55f9ab2cfe1ec49d86d3","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            # on the backend"},{"line_number":258,"context_line":"            if \u0027Error Getting Volume\u0027 in ex.message:"},{"line_number":259,"context_line":"                LOG.error(_LE(\"Volume ID %s was not found on \""},{"line_number":260,"context_line":"                              \"on the zfssa device while attempting \""},{"line_number":261,"context_line":"                              \"delete_volume operation!\"), volume[\u0027id\u0027])"},{"line_number":262,"context_line":"                return"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_969e7ab7","line":260,"in_reply_to":"ba3cc151_405b3c86","updated":"2015-07-15 15:04:32.000000000","message":"Done","commit_id":"e8c1f85ae628cb9861866714ba6272a0d97b6fc6"}]}