)]}'
{"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6d0c0c04f35978f89c658d878ffbb830565590b2","unresolved":false,"context_lines":[{"line_number":5742,"context_line":"                                         db\u003ddb)"},{"line_number":5743,"context_line":""},{"line_number":5744,"context_line":"        with mock.patch.object(brick_lvm.LVM, \u0027get_all_physical_volumes\u0027,"},{"line_number":5745,"context_line":"                               return_value \u003d [{}]), \\"},{"line_number":5746,"context_line":"                mock.patch.object(lvm_driver, \u0027_execute\u0027) \\"},{"line_number":5747,"context_line":"                as mock_execute, \\"},{"line_number":5748,"context_line":"                mock.patch.object(volutils, \u0027copy_volume\u0027) as mock_copy, \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_b199116f","line":5745,"updated":"2015-07-09 21:41:36.000000000","message":"Can you please not use \\.","commit_id":"d42a59b8fbc6e0ba1e5634d8bc10673cb3098381"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"92d60870070b1a3d589672ab855319a74cde6f3a","unresolved":false,"context_lines":[{"line_number":5742,"context_line":"                                         db\u003ddb)"},{"line_number":5743,"context_line":""},{"line_number":5744,"context_line":"        with mock.patch.object(brick_lvm.LVM, \u0027get_all_physical_volumes\u0027,"},{"line_number":5745,"context_line":"                               return_value \u003d [{}]), \\"},{"line_number":5746,"context_line":"                mock.patch.object(lvm_driver, \u0027_execute\u0027) \\"},{"line_number":5747,"context_line":"                as mock_execute, \\"},{"line_number":5748,"context_line":"                mock.patch.object(volutils, \u0027copy_volume\u0027) as mock_copy, \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_4779e7c6","line":5745,"in_reply_to":"ba3cc151_b199116f","updated":"2015-07-09 22:38:48.000000000","message":"Without \\ here, we hit syntax error. Do you mean there is something other syntax for this with statement?","commit_id":"d42a59b8fbc6e0ba1e5634d8bc10673cb3098381"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6d0c0c04f35978f89c658d878ffbb830565590b2","unresolved":false,"context_lines":[{"line_number":6018,"context_line":""},{"line_number":6019,"context_line":"    def test_create_volume_from_snapshot_none_sparse(self):"},{"line_number":6020,"context_line":""},{"line_number":6021,"context_line":"        with mock.patch.object(self.volume.driver, \u0027vg\u0027), \\"},{"line_number":6022,"context_line":"                mock.patch.object(self.volume.driver, \u0027_create_volume\u0027), \\"},{"line_number":6023,"context_line":"                mock.patch.object(volutils, \u0027copy_volume\u0027) as mock_copy:"},{"line_number":6024,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_11c23d34","line":6021,"updated":"2015-07-09 21:41:36.000000000","message":"Same here.","commit_id":"d42a59b8fbc6e0ba1e5634d8bc10673cb3098381"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"98e03c27766e4f3793853f44a779c57791d34d83","unresolved":false,"context_lines":[{"line_number":5800,"context_line":"        host \u003d {\u0027capabilities\u0027: capabilities}"},{"line_number":5801,"context_line":"        vol \u003d {\u0027name\u0027: \u0027testvol\u0027, \u0027id\u0027: 1, \u0027size\u0027: 2, \u0027status\u0027: \u0027available\u0027}"},{"line_number":5802,"context_line":""},{"line_number":5803,"context_line":"        def fake_execute(*args, **kwargs):"},{"line_number":5804,"context_line":"            pass"},{"line_number":5805,"context_line":""},{"line_number":5806,"context_line":"        def get_all_volume_groups():"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_852128b7","line":5803,"updated":"2015-07-23 20:57:18.000000000","message":"Method not used.","commit_id":"0f224f117af7d6af8c5ff63c1c97860d7ffd47d2"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"2f39f3cf57a4d71d88fd0a838f5243279e8dd80c","unresolved":false,"context_lines":[{"line_number":5800,"context_line":"        host \u003d {\u0027capabilities\u0027: capabilities}"},{"line_number":5801,"context_line":"        vol \u003d {\u0027name\u0027: \u0027testvol\u0027, \u0027id\u0027: 1, \u0027size\u0027: 2, \u0027status\u0027: \u0027available\u0027}"},{"line_number":5802,"context_line":""},{"line_number":5803,"context_line":"        def fake_execute(*args, **kwargs):"},{"line_number":5804,"context_line":"            pass"},{"line_number":5805,"context_line":""},{"line_number":5806,"context_line":"        def get_all_volume_groups():"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_b06ca0d1","line":5803,"in_reply_to":"3a50d1a3_852128b7","updated":"2015-07-23 21:03:55.000000000","message":"Will remove this.","commit_id":"0f224f117af7d6af8c5ff63c1c97860d7ffd47d2"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"6ee99c2b57840048dd124e12f33ec2b4519bd0ba","unresolved":false,"context_lines":[{"line_number":5829,"context_line":"                                                  None,"},{"line_number":5830,"context_line":"                                                  \u0027default\u0027)"},{"line_number":5831,"context_line":"            lvm_driver.sparse_copy_volume \u003d True"},{"line_number":5832,"context_line":"            moved, model_update \u003d \\"},{"line_number":5833,"context_line":"                lvm_driver.migrate_volume(self.context, vol, host)"},{"line_number":5834,"context_line":"            self.assertTrue(moved)"},{"line_number":5835,"context_line":"            self.assertIsNone(model_update)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_83dd4b72","line":5832,"updated":"2015-07-27 05:39:36.000000000","message":"You can use () here to replace \\.","commit_id":"8a944bc8573eee775de8ea983191e0a4e808aaba"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"fa57df76bb13963472993441dfce1b6bdeb667da","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        # copy_volume expects sizes in MiB, we store integer GiB"},{"line_number":356,"context_line":"        # be sure to convert before passing in"},{"line_number":357,"context_line":"        sparse \u003d self.configuration.lvm_type \u003d\u003d \u0027thin\u0027"},{"line_number":358,"context_line":"        volutils.copy_volume(self.local_path(snapshot),"},{"line_number":359,"context_line":"                             self.local_path(volume),"},{"line_number":360,"context_line":"                             snapshot[\u0027volume_size\u0027] * units.Ki,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_d4592efe","line":357,"updated":"2015-07-23 16:24:35.000000000","message":"can we directly use this condition in line 363?\ni mean sparse\u003dself.configuration.lvm_type \u003d\u003d \u0027thin\u0027","commit_id":"0f224f117af7d6af8c5ff63c1c97860d7ffd47d2"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"98e03c27766e4f3793853f44a779c57791d34d83","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        # copy_volume expects sizes in MiB, we store integer GiB"},{"line_number":356,"context_line":"        # be sure to convert before passing in"},{"line_number":357,"context_line":"        sparse \u003d self.configuration.lvm_type \u003d\u003d \u0027thin\u0027"},{"line_number":358,"context_line":"        volutils.copy_volume(self.local_path(snapshot),"},{"line_number":359,"context_line":"                             self.local_path(volume),"},{"line_number":360,"context_line":"                             snapshot[\u0027volume_size\u0027] * units.Ki,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_45e1e099","line":357,"in_reply_to":"3a50d1a3_1aac9c8a","updated":"2015-07-23 20:57:18.000000000","message":"I think it would be better to just set a self.sparse_copy boolean variable in check_for_setup_error rather than making this comparison in three different places.\n\nFor that, watch for collisions with https://review.openstack.org/#/c/104653/ .","commit_id":"0f224f117af7d6af8c5ff63c1c97860d7ffd47d2"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"2f39f3cf57a4d71d88fd0a838f5243279e8dd80c","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        # copy_volume expects sizes in MiB, we store integer GiB"},{"line_number":356,"context_line":"        # be sure to convert before passing in"},{"line_number":357,"context_line":"        sparse \u003d self.configuration.lvm_type \u003d\u003d \u0027thin\u0027"},{"line_number":358,"context_line":"        volutils.copy_volume(self.local_path(snapshot),"},{"line_number":359,"context_line":"                             self.local_path(volume),"},{"line_number":360,"context_line":"                             snapshot[\u0027volume_size\u0027] * units.Ki,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_b03fc086","line":357,"in_reply_to":"3a50d1a3_45e1e099","updated":"2015-07-23 21:03:55.000000000","message":"I completely agree on your suggestion. Thanks.\n\n\u003e\u003eFor that, watch for collisions with https://review.openstack.org/#/c/104653/ .\n\nI see.","commit_id":"0f224f117af7d6af8c5ff63c1c97860d7ffd47d2"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"43be2d09b481ec91039d79f34269929c69a8ca02","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        # copy_volume expects sizes in MiB, we store integer GiB"},{"line_number":356,"context_line":"        # be sure to convert before passing in"},{"line_number":357,"context_line":"        sparse \u003d self.configuration.lvm_type \u003d\u003d \u0027thin\u0027"},{"line_number":358,"context_line":"        volutils.copy_volume(self.local_path(snapshot),"},{"line_number":359,"context_line":"                             self.local_path(volume),"},{"line_number":360,"context_line":"                             snapshot[\u0027volume_size\u0027] * units.Ki,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_1aac9c8a","line":357,"in_reply_to":"3a50d1a3_8f7ab322","updated":"2015-07-23 18:04:10.000000000","message":"ok thanks.","commit_id":"0f224f117af7d6af8c5ff63c1c97860d7ffd47d2"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"1d6cbf652b32407005cdb87b79c06f5346813e79","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        # copy_volume expects sizes in MiB, we store integer GiB"},{"line_number":356,"context_line":"        # be sure to convert before passing in"},{"line_number":357,"context_line":"        sparse \u003d self.configuration.lvm_type \u003d\u003d \u0027thin\u0027"},{"line_number":358,"context_line":"        volutils.copy_volume(self.local_path(snapshot),"},{"line_number":359,"context_line":"                             self.local_path(volume),"},{"line_number":360,"context_line":"                             snapshot[\u0027volume_size\u0027] * units.Ki,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_8f7ab322","line":357,"in_reply_to":"3a50d1a3_d4592efe","updated":"2015-07-23 16:40:43.000000000","message":"Yes, we can do, but I thought it\u0027s little bit long for an argument.\nso I divided it same as size_in_mb.","commit_id":"0f224f117af7d6af8c5ff63c1c97860d7ffd47d2"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"98e03c27766e4f3793853f44a779c57791d34d83","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                                mirror_count)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"            self.vg.activate_lv(temp_snapshot[\u0027name\u0027], is_snapshot\u003dTrue)"},{"line_number":454,"context_line":"            sparse \u003d self.configuration.lvm_type \u003d\u003d \u0027thin\u0027"},{"line_number":455,"context_line":"            volutils.copy_volume("},{"line_number":456,"context_line":"                self.local_path(temp_snapshot),"},{"line_number":457,"context_line":"                self.local_path(volume),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_65017c39","line":454,"updated":"2015-07-23 20:57:18.000000000","message":"\u003c- This was more readable.","commit_id":"0f224f117af7d6af8c5ff63c1c97860d7ffd47d2"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"fa57df76bb13963472993441dfce1b6bdeb667da","unresolved":false,"context_lines":[{"line_number":619,"context_line":"            # copy_volume expects sizes in MiB, we store integer GiB"},{"line_number":620,"context_line":"            # be sure to convert before passing in"},{"line_number":621,"context_line":"            size_in_mb \u003d int(volume[\u0027size\u0027]) * units.Ki"},{"line_number":622,"context_line":"            sparse \u003d self.configuration.lvm_type \u003d\u003d \u0027thin\u0027"},{"line_number":623,"context_line":"            volutils.copy_volume(self.local_path(volume),"},{"line_number":624,"context_line":"                                 self.local_path(volume, vg\u003ddest_vg),"},{"line_number":625,"context_line":"                                 size_in_mb,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_34bdf201","line":622,"updated":"2015-07-23 16:24:35.000000000","message":"can we directly use this condition in line 628?\ni mean sparse\u003dself.configuration.lvm_type \u003d\u003d \u0027thin\u0027","commit_id":"0f224f117af7d6af8c5ff63c1c97860d7ffd47d2"}]}