)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"8ef09e61ab82887fbd4d9fbf4757ed30c5cc70af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check for non-default volume name template."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The iscsi delete methods in iscsi.py had hard-codes volume names to"},{"line_number":10,"context_line":"be \u0027volume-%s\u0027 (the default volume name template).  If a user"},{"line_number":11,"context_line":"configured volume_name_template to be something other than default"},{"line_number":12,"context_line":"the result is failure to remove the iscsi_target."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAM3%2F%2FZWA%3D","line":9,"updated":"2013-01-24 05:49:27.000000000","message":"Minor typo","commit_id":"84affd5ffd4eb7923d155338cd94f81ea325328a"}],"cinder/volume/iscsi.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"0b356d897d4c6304a069396a77fc297994c64079","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                    \u0027directory\u0027),"},{"line_number":40,"context_line":"                    cfg.StrOpt(\u0027iet_conf\u0027,"},{"line_number":41,"context_line":"                               default\u003d\u0027/etc/iet/ietd.conf\u0027,"},{"line_number":42,"context_line":"                               help\u003d\u0027IET configuration file\u0027),"},{"line_number":43,"context_line":"                    cfg.StrOpt(\u0027volume_name_template\u0027,"},{"line_number":44,"context_line":"                               default\u003d\u0027volume-%s\u0027,"},{"line_number":45,"context_line":"                               help\u003d\u0027Template string to be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FeR8%3D","line":42,"updated":"2013-01-21 03:09:38.000000000","message":"Why do we need this flag here too?","commit_id":"c7372deef14a5ee4e7bbe530145f18e3b2e561e6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7077267e6167769030b199f68a817ad33b96153c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                    \u0027directory\u0027),"},{"line_number":40,"context_line":"                    cfg.StrOpt(\u0027iet_conf\u0027,"},{"line_number":41,"context_line":"                               default\u003d\u0027/etc/iet/ietd.conf\u0027,"},{"line_number":42,"context_line":"                               help\u003d\u0027IET configuration file\u0027),"},{"line_number":43,"context_line":"                    cfg.StrOpt(\u0027volume_name_template\u0027,"},{"line_number":44,"context_line":"                               default\u003d\u0027volume-%s\u0027,"},{"line_number":45,"context_line":"                               help\u003d\u0027Template string to be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fdos%3D","line":42,"in_reply_to":"AAAAM3%2F%2FeR8%3D","updated":"2013-01-21 17:04:06.000000000","message":"Done","commit_id":"c7372deef14a5ee4e7bbe530145f18e3b2e561e6"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"0749a47727229fbd3e7f42b7c70ee166be09e12b","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def remove_iscsi_target(self, tid, lun, vol_id, **kwargs):"},{"line_number":175,"context_line":"        LOG.info(_(\u0027Removing volume: %s\u0027) % vol_id)"},{"line_number":176,"context_line":"        vol_uuid_file \u003d FLAGS.volume_name_template % vol_id"},{"line_number":177,"context_line":"        volume_path \u003d os.path.join(FLAGS.volumes_dir, vol_uuid_file)"},{"line_number":178,"context_line":"        if os.path.isfile(volume_path):"},{"line_number":179,"context_line":"            iqn \u003d \u0027%s%s\u0027 % (FLAGS.iscsi_target_prefix,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FZX0%3D","line":176,"updated":"2013-01-24 05:26:45.000000000","message":"Are we sure this will have a %s in it?","commit_id":"84affd5ffd4eb7923d155338cd94f81ea325328a"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"328fc9bfb58f6b60664060c2d05ac37914d7797c","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def remove_iscsi_target(self, tid, lun, vol_id, **kwargs):"},{"line_number":175,"context_line":"        LOG.info(_(\u0027Removing volume: %s\u0027) % vol_id)"},{"line_number":176,"context_line":"        vol_uuid_file \u003d FLAGS.volume_name_template % vol_id"},{"line_number":177,"context_line":"        volume_path \u003d os.path.join(FLAGS.volumes_dir, vol_uuid_file)"},{"line_number":178,"context_line":"        if os.path.isfile(volume_path):"},{"line_number":179,"context_line":"            iqn \u003d \u0027%s%s\u0027 % (FLAGS.iscsi_target_prefix,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FZXk%3D","line":176,"in_reply_to":"AAAAM3%2F%2FZX0%3D","updated":"2013-01-24 05:29:19.000000000","message":"Yeah, if you look at the FLAG in db.api or in cinder.conf.sample:\n\n# Template string to be used to generate volume names (string\n# value)\n#volume_name_template\u003dvolume-%s\n\n\nWe actually put the %s in the Cfg opt.","commit_id":"84affd5ffd4eb7923d155338cd94f81ea325328a"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"8640595502cd0e788002fd4791ffee1986a0fcde","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                               help\u003d\u0027IET configuration file\u0027), ]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":45,"context_line":"FLAGS.register_opts(iscsi_helper_opt)"},{"line_number":46,"context_line":"FLAGS.import_opt(\u0027volume_name_template\u0027, \u0027cinder.db\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FXoI%3D","line":45,"updated":"2013-01-25 04:50:53.000000000","message":"This doesn\u0027t have to be explicitly cinder.db.api?","commit_id":"f02c575b4b28b69cade6c1c06dd772c62754fc9c"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"b54ddaadbd27d712b875ffcfe0c10cfd77557a69","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                               help\u003d\u0027IET configuration file\u0027), ]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":45,"context_line":"FLAGS.register_opts(iscsi_helper_opt)"},{"line_number":46,"context_line":"FLAGS.import_opt(\u0027volume_name_template\u0027, \u0027cinder.db\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FWL4%3D","line":45,"in_reply_to":"AAAAM3%2F%2FXoI%3D","updated":"2013-01-27 05:53:22.000000000","message":"Looks that way to me too","commit_id":"f02c575b4b28b69cade6c1c06dd772c62754fc9c"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"6992a3b6ae2283641115d85b5e881c893fa224f5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                               help\u003d\u0027IET configuration file\u0027), ]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":45,"context_line":"FLAGS.register_opts(iscsi_helper_opt)"},{"line_number":46,"context_line":"FLAGS.import_opt(\u0027volume_name_template\u0027, \u0027cinder.db\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FWD4%3D","line":45,"in_reply_to":"AAAAM3%2F%2FXoI%3D","updated":"2013-01-28 01:28:17.000000000","message":"No, the __init__ in cinder.db pulls does \"from cinder.db.api import *\".\n\nAlso, as a general rule we shouldn\u0027t import db.api directly anywhere.","commit_id":"f02c575b4b28b69cade6c1c06dd772c62754fc9c"}]}