)]}'
{"cinder/volume/utils.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"ee680708c438417914fac897d3f40fe81f83abf3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            context, volume_ref[\u0027id\u0027])"},{"line_number":82,"context_line":"        usage_info[\u0027volume_attachment\u0027] \u003d attachments"},{"line_number":83,"context_line":"    except exception.VolumeNotFound:"},{"line_number":84,"context_line":"        LOG.debug(\"Can not find volume %s at notify usage\", volume_ref[\u0027id\u0027])"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    return usage_info"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_1b09d731","line":84,"updated":"2015-07-17 03:35:08.000000000","message":"This could potentially log the same message twice in a row.   I would move this code into the try block for the glance_meta.  Then the first failure to find the volume will log the message and move on.","commit_id":"2d27deb1a287704515272c6acc3580a55d363c89"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"ce018356a5358c00a683dd7b79a9257697526c19","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            context, volume_ref[\u0027id\u0027])"},{"line_number":82,"context_line":"        usage_info[\u0027volume_attachment\u0027] \u003d attachments"},{"line_number":83,"context_line":"    except exception.VolumeNotFound:"},{"line_number":84,"context_line":"        LOG.debug(\"Can not find volume %s at notify usage\", volume_ref[\u0027id\u0027])"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    return usage_info"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_2529ed37","line":84,"in_reply_to":"9a41bdd9_1b09d731","updated":"2015-07-17 20:59:18.000000000","message":"You are right, I haven\u0027t thought of that.","commit_id":"2d27deb1a287704515272c6acc3580a55d363c89"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"9bf1e53d0a6e6ed4bc138a0784358f1b9c8c44d2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    except exception.GlanceMetadataNotFound:"},{"line_number":79,"context_line":"        pass"},{"line_number":80,"context_line":"    except exception.VolumeNotFound:"},{"line_number":81,"context_line":"        LOG.debug(\"Can not find volume %s at notify usage\", volume_ref[\u0027id\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    return usage_info"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_1c4e7896","line":81,"updated":"2015-07-21 11:19:23.000000000","message":"Add a \u0027.\u0027 to the EOL.","commit_id":"4eb70bcf6ae6a4bb3631018da1923b6cfaae59dd"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"2a8ab8e9ea9d04da8f6394dfa1d9236404350750","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    except exception.GlanceMetadataNotFound:"},{"line_number":79,"context_line":"        pass"},{"line_number":80,"context_line":"    except exception.VolumeNotFound:"},{"line_number":81,"context_line":"        LOG.debug(\"Can not find volume %s at notify usage\", volume_ref[\u0027id\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    return usage_info"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_203c49e1","line":81,"in_reply_to":"3a50d1a3_1c4e7896","updated":"2015-07-21 20:35:03.000000000","message":"This logging message was already part of the code base.\nShould I start fixing existing code? I don\u0027t think this nitpick warrants a -1 over existing code.","commit_id":"4eb70bcf6ae6a4bb3631018da1923b6cfaae59dd"}]}