)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"dff2680bc26a6ef603c08687c80007219f43a413","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds the connector object as a parameter"},{"line_number":10,"context_line":"to all driver create_export calls.  This will enable"},{"line_number":11,"context_line":"drivers to actually use create_export method for doing"},{"line_number":12,"context_line":"what they are now doing inside of initialize_connection."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia13897a3704080fc5da71e6c8445f308d474f64a"},{"line_number":15,"context_line":"Implements: blueprint add-create-export-connector"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_49ab1d8a","line":12,"updated":"2015-07-20 13:13:20.000000000","message":"Whats the benefit of creating the exports on create_export in spite of doing on initialize_connection??","commit_id":"9cfeadd0c3df58ca04f739258193de4c35319462"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c5e81df98dfbd3da4bbc53251b7de8fb651795cf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds the connector object as a parameter"},{"line_number":10,"context_line":"to all driver create_export calls.  This will enable"},{"line_number":11,"context_line":"drivers to actually use create_export method for doing"},{"line_number":12,"context_line":"what they are now doing inside of initialize_connection."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia13897a3704080fc5da71e6c8445f308d474f64a"},{"line_number":15,"context_line":"Implements: blueprint add-create-export-connector"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_5be8b1e2","line":12,"in_reply_to":"3a50d1a3_49ab1d8a","updated":"2015-07-20 17:18:32.000000000","message":"That\u0027s the entire purpose of create_export.  Cinder drivers are supposed to be creating the exports on their backends in create_export, not initialize_connection.\n\nNova calls initialize_connection many times during the process of live migration w/o the desire to actually export a volume, but to simply collect information.   I believe I covered this in the cinder-spec.","commit_id":"9cfeadd0c3df58ca04f739258193de4c35319462"}],"cinder/volume/driver.py":[{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"0abf7b638c309269787c27e1b8391fec59eae7c8","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        return"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    @abc.abstractmethod"},{"line_number":834,"context_line":"    def create_export(self, context, volume, connector):"},{"line_number":835,"context_line":"        \"\"\"Exports the volume."},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        Can optionally return a Dictionary of changes"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_ed1667f0","line":834,"updated":"2015-07-21 16:38:01.000000000","message":"Could you update doc strings of create_export, remove_export, initialize_connection, terminate_connection based on your cinder-spec?\n\nIt\u0027s helpful to understand what we should implement in these methods for new contributors.\n\nThanks.","commit_id":"8daa37d02c4e6236f8fc8ca1268a25d070505b3a"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"9a2900c455b59b8391287d07df4ee6a3ae5027b8","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        return"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    @abc.abstractmethod"},{"line_number":834,"context_line":"    def create_export(self, context, volume, connector):"},{"line_number":835,"context_line":"        \"\"\"Exports the volume."},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        Can optionally return a Dictionary of changes"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_52f7368c","line":834,"in_reply_to":"3a50d1a3_0f7ff917","updated":"2015-07-30 19:28:35.000000000","message":"Thank you for adding explanation!","commit_id":"8daa37d02c4e6236f8fc8ca1268a25d070505b3a"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cfb3272195ac4d15487efdaf7816f300b183437d","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        return"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    @abc.abstractmethod"},{"line_number":834,"context_line":"    def create_export(self, context, volume, connector):"},{"line_number":835,"context_line":"        \"\"\"Exports the volume."},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        Can optionally return a Dictionary of changes"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_0f7ff917","line":834,"in_reply_to":"3a50d1a3_ed1667f0","updated":"2015-07-27 19:00:06.000000000","message":"Done","commit_id":"8daa37d02c4e6236f8fc8ca1268a25d070505b3a"}],"cinder/volume/drivers/xio.py":[{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"77e6cdb9173c0f39a087920d7f0768f973a77677","unresolved":false,"context_lines":[{"line_number":1345,"context_line":"            self._alloc_location(volume, host[\u0027name\u0027], 1)"},{"line_number":1346,"context_line":"        return host[\u0027name\u0027]"},{"line_number":1347,"context_line":""},{"line_number":1348,"context_line":"    def create_export(self, context, volume, connector):"},{"line_number":1349,"context_line":"        LOG.debug(\"X-IO create_export called.\")"},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"    def ensure_export(self, context, volume):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_7278322c","line":1348,"updated":"2015-07-30 19:26:34.000000000","message":"I think we don\u0027t need connector here because this calss doesn\u0027t inherit classes in driver.py","commit_id":"55cdbc0f6f290cda0dfb1a19dcfca32d432da9ee"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"77e6cdb9173c0f39a087920d7f0768f973a77677","unresolved":false,"context_lines":[{"line_number":1485,"context_line":""},{"line_number":1486,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":1487,"context_line":"        return self.driver.delete_snapshot(snapshot)"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":"    def create_export(self, context, volume):"},{"line_number":1490,"context_line":"        return self.driver.create_export(context, volume)"},{"line_number":1491,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_f22f623c","line":1488,"updated":"2015-07-30 19:26:34.000000000","message":"please add connector as an argument of L1489.","commit_id":"55cdbc0f6f290cda0dfb1a19dcfca32d432da9ee"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"77e6cdb9173c0f39a087920d7f0768f973a77677","unresolved":false,"context_lines":[{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":1596,"context_line":"        return self.driver.delete_snapshot(snapshot)"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"    def create_export(self, context, volume):"},{"line_number":1599,"context_line":"        return self.driver.create_export(context, volume)"},{"line_number":1600,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_f208c2db","line":1597,"updated":"2015-07-30 19:26:34.000000000","message":"please add connector as an argument of L1598.","commit_id":"55cdbc0f6f290cda0dfb1a19dcfca32d432da9ee"}]}