)]}'
{"cinder/volume/drivers/netapp/dataontap/ssc_cmode.py":[{"author":{"_account_id":16973,"name":"Skyler Berg","email":"skylertheberg@gmail.com","username":"sberg"},"change_message_id":"360e699fd4ff89cfb74c0a7f52e6c69b493881a2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"def query_cluster_vols_for_ssc(na_server, vserver, volume\u003dNone):"},{"line_number":148,"context_line":"    \"\"\"Queries cluster volumes for ssc.\"\"\""},{"line_number":149,"context_line":"    query \u003d {\u0027volume-attributes\u0027: None}"},{"line_number":150,"context_line":"    volume_id \u003d {\u0027volume-id-attributes\u0027: [{\u0027owning-vserver-name\u0027: vserver},"},{"line_number":151,"context_line":"                                          {\u0027type\u0027: \u0027rw\u0027},"},{"line_number":152,"context_line":"                                          {\u0027style\u0027: \u0027flex\u0027}]}"},{"line_number":153,"context_line":"    if volume:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_136ad0b3","line":150,"updated":"2015-07-21 17:12:44.000000000","message":"Should this just be a dictionary, not a list?","commit_id":"1dec3ce6d515286f44caf0ff02371392d6021b82"},{"author":{"_account_id":16064,"name":"Mike Rooney","email":"rooneym@netapp.com","username":"rooneym"},"change_message_id":"c22afaed497b013d06f78cb21f5f101f917977fb","unresolved":false,"context_lines":[{"line_number":147,"context_line":"def query_cluster_vols_for_ssc(na_server, vserver, volume\u003dNone):"},{"line_number":148,"context_line":"    \"\"\"Queries cluster volumes for ssc.\"\"\""},{"line_number":149,"context_line":"    query \u003d {\u0027volume-attributes\u0027: None}"},{"line_number":150,"context_line":"    volume_id \u003d {\u0027volume-id-attributes\u0027: [{\u0027owning-vserver-name\u0027: vserver},"},{"line_number":151,"context_line":"                                          {\u0027type\u0027: \u0027rw\u0027},"},{"line_number":152,"context_line":"                                          {\u0027style\u0027: \u0027flex\u0027}]}"},{"line_number":153,"context_line":"    if volume:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_db728849","line":150,"in_reply_to":"3a50d1a3_136ad0b3","updated":"2015-07-24 15:03:11.000000000","message":"Ideally yes, but the API layer code used to send requests to NetApp filers currently expects a list going into its parsing routine.","commit_id":"1dec3ce6d515286f44caf0ff02371392d6021b82"},{"author":{"_account_id":16973,"name":"Skyler Berg","email":"skylertheberg@gmail.com","username":"sberg"},"change_message_id":"360e699fd4ff89cfb74c0a7f52e6c69b493881a2","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                          {\u0027type\u0027: \u0027rw\u0027},"},{"line_number":152,"context_line":"                                          {\u0027style\u0027: \u0027flex\u0027}]}"},{"line_number":153,"context_line":"    if volume:"},{"line_number":154,"context_line":"        volume_id[\u0027volume-id-attributes\u0027][\u0027name\u0027] \u003d volume"},{"line_number":155,"context_line":"    query[\u0027volume-attributes\u0027] \u003d volume_id"},{"line_number":156,"context_line":"    des_attr \u003d {\u0027volume-attributes\u0027:"},{"line_number":157,"context_line":"                [\u0027volume-id-attributes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_f002ba0a","line":154,"updated":"2015-07-21 17:12:44.000000000","message":"Since you changed the type of volume_id[\u0027volume-id-attributes\u0027] from dictionary to list, this indexing will fail any time volume is not None.","commit_id":"1dec3ce6d515286f44caf0ff02371392d6021b82"},{"author":{"_account_id":16064,"name":"Mike Rooney","email":"rooneym@netapp.com","username":"rooneym"},"change_message_id":"c22afaed497b013d06f78cb21f5f101f917977fb","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                          {\u0027type\u0027: \u0027rw\u0027},"},{"line_number":152,"context_line":"                                          {\u0027style\u0027: \u0027flex\u0027}]}"},{"line_number":153,"context_line":"    if volume:"},{"line_number":154,"context_line":"        volume_id[\u0027volume-id-attributes\u0027][\u0027name\u0027] \u003d volume"},{"line_number":155,"context_line":"    query[\u0027volume-attributes\u0027] \u003d volume_id"},{"line_number":156,"context_line":"    des_attr \u003d {\u0027volume-attributes\u0027:"},{"line_number":157,"context_line":"                [\u0027volume-id-attributes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_5b9d1858","line":154,"in_reply_to":"3a50d1a3_f002ba0a","updated":"2015-07-24 15:03:11.000000000","message":"This is a good catch, thanks for pointing that out!","commit_id":"1dec3ce6d515286f44caf0ff02371392d6021b82"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"71f8c5ae8b343da4ca9a3ec19c7f896a901a309c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        \u0027volume-id-attributes\u0027: {"},{"line_number":159,"context_line":"            \u0027owning-vserver-name\u0027: vserver,"},{"line_number":160,"context_line":"            \u0027type\u0027: \u0027rw\u0027,"},{"line_number":161,"context_line":"            \u0027style\u0027: \u0027flex\u0027,"},{"line_number":162,"context_line":"        },"},{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":"    if volume:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_edcd18b8","line":161,"updated":"2015-09-15 15:28:53.000000000","message":"These trailing commas should be deleted","commit_id":"a591d2641949985e192ceaaf3cf155310ddd5f97"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"082c4a4acb13ef649d0adee63a37891dad9e3042","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        \u0027volume-id-attributes\u0027: {"},{"line_number":159,"context_line":"            \u0027owning-vserver-name\u0027: vserver,"},{"line_number":160,"context_line":"            \u0027type\u0027: \u0027rw\u0027,"},{"line_number":161,"context_line":"            \u0027style\u0027: \u0027flex\u0027,"},{"line_number":162,"context_line":"        },"},{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":"    if volume:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_edebd876","line":161,"in_reply_to":"ba15a1d1_0d05ec78","updated":"2015-09-15 15:39:32.000000000","message":"Ah interesting. Looks really strange to me, sorry.","commit_id":"a591d2641949985e192ceaaf3cf155310ddd5f97"},{"author":{"_account_id":16064,"name":"Mike Rooney","email":"rooneym@netapp.com","username":"rooneym"},"change_message_id":"bd8d5cc9eb098e9f7352c3e2d8d12b31c0b2a8a1","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        \u0027volume-id-attributes\u0027: {"},{"line_number":159,"context_line":"            \u0027owning-vserver-name\u0027: vserver,"},{"line_number":160,"context_line":"            \u0027type\u0027: \u0027rw\u0027,"},{"line_number":161,"context_line":"            \u0027style\u0027: \u0027flex\u0027,"},{"line_number":162,"context_line":"        },"},{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":"    if volume:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_0d05ec78","line":161,"in_reply_to":"ba15a1d1_edcd18b8","updated":"2015-09-15 15:33:49.000000000","message":"That isn\u0027t how I read: http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"a591d2641949985e192ceaaf3cf155310ddd5f97"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"71f8c5ae8b343da4ca9a3ec19c7f896a901a309c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            \u0027owning-vserver-name\u0027: vserver,"},{"line_number":160,"context_line":"            \u0027type\u0027: \u0027rw\u0027,"},{"line_number":161,"context_line":"            \u0027style\u0027: \u0027flex\u0027,"},{"line_number":162,"context_line":"        },"},{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":"    if volume:"},{"line_number":165,"context_line":"        volume_id[\u0027volume-id-attributes\u0027][\u0027name\u0027] \u003d volume"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_2dd47045","line":162,"updated":"2015-09-15 15:28:53.000000000","message":"These trailing commas should be deleted","commit_id":"a591d2641949985e192ceaaf3cf155310ddd5f97"}]}