)]}'
{"cinder/volume/driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0ad15f50a207ddc9e9bc10aab03477e2fe5e91e5","unresolved":false,"context_lines":[{"line_number":834,"context_line":"        and the secondary volume."},{"line_number":835,"context_line":"        \"\"\""},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        return"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    # #######  Interface methods for DataPath (Connector) ########"},{"line_number":840,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_cd7b747a","line":837,"updated":"2015-08-24 20:23:54.000000000","message":"I think this needs to be a method that just issues \"pass\" rather than an abstract method, so that drivers based on BaseVD will use the default behavior driven by the volume manager.\n\nSee https://review.openstack.org/#/c/206559/ for a similar case with retype.","commit_id":"dc4578e6c095ac734c31f4f7aecc746a2a27d1ce"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"895799ccf5f8539da735738b5218d5680a09225e","unresolved":false,"context_lines":[{"line_number":834,"context_line":"        and the secondary volume."},{"line_number":835,"context_line":"        \"\"\""},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        return"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    # #######  Interface methods for DataPath (Connector) ########"},{"line_number":840,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_5bab9089","line":837,"in_reply_to":"fa1b9901_cd7b747a","updated":"2015-08-25 06:16:21.000000000","message":"retype is a different case: it returned values in the base class. The old driver.py for create_cloned_volume raised a NotImplementedException [1]. \nUsing simple pass would change the code flow...\n\n[1]: https://github.com/openstack/cinder/blob/stable/juno/cinder/volume/driver.py#L325","commit_id":"dc4578e6c095ac734c31f4f7aecc746a2a27d1ce"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"726b2ff9ffb646dabec339f38c8b164161f8661d","unresolved":false,"context_lines":[{"line_number":1089,"context_line":"    def validate_connector_has_setting(connector, setting):"},{"line_number":1090,"context_line":"        pass"},{"line_number":1091,"context_line":""},{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"        If volume_type extra specs includes \u0027replication: \u003cis\u003e True\u0027 the"},{"line_number":1094,"context_line":"        driver needs to create a volume replica (secondary)"},{"line_number":1095,"context_line":"        and setup replication between the newly created volume"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_afbaa2df","line":1092,"updated":"2015-08-25 07:47:46.000000000","message":"Wrong here. Missed \ndef create_cloned_volume(self, volume, src_vref):","commit_id":"2233e8a9b6601d72704026a8e9cb38cab235c570"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c69707a4cf7254f22ba9b8abf5298025929e1a98","unresolved":false,"context_lines":[{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"class VolumeDriver(ConsistencyGroupVD, TransferVD, ManageableVD, ExtendVD,"},{"line_number":1909,"context_line":"                   CloneableImageVD, SnapshotVD, ReplicaVD,"},{"line_number":1910,"context_line":"                   SnapshotVD, ReplicaVD, LocalVD, MigrateVD, BaseVD):"},{"line_number":1911,"context_line":"    \"\"\"This class will be deprecated soon."},{"line_number":1912,"context_line":""},{"line_number":1913,"context_line":"    Please use the abstract classes above for new drivers."}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_0e61b7a8","line":1910,"updated":"2015-09-08 12:07:00.000000000","message":"ReplicaVd and SnapshotVD occur twice.","commit_id":"dd355b362a14950f686e7057e0ec8494908abeaf"}]}