)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"8c07b3f058f462d370c4732ad75dda3b70a2ea91","unresolved":false,"context_lines":[{"line_number":12,"context_line":"cleaned up some unwanted tests related to that."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Removed unused configuration parameter eqlx_cli_timeout"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I67a1f0b3838d67a6846b8fef33cd32957a30f9df"},{"line_number":17,"context_line":"Closes-Bug: #1415186"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a50d1a3_e73c7e95","line":15,"updated":"2015-07-20 18:28:06.000000000","message":"I would have kept the option out but if you\u0027re going to re-add it you need to fix this.","commit_id":"1cb9c01bfe749983bfe28ef8d9d9e87b5628c41c"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"3c20ae0e4c6a022c28a4077fe42a4ee8a010096d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"use that implementation and took out those functions and"},{"line_number":12,"context_line":"cleaned up some unwanted tests related to that."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Removed unused configuration parameter eqlx_cli_timeout"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I67a1f0b3838d67a6846b8fef33cd32957a30f9df"},{"line_number":17,"context_line":"Closes-Bug: #1415186"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a50d1a3_8799fa70","line":14,"updated":"2015-07-20 18:32:09.000000000","message":"Probably want to change this line.","commit_id":"ee31eb19f642b39c9a9b70a30344d4e4d9611cb4"}],"cinder/tests/unit/test_eqlx.py":[{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"302effffe02fdb8a968055071b138daeb1f8836e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.configuration.eqlx_pool \u003d \u0027non-default\u0027"},{"line_number":48,"context_line":"        self.configuration.eqlx_group_name \u003d \u0027group-0\u0027"},{"line_number":49,"context_line":"        self.configuration.eqlx_cli_max_retries \u003d 5"},{"line_number":50,"context_line":"        self.configuration.eqlx_cli_timeout \u003d 30"},{"line_number":51,"context_line":"        self.configuration.eqlx_use_chap \u003d False"},{"line_number":52,"context_line":"        self.configuration.use_chap_auth \u003d True"},{"line_number":53,"context_line":"        self.configuration.chap_username \u003d \u0027admin\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a50d1a3_df4a29ac","line":50,"updated":"2015-07-21 18:24:20.000000000","message":"Why is this back?","commit_id":"3aa9dbb91b215c3f2835ebd13583382d6febd9fa"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"4b6ece3b79decd3da5ecf255059758b550e57170","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.configuration.eqlx_pool \u003d \u0027non-default\u0027"},{"line_number":48,"context_line":"        self.configuration.eqlx_group_name \u003d \u0027group-0\u0027"},{"line_number":49,"context_line":"        self.configuration.eqlx_cli_max_retries \u003d 5"},{"line_number":50,"context_line":"        self.configuration.eqlx_cli_timeout \u003d 30"},{"line_number":51,"context_line":"        self.configuration.eqlx_use_chap \u003d False"},{"line_number":52,"context_line":"        self.configuration.use_chap_auth \u003d True"},{"line_number":53,"context_line":"        self.configuration.chap_username \u003d \u0027admin\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a50d1a3_5145ad14","line":50,"in_reply_to":"3a50d1a3_df4a29ac","updated":"2015-07-21 18:34:02.000000000","message":"The code checks for it, it will be removed next release. For now it is deprecated","commit_id":"3aa9dbb91b215c3f2835ebd13583382d6febd9fa"}],"cinder/volume/drivers/eqlx.py":[{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"e2f766f7b2b324411c8dcab970c12333c6981368","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                        return processutils.ssh_execute("},{"line_number":194,"context_line":"                            ssh,"},{"line_number":195,"context_line":"                            command,"},{"line_number":196,"context_line":"                            check_exit_code\u003dcheck_exit_code)"},{"line_number":197,"context_line":"                    except Exception:"},{"line_number":198,"context_line":"                        LOG.exception(_LE(\u0027Error running command.\u0027))"},{"line_number":199,"context_line":"                        greenthread.sleep(random.randint(20, 500) / 100.0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_324ceac6","line":196,"updated":"2015-07-20 16:31:38.000000000","message":"eqlx_cli_timeout is no longer being used and should probably be removed.","commit_id":"c527d4655db39867666fa897bb53d463a30e5e0e"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"a8b2d9b1091f2d30d18d669c35a34ca43811741b","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                        return processutils.ssh_execute("},{"line_number":194,"context_line":"                            ssh,"},{"line_number":195,"context_line":"                            command,"},{"line_number":196,"context_line":"                            check_exit_code\u003dcheck_exit_code)"},{"line_number":197,"context_line":"                    except Exception:"},{"line_number":198,"context_line":"                        LOG.exception(_LE(\u0027Error running command.\u0027))"},{"line_number":199,"context_line":"                        greenthread.sleep(random.randint(20, 500) / 100.0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_750a5c28","line":196,"in_reply_to":"3a50d1a3_324ceac6","updated":"2015-07-20 16:54:27.000000000","message":"Good catch, there is a ssh_conn_timeout, seems like it acheives the same as eqlx_cli_timeout. Will remove","commit_id":"c527d4655db39867666fa897bb53d463a30e5e0e"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"61c6b4b12fcab72ef8e3bfde80681e8ba5dff677","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    without \u0027\u003e\u0027 ending. E.g. if prompt looks like \u0027group-0\u003e\u0027, then the"},{"line_number":130,"context_line":"    parameter must be set to \u0027group-0\u0027"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    VERSION \u003d \"1.1.0\""},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_989f1f03","line":132,"updated":"2015-07-20 17:09:26.000000000","message":"You might want to mention the built in timeout that replaces this.  Or not.","commit_id":"621d2d0b9ecb9c35505074d6b0449cb37d4be226"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"f07e073ad98d71fb6676b5ad174f8f87be5de4cc","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    without \u0027\u003e\u0027 ending. E.g. if prompt looks like \u0027group-0\u003e\u0027, then the"},{"line_number":130,"context_line":"    parameter must be set to \u0027group-0\u0027"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    VERSION \u003d \"1.1.0\""},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_2cc6cd67","line":132,"in_reply_to":"3a50d1a3_989f1f03","updated":"2015-07-20 18:13:19.000000000","message":"Probably not. I will post a bug to update docs.","commit_id":"621d2d0b9ecb9c35505074d6b0449cb37d4be226"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b8cfbf9056e7e3df75461b3fd5389edbfbee45b8","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    VERSION \u003d \"1.1.0\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":137,"context_line":"        super(DellEQLSanISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_fb3c1d95","line":134,"updated":"2015-07-20 17:15:56.000000000","message":"Should probably bump up the driver version too.","commit_id":"621d2d0b9ecb9c35505074d6b0449cb37d4be226"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"f07e073ad98d71fb6676b5ad174f8f87be5de4cc","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    \"\"\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    VERSION \u003d \"1.1.0\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":137,"context_line":"        super(DellEQLSanISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_8cab6189","line":134,"in_reply_to":"3a50d1a3_fb3c1d95","updated":"2015-07-20 18:13:19.000000000","message":"Will do","commit_id":"621d2d0b9ecb9c35505074d6b0449cb37d4be226"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"8c07b3f058f462d370c4732ad75dda3b70a2ea91","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\t                    \u0027Default is 30. Note that this \u0027"},{"line_number":47,"context_line":"                     \u0027option is deprecated in favour of \"ssh_conn_timeout\" as \u0027"},{"line_number":48,"context_line":"                     \u0027specified in cinder/volume/drivers/san/san.py and will be \u0027"},{"line_number":49,"context_line":"                     \u0027removed in next release.\u0027),"},{"line_number":50,"context_line":"    cfg.IntOpt(\u0027eqlx_cli_max_retries\u0027,"},{"line_number":51,"context_line":"               default\u003d5,"},{"line_number":52,"context_line":"               help\u003d\u0027Maximum retry count for reconnection. Default is 5.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_a7f8b6e6","line":49,"updated":"2015-07-20 18:28:06.000000000","message":"Formatting is off.","commit_id":"1cb9c01bfe749983bfe28ef8d9d9e87b5628c41c"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"f138db6194b623f1a287f1a6167a17bb928c83e3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                    \u0027Default is 30. Note that this option is deprecated \u0027"},{"line_number":47,"context_line":"                    \u0027in favour of \"ssh_conn_timeout\" as \u0027"},{"line_number":48,"context_line":"                    \u0027specified in cinder/volume/drivers/san/san.py and will be \u0027"},{"line_number":49,"context_line":"                    \u0027removed in next release.\u0027),"},{"line_number":50,"context_line":"    cfg.IntOpt(\u0027eqlx_cli_max_retries\u0027,"},{"line_number":51,"context_line":"               default\u003d5,"},{"line_number":52,"context_line":"               help\u003d\u0027Maximum retry count for reconnection. Default is 5.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_8d81184d","line":49,"updated":"2015-07-20 20:04:34.000000000","message":"nice","commit_id":"038a314e47c04396335ba1dca7bbc6c0a1181b30"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"f80860635ce0e690e9ed5ab44c6da3c597770fc4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    \u0027in favour of \"ssh_conn_timeout\" as \u0027"},{"line_number":48,"context_line":"                    \u0027specified in cinder/volume/drivers/san/san.py \u0027"},{"line_number":49,"context_line":"                    \u0027and will be \u0027"},{"line_number":50,"context_line":"                    \u0027removed in next release.\u0027),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027eqlx_cli_max_retries\u0027,"},{"line_number":52,"context_line":"               default\u003d5,"},{"line_number":53,"context_line":"               help\u003d\u0027Maximum retry count for reconnection. Default is 5.\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_630ffbe1","line":50,"updated":"2015-07-20 20:52:29.000000000","message":"Maybe join those lines?\n\nAlso someone with +2 power will likely note that you edited this text with out mentioning it in the commit message.  I\u0027m cool with it but good luck.","commit_id":"70107b90aea538c01ad07b052e4740c8c8849a8a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0d46fce83af56adb322a9f1d4aaa4429924b3cb4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    \u0027in favour of \"ssh_conn_timeout\" as \u0027"},{"line_number":48,"context_line":"                    \u0027specified in cinder/volume/drivers/san/san.py \u0027"},{"line_number":49,"context_line":"                    \u0027and will be \u0027"},{"line_number":50,"context_line":"                    \u0027removed in next release.\u0027),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027eqlx_cli_max_retries\u0027,"},{"line_number":52,"context_line":"               default\u003d5,"},{"line_number":53,"context_line":"               help\u003d\u0027Maximum retry count for reconnection. Default is 5.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_1d9c4fbf","line":50,"updated":"2015-07-20 23:15:03.000000000","message":"You should use versionutils to report that this is deprecated.  You can see an example in /cinder/scheduler/manager.py","commit_id":"977756107c1a787d61bcf93dcc1355b2dc33ce49"}]}