)]}'
{"cinder/volume/drivers/ibm/storwize_svc/__init__.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"88faa6985b6158228c3af60d491a89eeef01bff4","unresolved":false,"context_lines":[{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"    def unmanage(self, volume):"},{"line_number":1068,"context_line":"        \"\"\"Remove the specified volume from Cinder management.\"\"\""},{"line_number":1069,"context_line":"        pass"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    def get_volume_stats(self, refresh\u003dFalse):"},{"line_number":1072,"context_line":"        \"\"\"Get volume stats."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_949a98c4","line":1069,"updated":"2015-07-24 12:46:55.000000000","message":"This doesn\u0027t seem right. You allow managing an existing volume but not unmanaging it? It probably should just pass then. An exception should be thrown so cinder doesn\u0027t think the volume has been unmanaged when nothings actually been done.","commit_id":"30df3c0e09e6f0ae7bca2ed15a79b3f1f1467d81"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"1ca7e69de45960335cd31465c98cac8a6b021ccc","unresolved":false,"context_lines":[{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"    def unmanage(self, volume):"},{"line_number":1068,"context_line":"        \"\"\"Remove the specified volume from Cinder management.\"\"\""},{"line_number":1069,"context_line":"        pass"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    def get_volume_stats(self, refresh\u003dFalse):"},{"line_number":1072,"context_line":"        \"\"\"Get volume stats."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_daa92926","line":1069,"in_reply_to":"3a50d1a3_949a98c4","updated":"2015-07-24 13:34:55.000000000","message":"All the unmanage function does is remove the volume from the management of openstack, but the volume should stay. In this case there is nothing to do here and the removal from openstack management is done outside the driver. \n\nWhat does bother me a little is that under the same commit there are two separate fixes, but I would let it pass because the changes are really small here.","commit_id":"30df3c0e09e6f0ae7bca2ed15a79b3f1f1467d81"}]}