)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bf0f6c2b81f7ebe4830cb99848ac15bd92da72e2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"machine configuration file. This patch sets the UUID of virtual"},{"line_number":13,"context_line":"disk corresponding to a cinder volume to volume ID so that end-"},{"line_number":14,"context_line":"users can identify the device associated with the volume using"},{"line_number":15,"context_line":"/dev/disk/by-id symlink."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1475738"},{"line_number":18,"context_line":"Change-Id: I8f9d210083010b25833a7b108ae135417c72fd09"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a4dcd0f_1be609b0","line":15,"updated":"2015-08-12 21:18:35.000000000","message":"which path are you actually changing?\n\nYou cannot change the /dev/disk/by-id/scsi-\u003cUUID\u003e path, because this is used and relied upon by the multipath daemon.  If a guest happens to be running multipath to get a /dev/mapper/\u003cUUID\u003e path, then this will most likely break that path.","commit_id":"b8d6988877014846155cc71041a527a54ab236ee"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f198cb0341486c733a8874598e6560e47ad57077","unresolved":false,"context_lines":[{"line_number":12,"context_line":"machine configuration file. This patch sets the UUID of virtual"},{"line_number":13,"context_line":"disk corresponding to a cinder volume to volume ID so that end-"},{"line_number":14,"context_line":"users can identify the device associated with the volume using"},{"line_number":15,"context_line":"/dev/disk/by-id symlink."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1475738"},{"line_number":18,"context_line":"Change-Id: I8f9d210083010b25833a7b108ae135417c72fd09"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a4dcd0f_e457e757","line":15,"in_reply_to":"1a4dcd0f_1be609b0","updated":"2015-08-13 10:35:17.000000000","message":"We are not changing any path. \n\nDuring volume creation, we set the UUID of the virtual disk in vCenter (cinder volume) to Cinder volume ID. When we attach this virtual disk (volume attach) to a Nova instance, the instance\u0027s guest will use the disk UUID (volume ID) to generate a symlink in /dev/disk/by-id/. Given a Cinder volume, user can find the corresponding device in instance\u0027s guest using the symlink /dev/disk/by-id/scsi-\u003cUUID\u003e where UUID \u003d volume ID.\n\nIf we do not set any virtual disk UUID at the time of volume creation, the ID will be random.\n\nUpdated the commit message.","commit_id":"b8d6988877014846155cc71041a527a54ab236ee"}],"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2997bc319d0f73ae7413222f6abecba0a98d0dfa","unresolved":false,"context_lines":[{"line_number":470,"context_line":"                                                summary.name,"},{"line_number":471,"context_line":"                                                profile_id,"},{"line_number":472,"context_line":"                                                adapter_type,"},{"line_number":473,"context_line":"                                                extra_config)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        self.volumeops.update_backing_disk_uuid(backing, volume[\u0027id\u0027])"},{"line_number":476,"context_line":"        return backing"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_72c81975","line":473,"updated":"2015-08-10 15:45:03.000000000","message":"same problem here as with the parent review.  You need to use the named params when calling this method.  Especially, since you named one of the vars profile_id, instead of profileId\n\nprofileId\u003dprofile_id, \nadapter_type\u003dadapter_type,\nextra_config\u003dextra_config","commit_id":"c06563c4a94586f69ef57cb51146456bb0558004"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"5831c21b2ae4d83346c56ac4ec60dbbffbcc29b8","unresolved":false,"context_lines":[{"line_number":470,"context_line":"                                                summary.name,"},{"line_number":471,"context_line":"                                                profile_id,"},{"line_number":472,"context_line":"                                                adapter_type,"},{"line_number":473,"context_line":"                                                extra_config)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        self.volumeops.update_backing_disk_uuid(backing, volume[\u0027id\u0027])"},{"line_number":476,"context_line":"        return backing"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_e38bd466","line":473,"in_reply_to":"1a4dcd0f_72c81975","updated":"2015-08-11 11:28:12.000000000","message":"Done.\n\nI don\u0027t think this is a problem since we are passing all the params including optional ones.","commit_id":"c06563c4a94586f69ef57cb51146456bb0558004"}]}