)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"0227eb18a43d7ee2e7783515e31107177dbde193","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up volume_types logging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Redundant logging of exceptions were being done with"},{"line_number":10,"context_line":"formatting exception details in the text passed in"},{"line_number":11,"context_line":"to LOG.exception."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_7a0d7536","line":9,"updated":"2015-07-24 13:21:19.000000000","message":"were-\u003ewas","commit_id":"9b2f95c1c13c83e0913e876c418b4ac19ef13c1e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"99509bea7e670516bda486da01a2acacaf8ac241","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up volume_types logging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Redundant logging of exceptions were being done with"},{"line_number":10,"context_line":"formatting exception details in the text passed in"},{"line_number":11,"context_line":"to LOG.exception."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_7a025571","line":9,"in_reply_to":"3a50d1a3_7a0d7536","updated":"2015-07-24 13:29:55.000000000","message":"Done","commit_id":"9b2f95c1c13c83e0913e876c418b4ac19ef13c1e"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"b18130f9428049fad421bf22233469b56ed627f2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"rather than passing formatting arguments in to the"},{"line_number":15,"context_line":"logger to be formatted if/when needed."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic418e40850d1ed370a94473a0cca062d56736726"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a50d1a3_282b0bed","line":17,"updated":"2015-07-25 06:26:00.000000000","message":"There is no bug related to this patch?","commit_id":"495ae80f80028032fae650e0ebb2b36974b6c41c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4f96bf31cb507a0c428d1b12baa5c04242892a4f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"rather than passing formatting arguments in to the"},{"line_number":15,"context_line":"logger to be formatted if/when needed."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic418e40850d1ed370a94473a0cca062d56736726"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a50d1a3_5b2dfcfb","line":17,"in_reply_to":"3a50d1a3_282b0bed","updated":"2015-07-31 09:30:08.000000000","message":"This is a simple cleanup, no need for a bug","commit_id":"495ae80f80028032fae650e0ebb2b36974b6c41c"}],"cinder/volume/volume_types.py":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"b55bb3d92e218ec33d07b95f29f4dbe1c23fa439","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                              description\u003ddescription),"},{"line_number":52,"context_line":"                                         projects\u003dprojects)"},{"line_number":53,"context_line":"    except db_exc.DBError:"},{"line_number":54,"context_line":"        LOG.exception(_LE(\u0027DB error: \u0027))"},{"line_number":55,"context_line":"        raise exception.VolumeTypeCreateFailed(name\u003dname,"},{"line_number":56,"context_line":"                                               extra_specs\u003dextra_specs)"},{"line_number":57,"context_line":"    return type_ref"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_6f24d9ae","line":54,"updated":"2015-07-24 13:05:17.000000000","message":"Do we need \": \" here or it should just be logged as _LE(\u0027DB error\u0027) ?","commit_id":"3adfeb1a8a46eb84dc5d22dd8d3970bdcb4d564c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5ceaab16811df1d57d3bc31a3a932d9b1de2995f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                              description\u003ddescription),"},{"line_number":52,"context_line":"                                         projects\u003dprojects)"},{"line_number":53,"context_line":"    except db_exc.DBError:"},{"line_number":54,"context_line":"        LOG.exception(_LE(\u0027DB error: \u0027))"},{"line_number":55,"context_line":"        raise exception.VolumeTypeCreateFailed(name\u003dname,"},{"line_number":56,"context_line":"                                               extra_specs\u003dextra_specs)"},{"line_number":57,"context_line":"    return type_ref"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_4f59dd8d","line":54,"in_reply_to":"3a50d1a3_6f24d9ae","updated":"2015-07-24 13:14:19.000000000","message":"I think it makes it a little more readable. The resulting log text should end up something like:\n\n2015-07-24 08:09:51.161 ERROR [req-...] DB error:\n[excpetion details]","commit_id":"3adfeb1a8a46eb84dc5d22dd8d3970bdcb4d564c"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"b55bb3d92e218ec33d07b95f29f4dbe1c23fa439","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            # flag, record this issue and move on"},{"line_number":163,"context_line":"            # TODO(zhiteng) consider add notification to warn admin"},{"line_number":164,"context_line":"            LOG.exception(_LE(\u0027Default volume type is not found, \u0027"},{"line_number":165,"context_line":"                          \u0027please check default_volume_type config: %s\u0027))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    return vol_type"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_142528c1","line":165,"updated":"2015-07-24 13:05:17.000000000","message":"Please remove %s from this log message, else I think it will cause formatting error here.","commit_id":"3adfeb1a8a46eb84dc5d22dd8d3970bdcb4d564c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5ceaab16811df1d57d3bc31a3a932d9b1de2995f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            # flag, record this issue and move on"},{"line_number":163,"context_line":"            # TODO(zhiteng) consider add notification to warn admin"},{"line_number":164,"context_line":"            LOG.exception(_LE(\u0027Default volume type is not found, \u0027"},{"line_number":165,"context_line":"                          \u0027please check default_volume_type config: %s\u0027))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    return vol_type"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_afcbc11d","line":165,"in_reply_to":"3a50d1a3_142528c1","updated":"2015-07-24 13:14:19.000000000","message":"Oops, good catch. Will fix that.","commit_id":"3adfeb1a8a46eb84dc5d22dd8d3970bdcb4d564c"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"0227eb18a43d7ee2e7783515e31107177dbde193","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            # flag, record this issue and move on"},{"line_number":163,"context_line":"            # TODO(zhiteng) consider add notification to warn admin"},{"line_number":164,"context_line":"            LOG.exception(_LE(\u0027Default volume type is not found, \u0027"},{"line_number":165,"context_line":"                          \u0027please check default_volume_type config:\u0027))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    return vol_type"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_ef2b0993","line":165,"updated":"2015-07-24 13:21:19.000000000","message":"Suggest: \"...is not found. Please check default_volume_type config.\"","commit_id":"9b2f95c1c13c83e0913e876c418b4ac19ef13c1e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"99509bea7e670516bda486da01a2acacaf8ac241","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            # flag, record this issue and move on"},{"line_number":163,"context_line":"            # TODO(zhiteng) consider add notification to warn admin"},{"line_number":164,"context_line":"            LOG.exception(_LE(\u0027Default volume type is not found, \u0027"},{"line_number":165,"context_line":"                          \u0027please check default_volume_type config:\u0027))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    return vol_type"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_5afd196d","line":165,"in_reply_to":"3a50d1a3_ef2b0993","updated":"2015-07-24 13:29:55.000000000","message":"Sure, since I\u0027m creating work for the translators by adding a space, I might as well. :)","commit_id":"9b2f95c1c13c83e0913e876c418b4ac19ef13c1e"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"103f66b5d81c01a66a5776a98cccd849da4c1d23","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                              description\u003ddescription),"},{"line_number":52,"context_line":"                                         projects\u003dprojects)"},{"line_number":53,"context_line":"    except db_exc.DBError:"},{"line_number":54,"context_line":"        LOG.exception(_LE(\u0027DB error:\u0027))"},{"line_number":55,"context_line":"        raise exception.VolumeTypeCreateFailed(name\u003dname,"},{"line_number":56,"context_line":"                                               extra_specs\u003dextra_specs)"},{"line_number":57,"context_line":"    return type_ref"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_a7052515","line":54,"updated":"2015-07-24 14:06:52.000000000","message":"Is the colon suppose to be left over?  It does not make sense since you removed the argument.","commit_id":"495ae80f80028032fae650e0ebb2b36974b6c41c"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"0ce0bd81ac9d89ad03c9a979cb0df74f90b178ec","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                              description\u003ddescription),"},{"line_number":52,"context_line":"                                         projects\u003dprojects)"},{"line_number":53,"context_line":"    except db_exc.DBError:"},{"line_number":54,"context_line":"        LOG.exception(_LE(\u0027DB error:\u0027))"},{"line_number":55,"context_line":"        raise exception.VolumeTypeCreateFailed(name\u003dname,"},{"line_number":56,"context_line":"                                               extra_specs\u003dextra_specs)"},{"line_number":57,"context_line":"    return type_ref"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_cae1589c","line":54,"in_reply_to":"3a50d1a3_0a92e057","updated":"2015-07-24 14:17:02.000000000","message":"Ok.  Maybe you can put that in the commit message for other reviewers?  It was not obvious to me.","commit_id":"495ae80f80028032fae650e0ebb2b36974b6c41c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c49bfef65324890bfeb7e51d3d36fa083a57562e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                              description\u003ddescription),"},{"line_number":52,"context_line":"                                         projects\u003dprojects)"},{"line_number":53,"context_line":"    except db_exc.DBError:"},{"line_number":54,"context_line":"        LOG.exception(_LE(\u0027DB error:\u0027))"},{"line_number":55,"context_line":"        raise exception.VolumeTypeCreateFailed(name\u003dname,"},{"line_number":56,"context_line":"                                               extra_specs\u003dextra_specs)"},{"line_number":57,"context_line":"    return type_ref"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_0a92e057","line":54,"in_reply_to":"3a50d1a3_a7052515","updated":"2015-07-24 14:13:23.000000000","message":"Yes, the resulting output will be more readable by keeping the colon at the end. Removing the argument just removed redundant logging of the exception.","commit_id":"495ae80f80028032fae650e0ebb2b36974b6c41c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4f96bf31cb507a0c428d1b12baa5c04242892a4f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                                              description\u003ddescription),"},{"line_number":52,"context_line":"                                         projects\u003dprojects)"},{"line_number":53,"context_line":"    except db_exc.DBError:"},{"line_number":54,"context_line":"        LOG.exception(_LE(\u0027DB error:\u0027))"},{"line_number":55,"context_line":"        raise exception.VolumeTypeCreateFailed(name\u003dname,"},{"line_number":56,"context_line":"                                               extra_specs\u003dextra_specs)"},{"line_number":57,"context_line":"    return type_ref"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_db4eecc1","line":54,"in_reply_to":"3a50d1a3_cae1589c","updated":"2015-07-31 09:30:08.000000000","message":"I don\u0027t think this needs clarification, it\u0027s in the method documentation: https://docs.python.org/2/library/logging.html#logging.Logger.exception","commit_id":"495ae80f80028032fae650e0ebb2b36974b6c41c"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"103f66b5d81c01a66a5776a98cccd849da4c1d23","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                             dict(name\u003dname,"},{"line_number":69,"context_line":"                                                  description\u003ddescription))"},{"line_number":70,"context_line":"    except db_exc.DBError:"},{"line_number":71,"context_line":"        LOG.exception(_LE(\u0027DB error:\u0027))"},{"line_number":72,"context_line":"        raise exception.VolumeTypeUpdateFailed(id\u003did)"},{"line_number":73,"context_line":"    return type_updated"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_c702b10b","line":71,"updated":"2015-07-24 14:06:52.000000000","message":"Ditto","commit_id":"495ae80f80028032fae650e0ebb2b36974b6c41c"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"103f66b5d81c01a66a5776a98cccd849da4c1d23","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            # flag, record this issue and move on"},{"line_number":163,"context_line":"            # TODO(zhiteng) consider add notification to warn admin"},{"line_number":164,"context_line":"            LOG.exception(_LE(\u0027Default volume type is not found. \u0027"},{"line_number":165,"context_line":"                          \u0027Please check default_volume_type config:\u0027))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    return vol_type"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_276cb507","line":165,"updated":"2015-07-24 14:06:52.000000000","message":"Ditto","commit_id":"495ae80f80028032fae650e0ebb2b36974b6c41c"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"9649039d698408dd43b9df6e0fa739fae2df92c9","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            # flag, record this issue and move on"},{"line_number":163,"context_line":"            # TODO(zhiteng) consider add notification to warn admin"},{"line_number":164,"context_line":"            LOG.exception(_LE(\u0027Default volume type is not found. \u0027"},{"line_number":165,"context_line":"                          \u0027Please check default_volume_type config:\u0027))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    return vol_type"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_1a5eb145","line":165,"updated":"2015-07-24 13:35:15.000000000","message":"I think you missed something here, we don\u0027t raise exception here","commit_id":"495ae80f80028032fae650e0ebb2b36974b6c41c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d33fb3d4b09050c7330da19439d0473558821ee7","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            # flag, record this issue and move on"},{"line_number":163,"context_line":"            # TODO(zhiteng) consider add notification to warn admin"},{"line_number":164,"context_line":"            LOG.exception(_LE(\u0027Default volume type is not found. \u0027"},{"line_number":165,"context_line":"                          \u0027Please check default_volume_type config:\u0027))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    return vol_type"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_f5e3d631","line":165,"in_reply_to":"3a50d1a3_1a5eb145","updated":"2015-07-24 13:39:33.000000000","message":"Not sure what you mean. This just logs that the default volume type was not found. I haven\u0027t changed any behavior either. Can you elaborate?","commit_id":"495ae80f80028032fae650e0ebb2b36974b6c41c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c49bfef65324890bfeb7e51d3d36fa083a57562e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            # flag, record this issue and move on"},{"line_number":163,"context_line":"            # TODO(zhiteng) consider add notification to warn admin"},{"line_number":164,"context_line":"            LOG.exception(_LE(\u0027Default volume type is not found. \u0027"},{"line_number":165,"context_line":"                          \u0027Please check default_volume_type config:\u0027))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    return vol_type"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_aaac0c8d","line":165,"in_reply_to":"3a50d1a3_276cb507","updated":"2015-07-24 14:13:23.000000000","message":"Anton clarified what he was asking on IRC. This was related to a misunderstanding of what LOG.exception does. I have a feeling this may be the same case for you Thang.","commit_id":"495ae80f80028032fae650e0ebb2b36974b6c41c"}]}