)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"7fbb026cec7ff128df0f9a84e2b6f8e5e1f41f15","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When getting the default quota value of a project, the DBQuotaDriver"},{"line_number":10,"context_line":"is just checking if the default_quota_class CONF is set to True."},{"line_number":11,"context_line":"But this conf should not be considered when getting default quota"},{"line_number":12,"context_line":"values to subprojects."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib88bafca915dfd387086c353c25b2af037e6d50f"},{"line_number":15,"context_line":"Closes-bug: 1478651"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_4f050178","line":12,"updated":"2015-07-27 19:03:19.000000000","message":"Can you add to this last sentence to explain why this extra check is a bad thing?","commit_id":"e1e201cabd6e372aa856d8a94315055aa161d85b"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"d0a404409cd7efd903f1f4515739c8598371d577","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When getting the default quota value of a project, the DBQuotaDriver"},{"line_number":10,"context_line":"is just checking if the default_quota_class CONF is set to True."},{"line_number":11,"context_line":"But this conf should not be considered when getting default quota"},{"line_number":12,"context_line":"values to subprojects."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib88bafca915dfd387086c353c25b2af037e6d50f"},{"line_number":15,"context_line":"Closes-bug: 1478651"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_b51412e9","line":12,"in_reply_to":"3a50d1a3_4f050178","updated":"2015-07-27 19:43:41.000000000","message":"Done","commit_id":"e1e201cabd6e372aa856d8a94315055aa161d85b"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"a112bf42b1500799213511eb60c5ac0ef907b86b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"But this conf should not be considered when getting default quota"},{"line_number":12,"context_line":"values for subprojects."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"with the previous check, if we asked for the default quota of a"},{"line_number":15,"context_line":"subproject, that would return the default values as it was a root"},{"line_number":16,"context_line":"project."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_80a756bc","line":14,"updated":"2015-07-27 20:16:32.000000000","message":"Capitalize \"with\".","commit_id":"8dded82a12b4c9389bd3a3cd3399985d0091adc9"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"a112bf42b1500799213511eb60c5ac0ef907b86b","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"with the previous check, if we asked for the default quota of a"},{"line_number":15,"context_line":"subproject, that would return the default values as it was a root"},{"line_number":16,"context_line":"project."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib88bafca915dfd387086c353c25b2af037e6d50f"},{"line_number":19,"context_line":"Closes-bug: 1478651"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_60d1ea56","line":16,"updated":"2015-07-27 20:16:32.000000000","message":"This paragraph is a little confusing to me. Suggestion: \"Previously when we asked for the default quota values of a subproject, the default quota values of the root project was returned.\".","commit_id":"8dded82a12b4c9389bd3a3cd3399985d0091adc9"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"f101e4760d0553cda6eb5c1f85f208c6f961c590","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"with the previous check, if we asked for the default quota of a"},{"line_number":15,"context_line":"subproject, that would return the default values as it was a root"},{"line_number":16,"context_line":"project."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib88bafca915dfd387086c353c25b2af037e6d50f"},{"line_number":19,"context_line":"Closes-bug: 1478651"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_c6eb36db","line":16,"in_reply_to":"3a50d1a3_60d1ea56","updated":"2015-07-27 20:58:39.000000000","message":"I have updated it, thanks.","commit_id":"8dded82a12b4c9389bd3a3cd3399985d0091adc9"}],"cinder/quota.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"67a7367da31c721f02b7eb912601e492c2dda0ea","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        quotas \u003d {}"},{"line_number":124,"context_line":"        default_quotas \u003d {}"},{"line_number":125,"context_line":"        if CONF.use_default_quota_class and not parent_project_id:"},{"line_number":126,"context_line":"            default_quotas \u003d db.quota_class_get_default(context)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        for resource in resources.values():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_bd94c28a","line":125,"updated":"2015-07-28 19:43:09.000000000","message":"Unless I\u0027m not reading this right, if this is a subproject default_quotas will be an empty dict. Then below when it checks if resource.name is in default_quotas it will make that if condition true and report any resource values as deprecated.","commit_id":"f526cb977624fdb3e5584b3d162a8f1596e242cc"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"813bef65eb11ac5550cc3070eb8b75f5c6a72285","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        quotas \u003d {}"},{"line_number":124,"context_line":"        default_quotas \u003d {}"},{"line_number":125,"context_line":"        if CONF.use_default_quota_class and not parent_project_id:"},{"line_number":126,"context_line":"            default_quotas \u003d db.quota_class_get_default(context)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        for resource in resources.values():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_3888c070","line":125,"in_reply_to":"3a50d1a3_bd94c28a","updated":"2015-07-28 21:26:19.000000000","message":"You are right! Good catch!","commit_id":"f526cb977624fdb3e5584b3d162a8f1596e242cc"}]}