)]}'
{"cinder/tests/unit/api/contrib/test_cgsnapshots.py":[{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"ba0a0867ad0e64864332ebecef2f487b592d8332","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        res_dict \u003d json.loads(res.body)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        self.assertEqual(200, res.status_int)"},{"line_number":238,"context_line":"        self.assertEqual("},{"line_number":239,"context_line":"            \u0027this is a test cgsnapshot\u0027,"},{"line_number":240,"context_line":"            res_dict[\u0027cgsnapshots\u0027][0][\u0027description\u0027])"},{"line_number":241,"context_line":"        self.assertEqual(\u0027test_cgsnapshot\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_d95e2445","line":238,"updated":"2015-08-03 23:04:18.000000000","message":"No new line was required here.","commit_id":"c277f5d1dc319277e472d63b1218b7e47646cd9e"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"ba0a0867ad0e64864332ebecef2f487b592d8332","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        res \u003d req.get_response(fakes.wsgi_app())"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        self.assertEqual(202, res.status_int)"},{"line_number":455,"context_line":"        self.assertEqual(\u0027deleting\u0027, self._get_cgsnapshot_attrib(cgsnapshot_id,"},{"line_number":456,"context_line":"                         \u0027status\u0027))"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        db.cgsnapshot_destroy(context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_7936f004","line":455,"updated":"2015-08-03 23:04:18.000000000","message":"While here you\u0027re removing the new line. I would prefer a consistent approach to this.","commit_id":"c277f5d1dc319277e472d63b1218b7e47646cd9e"}],"cinder/tests/unit/test_cmd.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"0016e9d197e121848bef17a1c04270f1f7e3d64d","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"        exit \u003d self.assertRaises(SystemExit, cinder_rtstool.usage)"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        self.assertTrue(usage.called)"},{"line_number":1055,"context_line":"        self.assertEqual(exit.code, 1)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"    def test_main_create_argv_lt_6(self):"},{"line_number":1058,"context_line":"        sys.argv \u003d [\u0027cinder-rtstool\u0027, \u0027create\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_d453c715","line":1055,"updated":"2015-07-28 09:58:34.000000000","message":"missed","commit_id":"07bf7fb341d345087692a8f9f7eb34b95ddc91d0"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"9010afe8852cba823d2e7635a8582c044e78c9a1","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"        exit \u003d self.assertRaises(SystemExit, cinder_rtstool.usage)"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        self.assertTrue(usage.called)"},{"line_number":1055,"context_line":"        self.assertEqual(exit.code, 1)"},{"line_number":1056,"context_line":""},{"line_number":1057,"context_line":"    def test_main_create_argv_lt_6(self):"},{"line_number":1058,"context_line":"        sys.argv \u003d [\u0027cinder-rtstool\u0027, \u0027create\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_225c1c7c","line":1055,"in_reply_to":"3a50d1a3_d453c715","updated":"2015-07-28 15:57:20.000000000","message":"Done","commit_id":"07bf7fb341d345087692a8f9f7eb34b95ddc91d0"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"e891f99b7f57c6d766f70f2d29e77bad3d45bfa1","unresolved":false,"context_lines":[{"line_number":1221,"context_line":"        exit \u003d self.assertRaises(SystemExit, volume_usage_audit.main)"},{"line_number":1222,"context_line":""},{"line_number":1223,"context_line":"        get_admin_context.assert_called_once_with()"},{"line_number":1224,"context_line":"        self.assertEqual(CONF.project, \u0027cinder\u0027)"},{"line_number":1225,"context_line":"        self.assertEqual(CONF.version, version.version_string())"},{"line_number":1226,"context_line":"        log_setup.assert_called_once_with(CONF, \"cinder\")"},{"line_number":1227,"context_line":"        get_logger.assert_called_once_with(\u0027cinder\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_53f471ef","line":1224,"updated":"2015-07-29 10:20:04.000000000","message":"It is missed here.","commit_id":"d3e9dff6691eb8f00cb972f7f1bacb7a7e00d97f"}],"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"0016e9d197e121848bef17a1c04270f1f7e3d64d","unresolved":false,"context_lines":[{"line_number":562,"context_line":"                    val1_dict \u003d {x.key: x.value for x in val1}"},{"line_number":563,"context_line":"                    val2_dict \u003d {x.key: x.value for x in val2}"},{"line_number":564,"context_line":"                    self.assertDictMatch(val1_dict, val2_dict)"},{"line_number":565,"context_line":"                else:"},{"line_number":566,"context_line":"                    self.assertEqual(val1, val2)"},{"line_number":567,"context_line":"        return result"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_19a5ea45","line":565,"updated":"2015-07-28 09:58:34.000000000","message":"I think here too","commit_id":"07bf7fb341d345087692a8f9f7eb34b95ddc91d0"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"9010afe8852cba823d2e7635a8582c044e78c9a1","unresolved":false,"context_lines":[{"line_number":562,"context_line":"                    val1_dict \u003d {x.key: x.value for x in val1}"},{"line_number":563,"context_line":"                    val2_dict \u003d {x.key: x.value for x in val2}"},{"line_number":564,"context_line":"                    self.assertDictMatch(val1_dict, val2_dict)"},{"line_number":565,"context_line":"                else:"},{"line_number":566,"context_line":"                    self.assertEqual(val1, val2)"},{"line_number":567,"context_line":"        return result"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_a2dfccd4","line":565,"in_reply_to":"3a50d1a3_19a5ea45","updated":"2015-07-28 15:57:20.000000000","message":"This is just to check the equality. I am going to keep it as is.","commit_id":"07bf7fb341d345087692a8f9f7eb34b95ddc91d0"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"b0d55c99bcc9bd6c5e05fbfdfa0513700d5cf0e4","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        # single match"},{"line_number":512,"context_line":"        volumes \u003d db.volume_get_all(self.ctxt, None, None, [\u0027created_at\u0027],"},{"line_number":513,"context_line":"                                    [\u0027asc\u0027], {\u0027status\u0027: \u0027in-use\u0027})"},{"line_number":514,"context_line":"        self.assertEqual(len(volumes), 1)"},{"line_number":515,"context_line":"        self.assertEqual(volumes[0][\u0027status\u0027], \u0027in-use\u0027)"},{"line_number":516,"context_line":"        # multiple match"},{"line_number":517,"context_line":"        volumes \u003d db.volume_get_all(self.ctxt, None, None, [\u0027created_at\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_330a057a","line":514,"updated":"2015-07-29 10:25:42.000000000","message":"missed","commit_id":"d3e9dff6691eb8f00cb972f7f1bacb7a7e00d97f"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"b0d55c99bcc9bd6c5e05fbfdfa0513700d5cf0e4","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        volumes \u003d db.volume_get_all(self.ctxt, None, None, [\u0027created_at\u0027],"},{"line_number":513,"context_line":"                                    [\u0027asc\u0027], {\u0027status\u0027: \u0027in-use\u0027})"},{"line_number":514,"context_line":"        self.assertEqual(len(volumes), 1)"},{"line_number":515,"context_line":"        self.assertEqual(volumes[0][\u0027status\u0027], \u0027in-use\u0027)"},{"line_number":516,"context_line":"        # multiple match"},{"line_number":517,"context_line":"        volumes \u003d db.volume_get_all(self.ctxt, None, None, [\u0027created_at\u0027],"},{"line_number":518,"context_line":"                                    [\u0027asc\u0027], {\u0027status\u0027: \u0027available\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_737badf5","line":515,"updated":"2015-07-29 10:25:42.000000000","message":"missed","commit_id":"d3e9dff6691eb8f00cb972f7f1bacb7a7e00d97f"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"b0d55c99bcc9bd6c5e05fbfdfa0513700d5cf0e4","unresolved":false,"context_lines":[{"line_number":518,"context_line":"                                    [\u0027asc\u0027], {\u0027status\u0027: \u0027available\u0027})"},{"line_number":519,"context_line":"        self.assertEqual(2, len(volumes))"},{"line_number":520,"context_line":"        for volume in volumes:"},{"line_number":521,"context_line":"            self.assertEqual(volume[\u0027status\u0027], \u0027available\u0027)"},{"line_number":522,"context_line":"        # multiple filters"},{"line_number":523,"context_line":"        volumes \u003d db.volume_get_all(self.ctxt, None, None, [\u0027created_at\u0027],"},{"line_number":524,"context_line":"                                    [\u0027asc\u0027], {\u0027status\u0027: \u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_93651946","line":521,"updated":"2015-07-29 10:25:42.000000000","message":"missed","commit_id":"d3e9dff6691eb8f00cb972f7f1bacb7a7e00d97f"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"b0d55c99bcc9bd6c5e05fbfdfa0513700d5cf0e4","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                                              \u0027display_name\u0027: \u0027vol1\u0027})"},{"line_number":526,"context_line":"        self.assertEqual(1, len(volumes))"},{"line_number":527,"context_line":"        self.assertEqual(volumes[0][\u0027display_name\u0027], \u0027vol1\u0027)"},{"line_number":528,"context_line":"        self.assertEqual(volumes[0][\u0027status\u0027], \u0027available\u0027)"},{"line_number":529,"context_line":"        # no match"},{"line_number":530,"context_line":"        volumes \u003d db.volume_get_all(self.ctxt, None, None, [\u0027created_at\u0027],"},{"line_number":531,"context_line":"                                    [\u0027asc\u0027], {\u0027status\u0027: \u0027in-use\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_33cf652a","line":528,"updated":"2015-07-29 10:25:42.000000000","message":"missed","commit_id":"d3e9dff6691eb8f00cb972f7f1bacb7a7e00d97f"}],"cinder/tests/unit/test_volume_utils.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"40287d2d5c87361d3da804c54f6bbc24fc11f94a","unresolved":false,"context_lines":[{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_extract_host(self):"},{"line_number":649,"context_line":"        host \u003d \u0027Host\u0027"},{"line_number":650,"context_line":"        pool \u003d \u0027Pool\u0027"},{"line_number":651,"context_line":"        # default level is \u0027backend\u0027"},{"line_number":652,"context_line":"        self.assertEqual(host,"},{"line_number":653,"context_line":"                         volume_utils.extract_host(host))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_593932d6","line":650,"updated":"2015-07-28 09:41:45.000000000","message":"This code will be more readable if you set the pool variable at the top of the stanzas where it is used, and only at the top of those stanzas, the same way you do with the host variable.  I realized it doesn\u0027t change its value the way the host variable does.","commit_id":"07bf7fb341d345087692a8f9f7eb34b95ddc91d0"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"9010afe8852cba823d2e7635a8582c044e78c9a1","unresolved":false,"context_lines":[{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_extract_host(self):"},{"line_number":649,"context_line":"        host \u003d \u0027Host\u0027"},{"line_number":650,"context_line":"        pool \u003d \u0027Pool\u0027"},{"line_number":651,"context_line":"        # default level is \u0027backend\u0027"},{"line_number":652,"context_line":"        self.assertEqual(host,"},{"line_number":653,"context_line":"                         volume_utils.extract_host(host))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_2522e6a3","line":650,"in_reply_to":"3a50d1a3_593932d6","updated":"2015-07-28 15:57:20.000000000","message":"Done","commit_id":"07bf7fb341d345087692a8f9f7eb34b95ddc91d0"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"0016e9d197e121848bef17a1c04270f1f7e3d64d","unresolved":false,"context_lines":[{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_extract_host(self):"},{"line_number":649,"context_line":"        host \u003d \u0027Host\u0027"},{"line_number":650,"context_line":"        pool \u003d \u0027Pool\u0027"},{"line_number":651,"context_line":"        # default level is \u0027backend\u0027"},{"line_number":652,"context_line":"        self.assertEqual(host,"},{"line_number":653,"context_line":"                         volume_utils.extract_host(host))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_34154b3f","line":650,"in_reply_to":"3a50d1a3_593932d6","updated":"2015-07-28 09:58:34.000000000","message":"Good suggestion","commit_id":"07bf7fb341d345087692a8f9f7eb34b95ddc91d0"}],"cinder/tests/unit/test_wsgi.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"9c78b69457e3ae263fbc70cb8623fd917f907654","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        expected \u003d (\u0027ExceptionWithSafety: some explanation\u0027 if expose else"},{"line_number":294,"context_line":"                    \u0027The server has either erred or is incapable \u0027"},{"line_number":295,"context_line":"                    \u0027of performing the requested operation.\u0027)"},{"line_number":296,"context_line":"        self.assertIn(expected, resp.body)"},{"line_number":297,"context_line":"        self.assertEqual(resp.status_int, 500, resp.body)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def test_safe_exceptions_are_described_in_faults(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_3b8a6165","line":296,"updated":"2015-07-31 14:09:40.000000000","message":"Missed here.","commit_id":"d3e9dff6691eb8f00cb972f7f1bacb7a7e00d97f"}]}