)]}'
{"cinder/api/contrib/types_manage.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"24a2f63a16d754875079956bca124de27f9b7466","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if not utils.is_valid_boolstr(is_public):"},{"line_number":77,"context_line":"            msg \u003d _(\"Invalid value \u0027%s\u0027 for is_public.\") % is_public"},{"line_number":78,"context_line":"            raise exception.InvalidInput(message\u003dmsg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            volume_types.create(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_cf7f6a15","line":78,"updated":"2015-07-29 14:47:27.000000000","message":"The exception should be webob.exc.HTTPBadRequest","commit_id":"5d1aa2b3e8cd6b56506d73941615a5505f3cd973"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"571579f9b2119d34b25242ebef4c1f311814fcec","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if not utils.is_valid_boolstr(is_public):"},{"line_number":77,"context_line":"            msg \u003d _(\"Invalid value \u0027%s\u0027 for is_public.\") % is_public"},{"line_number":78,"context_line":"            raise exception.InvalidInput(message\u003dmsg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            volume_types.create(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_eb2ebdaa","line":78,"in_reply_to":"3a50d1a3_92a505a3","updated":"2015-07-30 01:25:23.000000000","message":"Done","commit_id":"5d1aa2b3e8cd6b56506d73941615a5505f3cd973"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"c0d12dbc3fa19df4af32221a79ee9a44b5e75a66","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if not utils.is_valid_boolstr(is_public):"},{"line_number":77,"context_line":"            msg \u003d _(\"Invalid value \u0027%s\u0027 for is_public.\") % is_public"},{"line_number":78,"context_line":"            raise exception.InvalidInput(message\u003dmsg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            volume_types.create(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_92a505a3","line":78,"in_reply_to":"3a50d1a3_cf7f6a15","updated":"2015-07-29 15:05:35.000000000","message":"Agree, also please specify correct value","commit_id":"5d1aa2b3e8cd6b56506d73941615a5505f3cd973"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"571579f9b2119d34b25242ebef4c1f311814fcec","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if not utils.is_valid_boolstr(is_public):"},{"line_number":77,"context_line":"            msg \u003d _(\"Invalid value \u0027%s\u0027 for is_public.\") % is_public"},{"line_number":78,"context_line":"            raise exception.InvalidInput(message\u003dmsg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            volume_types.create(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_4b53313a","line":78,"in_reply_to":"3a50d1a3_cf7f6a15","updated":"2015-07-30 01:25:23.000000000","message":"Done","commit_id":"5d1aa2b3e8cd6b56506d73941615a5505f3cd973"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"deb1768934984271671d7440843aabac0a78139c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                      min_length\u003d0, max_length\u003d255)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if not utils.is_valid_boolstr(is_public):"},{"line_number":77,"context_line":"            msg \u003d _(\"Invalid value \u0027%s\u0027 for is_public, available value: \""},{"line_number":78,"context_line":"                    \"True or False.\") % is_public"},{"line_number":79,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_ae408336","line":77,"updated":"2015-07-31 08:29:04.000000000","message":"s/value/values","commit_id":"8747058139b51532997a5047f2f168cc1fdbdebf"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"60dc6ed96fc3f71ecc8bf00ad7efb950ac37cf53","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                      min_length\u003d0, max_length\u003d255)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if not utils.is_valid_boolstr(is_public):"},{"line_number":77,"context_line":"            msg \u003d _(\"Invalid value \u0027%s\u0027 for is_public, available value: \""},{"line_number":78,"context_line":"                    \"True or False.\") % is_public"},{"line_number":79,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_d48fbe73","line":77,"in_reply_to":"3a50d1a3_ae408336","updated":"2015-08-10 00:54:08.000000000","message":"Done","commit_id":"8747058139b51532997a5047f2f168cc1fdbdebf"}],"cinder/tests/unit/api/contrib/test_types_manage.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"352c50f1881f7b5869e6362e3e9f14bdf68c982d","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        self.assertRaises(webob.exc.HTTPConflict,"},{"line_number":247,"context_line":"                          self.controller._create, req, body)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def test_create_type_with_invalid_is_public(self):"},{"line_number":250,"context_line":"        body \u003d {\"volume_type\": {\"name\": \"vol_type_1\","},{"line_number":251,"context_line":"                                \"os-volume-type-access:is_public\": \"fake\","},{"line_number":252,"context_line":"                                \"description\": \"test description\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_79f60092","line":249,"updated":"2015-07-30 05:39:49.000000000","message":"What about adding a case for the valid is_public?","commit_id":"ff193eda52d9428057b6a096d5287fe2e074b0ee"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"a0e2d3eaf2d429e9a1cfe2ce62d429a4e48831b7","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        self.assertRaises(webob.exc.HTTPConflict,"},{"line_number":247,"context_line":"                          self.controller._create, req, body)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def test_create_type_with_invalid_is_public(self):"},{"line_number":250,"context_line":"        body \u003d {\"volume_type\": {\"name\": \"vol_type_1\","},{"line_number":251,"context_line":"                                \"os-volume-type-access:is_public\": \"fake\","},{"line_number":252,"context_line":"                                \"description\": \"test description\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_4e024a74","line":249,"in_reply_to":"3a50d1a3_79f60092","updated":"2015-07-30 12:13:10.000000000","message":"Reasonable, done","commit_id":"ff193eda52d9428057b6a096d5287fe2e074b0ee"}]}