)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5b84b7c8516585fd047a6a63cfcece9b467bbcd4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Over subscription for HP LeftHand iSCSI driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support for over subscription in the HP LeftHand iSCSI driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ibaef68264edd8019a4afd72fea4d8f002254adbb"},{"line_number":12,"context_line":"Implements: blueprint over-subscription-lefthand"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_f2ef57e7","line":10,"updated":"2015-07-31 01:43:05.000000000","message":"Please add DocImpact for the new config options.","commit_id":"10bcedaf6fc49fc57633ed002347f8552063f9c8"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"763533660dfef701316133b7af3ab57acd2c9011","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Over subscription for HP LeftHand iSCSI driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support for over subscription in the HP LeftHand iSCSI driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ibaef68264edd8019a4afd72fea4d8f002254adbb"},{"line_number":12,"context_line":"Implements: blueprint over-subscription-lefthand"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_c1426b68","line":10,"in_reply_to":"3a50d1a3_f2ef57e7","updated":"2015-07-31 15:49:16.000000000","message":"Done","commit_id":"10bcedaf6fc49fc57633ed002347f8552063f9c8"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"b72757d511d89c6f0b5d64971e0c6cc81a5a587d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Over subscription for HP LeftHand iSCSI driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add support for over subscription in the HP LeftHand iSCSI driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ibaef68264edd8019a4afd72fea4d8f002254adbb"},{"line_number":12,"context_line":"Implements: blueprint over-subscription-lefthand"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_8139c3da","line":10,"in_reply_to":"3a50d1a3_f2ef57e7","updated":"2015-07-31 15:33:03.000000000","message":"I don\u0027t see that individual drivers that have implemented over subscription document anything in the Configuration reference guide, at least for Kilo? Do I still need the DocImpact flag? If I have to do another patch set I\u0027ll add it.","commit_id":"10bcedaf6fc49fc57633ed002347f8552063f9c8"}],"cinder/volume/drivers/san/hp/hp_lefthand_rest_proxy.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"e5d411858a061de9c0793d8a244e7477b4b7618e","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        finally:"},{"line_number":295,"context_line":"            self._logout(client)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def _update_backend_status(self, client):"},{"line_number":298,"context_line":"        data \u003d {}"},{"line_number":299,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":300,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or self.__class__.__name__"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_5cb9b214","line":297,"updated":"2015-07-30 06:15:30.000000000","message":"Kurt, would it be possible to add a test method for _update_backend_status?\nI think we can verify if device_stats gets all the data we need.\nThanks.","commit_id":"3b47a03b43bf6b93a981d5629fe48472499f5a46"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"976d243c4c334d5f9d1ce49915eaf5737d3d519d","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        finally:"},{"line_number":295,"context_line":"            self._logout(client)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def _update_backend_status(self, client):"},{"line_number":298,"context_line":"        data \u003d {}"},{"line_number":299,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":300,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or self.__class__.__name__"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_fb4dfd99","line":297,"in_reply_to":"3a50d1a3_5cb9b214","updated":"2015-07-30 20:52:17.000000000","message":"Done","commit_id":"3b47a03b43bf6b93a981d5629fe48472499f5a46"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5b84b7c8516585fd047a6a63cfcece9b467bbcd4","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        data \u003d {}"},{"line_number":299,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":300,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or self.__class__.__name__"},{"line_number":301,"context_line":"        data[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":302,"context_line":"        data[\u0027storage_protocol\u0027] \u003d \u0027iSCSI\u0027"},{"line_number":303,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027Hewlett-Packard\u0027"},{"line_number":304,"context_line":"        data[\u0027location_info\u0027] \u003d (self.DRIVER_LOCATION % {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_b2d1cf31","line":301,"updated":"2015-07-31 01:43:05.000000000","message":"Don\u0027t you want to change this to read from cinder.conf?  This is used in the scheduler to calculate capacities as well.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/lvm.py#L234","commit_id":"10bcedaf6fc49fc57633ed002347f8552063f9c8"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"b72757d511d89c6f0b5d64971e0c6cc81a5a587d","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        data \u003d {}"},{"line_number":299,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":300,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or self.__class__.__name__"},{"line_number":301,"context_line":"        data[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":302,"context_line":"        data[\u0027storage_protocol\u0027] \u003d \u0027iSCSI\u0027"},{"line_number":303,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027Hewlett-Packard\u0027"},{"line_number":304,"context_line":"        data[\u0027location_info\u0027] \u003d (self.DRIVER_LOCATION % {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_267b25f6","line":301,"in_reply_to":"3a50d1a3_b2d1cf31","updated":"2015-07-31 15:33:03.000000000","message":"Hi Xing, I would like to add this as a seperate patch if possible?","commit_id":"10bcedaf6fc49fc57633ed002347f8552063f9c8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f4e96e9909cfa04696fa9400b6e12cf8e8d979d1","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        data \u003d {}"},{"line_number":299,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":300,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or self.__class__.__name__"},{"line_number":301,"context_line":"        data[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":302,"context_line":"        data[\u0027storage_protocol\u0027] \u003d \u0027iSCSI\u0027"},{"line_number":303,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027Hewlett-Packard\u0027"},{"line_number":304,"context_line":"        data[\u0027location_info\u0027] \u003d (self.DRIVER_LOCATION % {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_f8e63543","line":301,"updated":"2015-07-31 16:45:13.000000000","message":"\u0027reserved_percentage\u0027 should be getting the config value from cinder.conf, but that can be a different patch.","commit_id":"e0fc121064d773215ad70f4ede0611ce096dfc5a"}]}