)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f66dfe02d7cd81a0d910e235972bc07007916a31","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: Fix re-attach volume error for VC 5.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vCenter server version 5.1 does not support Storage Policy Based"},{"line_number":10,"context_line":"Management. This patch adds a check before retrieving storage profiles"},{"line_number":11,"context_line":"which depends on SPBM."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iba465becdc3e7bac2f47c3984ea42cc6537911ae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a4dcd0f_7ca5a79f","line":10,"updated":"2015-08-13 11:48:49.000000000","message":"You could add a note why we need to fetch storage policies during volume attach.","commit_id":"4fe73ed879ffa98780d7e49564bd0b76bf55ecf2"},{"author":{"_account_id":15935,"name":"Xiangfei Zhu","email":"xiangfeiz@vmware.com","username":"xiangfeiz"},"change_message_id":"0bf3a0ccce925d70d7adc012e901467b81137ff8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: Fix re-attach volume error for VC 5.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vCenter server version 5.1 does not support Storage Policy Based"},{"line_number":10,"context_line":"Management. This patch adds a check before retrieving storage profiles"},{"line_number":11,"context_line":"which depends on SPBM."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iba465becdc3e7bac2f47c3984ea42cc6537911ae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_88247caf","line":10,"in_reply_to":"1a4dcd0f_7ca5a79f","updated":"2015-08-19 07:47:38.000000000","message":"Done","commit_id":"4fe73ed879ffa98780d7e49564bd0b76bf55ecf2"}],"cinder/tests/unit/test_vmware_vmdk.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"0db98a3f44b9a8bd505f14f88a9d0f578711fd7e","unresolved":false,"context_lines":[{"line_number":2808,"context_line":"        session.return_value \u003d session_obj"},{"line_number":2809,"context_line":"        get_vc_version.return_value \u003d ver.LooseVersion(\u00275.1\u0027)"},{"line_number":2810,"context_line":""},{"line_number":2811,"context_line":"        self._driver.do_setup(mock.ANY)"},{"line_number":2812,"context_line":""},{"line_number":2813,"context_line":"        self.assertFalse(self._driver._storage_policy_enabled)"},{"line_number":2814,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_28933902","line":2811,"updated":"2015-07-30 10:35:33.000000000","message":"Set self._driver._storage_policy_enabled to False instead of calling public methods.","commit_id":"242fa884d92ce4db3a467be3ce969a758db00a26"},{"author":{"_account_id":15935,"name":"Xiangfei Zhu","email":"xiangfeiz@vmware.com","username":"xiangfeiz"},"change_message_id":"32591c72690f7d469bbbadce44e38b957882d1ff","unresolved":false,"context_lines":[{"line_number":2808,"context_line":"        session.return_value \u003d session_obj"},{"line_number":2809,"context_line":"        get_vc_version.return_value \u003d ver.LooseVersion(\u00275.1\u0027)"},{"line_number":2810,"context_line":""},{"line_number":2811,"context_line":"        self._driver.do_setup(mock.ANY)"},{"line_number":2812,"context_line":""},{"line_number":2813,"context_line":"        self.assertFalse(self._driver._storage_policy_enabled)"},{"line_number":2814,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_6f24c45f","line":2811,"in_reply_to":"3a50d1a3_28933902","updated":"2015-07-31 02:20:42.000000000","message":"Done","commit_id":"242fa884d92ce4db3a467be3ce969a758db00a26"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"0db98a3f44b9a8bd505f14f88a9d0f578711fd7e","unresolved":false,"context_lines":[{"line_number":2810,"context_line":""},{"line_number":2811,"context_line":"        self._driver.do_setup(mock.ANY)"},{"line_number":2812,"context_line":""},{"line_number":2813,"context_line":"        self.assertFalse(self._driver._storage_policy_enabled)"},{"line_number":2814,"context_line":""},{"line_number":2815,"context_line":"        volume \u003d {\u0027name\u0027: \u0027vol-1\u0027, \u0027size\u0027: 1, \u0027project_id\u0027: \u0027abc\u0027}"},{"line_number":2816,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_28ba5972","line":2813,"updated":"2015-07-30 10:35:33.000000000","message":"Already covered by test_do_setup_with_pbm_disabled","commit_id":"242fa884d92ce4db3a467be3ce969a758db00a26"},{"author":{"_account_id":15935,"name":"Xiangfei Zhu","email":"xiangfeiz@vmware.com","username":"xiangfeiz"},"change_message_id":"32591c72690f7d469bbbadce44e38b957882d1ff","unresolved":false,"context_lines":[{"line_number":2810,"context_line":""},{"line_number":2811,"context_line":"        self._driver.do_setup(mock.ANY)"},{"line_number":2812,"context_line":""},{"line_number":2813,"context_line":"        self.assertFalse(self._driver._storage_policy_enabled)"},{"line_number":2814,"context_line":""},{"line_number":2815,"context_line":"        volume \u003d {\u0027name\u0027: \u0027vol-1\u0027, \u0027size\u0027: 1, \u0027project_id\u0027: \u0027abc\u0027}"},{"line_number":2816,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_8f29103a","line":2813,"in_reply_to":"3a50d1a3_28ba5972","updated":"2015-07-31 02:20:42.000000000","message":"Done","commit_id":"242fa884d92ce4db3a467be3ce969a758db00a26"}],"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"0db98a3f44b9a8bd505f14f88a9d0f578711fd7e","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"                                                   backing_profile)):"},{"line_number":1904,"context_line":"            LOG.debug(\"Datastore: %(datastore)s of backing: %(backing)s is \""},{"line_number":1905,"context_line":"                      \"already accessible to instance\u0027s host: %(host)s and \""},{"line_number":1906,"context_line":"                      \"compliant with storage profile: %(profile)s.\","},{"line_number":1907,"context_line":"                      {\u0027backing\u0027: backing,"},{"line_number":1908,"context_line":"                       \u0027datastore\u0027: datastore,"},{"line_number":1909,"context_line":"                       \u0027host\u0027: host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_2848198a","line":1906,"updated":"2015-07-30 10:35:33.000000000","message":"The profile will be logged even if PBM is disabled.","commit_id":"242fa884d92ce4db3a467be3ce969a758db00a26"},{"author":{"_account_id":15935,"name":"Xiangfei Zhu","email":"xiangfeiz@vmware.com","username":"xiangfeiz"},"change_message_id":"32591c72690f7d469bbbadce44e38b957882d1ff","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"                                                   backing_profile)):"},{"line_number":1904,"context_line":"            LOG.debug(\"Datastore: %(datastore)s of backing: %(backing)s is \""},{"line_number":1905,"context_line":"                      \"already accessible to instance\u0027s host: %(host)s and \""},{"line_number":1906,"context_line":"                      \"compliant with storage profile: %(profile)s.\","},{"line_number":1907,"context_line":"                      {\u0027backing\u0027: backing,"},{"line_number":1908,"context_line":"                       \u0027datastore\u0027: datastore,"},{"line_number":1909,"context_line":"                       \u0027host\u0027: host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_2dc3248c","line":1906,"in_reply_to":"3a50d1a3_2848198a","updated":"2015-07-31 02:20:42.000000000","message":"Done","commit_id":"242fa884d92ce4db3a467be3ce969a758db00a26"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e988a934ac09ef9d8d71150f38359279dc86ac70","unresolved":false,"context_lines":[{"line_number":1902,"context_line":"                self.ds_sel.is_datastore_compliant(datastore,"},{"line_number":1903,"context_line":"                                                   backing_profile)):"},{"line_number":1904,"context_line":"            LOG.debug(\"Datastore: %(datastore)s of backing: %(backing)s is \""},{"line_number":1905,"context_line":"                      \"already accessible to instance\u0027s host: %(host)s\","},{"line_number":1906,"context_line":"                      {\u0027backing\u0027: backing,"},{"line_number":1907,"context_line":"                       \u0027datastore\u0027: datastore,"},{"line_number":1908,"context_line":"                       \u0027host\u0027: host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_dadb3b20","line":1905,"updated":"2015-07-31 13:28:22.000000000","message":"end with period.","commit_id":"bf1c04c4248d6d49a05cba18eb7ad7e13a3ca16f"},{"author":{"_account_id":15935,"name":"Xiangfei Zhu","email":"xiangfeiz@vmware.com","username":"xiangfeiz"},"change_message_id":"780d80c8532162feb2c2d8139aa7b58e9865f206","unresolved":false,"context_lines":[{"line_number":1902,"context_line":"                self.ds_sel.is_datastore_compliant(datastore,"},{"line_number":1903,"context_line":"                                                   backing_profile)):"},{"line_number":1904,"context_line":"            LOG.debug(\"Datastore: %(datastore)s of backing: %(backing)s is \""},{"line_number":1905,"context_line":"                      \"already accessible to instance\u0027s host: %(host)s\","},{"line_number":1906,"context_line":"                      {\u0027backing\u0027: backing,"},{"line_number":1907,"context_line":"                       \u0027datastore\u0027: datastore,"},{"line_number":1908,"context_line":"                       \u0027host\u0027: host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_75042c49","line":1905,"in_reply_to":"3a50d1a3_dadb3b20","updated":"2015-08-06 04:30:11.000000000","message":"Done","commit_id":"bf1c04c4248d6d49a05cba18eb7ad7e13a3ca16f"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e988a934ac09ef9d8d71150f38359279dc86ac70","unresolved":false,"context_lines":[{"line_number":1907,"context_line":"                       \u0027datastore\u0027: datastore,"},{"line_number":1908,"context_line":"                       \u0027host\u0027: host})"},{"line_number":1909,"context_line":"            if (backing_profile is not None):"},{"line_number":1910,"context_line":"                LOG.debug(\"and compliant with storage profile: %(profile)s.\","},{"line_number":1911,"context_line":"                          {\u0027profile\u0027: backing_profile})"},{"line_number":1912,"context_line":"            return"},{"line_number":1913,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_3a433fb1","line":1910,"updated":"2015-07-31 13:28:22.000000000","message":"This will be in a separate line and should be fixed.\n\nBacking: %(backing)s is compliant with storage profile: %(profile)s.","commit_id":"bf1c04c4248d6d49a05cba18eb7ad7e13a3ca16f"},{"author":{"_account_id":15935,"name":"Xiangfei Zhu","email":"xiangfeiz@vmware.com","username":"xiangfeiz"},"change_message_id":"780d80c8532162feb2c2d8139aa7b58e9865f206","unresolved":false,"context_lines":[{"line_number":1907,"context_line":"                       \u0027datastore\u0027: datastore,"},{"line_number":1908,"context_line":"                       \u0027host\u0027: host})"},{"line_number":1909,"context_line":"            if (backing_profile is not None):"},{"line_number":1910,"context_line":"                LOG.debug(\"and compliant with storage profile: %(profile)s.\","},{"line_number":1911,"context_line":"                          {\u0027profile\u0027: backing_profile})"},{"line_number":1912,"context_line":"            return"},{"line_number":1913,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_9501b83a","line":1910,"in_reply_to":"3a50d1a3_3a433fb1","updated":"2015-08-06 04:30:11.000000000","message":"Done","commit_id":"bf1c04c4248d6d49a05cba18eb7ad7e13a3ca16f"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"80012aea5a036c6ac5503cccb6ddaa94bbf8cc51","unresolved":false,"context_lines":[{"line_number":1906,"context_line":"                      {\u0027backing\u0027: backing,"},{"line_number":1907,"context_line":"                       \u0027datastore\u0027: datastore,"},{"line_number":1908,"context_line":"                       \u0027host\u0027: host})"},{"line_number":1909,"context_line":"            if (backing_profile is not None):"},{"line_number":1910,"context_line":"                LOG.debug(\"Backing: %(backing)s is compliant with \""},{"line_number":1911,"context_line":"                          \"storage profile: %(profile)s.\","},{"line_number":1912,"context_line":"                          {\u0027backing\u0027: backing,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_7848dd2d","line":1909,"updated":"2015-08-19 06:31:29.000000000","message":"Would \"if backing_profile\" be enough?","commit_id":"4fe73ed879ffa98780d7e49564bd0b76bf55ecf2"},{"author":{"_account_id":15935,"name":"Xiangfei Zhu","email":"xiangfeiz@vmware.com","username":"xiangfeiz"},"change_message_id":"0bf3a0ccce925d70d7adc012e901467b81137ff8","unresolved":false,"context_lines":[{"line_number":1906,"context_line":"                      {\u0027backing\u0027: backing,"},{"line_number":1907,"context_line":"                       \u0027datastore\u0027: datastore,"},{"line_number":1908,"context_line":"                       \u0027host\u0027: host})"},{"line_number":1909,"context_line":"            if (backing_profile is not None):"},{"line_number":1910,"context_line":"                LOG.debug(\"Backing: %(backing)s is compliant with \""},{"line_number":1911,"context_line":"                          \"storage profile: %(profile)s.\","},{"line_number":1912,"context_line":"                          {\u0027backing\u0027: backing,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_283c50c7","line":1909,"in_reply_to":"fa1b9901_7848dd2d","updated":"2015-08-19 07:47:38.000000000","message":"Done","commit_id":"4fe73ed879ffa98780d7e49564bd0b76bf55ecf2"}]}