)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"92ad4fbe00647adc4544528ca6eccb5a70c6225b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The barbican plugin requires both the barbican and the keystone"},{"line_number":10,"context_line":"endpoint. Since these are generally in the catalog, we can get them from"},{"line_number":11,"context_line":"there rather than requiring them to be hard-coded."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I926547d2d95b3c59a849c1796342a11cc41b73cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_2749d8b7","line":12,"updated":"2015-07-31 19:07:54.000000000","message":"Just wondering, does this patch have a blueprint, partially implement a blueprint, close a bug, etc?","commit_id":"b9aa1c2cb9074b3e27ed7e0cbaf5970d9d492505"}],"cinder/context.py":[{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"ff2daf316da1ba93db1185c755e3e7c8f51cf437","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            self.service_catalog \u003d [s for s in service_catalog"},{"line_number":95,"context_line":"                                    if s.get(\u0027type\u0027) in"},{"line_number":96,"context_line":"                                    (\u0027identity\u0027, \u0027compute\u0027, \u0027object-store\u0027,"},{"line_number":97,"context_line":"                                     \u0027key-mgr\u0027)]"},{"line_number":98,"context_line":"        else:"},{"line_number":99,"context_line":"            # if list is empty or none"},{"line_number":100,"context_line":"            self.service_catalog \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_998dfe7d","line":97,"updated":"2015-08-17 21:58:39.000000000","message":"I think type needs to be \u0027key-manager\u0027 as mentioned in https://github.com/openstack/barbican/blob/master/contrib/devstack/lib/barbican#L357","commit_id":"b9aa1c2cb9074b3e27ed7e0cbaf5970d9d492505"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"da4c7c37f4e89c12104549360bcd41870618762c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            self.service_catalog \u003d [s for s in service_catalog"},{"line_number":95,"context_line":"                                    if s.get(\u0027type\u0027) in"},{"line_number":96,"context_line":"                                    (\u0027identity\u0027, \u0027compute\u0027, \u0027object-store\u0027,"},{"line_number":97,"context_line":"                                     \u0027key-mgr\u0027)]"},{"line_number":98,"context_line":"        else:"},{"line_number":99,"context_line":"            # if list is empty or none"},{"line_number":100,"context_line":"            self.service_catalog \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_1edb0d7e","line":97,"in_reply_to":"fa1b9901_998dfe7d","updated":"2015-08-27 07:15:00.000000000","message":"I couldn\u0027t find a good answer for what this value \u0027should\u0027 be, devstack plugin is fairly defacto though, so done.","commit_id":"b9aa1c2cb9074b3e27ed7e0cbaf5970d9d492505"}],"cinder/keymgr/barbican.py":[{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"ff2daf316da1ba93db1185c755e3e7c8f51cf437","unresolved":false,"context_lines":[{"line_number":44,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class BarbicanKeyManager(key_mgr.KeyManage):"},{"line_number":48,"context_line":"    \"\"\"Key Manager Interface that wraps the Barbican client API.\"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_b4afa7e2","line":47,"updated":"2015-08-17 21:58:39.000000000","message":"Typo?\n\nDon\u0027t see any \u0027KeyManage\u0027 class in https://github.com/openstack/cinder/blob/master/cinder/keymgr/key_mgr.py#L39?","commit_id":"b9aa1c2cb9074b3e27ed7e0cbaf5970d9d492505"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"ff2daf316da1ba93db1185c755e3e7c8f51cf437","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                    \"Failed to parse the configuration option \""},{"line_number":59,"context_line":"                    \"\u0027encryption_api_catalog_info\u0027, must be in the form \""},{"line_number":60,"context_line":"                    \"\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e.\"))"},{"line_number":61,"context_line":"            for entry in context.service_catalog:"},{"line_number":62,"context_line":"                if entry.get(\u0027type\u0027) \u003d\u003d service_type:"},{"line_number":63,"context_line":"                    self._base_url \u003d entry.get("},{"line_number":64,"context_line":"                            \u0027endpoints\u0027)[0].get(endpoint_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_b4f9e7ca","line":61,"updated":"2015-08-17 21:58:39.000000000","message":"Not sure from where this \u0027context\u0027 reference is coming from. Did not see anything passed or initialized anywhere.\n\nCannot tell if request context is available (or set) prior to Key Manager API initialization. Please check.","commit_id":"b9aa1c2cb9074b3e27ed7e0cbaf5970d9d492505"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"31ae8044f89a35d179c326f5207c4a8796c52adf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                    \"cinder.conf config option \u0027encryption_api_url\u0027 in the \""},{"line_number":71,"context_line":"                    \"section [keymgr].\"))"},{"line_number":72,"context_line":"        # the barbican endpoint can\u0027t have the \u0027/v1\u0027 on the end"},{"line_number":73,"context_line":"        #FIXME (DuncanT) This should check if the think it is trying to trim"},{"line_number":74,"context_line":"        #                is actually there!"},{"line_number":75,"context_line":"        self._barbican_endpoint \u003d self._base_url.rpartition(\u0027/\u0027)[0]"},{"line_number":76,"context_line":"        self._barbican_client \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_4c3ec0db","line":73,"updated":"2015-07-30 19:11:04.000000000","message":"think -\u003e thing","commit_id":"b9aa1c2cb9074b3e27ed7e0cbaf5970d9d492505"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"dba727b132f63e16ac0a067828fc6ce9f39903f3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        if self._auth_url is None:"},{"line_number":80,"context_line":"            try:"},{"line_number":81,"context_line":"                info \u003d CONF.encryption_auth_catalog_info"},{"line_number":82,"context_line":"                service_type, service_name, endpoint_type \u003d info.split(\u0027:\u0027)"},{"line_number":83,"context_line":"            except ValueError:"},{"line_number":84,"context_line":"                raise exception.KeymgrConfigException(_("},{"line_number":85,"context_line":"                    \"Failed to parse the configuration option \""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_93f28bd1","line":82,"updated":"2015-08-18 17:40:49.000000000","message":"In some projects, region information is added to derive service URL from catalog e.g. https://github.com/openstack/nova/blob/master/nova/keymgr/barbican.py#L46","commit_id":"b9aa1c2cb9074b3e27ed7e0cbaf5970d9d492505"}],"cinder/keymgr/key_mgr.py":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"92ad4fbe00647adc4544528ca6eccb5a70c6225b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.StrOpt(\u0027encryption_auth_url\u0027,"},{"line_number":27,"context_line":"               default\u003dNone,"},{"line_number":28,"context_line":"               help\u003d\u0027Authentication url for encryption service.\u0027"},{"line_number":29,"context_line":"                    \u0027 Set to \"None\" to use catalog\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027auth_catalog_info\u0027,"},{"line_number":31,"context_line":"               default\u003d\u0027identity:keystone:publicURL\u0027,"},{"line_number":32,"context_line":"               help\u003d\u0027Info to match when looking for keystone in the service \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_6cfd873a","line":29,"updated":"2015-07-31 19:07:54.000000000","message":"Missing \".\" at EOL.","commit_id":"b9aa1c2cb9074b3e27ed7e0cbaf5970d9d492505"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"92ad4fbe00647adc4544528ca6eccb5a70c6225b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    cfg.StrOpt(\u0027encryption_api_url\u0027,"},{"line_number":37,"context_line":"               default\u003dNone"},{"line_number":38,"context_line":"               help\u003d\u0027Url for encryption service.\u0027"},{"line_number":39,"context_line":"                    \u0027 Set to \"None\" to use catalog\u0027),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027encryption_api_catalog_info\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027key-mgr:barbican:publicURL\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Info to match when looking for babican in the service \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_ecbe7763","line":39,"updated":"2015-07-31 19:07:54.000000000","message":"Missing \".\" at EOL.","commit_id":"b9aa1c2cb9074b3e27ed7e0cbaf5970d9d492505"},{"author":{"_account_id":1091,"name":"Arun Kant","email":"arukant@cisco.com","username":"arunkant-uws"},"change_message_id":"ff2daf316da1ba93db1185c755e3e7c8f51cf437","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               help\u003d\u0027Url for encryption service.\u0027"},{"line_number":39,"context_line":"                    \u0027 Set to \"None\" to use catalog\u0027),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027encryption_api_catalog_info\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027key-mgr:barbican:publicURL\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Info to match when looking for babican in the service \u0027"},{"line_number":43,"context_line":"                    \u0027catalog. Format is: separated values of the form: \u0027"},{"line_number":44,"context_line":"                    \u0027\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpint_type\u003e - \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_d9a05693","line":41,"updated":"2015-08-17 21:58:39.000000000","message":"key-manager as service type for barbican","commit_id":"b9aa1c2cb9074b3e27ed7e0cbaf5970d9d492505"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"31ae8044f89a35d179c326f5207c4a8796c52adf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    \u0027 Set to \"None\" to use catalog\u0027),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027encryption_api_catalog_info\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027key-mgr:barbican:publicURL\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Info to match when looking for babican in the service \u0027"},{"line_number":43,"context_line":"                    \u0027catalog. Format is: separated values of the form: \u0027"},{"line_number":44,"context_line":"                    \u0027\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpint_type\u003e - \u0027"},{"line_number":45,"context_line":"                    \u0027Only used if encryption_api_url is unset.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_ac7f44aa","line":42,"updated":"2015-07-30 19:11:04.000000000","message":"babican -\u003e barbican","commit_id":"b9aa1c2cb9074b3e27ed7e0cbaf5970d9d492505"}]}