)]}'
{"cinder/volume/drivers/xenapi/lib.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eed3fc4ca17f788f19afe6ef5b5019b8d927a331","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            host_ref \u003d session.get_this_host()"},{"line_number":375,"context_line":"            return session.call_plugin(host_ref, plugin, function, args)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def resize_volume(self, server, serverpath, sr_uuid, vdi_uuid,"},{"line_number":378,"context_line":"                      size_in_gigabytes):"},{"line_number":379,"context_line":"        self.connect_volume(server, serverpath, sr_uuid, vdi_uuid)"},{"line_number":380,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FQBg%3D","line":377,"updated":"2013-01-31 10:54:34.000000000","message":"Note this does not resize the partition table or file system, but the \"auto_resize\" code in nova does do that. Probably needs documenting for the moment? Can add the \"auto_resize\" feature later.","commit_id":"427d80edc12d17627199844a555084c1313f3d58"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"1d2f4dc2440f2ad44fd7e6e3bc9bbfd7e93a09f1","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            host_ref \u003d session.get_this_host()"},{"line_number":375,"context_line":"            return session.call_plugin(host_ref, plugin, function, args)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def resize_volume(self, server, serverpath, sr_uuid, vdi_uuid,"},{"line_number":378,"context_line":"                      size_in_gigabytes):"},{"line_number":379,"context_line":"        self.connect_volume(server, serverpath, sr_uuid, vdi_uuid)"},{"line_number":380,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FP4M%3D","line":377,"in_reply_to":"AAAAM3%2F%2FQBg%3D","updated":"2013-01-31 15:27:06.000000000","message":"The same thing happens in the reference implementation case. Resizing would involve that you know what sort of filesystem you have on your disk.","commit_id":"427d80edc12d17627199844a555084c1313f3d58"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eed3fc4ca17f788f19afe6ef5b5019b8d927a331","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        try:"},{"line_number":382,"context_line":"            with self._session_factory.get_session() as session:"},{"line_number":383,"context_line":"                vdi_ref \u003d session.VDI.get_by_uuid(vdi_uuid)"},{"line_number":384,"context_line":"                session.VDI.resize(vdi_ref, to_bytes(size_in_gigabytes))"},{"line_number":385,"context_line":"        finally:"},{"line_number":386,"context_line":"            self.disconnect_volume(vdi_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FQBc%3D","line":384,"updated":"2013-01-31 10:54:34.000000000","message":"I would maybe error if you are trying to make it smaller?","commit_id":"427d80edc12d17627199844a555084c1313f3d58"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"1d2f4dc2440f2ad44fd7e6e3bc9bbfd7e93a09f1","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        try:"},{"line_number":382,"context_line":"            with self._session_factory.get_session() as session:"},{"line_number":383,"context_line":"                vdi_ref \u003d session.VDI.get_by_uuid(vdi_uuid)"},{"line_number":384,"context_line":"                session.VDI.resize(vdi_ref, to_bytes(size_in_gigabytes))"},{"line_number":385,"context_line":"        finally:"},{"line_number":386,"context_line":"            self.disconnect_volume(vdi_uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FP4A%3D","line":384,"in_reply_to":"AAAAM3%2F%2FQBc%3D","updated":"2013-01-31 15:27:06.000000000","message":"I think it should be handled at the manager level, not on the driver level, but it is a good point otherwise.","commit_id":"427d80edc12d17627199844a555084c1313f3d58"}],"cinder/volume/drivers/xenapi/sm.py":[{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"b98d30f13f445f22b7fa9489a9c312aaaba35ffa","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def ensure_export(self, context, volume):"},{"line_number":148,"context_line":"        pass"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def copy_image_to_volume(self, context, volume, image_service, image_id):"},{"line_number":151,"context_line":"        sr_uuid, vdi_uuid \u003d volume[\u0027provider_location\u0027].split(\u0027/\u0027)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        uuid_stack \u003d [vdi_uuid]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FSHY%3D","line":150,"updated":"2013-01-30 11:10:58.000000000","message":"I think most of this implementation should be moved to cinder.volume.drivers.xenapi.lib, hiding the dirty details of calling the glance plugin, and doing the pickle-depickle.","commit_id":"427d80edc12d17627199844a555084c1313f3d58"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eed3fc4ca17f788f19afe6ef5b5019b8d927a331","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            glance_port\u003dglance_port,"},{"line_number":163,"context_line":"            glance_use_ssl\u003dglance_use_ssl,"},{"line_number":164,"context_line":"            uuid_stack\u003duuid_stack,"},{"line_number":165,"context_line":"            sr_path\u003d\"/var/run/sr-mount/\" + sr_uuid,"},{"line_number":166,"context_line":"            auth_token\u003dauth_token)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        plugin_params \u003d dict(args\u003d[], kwargs\u003dplugin_kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FQBk%3D","line":165,"updated":"2013-01-31 10:54:34.000000000","message":"I would get this from XenAPI rather than hard code. It might be different on ubuntu XCP-XAPI.","commit_id":"427d80edc12d17627199844a555084c1313f3d58"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"1d2f4dc2440f2ad44fd7e6e3bc9bbfd7e93a09f1","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            glance_port\u003dglance_port,"},{"line_number":163,"context_line":"            glance_use_ssl\u003dglance_use_ssl,"},{"line_number":164,"context_line":"            uuid_stack\u003duuid_stack,"},{"line_number":165,"context_line":"            sr_path\u003d\"/var/run/sr-mount/\" + sr_uuid,"},{"line_number":166,"context_line":"            auth_token\u003dauth_token)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        plugin_params \u003d dict(args\u003d[], kwargs\u003dplugin_kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FP3w%3D","line":165,"in_reply_to":"AAAAM3%2F%2FQBk%3D","updated":"2013-01-31 15:27:06.000000000","message":"I will set up a configuration option for this. The same thing happens in nova.","commit_id":"427d80edc12d17627199844a555084c1313f3d58"}],"cinder/volume/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eed3fc4ca17f788f19afe6ef5b5019b8d927a331","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"            if model_update:"},{"line_number":194,"context_line":"                self.db.volume_update(context, volume_ref[\u0027id\u0027], model_update)"},{"line_number":195,"context_line":"                volume_ref.update(model_update)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"            LOG.debug(_(\"volume %s: creating export\"), volume_ref[\u0027name\u0027])"},{"line_number":198,"context_line":"            model_update \u003d self.driver.create_export(context, volume_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FQBo%3D","line":195,"updated":"2013-01-31 10:54:34.000000000","message":"This looks odd. I guess volume_update doesn\u0027t return anything useful.","commit_id":"427d80edc12d17627199844a555084c1313f3d58"},{"author":{"_account_id":5044,"name":"Mate Lakat","email":"mlakat@suse.com","username":"mate-lakat"},"change_message_id":"1d2f4dc2440f2ad44fd7e6e3bc9bbfd7e93a09f1","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"            if model_update:"},{"line_number":194,"context_line":"                self.db.volume_update(context, volume_ref[\u0027id\u0027], model_update)"},{"line_number":195,"context_line":"                volume_ref.update(model_update)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"            LOG.debug(_(\"volume %s: creating export\"), volume_ref[\u0027name\u0027])"},{"line_number":198,"context_line":"            model_update \u003d self.driver.create_export(context, volume_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FP3g%3D","line":195,"in_reply_to":"AAAAM3%2F%2FQBo%3D","updated":"2013-01-31 15:27:06.000000000","message":"Actually, it was my bad. volume_update returns the updated ref. Thanks!","commit_id":"427d80edc12d17627199844a555084c1313f3d58"}]}