)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a7fef13157eacb411303d3204420fe09fa4b196b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sonia Ghanekar \u003csonia.ghanekar@nimblestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-04 14:43:40 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update snap-quota to unlimited in Nimble driver."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change the snap-quota from limited fix size of the volume"},{"line_number":10,"context_line":"to unlimited on the Nimble driver. This applies to creating"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a4dcd0f_47218ffa","line":7,"updated":"2015-08-04 22:04:22.000000000","message":"No period for commit headers.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\n\"The first line should be limited to 50 characters and should not end with a period\"","commit_id":"12a987fc0645a3e399e728395d1861d46d0c440e"},{"author":{"_account_id":16901,"name":"Sonia Ghanekar","email":"sonia.ghanekar@nimblestorage.com","username":"soniaghanekar"},"change_message_id":"6bdb9f791df4cd3aced4e6a873494019b5976a95","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sonia Ghanekar \u003csonia.ghanekar@nimblestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-04 14:43:40 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update snap-quota to unlimited in Nimble driver."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change the snap-quota from limited fix size of the volume"},{"line_number":10,"context_line":"to unlimited on the Nimble driver. This applies to creating"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a4dcd0f_0732a710","line":7,"in_reply_to":"1a4dcd0f_47218ffa","updated":"2015-08-04 22:10:10.000000000","message":"Done","commit_id":"12a987fc0645a3e399e728395d1861d46d0c440e"}],"cinder/tests/unit/test_nimble.py":[{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"a63cd4a60623a486dc7d1738d090b22bd132aaaa","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                                       \u0027display_description\u0027: \u0027\u0027}))"},{"line_number":243,"context_line":"        self.mock_client_service.service.createVol.assert_called_once_with("},{"line_number":244,"context_line":"            request\u003d{"},{"line_number":245,"context_line":"                \u0027attr\u0027: {\u0027snap-quota\u0027: 9223372036854775807,"},{"line_number":246,"context_line":"                         \u0027warn-level\u0027: 858993459,"},{"line_number":247,"context_line":"                         \u0027name\u0027: \u0027testvolume\u0027, \u0027reserve\u0027: 0,"},{"line_number":248,"context_line":"                         \u0027online\u0027: True, \u0027pool-name\u0027: \u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_e669cb26","line":245,"updated":"2015-08-04 17:15:02.000000000","message":"Suggesting to use sys.maxint here as well.","commit_id":"98ed05247b5027c0682444105e69fedaecbd9b1e"},{"author":{"_account_id":16901,"name":"Sonia Ghanekar","email":"sonia.ghanekar@nimblestorage.com","username":"soniaghanekar"},"change_message_id":"f2549029a8721b0e907359bfc4ed5ed52a5c58fe","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                                       \u0027display_description\u0027: \u0027\u0027}))"},{"line_number":243,"context_line":"        self.mock_client_service.service.createVol.assert_called_once_with("},{"line_number":244,"context_line":"            request\u003d{"},{"line_number":245,"context_line":"                \u0027attr\u0027: {\u0027snap-quota\u0027: 9223372036854775807,"},{"line_number":246,"context_line":"                         \u0027warn-level\u0027: 858993459,"},{"line_number":247,"context_line":"                         \u0027name\u0027: \u0027testvolume\u0027, \u0027reserve\u0027: 0,"},{"line_number":248,"context_line":"                         \u0027online\u0027: True, \u0027pool-name\u0027: \u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_4100a901","line":245,"in_reply_to":"1a4dcd0f_e669cb26","updated":"2015-08-04 17:21:42.000000000","message":"Done","commit_id":"98ed05247b5027c0682444105e69fedaecbd9b1e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"968a4bc06d55f3a03ebbb751f14de6e81320a65e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_313b619e","line":17,"updated":"2015-08-04 21:02:54.000000000","message":"Will need to change order to:\n\nimport sys\n\nimport mock\nfrom oslo_config import cfg","commit_id":"4aff4bf16dc047638a5345cfa9406e7479e4bea2"},{"author":{"_account_id":16901,"name":"Sonia Ghanekar","email":"sonia.ghanekar@nimblestorage.com","username":"soniaghanekar"},"change_message_id":"b7dcd8cc97bc6c6523bbde89a25c40c13eec96bc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_07eaa70f","line":17,"in_reply_to":"1a4dcd0f_313b619e","updated":"2015-08-04 21:50:35.000000000","message":"Done","commit_id":"4aff4bf16dc047638a5345cfa9406e7479e4bea2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"968a4bc06d55f3a03ebbb751f14de6e81320a65e","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                                       \u0027display_description\u0027: \u0027\u0027}))"},{"line_number":244,"context_line":"        self.mock_client_service.service.createVol.assert_called_once_with("},{"line_number":245,"context_line":"            request\u003d{"},{"line_number":246,"context_line":"                \u0027attr\u0027: {\u0027snap-quota\u0027: sys.maxint,"},{"line_number":247,"context_line":"                         \u0027warn-level\u0027: 858993459,"},{"line_number":248,"context_line":"                         \u0027name\u0027: \u0027testvolume\u0027, \u0027reserve\u0027: 0,"},{"line_number":249,"context_line":"                         \u0027online\u0027: True, \u0027pool-name\u0027: \u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_914cb543","line":246,"updated":"2015-08-04 21:02:54.000000000","message":"sys.maxint doesn\u0027t exist in Python 3. Need to use sys.maxsize instead.","commit_id":"4aff4bf16dc047638a5345cfa9406e7479e4bea2"},{"author":{"_account_id":16901,"name":"Sonia Ghanekar","email":"sonia.ghanekar@nimblestorage.com","username":"soniaghanekar"},"change_message_id":"b7dcd8cc97bc6c6523bbde89a25c40c13eec96bc","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                                       \u0027display_description\u0027: \u0027\u0027}))"},{"line_number":244,"context_line":"        self.mock_client_service.service.createVol.assert_called_once_with("},{"line_number":245,"context_line":"            request\u003d{"},{"line_number":246,"context_line":"                \u0027attr\u0027: {\u0027snap-quota\u0027: sys.maxint,"},{"line_number":247,"context_line":"                         \u0027warn-level\u0027: 858993459,"},{"line_number":248,"context_line":"                         \u0027name\u0027: \u0027testvolume\u0027, \u0027reserve\u0027: 0,"},{"line_number":249,"context_line":"                         \u0027online\u0027: True, \u0027pool-name\u0027: \u0027default\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_27ed6325","line":246,"in_reply_to":"1a4dcd0f_914cb543","updated":"2015-08-04 21:50:35.000000000","message":"Done","commit_id":"4aff4bf16dc047638a5345cfa9406e7479e4bea2"}],"cinder/volume/drivers/nimble.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"e163963dbaafa1bb3a291b5281e30905055899ef","unresolved":false,"context_lines":[{"line_number":43,"context_line":"EXTRA_SPEC_PERF_POLICY \u003d \u0027nimble:perfpol-name\u0027"},{"line_number":44,"context_line":"DEFAULT_PERF_POLICY_SETTING \u003d \u0027default\u0027"},{"line_number":45,"context_line":"DEFAULT_ENCRYPTION_SETTING \u003d \u0027no\u0027"},{"line_number":46,"context_line":"DEFAULT_SNAP_QUOTA \u003d 9223372036854775807"},{"line_number":47,"context_line":"VOL_EDIT_MASK \u003d 4 + 16 + 32 + 64 + 256 + 512"},{"line_number":48,"context_line":"SOAP_PORT \u003d 5391"},{"line_number":49,"context_line":"SM_ACL_APPLY_TO_BOTH \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_474e8697","line":46,"updated":"2015-08-04 14:43:36.000000000","message":"Odd number to mean unlimited, but ok.","commit_id":"ba443e7698306b4a5211c27f62cde7a9f8079e43"},{"author":{"_account_id":16901,"name":"Sonia Ghanekar","email":"sonia.ghanekar@nimblestorage.com","username":"soniaghanekar"},"change_message_id":"259e18035fa1f4b179b4f559f8b33529db257e4a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"EXTRA_SPEC_PERF_POLICY \u003d \u0027nimble:perfpol-name\u0027"},{"line_number":44,"context_line":"DEFAULT_PERF_POLICY_SETTING \u003d \u0027default\u0027"},{"line_number":45,"context_line":"DEFAULT_ENCRYPTION_SETTING \u003d \u0027no\u0027"},{"line_number":46,"context_line":"DEFAULT_SNAP_QUOTA \u003d 9223372036854775807"},{"line_number":47,"context_line":"VOL_EDIT_MASK \u003d 4 + 16 + 32 + 64 + 256 + 512"},{"line_number":48,"context_line":"SOAP_PORT \u003d 5391"},{"line_number":49,"context_line":"SM_ACL_APPLY_TO_BOTH \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_cb5ff83f","line":46,"in_reply_to":"1a4dcd0f_474e8697","updated":"2015-08-04 17:10:36.000000000","message":"It is actually the maximum integer value supported by python. \nI have changed it to sys.maxint. Thanks!","commit_id":"ba443e7698306b4a5211c27f62cde7a9f8079e43"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"778a84ecca6fe4858187afe50c37fbed46f718b2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"DEFAULT_PERF_POLICY_SETTING \u003d \u0027default\u0027"},{"line_number":45,"context_line":"DEFAULT_ENCRYPTION_SETTING \u003d \u0027no\u0027"},{"line_number":46,"context_line":"DEFAULT_SNAP_QUOTA \u003d 9223372036854775807"},{"line_number":47,"context_line":"VOL_EDIT_MASK \u003d 4 + 16 + 32 + 64 + 256 + 512"},{"line_number":48,"context_line":"SOAP_PORT \u003d 5391"},{"line_number":49,"context_line":"SM_ACL_APPLY_TO_BOTH \u003d 3"},{"line_number":50,"context_line":"SM_ACL_CHAP_USER_ANY \u003d \u0027*\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_cd6f4b91","line":47,"updated":"2015-08-03 18:37:52.000000000","message":"Is this change related to the quota change? commit message does not mention this.","commit_id":"ba443e7698306b4a5211c27f62cde7a9f8079e43"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"6868cf1a852af5754aee666885c8e10aec139187","unresolved":false,"context_lines":[{"line_number":44,"context_line":"DEFAULT_PERF_POLICY_SETTING \u003d \u0027default\u0027"},{"line_number":45,"context_line":"DEFAULT_ENCRYPTION_SETTING \u003d \u0027no\u0027"},{"line_number":46,"context_line":"DEFAULT_SNAP_QUOTA \u003d 9223372036854775807"},{"line_number":47,"context_line":"VOL_EDIT_MASK \u003d 4 + 16 + 32 + 64 + 256 + 512"},{"line_number":48,"context_line":"SOAP_PORT \u003d 5391"},{"line_number":49,"context_line":"SM_ACL_APPLY_TO_BOTH \u003d 3"},{"line_number":50,"context_line":"SM_ACL_CHAP_USER_ANY \u003d \u0027*\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_dcfdb76f","line":47,"in_reply_to":"1a4dcd0f_1046a823","updated":"2015-08-03 20:52:05.000000000","message":"Thanks!","commit_id":"ba443e7698306b4a5211c27f62cde7a9f8079e43"},{"author":{"_account_id":16901,"name":"Sonia Ghanekar","email":"sonia.ghanekar@nimblestorage.com","username":"soniaghanekar"},"change_message_id":"24e1ccfc023982b5c3da6b3a0d4cd4f3d7203ca1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"DEFAULT_PERF_POLICY_SETTING \u003d \u0027default\u0027"},{"line_number":45,"context_line":"DEFAULT_ENCRYPTION_SETTING \u003d \u0027no\u0027"},{"line_number":46,"context_line":"DEFAULT_SNAP_QUOTA \u003d 9223372036854775807"},{"line_number":47,"context_line":"VOL_EDIT_MASK \u003d 4 + 16 + 32 + 64 + 256 + 512"},{"line_number":48,"context_line":"SOAP_PORT \u003d 5391"},{"line_number":49,"context_line":"SM_ACL_APPLY_TO_BOTH \u003d 3"},{"line_number":50,"context_line":"SM_ACL_CHAP_USER_ANY \u003d \u0027*\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_1046a823","line":47,"in_reply_to":"1a4dcd0f_cd6f4b91","updated":"2015-08-03 18:46:05.000000000","message":"Yes. This field represents an edit to the snap-quota. Earlier this field was not explicitly set and in a edit_volume call, the snap-quota would still remain as it originally was. Now, with the field being set, the edit_volume call will always maintain the snap-quota to be infinite.","commit_id":"ba443e7698306b4a5211c27f62cde7a9f8079e43"}]}