)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f782a5c5a5cde78a1d1dc8300e2190ca16e112fb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VolumeLimitExceeded exception contains the wrong limit when"},{"line_number":10,"context_line":"the number of volumes exceeds the quota corresponding to a volume"},{"line_number":11,"context_line":"type . It always contains the limit of quota \u0027volumes\u0027. This patch"},{"line_number":12,"context_line":"fixes the limit in both exception and log message. It also adds"},{"line_number":13,"context_line":"the quota name to exception and log message for better clarity."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_457d301b","line":11,"updated":"2015-08-04 11:16:54.000000000","message":"Extra blank space after \"type\".","commit_id":"2f048a8d8b2cd4e4301f73bc86afde620226e2e5"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"034f1fdd746d234d2f7de134e709cf31fc3197d3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VolumeLimitExceeded exception contains the wrong limit when"},{"line_number":10,"context_line":"the number of volumes exceeds the quota corresponding to a volume"},{"line_number":11,"context_line":"type . It always contains the limit of quota \u0027volumes\u0027. This patch"},{"line_number":12,"context_line":"fixes the limit in both exception and log message. It also adds"},{"line_number":13,"context_line":"the quota name to exception and log message for better clarity."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_606b7a1f","line":11,"in_reply_to":"1a4dcd0f_457d301b","updated":"2015-08-04 11:32:47.000000000","message":"So you think that this patch shouldn\u0027t be merged because it contains an extra space in the commit message. Sorry to say that this is extremely harsh.","commit_id":"2f048a8d8b2cd4e4301f73bc86afde620226e2e5"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"1156fe7534eb9baf916615a102a88b2550b19d1e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VolumeLimitExceeded exception contains the wrong limit when"},{"line_number":10,"context_line":"the number of volumes exceeds the quota corresponding to a volume"},{"line_number":11,"context_line":"type . It always contains the limit of quota \u0027volumes\u0027. This patch"},{"line_number":12,"context_line":"fixes the limit in both exception and log message. It also adds"},{"line_number":13,"context_line":"the quota name to exception and log message for better clarity."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_3ae83ae2","line":11,"in_reply_to":"1a4dcd0f_606b7a1f","updated":"2015-08-04 12:08:46.000000000","message":"I didn\u0027t mean that. I found it unintentionally when I read the Commit Message. Just ignore it.","commit_id":"2f048a8d8b2cd4e4301f73bc86afde620226e2e5"}],"cinder/tests/unit/test_quota.py":[{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f782a5c5a5cde78a1d1dc8300e2190ca16e112fb","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                               volume.API().create,"},{"line_number":139,"context_line":"                               self.context, 1, \u0027\u0027, \u0027\u0027,"},{"line_number":140,"context_line":"                               volume_type\u003dself.volume_type)"},{"line_number":141,"context_line":"        msg \u003d (\"Maximum number of volumes allowed (1) exceeded for\""},{"line_number":142,"context_line":"               \" quota \u0027%s\u0027.\" % resource)"},{"line_number":143,"context_line":"        self.assertEqual(msg, six.text_type(ex))"},{"line_number":144,"context_line":"        db.volume_destroy(self.context, vol_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_655cec4b","line":141,"updated":"2015-08-04 11:16:54.000000000","message":"What\u0027s the (1) means?","commit_id":"2f048a8d8b2cd4e4301f73bc86afde620226e2e5"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"034f1fdd746d234d2f7de134e709cf31fc3197d3","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                               volume.API().create,"},{"line_number":139,"context_line":"                               self.context, 1, \u0027\u0027, \u0027\u0027,"},{"line_number":140,"context_line":"                               volume_type\u003dself.volume_type)"},{"line_number":141,"context_line":"        msg \u003d (\"Maximum number of volumes allowed (1) exceeded for\""},{"line_number":142,"context_line":"               \" quota \u0027%s\u0027.\" % resource)"},{"line_number":143,"context_line":"        self.assertEqual(msg, six.text_type(ex))"},{"line_number":144,"context_line":"        db.volume_destroy(self.context, vol_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_207fb2ab","line":141,"in_reply_to":"1a4dcd0f_655cec4b","updated":"2015-08-04 11:32:47.000000000","message":"maximum number of volumes allowed","commit_id":"2f048a8d8b2cd4e4301f73bc86afde620226e2e5"}],"cinder/volume/flows/api/create_volume.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"932f748b7232ef5b7efbe1b1edf8967be80772a5","unresolved":false,"context_lines":[{"line_number":566,"context_line":"                          \"already consumed)\")"},{"line_number":567,"context_line":"                LOG.warning(msg, {\u0027s_pid\u0027: context.project_id,"},{"line_number":568,"context_line":"                                  \u0027d_consumed\u0027: _consumed(\u0027volumes\u0027)})"},{"line_number":569,"context_line":"                raise exception.VolumeLimitExceeded(allowed\u003dquotas[\u0027volumes\u0027])"},{"line_number":570,"context_line":"            else:"},{"line_number":571,"context_line":"                # If nothing was reraised, ensure we reraise the initial error"},{"line_number":572,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_283b26ed","side":"PARENT","line":569,"updated":"2015-08-04 08:10:04.000000000","message":"the only thing needs changing is \n\n  quotas[\u0027volumes\u0027]  \u003d\u003e quotas[_get_over(\u0027volumes\u0027)]","commit_id":"371ab03b4170f39d40ee73831c77aef4a6c6c238"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"77167bb10cd8043f8af439184a15a38abc4b60b2","unresolved":false,"context_lines":[{"line_number":566,"context_line":"                          \"already consumed)\")"},{"line_number":567,"context_line":"                LOG.warning(msg, {\u0027s_pid\u0027: context.project_id,"},{"line_number":568,"context_line":"                                  \u0027d_consumed\u0027: _consumed(\u0027volumes\u0027)})"},{"line_number":569,"context_line":"                raise exception.VolumeLimitExceeded(allowed\u003dquotas[\u0027volumes\u0027])"},{"line_number":570,"context_line":"            else:"},{"line_number":571,"context_line":"                # If nothing was reraised, ensure we reraise the initial error"},{"line_number":572,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_7e948436","side":"PARENT","line":569,"in_reply_to":"1a4dcd0f_283b26ed","updated":"2015-08-04 08:42:49.000000000","message":"I think the quota name improves the exception and log message. We have made similar change in VolumeSizeExceedsAvailableQuota.","commit_id":"371ab03b4170f39d40ee73831c77aef4a6c6c238"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"932f748b7232ef5b7efbe1b1edf8967be80772a5","unresolved":false,"context_lines":[{"line_number":564,"context_line":"                exceeded_vol_limit_name \u003d _get_over(\u0027volumes\u0027)"},{"line_number":565,"context_line":"                if exceeded_vol_limit_name:"},{"line_number":566,"context_line":"                    msg \u003d _LW(\"Quota %(s_name)s exceeded for %(s_pid)s, tried \""},{"line_number":567,"context_line":"                              \"to create volume (%(d_consumed)d of %(d_quota)d\""},{"line_number":568,"context_line":"                              \" volume(s) already consumed).\")"},{"line_number":569,"context_line":"                    LOG.warning(msg,"},{"line_number":570,"context_line":"                                {\u0027s_name\u0027: exceeded_vol_limit_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_e8b0de8d","line":567,"updated":"2015-08-04 08:10:04.000000000","message":"Is this really necessary?  In terms of number of volumes, when quota excceeds, d_consumed always equals to d_quota.","commit_id":"0cae6bc14c790ead84766e125d70dbe8063d8a34"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"77167bb10cd8043f8af439184a15a38abc4b60b2","unresolved":false,"context_lines":[{"line_number":564,"context_line":"                exceeded_vol_limit_name \u003d _get_over(\u0027volumes\u0027)"},{"line_number":565,"context_line":"                if exceeded_vol_limit_name:"},{"line_number":566,"context_line":"                    msg \u003d _LW(\"Quota %(s_name)s exceeded for %(s_pid)s, tried \""},{"line_number":567,"context_line":"                              \"to create volume (%(d_consumed)d of %(d_quota)d\""},{"line_number":568,"context_line":"                              \" volume(s) already consumed).\")"},{"line_number":569,"context_line":"                    LOG.warning(msg,"},{"line_number":570,"context_line":"                                {\u0027s_name\u0027: exceeded_vol_limit_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_3ee27c04","line":567,"in_reply_to":"1a4dcd0f_e8b0de8d","updated":"2015-08-04 08:42:49.000000000","message":"Done","commit_id":"0cae6bc14c790ead84766e125d70dbe8063d8a34"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"043328a2b4408992e596f6d9780ec63bab16e0c0","unresolved":false,"context_lines":[{"line_number":560,"context_line":"                    requested\u003dsize,"},{"line_number":561,"context_line":"                    consumed\u003d_consumed(over_name),"},{"line_number":562,"context_line":"                    quota\u003dquotas[over_name])"},{"line_number":563,"context_line":"            else:"},{"line_number":564,"context_line":"                exceeded_vol_limit_name \u003d _get_over(\u0027volumes\u0027)"},{"line_number":565,"context_line":"                if exceeded_vol_limit_name:"},{"line_number":566,"context_line":"                    msg \u003d _LW(\"Quota %(s_name)s exceeded for %(s_pid)s, tried \""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_b9644fe5","line":563,"updated":"2015-08-04 14:08:10.000000000","message":"Any reason why you had to put this in an else, instead of keeping the elif?\n\nThe elif would work if you assign\"exceeded_vol_limit_name \u003d _get_over(\u0027volumes\u0027)\" in the beginning near L549, just like over_name.  This raises the cyclomatic complexity (https://github.com/openstack/cinder/blob/master/tox.ini#L149).","commit_id":"6d0c8fd648c2e0a2424aacce4754220ab5fdcc32"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f9afb87ab3983a9d601776c3a7a3e86d92554b22","unresolved":false,"context_lines":[{"line_number":560,"context_line":"                    requested\u003dsize,"},{"line_number":561,"context_line":"                    consumed\u003d_consumed(over_name),"},{"line_number":562,"context_line":"                    quota\u003dquotas[over_name])"},{"line_number":563,"context_line":"            else:"},{"line_number":564,"context_line":"                exceeded_vol_limit_name \u003d _get_over(\u0027volumes\u0027)"},{"line_number":565,"context_line":"                if exceeded_vol_limit_name:"},{"line_number":566,"context_line":"                    msg \u003d _LW(\"Quota %(s_name)s exceeded for %(s_pid)s, tried \""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_63a03144","line":563,"in_reply_to":"1a4dcd0f_b9644fe5","updated":"2015-08-05 06:27:59.000000000","message":"Done\n\nThought of declaring the variable close to its use.","commit_id":"6d0c8fd648c2e0a2424aacce4754220ab5fdcc32"}]}