)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"de4b8986223bdc2c26ceef4d1c088f77986a97fd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     James Carey \u003cjecarey@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-06 05:18:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix order of arguments in assertEqual for scheduler unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When assertEqual is used it should be assertEqual(exected, observed)."},{"line_number":10,"context_line":"Constant values are always the expected.  This patch makes them the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_2df08666","line":7,"updated":"2015-08-06 13:34:53.000000000","message":"The first line of commit message should be limited to 50 characters.\nref: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"790679968621b1f06455d377b24fa3960325c723","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     James Carey \u003cjecarey@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-06 05:18:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix order of arguments in assertEqual for scheduler unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When assertEqual is used it should be assertEqual(exected, observed)."},{"line_number":10,"context_line":"Constant values are always the expected.  This patch makes them the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_51cd5783","line":7,"in_reply_to":"1a4dcd0f_2df08666","updated":"2015-08-06 20:21:23.000000000","message":"Done","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"de4b8986223bdc2c26ceef4d1c088f77986a97fd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix order of arguments in assertEqual for scheduler unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When assertEqual is used it should be assertEqual(exected, observed)."},{"line_number":10,"context_line":"Constant values are always the expected.  This patch makes them the"},{"line_number":11,"context_line":"first parameter."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_ad049649","line":9,"updated":"2015-08-06 13:34:53.000000000","message":"s/exected/expected","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"790679968621b1f06455d377b24fa3960325c723","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix order of arguments in assertEqual for scheduler unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When assertEqual is used it should be assertEqual(exected, observed)."},{"line_number":10,"context_line":"Constant values are always the expected.  This patch makes them the"},{"line_number":11,"context_line":"first parameter."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_f1c7c361","line":9,"in_reply_to":"1a4dcd0f_ad049649","updated":"2015-08-06 20:21:23.000000000","message":"Done","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"de4b8986223bdc2c26ceef4d1c088f77986a97fd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When assertEqual is used it should be assertEqual(exected, observed)."},{"line_number":10,"context_line":"Constant values are always the expected.  This patch makes them the"},{"line_number":11,"context_line":"first parameter."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iec771d35d1005434281f9efd8bed8d53134abc7f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_607535f8","line":12,"updated":"2015-08-06 13:34:53.000000000","message":"Can you please also report a bug for this issue and link it with Closes-Bug tag.","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"790679968621b1f06455d377b24fa3960325c723","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When assertEqual is used it should be assertEqual(exected, observed)."},{"line_number":10,"context_line":"Constant values are always the expected.  This patch makes them the"},{"line_number":11,"context_line":"first parameter."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iec771d35d1005434281f9efd8bed8d53134abc7f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_b1a4dbb9","line":12,"in_reply_to":"1a4dcd0f_607535f8","updated":"2015-08-06 20:21:23.000000000","message":"Done","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":16973,"name":"Skyler Berg","email":"skylertheberg@gmail.com","username":"sberg"},"change_message_id":"df22981afaacfe2fcfaed6755c8b970a31f7f838","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Constant values are always the expected.  This patch makes them the"},{"line_number":11,"context_line":"first parameter and fixes some other non-constant cases."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1482373"},{"line_number":14,"context_line":"Change-Id: Iec771d35d1005434281f9efd8bed8d53134abc7f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_5866d72a","line":13,"updated":"2015-08-06 22:13:20.000000000","message":"This bug is a subset of https://bugs.launchpad.net/heat/+bug/1259292. Perhaps it should be closed as a duplicate and this should be Partial-Bug: #1259292.","commit_id":"62651e08ece0cf5661eff0034cb0a390ead1df82"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"d9ab9cb568dce88f925c3457a33f5bb041ebefba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     James Carey \u003cjecarey@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-11 05:25:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix order of parms in assertEqual for scheduler ut"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When assertEqual is used it should be assertEqual(expected, observed)."},{"line_number":10,"context_line":"Constant values are always the expected.  This patch makes them the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a4dcd0f_acb38be8","line":7,"updated":"2015-08-11 06:52:53.000000000","message":"s/parms/params","commit_id":"8508556da66bbd66c0739d1d0bf9e9cea796e74f"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"d9ab9cb568dce88f925c3457a33f5bb041ebefba","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix order of parms in assertEqual for scheduler ut"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When assertEqual is used it should be assertEqual(expected, observed)."},{"line_number":10,"context_line":"Constant values are always the expected.  This patch makes them the"},{"line_number":11,"context_line":"first parameter and fixes some other non-constant cases."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1482373"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a4dcd0f_ec07537f","line":10,"updated":"2015-08-11 06:52:53.000000000","message":"Please remove an extra space before \"This patch makes\".","commit_id":"8508556da66bbd66c0739d1d0bf9e9cea796e74f"}],"cinder/tests/unit/scheduler/test_capacity_weigher.py":[{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"3a3d2eea7b90b800e60ce2feb14aec6cad305a2d","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        worst_host \u003d weighed_hosts[-1]"},{"line_number":271,"context_line":"        self.assertEqual(-1.0, worst_host.weight)"},{"line_number":272,"context_line":"        self.assertEqual("},{"line_number":273,"context_line":"            \u0027host5\u0027,"},{"line_number":274,"context_line":"            utils.extract_host(worst_host.obj.host))"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def test_capacity_weight_free_infinite(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_a3a27e97","line":273,"updated":"2015-08-06 05:38:30.000000000","message":"Remove the extra lines to be consistent.","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"790679968621b1f06455d377b24fa3960325c723","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        worst_host \u003d weighed_hosts[-1]"},{"line_number":271,"context_line":"        self.assertEqual(-1.0, worst_host.weight)"},{"line_number":272,"context_line":"        self.assertEqual("},{"line_number":273,"context_line":"            \u0027host5\u0027,"},{"line_number":274,"context_line":"            utils.extract_host(worst_host.obj.host))"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def test_capacity_weight_free_infinite(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_3199ab7c","line":273,"in_reply_to":"1a4dcd0f_a3a27e97","updated":"2015-08-06 20:21:23.000000000","message":"Done","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"}],"cinder/tests/unit/scheduler/test_host_manager.py":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"de4b8986223bdc2c26ceef4d1c088f77986a97fd","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.host_manager.update_service_capabilities(service_name, \u0027host3\u0027,"},{"line_number":103,"context_line":"                                                      host3_volume_capabs)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Make sure dictionary isn\u0027t re-assigned"},{"line_number":106,"context_line":"        self.assertEqual(self.host_manager.service_states, service_states)"},{"line_number":107,"context_line":"        # Make sure original dictionary wasn\u0027t copied"},{"line_number":108,"context_line":"        self.assertEqual(1, host1_volume_capabs[\u0027timestamp\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_80b40135","line":105,"updated":"2015-08-06 13:34:53.000000000","message":"This should be self.assertEqual(service_states, self.host_manager.service_states)","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"790679968621b1f06455d377b24fa3960325c723","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.host_manager.update_service_capabilities(service_name, \u0027host3\u0027,"},{"line_number":103,"context_line":"                                                      host3_volume_capabs)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Make sure dictionary isn\u0027t re-assigned"},{"line_number":106,"context_line":"        self.assertEqual(self.host_manager.service_states, service_states)"},{"line_number":107,"context_line":"        # Make sure original dictionary wasn\u0027t copied"},{"line_number":108,"context_line":"        self.assertEqual(1, host1_volume_capabs[\u0027timestamp\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_91843f0b","line":105,"in_reply_to":"1a4dcd0f_80b40135","updated":"2015-08-06 20:21:23.000000000","message":"Done","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"de4b8986223bdc2c26ceef4d1c088f77986a97fd","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        expected \u003d {\u0027host1\u0027: host1_volume_capabs,"},{"line_number":115,"context_line":"                    \u0027host2\u0027: host2_volume_capabs,"},{"line_number":116,"context_line":"                    \u0027host3\u0027: host3_volume_capabs}"},{"line_number":117,"context_line":"        self.assertDictMatch(service_states, expected)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @mock.patch(\u0027cinder.utils.service_is_up\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_20072dcb","line":116,"updated":"2015-08-06 13:34:53.000000000","message":"Not relevant as per your commit message, but you can fix if you are OK with this change. \n\nself.assertDictMatch(expected, service_states)","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"790679968621b1f06455d377b24fa3960325c723","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        expected \u003d {\u0027host1\u0027: host1_volume_capabs,"},{"line_number":115,"context_line":"                    \u0027host2\u0027: host2_volume_capabs,"},{"line_number":116,"context_line":"                    \u0027host3\u0027: host3_volume_capabs}"},{"line_number":117,"context_line":"        self.assertDictMatch(service_states, expected)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @mock.patch(\u0027cinder.utils.service_is_up\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_517b1728","line":116,"in_reply_to":"1a4dcd0f_20072dcb","updated":"2015-08-06 20:21:23.000000000","message":"Done","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"de4b8986223bdc2c26ceef4d1c088f77986a97fd","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        self.assertEqual(3, len(host_state_map))"},{"line_number":257,"context_line":"        for i in range(3):"},{"line_number":258,"context_line":"            volume_node \u003d services[i]"},{"line_number":259,"context_line":"            host \u003d volume_node[\u0027host\u0027]"},{"line_number":260,"context_line":"            self.assertEqual(host_state_map[host].service, volume_node)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        # Second test: Now service_is_up returns False for host3"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_20bc0ddb","line":259,"updated":"2015-08-06 13:34:53.000000000","message":"This should be \n\nself.assertEqual(volume_node, host_state_map[host].service)","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"790679968621b1f06455d377b24fa3960325c723","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        self.assertEqual(3, len(host_state_map))"},{"line_number":257,"context_line":"        for i in range(3):"},{"line_number":258,"context_line":"            volume_node \u003d services[i]"},{"line_number":259,"context_line":"            host \u003d volume_node[\u0027host\u0027]"},{"line_number":260,"context_line":"            self.assertEqual(host_state_map[host].service, volume_node)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        # Second test: Now service_is_up returns False for host3"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_11710f44","line":259,"in_reply_to":"1a4dcd0f_20bc0ddb","updated":"2015-08-06 20:21:23.000000000","message":"Done","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"de4b8986223bdc2c26ceef4d1c088f77986a97fd","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        for i in range(2):"},{"line_number":284,"context_line":"            volume_node \u003d services[i]"},{"line_number":285,"context_line":"            host \u003d volume_node[\u0027host\u0027]"},{"line_number":286,"context_line":"            self.assertEqual(host_state_map[host].service,"},{"line_number":287,"context_line":"                             volume_node)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    @mock.patch(\u0027cinder.db.service_get_all_by_topic\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_a0d33d03","line":286,"updated":"2015-08-06 13:34:53.000000000","message":"IMO it should be\n\nself.assertEqual(volume_node, host_state_map[host].service)","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"790679968621b1f06455d377b24fa3960325c723","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        for i in range(2):"},{"line_number":284,"context_line":"            volume_node \u003d services[i]"},{"line_number":285,"context_line":"            host \u003d volume_node[\u0027host\u0027]"},{"line_number":286,"context_line":"            self.assertEqual(host_state_map[host].service,"},{"line_number":287,"context_line":"                             volume_node)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    @mock.patch(\u0027cinder.db.service_get_all_by_topic\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_51a2379a","line":286,"in_reply_to":"1a4dcd0f_a0d33d03","updated":"2015-08-06 20:21:23.000000000","message":"Done","commit_id":"1eeff3848f5b2fde3e9db3c7db98d45fa6ec3940"}]}