)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"856698550383a070723025b480cf71bdbf993d32","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During migration, the dummy target volume can be created in"},{"line_number":10,"context_line":"the internal tenant. It is not meaningful to create in the"},{"line_number":11,"context_line":"actual tenant."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib5dd9c03297fe94e1ea6337f44095c577656d9b8"},{"line_number":14,"context_line":"Partial-implements: blueprint migration-improvement"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa1b9901_ae13e15b","line":11,"updated":"2015-08-17 16:19:09.000000000","message":"Can you expand a little more here and talk about what you did? Maybe mention how the internal tenant is used now instead of how it worked before.","commit_id":"34852d93214798f4124a299b99c32e220cc16d46"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":17043,"name":"Timothy Symanczyk","email":"tim@symanczyk.com","username":"timothy_symanczyk"},"change_message_id":"1cfc59dd8004c5342e7cc351cf1ff5463fdcede2","unresolved":false,"context_lines":[{"line_number":1176,"context_line":"            value_to_dst \u003d src_original_data.get(key)"},{"line_number":1177,"context_line":"            # The implementation of update_migrated_volume will decide the"},{"line_number":1178,"context_line":"            # values for _name_id and provider_location."},{"line_number":1179,"context_line":"            # The columns of user_id and project_id do not need to change"},{"line_number":1180,"context_line":"            # as well."},{"line_number":1181,"context_line":"            if (key in (\u0027id\u0027, \u0027provider_location\u0027, \u0027user_id\u0027, \u0027project_id\u0027)"},{"line_number":1182,"context_line":"                    or not is_column(dest_volume_ref, key)):"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa1b9901_46bd4f01","line":1179,"updated":"2015-08-21 21:50:05.000000000","message":"The meaning of this comment is not clear to me.","commit_id":"01fb861aa6853466580b269eb1fa57b943cf2c1f"}],"cinder/volume/manager.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"8496bd931567439e42f78cc560e6f9b3b50c0c06","unresolved":false,"context_lines":[{"line_number":1237,"context_line":"        new_vol_values[\u0027volume_attachment\u0027] \u003d []"},{"line_number":1238,"context_line":"        internal_context \u003d context.get_internal_tenant_context()"},{"line_number":1239,"context_line":"        new_volume \u003d self.db.volume_create(internal_context, new_vol_values)"},{"line_number":1240,"context_line":"        rpcapi.create_volume(internal_context, new_volume, host[\u0027host\u0027],"},{"line_number":1241,"context_line":"                             None, None, allow_reschedule\u003dFalse)"},{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"        # Wait for new_volume to become ready"},{"line_number":1244,"context_line":"        starttime \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_657ae7be","line":1241,"range":{"start_line":1240,"start_character":8,"end_line":1241,"end_character":64},"updated":"2015-08-07 15:14:06.000000000","message":"I\u0027m not very familiar with the migration code flow so this might be a dumb question, but don\u0027t we then need to switch the owner of the new volume over to the original tenant once the data migration is complete and the new volume is ready to become the \u0027real\u0027 one?","commit_id":"a18b06131eb57cfd4d29de302a93ba38b7c0b4e5"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"18a25f6c4b91a504e143637b3a67a4268c34de80","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"        internal_context \u003d context.get_internal_tenant_context()"},{"line_number":1239,"context_line":"        new_volume \u003d self.db.volume_create(internal_context, new_vol_values)"},{"line_number":1240,"context_line":"        rpcapi.create_volume(internal_context, new_volume, host[\u0027host\u0027],"},{"line_number":1241,"context_line":"                             None, None, allow_reschedule\u003dFalse)"},{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"        # Wait for new_volume to become ready"},{"line_number":1244,"context_line":"        starttime \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_8f760e05","line":1241,"in_reply_to":"1a4dcd0f_657ae7be","updated":"2015-08-09 01:52:08.000000000","message":"First, when the new volume is ready after the migration, the old volume\u0027s record in DB will be used for it.\nSecond, some updates need to be done on the old volume\u0027s record, which we can keep the old tenant and user id to make sure that the information is correct.","commit_id":"a18b06131eb57cfd4d29de302a93ba38b7c0b4e5"}]}