)]}'
{"cinder/volume/drivers/netapp/dataontap/block_7mode.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"514f2a993a9c75865a9c3e4cd7ddb105e94ac464","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        for vol in self.vols:"},{"line_number":310,"context_line":"            vol_name \u003d vol.get_child_content(\u0027name\u0027)"},{"line_number":311,"context_line":"            if pool_regex.match(vol_name):"},{"line_number":312,"context_line":"                LOG.debug(\"Volume \u0027%s\u0027 matches against regular expression:\""},{"line_number":313,"context_line":"                          \" %s\", vol_name, pool_regex.pattern)"},{"line_number":314,"context_line":"                filtered_pools.append(vol_name)"},{"line_number":315,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_d28a8f1a","line":312,"updated":"2015-08-21 15:03:24.000000000","message":"If you do another update, please use named variables for these since there is more than one.","commit_id":"f3c14dd1cb5ff7d3e0bdb235237cf90053054b0d"}],"cinder/volume/drivers/netapp/dataontap/block_cmode.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"514f2a993a9c75865a9c3e4cd7ddb105e94ac464","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        return pools"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def _get_filtered_pools(self):"},{"line_number":247,"context_line":"        \"\"\"Return filtered pools given a pool name search pattern.\"\"\""},{"line_number":248,"context_line":"        pool_regex \u003d na_utils.get_pool_name_filter_regex(self.configuration)"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_b236fb4e","line":246,"updated":"2015-08-21 15:03:24.000000000","message":"Can this be moved into a common class? Very minor difference between the 7mode and cmode implementations.","commit_id":"f3c14dd1cb5ff7d3e0bdb235237cf90053054b0d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9d25b8250d76789177814b6b4f6dbd56242592b4","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        return pools"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def _get_filtered_pools(self):"},{"line_number":247,"context_line":"        \"\"\"Return filtered pools given a pool name search pattern.\"\"\""},{"line_number":248,"context_line":"        pool_regex \u003d na_utils.get_pool_name_filter_regex(self.configuration)"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_8f2145b7","line":246,"in_reply_to":"fa1b9901_b236fb4e","updated":"2015-08-21 18:24:45.000000000","message":"Hi Sean, Thanks for the input. Yes, I felt this could be moved too. In fact, we have a task upcoming (Mitaka) to fix 7mode implementation to align with cMode. We have ssc capabilities (the data structure with ssc info being reported to the scheduler) here in cMode that we haven\u0027t still supported in 7mode. I\u0027ll make sure to make this change in that patch.","commit_id":"f3c14dd1cb5ff7d3e0bdb235237cf90053054b0d"}]}