)]}'
{"cinder/volume/drivers/eqlx.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b4575efb30ec0dbda1fb9642ef225e7e1925299a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                    \u0027in favour of \"ssh_conn_timeout\" as \u0027"},{"line_number":49,"context_line":"                    \u0027specified in cinder/volume/drivers/san/san.py \u0027"},{"line_number":50,"context_line":"                    \u0027and will be \u0027"},{"line_number":51,"context_line":"                    \u0027removed in M release.\u0027),"},{"line_number":52,"context_line":"    cfg.IntOpt(\u0027eqlx_cli_max_retries\u0027,"},{"line_number":53,"context_line":"               default\u003d5,"},{"line_number":54,"context_line":"               help\u003d\u0027Maximum retry count for reconnection. Default is 5.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_cece662d","line":51,"updated":"2015-08-13 21:05:17.000000000","message":"This is inconsistent with the messaging you are logging later.  You say it will be removed in M release here, yet the log message later says it\u0027s going to be deprecated in M, which implies removal after M.\n\nwhich is it?","commit_id":"fdd58991f66ea41ec1083eadf7f6d176d95e0f7d"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"66aa69a86060489578525cbbda743a4ceb5a7f60","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                    \u0027in favour of \"ssh_conn_timeout\" as \u0027"},{"line_number":49,"context_line":"                    \u0027specified in cinder/volume/drivers/san/san.py \u0027"},{"line_number":50,"context_line":"                    \u0027and will be \u0027"},{"line_number":51,"context_line":"                    \u0027removed in M release.\u0027),"},{"line_number":52,"context_line":"    cfg.IntOpt(\u0027eqlx_cli_max_retries\u0027,"},{"line_number":53,"context_line":"               default\u003d5,"},{"line_number":54,"context_line":"               help\u003d\u0027Maximum retry count for reconnection. Default is 5.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_3ac91a5b","line":51,"in_reply_to":"1a4dcd0f_cece662d","updated":"2015-08-14 15:29:09.000000000","message":"Good catch. It is deprecated now and will go away in M. Will fix the other msg","commit_id":"fdd58991f66ea41ec1083eadf7f6d176d95e0f7d"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"648a81518dbfa73601c3bd2b065bdace9c3d53c8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            msg \u003d _LW(\u0027Configuration option eqlx_cli_timeout \u0027"},{"line_number":167,"context_line":"                      \u0027will be deprecated in M release. \u0027"},{"line_number":168,"context_line":"                      \u0027Use ssh_conn_timeout instead.\u0027)"},{"line_number":169,"context_line":"            self.configuration.ssh_conn_timeout \u003d \\"},{"line_number":170,"context_line":"                self.configuration.eqlx_cli_timeout"},{"line_number":171,"context_line":"            versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":172,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_84f7e7d3","line":169,"updated":"2015-08-13 18:42:44.000000000","message":"It is preferred to wrap long lines in parentheses and not a backslash for line continuation.","commit_id":"fdd58991f66ea41ec1083eadf7f6d176d95e0f7d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b4575efb30ec0dbda1fb9642ef225e7e1925299a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            msg \u003d _LW(\u0027Configuration option eqlx_cli_timeout \u0027"},{"line_number":167,"context_line":"                      \u0027will be deprecated in M release. \u0027"},{"line_number":168,"context_line":"                      \u0027Use ssh_conn_timeout instead.\u0027)"},{"line_number":169,"context_line":"            self.configuration.ssh_conn_timeout \u003d \\"},{"line_number":170,"context_line":"                self.configuration.eqlx_cli_timeout"},{"line_number":171,"context_line":"            versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":172,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_ce80a6c2","line":169,"in_reply_to":"1a4dcd0f_84f7e7d3","updated":"2015-08-13 21:05:17.000000000","message":"I\u0027m not sure I understand the point of this patch.  Why are we saying that we are going to deprecate an option in the future?  Isn\u0027t the purpose of deprecation is that we are going to remove an option in the future?   Shouldn\u0027t we deprecate this option now and say it will be removed in version X, instead of saying we are going to deprecate it in X?","commit_id":"fdd58991f66ea41ec1083eadf7f6d176d95e0f7d"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"66aa69a86060489578525cbbda743a4ceb5a7f60","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            msg \u003d _LW(\u0027Configuration option eqlx_cli_timeout \u0027"},{"line_number":167,"context_line":"                      \u0027will be deprecated in M release. \u0027"},{"line_number":168,"context_line":"                      \u0027Use ssh_conn_timeout instead.\u0027)"},{"line_number":169,"context_line":"            self.configuration.ssh_conn_timeout \u003d \\"},{"line_number":170,"context_line":"                self.configuration.eqlx_cli_timeout"},{"line_number":171,"context_line":"            versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":172,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_1a73fe16","line":169,"in_reply_to":"1a4dcd0f_84f7e7d3","updated":"2015-08-14 15:29:09.000000000","message":"I\u0027m not sure how you would use paraentheses here.","commit_id":"fdd58991f66ea41ec1083eadf7f6d176d95e0f7d"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"648a81518dbfa73601c3bd2b065bdace9c3d53c8","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            self.configuration.ssh_conn_timeout \u003d \\"},{"line_number":170,"context_line":"                self.configuration.eqlx_cli_timeout"},{"line_number":171,"context_line":"            versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":172,"context_line":"            return"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def _get_output(self, chan):"},{"line_number":175,"context_line":"        out \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_044bd760","line":172,"updated":"2015-08-13 18:42:44.000000000","message":"is this return required?","commit_id":"fdd58991f66ea41ec1083eadf7f6d176d95e0f7d"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"66aa69a86060489578525cbbda743a4ceb5a7f60","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            self.configuration.ssh_conn_timeout \u003d \\"},{"line_number":170,"context_line":"                self.configuration.eqlx_cli_timeout"},{"line_number":171,"context_line":"            versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":172,"context_line":"            return"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def _get_output(self, chan):"},{"line_number":175,"context_line":"        out \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_3a7b5a2b","line":172,"in_reply_to":"1a4dcd0f_044bd760","updated":"2015-08-14 15:29:09.000000000","message":"Agree. Will remove","commit_id":"fdd58991f66ea41ec1083eadf7f6d176d95e0f7d"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"79719de922ecc31de488203ccc44ffed32637661","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    \u0027Default is 30. Note that this option is deprecated \u0027"},{"line_number":48,"context_line":"                    \u0027in favour of \"ssh_conn_timeout\" as \u0027"},{"line_number":49,"context_line":"                    \u0027specified in cinder/volume/drivers/san/san.py \u0027"},{"line_number":50,"context_line":"                    \u0027and will be \u0027"},{"line_number":51,"context_line":"                    \u0027removed in M release.\u0027),"},{"line_number":52,"context_line":"    cfg.IntOpt(\u0027eqlx_cli_max_retries\u0027,"},{"line_number":53,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_a2c3b889","line":50,"updated":"2015-08-14 20:21:14.000000000","message":"It should be: \u0027and will be removed in M release.\u0027 A new line is not necessary, in this case, since it will have less then 80 characters.","commit_id":"3f898f5d7d592512944bb0c80c288676ca0f7546"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"8963d27ad5fbb73fd773bd7eb025edfec10c7f02","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                    \u0027Default is 30. Note that this option is deprecated \u0027"},{"line_number":48,"context_line":"                    \u0027in favour of \"ssh_conn_timeout\" as \u0027"},{"line_number":49,"context_line":"                    \u0027specified in cinder/volume/drivers/san/san.py \u0027"},{"line_number":50,"context_line":"                    \u0027and will be \u0027"},{"line_number":51,"context_line":"                    \u0027removed in M release.\u0027),"},{"line_number":52,"context_line":"    cfg.IntOpt(\u0027eqlx_cli_max_retries\u0027,"},{"line_number":53,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_ed077116","line":50,"in_reply_to":"1a4dcd0f_a2c3b889","updated":"2015-08-14 20:35:13.000000000","message":"Will fix. Thanks","commit_id":"3f898f5d7d592512944bb0c80c288676ca0f7546"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"44bdd203f39f5335a4e3443a5acd425d4756528c","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    \"\"\""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    VERSION \u003d \"1.2.0\""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":146,"context_line":"        super(DellEQLSanISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_674aa257","line":143,"updated":"2015-08-14 19:50:37.000000000","message":"Are you not keeping a version history for your changes?","commit_id":"3f898f5d7d592512944bb0c80c288676ca0f7546"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"8963d27ad5fbb73fd773bd7eb025edfec10c7f02","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    \"\"\""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    VERSION \u003d \"1.2.0\""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":146,"context_line":"        super(DellEQLSanISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_2d4c7975","line":143,"in_reply_to":"1a4dcd0f_674aa257","updated":"2015-08-14 20:35:13.000000000","message":"We never did. Will start tracking. Its probably a good idea","commit_id":"3f898f5d7d592512944bb0c80c288676ca0f7546"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a97174c8992a899357f9271e98dcc7c80ab9fafc","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            self.configuration.chap_password \u003d \\"},{"line_number":163,"context_line":"                self.configuration.eqlx_chap_password"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if self.configuration.eqlx_cli_timeout:"},{"line_number":166,"context_line":"            msg \u003d _LW(\u0027Configuration option eqlx_cli_timeout \u0027"},{"line_number":167,"context_line":"                      \u0027is deprecated and will be removed in M release. \u0027"},{"line_number":168,"context_line":"                      \u0027Use ssh_conn_timeout instead.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_7cc23555","line":165,"updated":"2015-08-14 19:31:09.000000000","message":"If eqlx_cli_timeout is set we should probably check if ssh_conn_timeout is set or not and override it with this value. That way the timeout will still work until they update their config and until the option is completely deprecated and removed.","commit_id":"3f898f5d7d592512944bb0c80c288676ca0f7546"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"8963d27ad5fbb73fd773bd7eb025edfec10c7f02","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            self.configuration.chap_password \u003d \\"},{"line_number":163,"context_line":"                self.configuration.eqlx_chap_password"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if self.configuration.eqlx_cli_timeout:"},{"line_number":166,"context_line":"            msg \u003d _LW(\u0027Configuration option eqlx_cli_timeout \u0027"},{"line_number":167,"context_line":"                      \u0027is deprecated and will be removed in M release. \u0027"},{"line_number":168,"context_line":"                      \u0027Use ssh_conn_timeout instead.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_ed6c51d2","line":165,"in_reply_to":"1a4dcd0f_7cc23555","updated":"2015-08-14 20:35:13.000000000","message":"Even if ssh_conn_timeout is not set, it will be set to default value. So I\u0027m thinking it will be set no matter what.","commit_id":"3f898f5d7d592512944bb0c80c288676ca0f7546"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"44bdd203f39f5335a4e3443a5acd425d4756528c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            self.configuration.chap_password \u003d \\"},{"line_number":163,"context_line":"                self.configuration.eqlx_chap_password"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if self.configuration.eqlx_cli_timeout:"},{"line_number":166,"context_line":"            msg \u003d _LW(\u0027Configuration option eqlx_cli_timeout \u0027"},{"line_number":167,"context_line":"                      \u0027is deprecated and will be removed in M release. \u0027"},{"line_number":168,"context_line":"                      \u0027Use ssh_conn_timeout instead.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_279a5ac6","line":165,"in_reply_to":"1a4dcd0f_7cc23555","updated":"2015-08-14 19:50:37.000000000","message":"Sounds reasonable.","commit_id":"3f898f5d7d592512944bb0c80c288676ca0f7546"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a97174c8992a899357f9271e98dcc7c80ab9fafc","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            msg \u003d _LW(\u0027Configuration option eqlx_cli_timeout \u0027"},{"line_number":167,"context_line":"                      \u0027is deprecated and will be removed in M release. \u0027"},{"line_number":168,"context_line":"                      \u0027Use ssh_conn_timeout instead.\u0027)"},{"line_number":169,"context_line":"            self.configuration.ssh_conn_timeout \u003d \\"},{"line_number":170,"context_line":"                self.configuration.eqlx_cli_timeout"},{"line_number":171,"context_line":"            versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_bc8f5d2d","line":169,"updated":"2015-08-14 19:31:09.000000000","message":"I know it\u0027s existing, but we\u0027ve been trying not to use \\ for line continuation for any new code going in. Use () instead to allow the assignment to span lines.","commit_id":"3f898f5d7d592512944bb0c80c288676ca0f7546"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"8963d27ad5fbb73fd773bd7eb025edfec10c7f02","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            msg \u003d _LW(\u0027Configuration option eqlx_cli_timeout \u0027"},{"line_number":167,"context_line":"                      \u0027is deprecated and will be removed in M release. \u0027"},{"line_number":168,"context_line":"                      \u0027Use ssh_conn_timeout instead.\u0027)"},{"line_number":169,"context_line":"            self.configuration.ssh_conn_timeout \u003d \\"},{"line_number":170,"context_line":"                self.configuration.eqlx_cli_timeout"},{"line_number":171,"context_line":"            versionutils.report_deprecated_feature(LOG, msg)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_cd62b5d9","line":169,"in_reply_to":"1a4dcd0f_bc8f5d2d","updated":"2015-08-14 20:35:13.000000000","message":"Will fix. Thx","commit_id":"3f898f5d7d592512944bb0c80c288676ca0f7546"}]}