)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f192198248422dd176bbbaf0d53923e1a93c0548","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Multiple test cases are timing out in the new"},{"line_number":10,"context_line":"Jenkins environment.  This patch lowers the file"},{"line_number":11,"context_line":"size in order to avoid this issue."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I04cf9d6dbdaebb8944a38ffa34d1e2e1b27e2552"},{"line_number":14,"context_line":"Closes-bug: 1480361"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_1029c837","line":11,"updated":"2015-08-13 22:07:07.000000000","message":"Jacob,\n\nWe need to provide some more details here as to how you determined this.  I.E. We have a test system that appears to be I/O constrained and is hitting timeouts.  Rather than mocking out the file copy we decided to reduce to file size to avoid timeouts.  This way we aren\u0027t changing the way the test case works but we are reducing the time required to run the test cases.  This will help improve check and gate performance as well.","commit_id":"fb00e1970adc5c33fa5dea0b60bc79be11ed91b6"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"e8c2e6e35c7512a264cdbae7058e5b98a4ae39db","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Multiple test cases are timing out in the new"},{"line_number":10,"context_line":"Jenkins environment.  This patch lowers the file"},{"line_number":11,"context_line":"size in order to avoid this issue."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I04cf9d6dbdaebb8944a38ffa34d1e2e1b27e2552"},{"line_number":14,"context_line":"Closes-bug: 1480361"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_b729ca39","line":11,"in_reply_to":"1a4dcd0f_07d42cbb","updated":"2015-08-14 13:48:27.000000000","message":"Done","commit_id":"fb00e1970adc5c33fa5dea0b60bc79be11ed91b6"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"e8c2e6e35c7512a264cdbae7058e5b98a4ae39db","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Multiple test cases are timing out in the new"},{"line_number":10,"context_line":"Jenkins environment.  This patch lowers the file"},{"line_number":11,"context_line":"size in order to avoid this issue."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I04cf9d6dbdaebb8944a38ffa34d1e2e1b27e2552"},{"line_number":14,"context_line":"Closes-bug: 1480361"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_9724ce60","line":11,"in_reply_to":"1a4dcd0f_1029c837","updated":"2015-08-14 13:48:27.000000000","message":"Done","commit_id":"fb00e1970adc5c33fa5dea0b60bc79be11ed91b6"},{"author":{"_account_id":8202,"name":"chenzongliang","email":"chenzongliang@huawei.com","username":"zongliang"},"change_message_id":"0ed59a4ee720c7cb8aa279025e0699e7ca250ab9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Multiple test cases are timing out in the new"},{"line_number":10,"context_line":"Jenkins environment.  This patch lowers the file"},{"line_number":11,"context_line":"size in order to avoid this issue."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I04cf9d6dbdaebb8944a38ffa34d1e2e1b27e2552"},{"line_number":14,"context_line":"Closes-bug: 1480361"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_07d42cbb","line":11,"in_reply_to":"1a4dcd0f_1029c837","updated":"2015-08-14 01:01:39.000000000","message":"I agree with Jay.May be more detail should offered.","commit_id":"fb00e1970adc5c33fa5dea0b60bc79be11ed91b6"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"87d175e3c6bb2b8f740b8a364bb526b5c294f12f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We currently have a test system that appears to be I/O constrained"},{"line_number":10,"context_line":"and is hitting timeouts. Rather than mocking out the file copy, we"},{"line_number":11,"context_line":"decided to reduce the file size in order to avoid timeouts. This way"},{"line_number":12,"context_line":"we are not changing they way these test cases work, but we are reducing"},{"line_number":13,"context_line":"the time required to run each test case. This patch will help improve"},{"line_number":14,"context_line":"check and gate performance as well."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_503ba738","line":12,"updated":"2015-08-14 16:11:51.000000000","message":"typo: the","commit_id":"162ea78a498dcabb88f2e09b1632211fff66f15c"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"29248936cb70d3878842b59cd09ac8944a7c84f9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We currently have a test system that appears to be I/O constrained"},{"line_number":10,"context_line":"and is hitting timeouts. Rather than mocking out the file copy, we"},{"line_number":11,"context_line":"decided to reduce the file size in order to avoid timeouts. This way"},{"line_number":12,"context_line":"we are not changing they way these test cases work, but we are reducing"},{"line_number":13,"context_line":"the time required to run each test case. This patch will help improve"},{"line_number":14,"context_line":"check and gate performance as well."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_4d39c5a2","line":12,"in_reply_to":"1a4dcd0f_503ba738","updated":"2015-08-14 20:38:57.000000000","message":"Done","commit_id":"162ea78a498dcabb88f2e09b1632211fff66f15c"}],"cinder/tests/unit/backup/drivers/test_backup_nfs.py":[{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"87d175e3c6bb2b8f740b8a364bb526b5c294f12f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                         mock.Mock(return_value\u003dmock_remotefsclient))"},{"line_number":146,"context_line":"        # Remove tempdir."},{"line_number":147,"context_line":"        self.addCleanup(shutil.rmtree, self.temp_dir)"},{"line_number":148,"context_line":"        for _i in range(0, 32):"},{"line_number":149,"context_line":"            self.volume_file.write(os.urandom(1024))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_backup_uncompressed(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_d329018b","line":148,"updated":"2015-08-14 16:11:51.000000000","message":"It is likely a silly question, but why have you changed it to \u002732\u0027 exactly and not other value?","commit_id":"162ea78a498dcabb88f2e09b1632211fff66f15c"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"7ba95c3f3279a0cf2c9188c06257405d4f0c8977","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                         mock.Mock(return_value\u003dmock_remotefsclient))"},{"line_number":146,"context_line":"        # Remove tempdir."},{"line_number":147,"context_line":"        self.addCleanup(shutil.rmtree, self.temp_dir)"},{"line_number":148,"context_line":"        for _i in range(0, 32):"},{"line_number":149,"context_line":"            self.volume_file.write(os.urandom(1024))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_backup_uncompressed(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_5654fac8","line":148,"in_reply_to":"1a4dcd0f_d329018b","updated":"2015-08-14 18:36:27.000000000","message":"So in this file three test cases (test_restore_bz2, test_restore_zlib, and test_restore_delta) were timing out while in test_backup_swift.py only one test case was timing out (test_restore_delta). So in this file in order to guarantee all 3 test cases would not timeout I had to lower the file size to \u002732\u0027. \n\nBut since in test_backup_swift.py only one test case was failing, lowering the file size to \u002764\u0027 was enough to guarantee that the test case would not timeout. So I left the size at \u002764\u0027 instead of needlessly lowering it to \u002732\u0027.\n\nHope I was able to answer your question!","commit_id":"162ea78a498dcabb88f2e09b1632211fff66f15c"},{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"224fda7c87ea2576632bcd6e0f70cce468533a2b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                         mock.Mock(return_value\u003dmock_remotefsclient))"},{"line_number":146,"context_line":"        # Remove tempdir."},{"line_number":147,"context_line":"        self.addCleanup(shutil.rmtree, self.temp_dir)"},{"line_number":148,"context_line":"        for _i in range(0, 32):"},{"line_number":149,"context_line":"            self.volume_file.write(os.urandom(1024))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_backup_uncompressed(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_6d2e01a7","line":148,"updated":"2015-08-14 20:54:57.000000000","message":"I think I have made the wrong question before.\n\nSorry if I\u0027m missing something, but why do you need this \u0027for\u0027? Can\u0027t you just write once?","commit_id":"f5576793ea78ff35981a78d9691e570b696f3fa7"}],"cinder/tests/unit/test_backup_swift.py":[{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"87d175e3c6bb2b8f740b8a364bb526b5c294f12f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.addCleanup(self.volume_file.close)"},{"line_number":92,"context_line":"        # Remove tempdir."},{"line_number":93,"context_line":"        self.addCleanup(shutil.rmtree, self.temp_dir)"},{"line_number":94,"context_line":"        for _i in range(0, 64):"},{"line_number":95,"context_line":"            self.volume_file.write(os.urandom(1024))"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_backup_swift_url(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_1319a979","line":94,"updated":"2015-08-14 16:11:51.000000000","message":"Same question here, why change it to \u002764\u0027?","commit_id":"162ea78a498dcabb88f2e09b1632211fff66f15c"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"7ba95c3f3279a0cf2c9188c06257405d4f0c8977","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.addCleanup(self.volume_file.close)"},{"line_number":92,"context_line":"        # Remove tempdir."},{"line_number":93,"context_line":"        self.addCleanup(shutil.rmtree, self.temp_dir)"},{"line_number":94,"context_line":"        for _i in range(0, 64):"},{"line_number":95,"context_line":"            self.volume_file.write(os.urandom(1024))"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_backup_swift_url(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_b6c8de76","line":94,"in_reply_to":"1a4dcd0f_1319a979","updated":"2015-08-14 18:36:27.000000000","message":"Answered in test_backup_nfs.py.","commit_id":"162ea78a498dcabb88f2e09b1632211fff66f15c"}]}
