)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"de56bc80417642296ce025e05b4c58ecde9f2a3c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use min and max on IntOpt option types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Latest version of oslo.config support the ability to set valid"},{"line_number":10,"context_line":"range on IntOpt option values.  This path makes use of that feature"},{"line_number":11,"context_line":"for a number of options with well known minimum and maximum values."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie4b081bdaa373c9dedf7dd0c9884553ffb42b61c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_96fed903","line":10,"updated":"2015-08-17 06:21:25.000000000","message":"s/path/patch/","commit_id":"3bb7fcb64301cec5fc9435d37deaa0617d207a7a"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"007d460e0dd50c42f1c70b646f55224bb68ea1f9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Latest version of oslo.config support the ability to set valid"},{"line_number":10,"context_line":"range on IntOpt option values.  This path makes use of that feature"},{"line_number":11,"context_line":"for a number of options with well known minimum and maximum values."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie4b081bdaa373c9dedf7dd0c9884553ffb42b61c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_c3010506","line":12,"updated":"2015-08-17 05:41:23.000000000","message":"It is better to have a bug or BP link here, so that we know the specific issue being tackled.","commit_id":"3bb7fcb64301cec5fc9435d37deaa0617d207a7a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"49aa4f0a6333994c3e2dc3637840bd8338159add","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Latest version of oslo.config support the ability to set valid"},{"line_number":10,"context_line":"range on IntOpt option values.  This path makes use of that feature"},{"line_number":11,"context_line":"for a number of options with well known minimum and maximum values."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie4b081bdaa373c9dedf7dd0c9884553ffb42b61c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa1b9901_f7c69715","line":12,"in_reply_to":"1a4dcd0f_c3010506","updated":"2015-08-17 14:01:45.000000000","message":"This is more of a small refactoring for more robust code, not really a BP or bug.","commit_id":"3bb7fcb64301cec5fc9435d37deaa0617d207a7a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a3a014f1d5d968ef0790f9cfe4b99e786784ba1d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Latest version of oslo.config support the ability to set valid"},{"line_number":10,"context_line":"range on IntOpt option values.  This path makes use of that feature"},{"line_number":11,"context_line":"for a number of options with well known minimum and maximum values."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie4b081bdaa373c9dedf7dd0c9884553ffb42b61c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa1b9901_55497bcf","line":12,"in_reply_to":"fa1b9901_f7c69715","updated":"2015-08-17 14:41:00.000000000","message":"Agree","commit_id":"3bb7fcb64301cec5fc9435d37deaa0617d207a7a"}],"cinder/volume/driver.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"4c0a513186baecd2d9f3118982fe971ed4917c26","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.IntOpt(\u0027num_shell_tries\u0027,"},{"line_number":46,"context_line":"               default\u003d3,"},{"line_number":47,"context_line":"               help\u003d\u0027Number of times to attempt to run flakey shell commands\u0027),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027reserved_percentage\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               help\u003d\u0027The percentage of backend capacity is reserved\u0027),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027iscsi_num_targets\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_7a11b95c","line":48,"updated":"2015-08-16 20:52:44.000000000","message":"min\u003d0, max\u003d100","commit_id":"0a25f849a854d717afdcd6387f3ef0a7f0a69849"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9992c196627965ea4f07f84a7d694719e7f96acd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.IntOpt(\u0027num_shell_tries\u0027,"},{"line_number":46,"context_line":"               default\u003d3,"},{"line_number":47,"context_line":"               help\u003d\u0027Number of times to attempt to run flakey shell commands\u0027),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027reserved_percentage\u0027,"},{"line_number":49,"context_line":"               default\u003d0,"},{"line_number":50,"context_line":"               help\u003d\u0027The percentage of backend capacity is reserved\u0027),"},{"line_number":51,"context_line":"    cfg.IntOpt(\u0027iscsi_num_targets\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_807bf87a","line":48,"in_reply_to":"1a4dcd0f_7a11b95c","updated":"2015-08-16 22:48:42.000000000","message":"Done","commit_id":"0a25f849a854d717afdcd6387f3ef0a7f0a69849"}],"cinder/volume/drivers/ibm/storwize_svc/__init__.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"4c0a513186baecd2d9f3118982fe971ed4917c26","unresolved":false,"context_lines":[{"line_number":89,"context_line":"               default\u003d0,"},{"line_number":90,"context_line":"               help\u003d\u0027The I/O group in which to allocate volumes\u0027),"},{"line_number":91,"context_line":"    cfg.IntOpt(\u0027storwize_svc_flashcopy_timeout\u0027,"},{"line_number":92,"context_line":"               default\u003d120,"},{"line_number":93,"context_line":"               help\u003d\u0027Maximum number of seconds to wait for FlashCopy to be \u0027"},{"line_number":94,"context_line":"                    \u0027prepared. Maximum value is 600 seconds (10 minutes)\u0027),"},{"line_number":95,"context_line":"    cfg.StrOpt(\u0027storwize_svc_connection_protocol\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_da332d12","line":92,"updated":"2015-08-16 20:52:44.000000000","message":"min\u003d0, max\u003d600 (based on the help text)?","commit_id":"0a25f849a854d717afdcd6387f3ef0a7f0a69849"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9992c196627965ea4f07f84a7d694719e7f96acd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"               default\u003d0,"},{"line_number":90,"context_line":"               help\u003d\u0027The I/O group in which to allocate volumes\u0027),"},{"line_number":91,"context_line":"    cfg.IntOpt(\u0027storwize_svc_flashcopy_timeout\u0027,"},{"line_number":92,"context_line":"               default\u003d120,"},{"line_number":93,"context_line":"               help\u003d\u0027Maximum number of seconds to wait for FlashCopy to be \u0027"},{"line_number":94,"context_line":"                    \u0027prepared. Maximum value is 600 seconds (10 minutes)\u0027),"},{"line_number":95,"context_line":"    cfg.StrOpt(\u0027storwize_svc_connection_protocol\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_00e7e840","line":92,"in_reply_to":"1a4dcd0f_da332d12","updated":"2015-08-16 22:48:42.000000000","message":"Done","commit_id":"0a25f849a854d717afdcd6387f3ef0a7f0a69849"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"007d460e0dd50c42f1c70b646f55224bb68ea1f9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               help\u003d\u0027Storage system storage pool for volumes\u0027),"},{"line_number":64,"context_line":"    cfg.IntOpt(\u0027storwize_svc_vol_rsize\u0027,"},{"line_number":65,"context_line":"               default\u003d2,"},{"line_number":66,"context_line":"               min\u003d-1, max\u003d100,"},{"line_number":67,"context_line":"               help\u003d\u0027Storage system space-efficiency parameter for volumes \u0027"},{"line_number":68,"context_line":"                    \u0027(percentage)\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027storwize_svc_vol_warning\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_e080b78d","line":66,"updated":"2015-08-17 05:41:23.000000000","message":"I think the positive values are easy to understand. Does the negative values have certain meanings for the specific driver?\nDo you think we can explain the negative values a bit?","commit_id":"3bb7fcb64301cec5fc9435d37deaa0617d207a7a"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"de56bc80417642296ce025e05b4c58ecde9f2a3c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               help\u003d\u0027Storage system storage pool for volumes\u0027),"},{"line_number":64,"context_line":"    cfg.IntOpt(\u0027storwize_svc_vol_rsize\u0027,"},{"line_number":65,"context_line":"               default\u003d2,"},{"line_number":66,"context_line":"               min\u003d-1, max\u003d100,"},{"line_number":67,"context_line":"               help\u003d\u0027Storage system space-efficiency parameter for volumes \u0027"},{"line_number":68,"context_line":"                    \u0027(percentage)\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027storwize_svc_vol_warning\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_b6019506","line":66,"updated":"2015-08-17 06:21:25.000000000","message":"Vincent, take a loot at check_vdisk_opts() in storwize_svc/helper.py","commit_id":"3bb7fcb64301cec5fc9435d37deaa0617d207a7a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"49aa4f0a6333994c3e2dc3637840bd8338159add","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               help\u003d\u0027Storage system storage pool for volumes\u0027),"},{"line_number":64,"context_line":"    cfg.IntOpt(\u0027storwize_svc_vol_rsize\u0027,"},{"line_number":65,"context_line":"               default\u003d2,"},{"line_number":66,"context_line":"               min\u003d-1, max\u003d100,"},{"line_number":67,"context_line":"               help\u003d\u0027Storage system space-efficiency parameter for volumes \u0027"},{"line_number":68,"context_line":"                    \u0027(percentage)\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027storwize_svc_vol_warning\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_776da731","line":66,"in_reply_to":"1a4dcd0f_e080b78d","updated":"2015-08-17 14:01:45.000000000","message":"The -1 was always an option according to the code.  But apparently the help message is not very good at explaining that.  I recommend a separate patch address that.","commit_id":"3bb7fcb64301cec5fc9435d37deaa0617d207a7a"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"007d460e0dd50c42f1c70b646f55224bb68ea1f9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                    \u0027(percentage)\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027storwize_svc_vol_warning\u0027,"},{"line_number":70,"context_line":"               default\u003d0,"},{"line_number":71,"context_line":"               min\u003d-1, max\u003d100,"},{"line_number":72,"context_line":"               help\u003d\u0027Storage system threshold for volume capacity warnings \u0027"},{"line_number":73,"context_line":"                    \u0027(percentage)\u0027),"},{"line_number":74,"context_line":"    cfg.BoolOpt(\u0027storwize_svc_vol_autoexpand\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_6043476d","line":71,"updated":"2015-08-17 05:41:23.000000000","message":"The same to the above.","commit_id":"3bb7fcb64301cec5fc9435d37deaa0617d207a7a"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"de56bc80417642296ce025e05b4c58ecde9f2a3c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                    \u0027(percentage)\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027storwize_svc_vol_warning\u0027,"},{"line_number":70,"context_line":"               default\u003d0,"},{"line_number":71,"context_line":"               min\u003d-1, max\u003d100,"},{"line_number":72,"context_line":"               help\u003d\u0027Storage system threshold for volume capacity warnings \u0027"},{"line_number":73,"context_line":"                    \u0027(percentage)\u0027),"},{"line_number":74,"context_line":"    cfg.BoolOpt(\u0027storwize_svc_vol_autoexpand\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_56085128","line":71,"updated":"2015-08-17 06:21:25.000000000","message":"ditto","commit_id":"3bb7fcb64301cec5fc9435d37deaa0617d207a7a"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"49aa4f0a6333994c3e2dc3637840bd8338159add","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                    \u0027(percentage)\u0027),"},{"line_number":69,"context_line":"    cfg.IntOpt(\u0027storwize_svc_vol_warning\u0027,"},{"line_number":70,"context_line":"               default\u003d0,"},{"line_number":71,"context_line":"               min\u003d-1, max\u003d100,"},{"line_number":72,"context_line":"               help\u003d\u0027Storage system threshold for volume capacity warnings \u0027"},{"line_number":73,"context_line":"                    \u0027(percentage)\u0027),"},{"line_number":74,"context_line":"    cfg.BoolOpt(\u0027storwize_svc_vol_autoexpand\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_976abb19","line":71,"in_reply_to":"1a4dcd0f_6043476d","updated":"2015-08-17 14:01:45.000000000","message":"The -1 was always an option according to the code.  But apparently the help message is not very good at explaining that.  I recommend a separate patch address that.","commit_id":"3bb7fcb64301cec5fc9435d37deaa0617d207a7a"}]}