)]}'
{"cinder/volume/drivers/pure.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"c5023457546edfcbb90ec53c0bfca61db2cd3069","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        # to throw a Invalid Reference exception"},{"line_number":532,"context_line":"        raise exception.ManageExistingInvalidReference("},{"line_number":533,"context_line":"            existing_ref\u003dexisting_ref,"},{"line_number":534,"context_line":"            reason\u003d_(\"Unable to find Purity ref with name\u003d%s\") % ref_vol_name)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    @log_debug_trace"},{"line_number":537,"context_line":"    def manage_existing(self, volume, existing_ref):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_ce261816","line":534,"updated":"2015-08-24 16:31:02.000000000","message":"\".\" at EOL","commit_id":"6501ea7dbc16cb0e277aba987878cf9a3a766371"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"c5023457546edfcbb90ec53c0bfca61db2cd3069","unresolved":false,"context_lines":[{"line_number":585,"context_line":"                if (err.code \u003d\u003d 400 and"},{"line_number":586,"context_line":"                        ERR_MSG_NOT_EXIST in err.text):"},{"line_number":587,"context_line":"                    ctxt.reraise \u003d raise_not_exist"},{"line_number":588,"context_line":"                    LOG.warning(_LW(\"Unable to rename %(old_name)s, error \""},{"line_number":589,"context_line":"                                    \"message: %(error)s\"),"},{"line_number":590,"context_line":"                                {\"old_name\": old_name, \"error\": err.text})"},{"line_number":591,"context_line":"        return new_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_8e4ee0bf","line":588,"updated":"2015-08-24 16:31:02.000000000","message":"Suggest: \"Unable to rename %(old_name)s. Error message: %(error)s.\"","commit_id":"6501ea7dbc16cb0e277aba987878cf9a3a766371"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"6c5dd1e111d4dfeab22f9da9bf0ac8e9ef2345d6","unresolved":false,"context_lines":[{"line_number":636,"context_line":"        self._rename_volume_object(ref_snap_name,"},{"line_number":637,"context_line":"                                   new_snap_name,"},{"line_number":638,"context_line":"                                   raise_not_exist\u003dTrue)"},{"line_number":639,"context_line":"        return None"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"    def manage_existing_snapshot_get_size(self, snapshot, existing_ref):"},{"line_number":642,"context_line":"        \"\"\"Return size of snapshot to be managed by manage_existing."}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_e7e8ee7e","line":639,"updated":"2015-08-27 16:37:43.000000000","message":"\"return None\" is really no need here, you can remove it.","commit_id":"9f3267165ec93f2d40cbd4dfca6d75f4309ddfb4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d12a25df0214f55237c0e2e063c669be183558ff","unresolved":false,"context_lines":[{"line_number":636,"context_line":"        self._rename_volume_object(ref_snap_name,"},{"line_number":637,"context_line":"                                   new_snap_name,"},{"line_number":638,"context_line":"                                   raise_not_exist\u003dTrue)"},{"line_number":639,"context_line":"        return None"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"    def manage_existing_snapshot_get_size(self, snapshot, existing_ref):"},{"line_number":642,"context_line":"        \"\"\"Return size of snapshot to be managed by manage_existing."}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_e4e32832","line":639,"in_reply_to":"da20952f_aa8cf67f","updated":"2015-09-02 03:45:37.000000000","message":"I prefer being explicit.  This is fine.","commit_id":"9f3267165ec93f2d40cbd4dfca6d75f4309ddfb4"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0f991586be7308343590d756703ae157f8e6db3e","unresolved":false,"context_lines":[{"line_number":636,"context_line":"        self._rename_volume_object(ref_snap_name,"},{"line_number":637,"context_line":"                                   new_snap_name,"},{"line_number":638,"context_line":"                                   raise_not_exist\u003dTrue)"},{"line_number":639,"context_line":"        return None"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"    def manage_existing_snapshot_get_size(self, snapshot, existing_ref):"},{"line_number":642,"context_line":"        \"\"\"Return size of snapshot to be managed by manage_existing."}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_c1c59a3d","line":639,"in_reply_to":"da20952f_e4e32832","updated":"2015-09-02 15:14:47.000000000","message":"Agree with Jay and Patrick.","commit_id":"9f3267165ec93f2d40cbd4dfca6d75f4309ddfb4"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"056ede54bd724d968f30b47bf871034885aa777a","unresolved":false,"context_lines":[{"line_number":636,"context_line":"        self._rename_volume_object(ref_snap_name,"},{"line_number":637,"context_line":"                                   new_snap_name,"},{"line_number":638,"context_line":"                                   raise_not_exist\u003dTrue)"},{"line_number":639,"context_line":"        return None"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"    def manage_existing_snapshot_get_size(self, snapshot, existing_ref):"},{"line_number":642,"context_line":"        \"\"\"Return size of snapshot to be managed by manage_existing."}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_aa8cf67f","line":639,"in_reply_to":"da20952f_e7e8ee7e","updated":"2015-08-27 18:20:59.000000000","message":"While not technically required by python I prefer to explicitly have it since the method is expected to return a model update. We intentionally are not returning one. Doing it this way, IMO, adds to code readability.","commit_id":"9f3267165ec93f2d40cbd4dfca6d75f4309ddfb4"}]}