)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4697693c78c750208abe16960c12bcd377538371","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the CG Snapshot is deleted. This is wrong. This is because the query"},{"line_number":11,"context_line":"to find CG who are parents of CG Snapshot didn\u0027t filter out the"},{"line_number":12,"context_line":"CG uuid and as a result, it is not possible to delete any CG if"},{"line_number":13,"context_line":"there are any CG Snanpshot existing."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixed the problem by fixing the function in db API"},{"line_number":16,"context_line":"that finds all CGs that have CG Snapshot depending on them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_d13df18e","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":26},"updated":"2015-08-26 13:17:59.000000000","message":"nit: s/CG Snanpshot existing/existing CG Snapshot","commit_id":"79c419827b9aeeb8c9595db903e60279e3923c93"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ea4a2f9ff22d762fec6391a31e35382c605c2244","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the CG Snapshot is deleted. This is wrong. This is because the query"},{"line_number":11,"context_line":"to find CG who are parents of CG Snapshot didn\u0027t filter out the"},{"line_number":12,"context_line":"CG uuid and as a result, it is not possible to delete any CG if"},{"line_number":13,"context_line":"there are any CG Snanpshot existing."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixed the problem by fixing the function in db API"},{"line_number":16,"context_line":"that finds all CGs that have CG Snapshot depending on them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_1e5be488","line":13,"in_reply_to":"fa1b9901_d13df18e","updated":"2015-08-27 20:03:19.000000000","message":"Done","commit_id":"79c419827b9aeeb8c9595db903e60279e3923c93"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4697693c78c750208abe16960c12bcd377538371","unresolved":false,"context_lines":[{"line_number":12,"context_line":"CG uuid and as a result, it is not possible to delete any CG if"},{"line_number":13,"context_line":"there are any CG Snanpshot existing."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixed the problem by fixing the function in db API"},{"line_number":16,"context_line":"that finds all CGs that have CG Snapshot depending on them."},{"line_number":17,"context_line":"* CGs with any CG Snapshot depending on them still cannot be deleted"},{"line_number":18,"context_line":"  until the CG Snapshot is deleted first."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_914c5943","line":15,"updated":"2015-08-26 13:17:59.000000000","message":"nit: s/fixed/fixes","commit_id":"79c419827b9aeeb8c9595db903e60279e3923c93"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ea4a2f9ff22d762fec6391a31e35382c605c2244","unresolved":false,"context_lines":[{"line_number":12,"context_line":"CG uuid and as a result, it is not possible to delete any CG if"},{"line_number":13,"context_line":"there are any CG Snanpshot existing."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixed the problem by fixing the function in db API"},{"line_number":16,"context_line":"that finds all CGs that have CG Snapshot depending on them."},{"line_number":17,"context_line":"* CGs with any CG Snapshot depending on them still cannot be deleted"},{"line_number":18,"context_line":"  until the CG Snapshot is deleted first."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_de556c50","line":15,"in_reply_to":"fa1b9901_914c5943","updated":"2015-08-27 20:03:19.000000000","message":"Done","commit_id":"79c419827b9aeeb8c9595db903e60279e3923c93"}],"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"2a3d325b084f9f5376678fa115510cc53e12bb39","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"                                           \u0027consistencygroup_id\u0027: \u0027g2\u0027})"},{"line_number":1225,"context_line":"        tests \u003d ["},{"line_number":1226,"context_line":"            ({\u0027consistencygroup_id\u0027: \u0027g1\u0027}, [cgsnapshot1, cgsnapshot2]),"},{"line_number":1227,"context_line":"            ({\u0027id\u0027: 3}, []),"},{"line_number":1228,"context_line":"            ({\u0027fake_key\u0027: \u0027fake\u0027}, [])"},{"line_number":1229,"context_line":"        ]"},{"line_number":1230,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_eac1b32f","line":1227,"updated":"2015-08-18 00:15:42.000000000","message":"is cgsnapshot3 supposed to be here?","commit_id":"68efd31527d92ae129535db0a3c6b08b2b6a8e62"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"4f5096e6b24b008738f9e3966df4938b7b93c7fb","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"                                           \u0027consistencygroup_id\u0027: \u0027g2\u0027})"},{"line_number":1225,"context_line":"        tests \u003d ["},{"line_number":1226,"context_line":"            ({\u0027consistencygroup_id\u0027: \u0027g1\u0027}, [cgsnapshot1, cgsnapshot2]),"},{"line_number":1227,"context_line":"            ({\u0027id\u0027: 3}, []),"},{"line_number":1228,"context_line":"            ({\u0027fake_key\u0027: \u0027fake\u0027}, [])"},{"line_number":1229,"context_line":"        ]"},{"line_number":1230,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_b0656c46","line":1227,"in_reply_to":"fa1b9901_507c1072","updated":"2015-08-18 01:34:50.000000000","message":"Ah, makes sense now. Yeah I see you are asserting there are only 2 cgsnapshots that are returned.","commit_id":"68efd31527d92ae129535db0a3c6b08b2b6a8e62"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"cb5d0aad7fc8630742d147cce6cf90b661357406","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"                                           \u0027consistencygroup_id\u0027: \u0027g2\u0027})"},{"line_number":1225,"context_line":"        tests \u003d ["},{"line_number":1226,"context_line":"            ({\u0027consistencygroup_id\u0027: \u0027g1\u0027}, [cgsnapshot1, cgsnapshot2]),"},{"line_number":1227,"context_line":"            ({\u0027id\u0027: 3}, []),"},{"line_number":1228,"context_line":"            ({\u0027fake_key\u0027: \u0027fake\u0027}, [])"},{"line_number":1229,"context_line":"        ]"},{"line_number":1230,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_507c1072","line":1227,"in_reply_to":"fa1b9901_eac1b32f","updated":"2015-08-18 01:17:53.000000000","message":"Yes, this is a filter in addition to consistencygroup_id.  Just to confirm that cgsnapshot3 won\u0027t be in the results because its consistency group_id is not \u0027g1\u0027.  That\u0027s why we have an empty [] as result.\n\nIf you look at the test above this one for test_cgsnapshot_get_all_by_filter, this filter will result in [cgsnapshot3] above.","commit_id":"68efd31527d92ae129535db0a3c6b08b2b6a8e62"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4697693c78c750208abe16960c12bcd377538371","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"        tests \u003d ["},{"line_number":1226,"context_line":"            ({\u0027consistencygroup_id\u0027: \u0027g1\u0027}, [cgsnapshot1, cgsnapshot2]),"},{"line_number":1227,"context_line":"            ({\u0027id\u0027: 3}, []),"},{"line_number":1228,"context_line":"            ({\u0027fake_key\u0027: \u0027fake\u0027}, [])"},{"line_number":1229,"context_line":"        ]"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        cgsnapshots \u003d db.cgsnapshot_get_all_by_group(self.ctxt, \u0027g1\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_7143c5af","line":1228,"updated":"2015-08-26 13:17:59.000000000","message":"nit: Maybe add ({\u0027consistencygroup_id\u0027: \u0027g2\u0027}, []),","commit_id":"79c419827b9aeeb8c9595db903e60279e3923c93"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ea4a2f9ff22d762fec6391a31e35382c605c2244","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"        tests \u003d ["},{"line_number":1226,"context_line":"            ({\u0027consistencygroup_id\u0027: \u0027g1\u0027}, [cgsnapshot1, cgsnapshot2]),"},{"line_number":1227,"context_line":"            ({\u0027id\u0027: 3}, []),"},{"line_number":1228,"context_line":"            ({\u0027fake_key\u0027: \u0027fake\u0027}, [])"},{"line_number":1229,"context_line":"        ]"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        cgsnapshots \u003d db.cgsnapshot_get_all_by_group(self.ctxt, \u0027g1\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_3e458816","line":1228,"in_reply_to":"fa1b9901_7143c5af","updated":"2015-08-27 20:03:19.000000000","message":"Done","commit_id":"79c419827b9aeeb8c9595db903e60279e3923c93"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4697693c78c750208abe16960c12bcd377538371","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"            ({\u0027fake_key\u0027: \u0027fake\u0027}, [])"},{"line_number":1229,"context_line":"        ]"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        cgsnapshots \u003d db.cgsnapshot_get_all_by_group(self.ctxt, \u0027g1\u0027)"},{"line_number":1232,"context_line":"        self.assertEqual(2, len(cgsnapshots))"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        for filters, expected in tests:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_11612939","line":1231,"updated":"2015-08-26 13:17:59.000000000","message":"-1: If we add (None, [cgsnapshot1, cgsnapshot2]) to tests we don\u0027t need lines 1231 and 1232","commit_id":"79c419827b9aeeb8c9595db903e60279e3923c93"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ea4a2f9ff22d762fec6391a31e35382c605c2244","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"            ({\u0027fake_key\u0027: \u0027fake\u0027}, [])"},{"line_number":1229,"context_line":"        ]"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"        cgsnapshots \u003d db.cgsnapshot_get_all_by_group(self.ctxt, \u0027g1\u0027)"},{"line_number":1232,"context_line":"        self.assertEqual(2, len(cgsnapshots))"},{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"        for filters, expected in tests:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_fe47101b","line":1231,"in_reply_to":"fa1b9901_11612939","updated":"2015-08-27 20:03:19.000000000","message":"Done","commit_id":"79c419827b9aeeb8c9595db903e60279e3923c93"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4697693c78c750208abe16960c12bcd377538371","unresolved":false,"context_lines":[{"line_number":1236,"context_line":"                                            db.cgsnapshot_get_all_by_group("},{"line_number":1237,"context_line":"                                                self.ctxt,"},{"line_number":1238,"context_line":"                                                \u0027g1\u0027,"},{"line_number":1239,"context_line":"                                                filters))"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    def test_cgsnapshot_get_all_by_project(self):"},{"line_number":1242,"context_line":"        cgsnapshot1 \u003d db.cgsnapshot_create(self.ctxt,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_7148a5b3","line":1239,"updated":"2015-08-26 13:17:59.000000000","message":"nit: We should do DB cleanup after each test","commit_id":"79c419827b9aeeb8c9595db903e60279e3923c93"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ea4a2f9ff22d762fec6391a31e35382c605c2244","unresolved":false,"context_lines":[{"line_number":1236,"context_line":"                                            db.cgsnapshot_get_all_by_group("},{"line_number":1237,"context_line":"                                                self.ctxt,"},{"line_number":1238,"context_line":"                                                \u0027g1\u0027,"},{"line_number":1239,"context_line":"                                                filters))"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    def test_cgsnapshot_get_all_by_project(self):"},{"line_number":1242,"context_line":"        cgsnapshot1 \u003d db.cgsnapshot_create(self.ctxt,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_be5198da","line":1239,"in_reply_to":"fa1b9901_7148a5b3","updated":"2015-08-27 20:03:19.000000000","message":"Done","commit_id":"79c419827b9aeeb8c9595db903e60279e3923c93"}]}