)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2bea6b2a740b4b76e7b378364967a3736d22b8ce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix the virtual port support in VNX driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNX support virtal port on each pythical iSCSI port. Fix the VNX"},{"line_number":10,"context_line":"driver to support the virtal port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11994dd5a0c8da74fcf15668f49796a45719b5e4"},{"line_number":13,"context_line":"Closes-Bug: #1485484"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_45efd7e8","line":10,"updated":"2015-08-20 15:17:04.000000000","message":"virtal -\u003e virtual  (in two places). Also, I think it would be good to add to the commit message to explain more about the problem and expand into how you addressed it.","commit_id":"33a86b00931d550709e75c3c54281c3f64073663"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"778bfbef2f99ae9460808bb09719f28d237a282f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix the virtual port support in VNX driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNX support virtal port on each pythical iSCSI port. Fix the VNX"},{"line_number":10,"context_line":"driver to support the virtal port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11994dd5a0c8da74fcf15668f49796a45719b5e4"},{"line_number":13,"context_line":"Closes-Bug: #1485484"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_5df556ea","line":10,"in_reply_to":"fa1b9901_45efd7e8","updated":"2015-08-21 02:44:53.000000000","message":"Done","commit_id":"33a86b00931d550709e75c3c54281c3f64073663"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"33a6c16fec891879a0a5d104262f9ba7f3fb31f0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the virtual port support in VNX driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNX support virtual port on each pythical iSCSI port. The"},{"line_number":10,"context_line":"driver used some incorrect command which cannot get the virtual"},{"line_number":11,"context_line":"port id information, so that the driver cannot tell whether the"},{"line_number":12,"context_line":"regeistered port is a virtaal port or not. This change fixed the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_7c20f1f7","line":9,"updated":"2015-08-24 14:17:26.000000000","message":"\"pythical\" -\u003e physical","commit_id":"a6cf57d868d378f2e7778ad49dabafd54bdec9a3"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"52f952fd7398c5bb800fc542404e6eee10ed4719","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the virtual port support in VNX driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNX support virtual port on each pythical iSCSI port. The"},{"line_number":10,"context_line":"driver used some incorrect command which cannot get the virtual"},{"line_number":11,"context_line":"port id information, so that the driver cannot tell whether the"},{"line_number":12,"context_line":"regeistered port is a virtaal port or not. This change fixed the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_180441be","line":9,"in_reply_to":"fa1b9901_7c20f1f7","updated":"2015-08-25 03:23:15.000000000","message":"Done","commit_id":"a6cf57d868d378f2e7778ad49dabafd54bdec9a3"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"33a6c16fec891879a0a5d104262f9ba7f3fb31f0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNX support virtual port on each pythical iSCSI port. The"},{"line_number":10,"context_line":"driver used some incorrect command which cannot get the virtual"},{"line_number":11,"context_line":"port id information, so that the driver cannot tell whether the"},{"line_number":12,"context_line":"regeistered port is a virtaal port or not. This change fixed the"},{"line_number":13,"context_line":"driver to use correct command and handle the virtual port id"},{"line_number":14,"context_line":"correctly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_1c3e95da","line":11,"updated":"2015-08-24 14:17:26.000000000","message":"Suggestion: Change \"port id information, so that the driver cannot tell ...\" to \"port id information. This causes the driver to not be able to tell ...\".","commit_id":"a6cf57d868d378f2e7778ad49dabafd54bdec9a3"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"52f952fd7398c5bb800fc542404e6eee10ed4719","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VNX support virtual port on each pythical iSCSI port. The"},{"line_number":10,"context_line":"driver used some incorrect command which cannot get the virtual"},{"line_number":11,"context_line":"port id information, so that the driver cannot tell whether the"},{"line_number":12,"context_line":"regeistered port is a virtaal port or not. This change fixed the"},{"line_number":13,"context_line":"driver to use correct command and handle the virtual port id"},{"line_number":14,"context_line":"correctly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_38ffc5ab","line":11,"in_reply_to":"fa1b9901_1c3e95da","updated":"2015-08-25 03:23:15.000000000","message":"Done","commit_id":"a6cf57d868d378f2e7778ad49dabafd54bdec9a3"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"33a6c16fec891879a0a5d104262f9ba7f3fb31f0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"VNX support virtual port on each pythical iSCSI port. The"},{"line_number":10,"context_line":"driver used some incorrect command which cannot get the virtual"},{"line_number":11,"context_line":"port id information, so that the driver cannot tell whether the"},{"line_number":12,"context_line":"regeistered port is a virtaal port or not. This change fixed the"},{"line_number":13,"context_line":"driver to use correct command and handle the virtual port id"},{"line_number":14,"context_line":"correctly."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_fcd081cb","line":12,"updated":"2015-08-24 14:17:26.000000000","message":"\"virtaal\" -\u003e \"virtual\"\n\nMaybe change \"fixed\" -\u003e \"fixes\".","commit_id":"a6cf57d868d378f2e7778ad49dabafd54bdec9a3"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"52f952fd7398c5bb800fc542404e6eee10ed4719","unresolved":false,"context_lines":[{"line_number":9,"context_line":"VNX support virtual port on each pythical iSCSI port. The"},{"line_number":10,"context_line":"driver used some incorrect command which cannot get the virtual"},{"line_number":11,"context_line":"port id information, so that the driver cannot tell whether the"},{"line_number":12,"context_line":"regeistered port is a virtaal port or not. This change fixed the"},{"line_number":13,"context_line":"driver to use correct command and handle the virtual port id"},{"line_number":14,"context_line":"correctly."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_b8299539","line":12,"in_reply_to":"fa1b9901_fcd081cb","updated":"2015-08-25 03:23:15.000000000","message":"Done","commit_id":"a6cf57d868d378f2e7778ad49dabafd54bdec9a3"}],"cinder/tests/unit/test_emc_vnxdirect.py":[{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"513506bff2714804ee5dc6a0672c739612bec1da","unresolved":false,"context_lines":[{"line_number":4533,"context_line":"        spport_set \u003d self.driver.cli._client.get_registered_spport_set("},{"line_number":4534,"context_line":"            \u0027iqn.1993-08.org.debian:01:222\u0027, \u0027fakehost\u0027,"},{"line_number":4535,"context_line":"            self.testData.STORAGE_GROUP_HAS_MAP_ISCSI(\u0027fakehost\u0027)[0])"},{"line_number":4536,"context_line":"        self.assertTrue({(\u0027A\u0027, 2, 0), (\u0027A\u0027, 0, 0), (\u0027B\u0027, 2, 0)} \u003d\u003d spport_set)"},{"line_number":4537,"context_line":""},{"line_number":4538,"context_line":"    def test_validate_iscsi_port(self):"},{"line_number":4539,"context_line":"        self.driverSetup()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_f72197b5","line":4536,"updated":"2015-09-02 07:31:53.000000000","message":"Here should use self.assertEqual().","commit_id":"178ef466aa4d4ca09a6a6a4289d23c2c211eebd0"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"80053880337b4480b71ffec93934c542d79d9a4f","unresolved":false,"context_lines":[{"line_number":4533,"context_line":"        spport_set \u003d self.driver.cli._client.get_registered_spport_set("},{"line_number":4534,"context_line":"            \u0027iqn.1993-08.org.debian:01:222\u0027, \u0027fakehost\u0027,"},{"line_number":4535,"context_line":"            self.testData.STORAGE_GROUP_HAS_MAP_ISCSI(\u0027fakehost\u0027)[0])"},{"line_number":4536,"context_line":"        self.assertTrue({(\u0027A\u0027, 2, 0), (\u0027A\u0027, 0, 0), (\u0027B\u0027, 2, 0)} \u003d\u003d spport_set)"},{"line_number":4537,"context_line":""},{"line_number":4538,"context_line":"    def test_validate_iscsi_port(self):"},{"line_number":4539,"context_line":"        self.driverSetup()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_adac2c8d","line":4536,"in_reply_to":"da20952f_f72197b5","updated":"2015-09-02 08:10:50.000000000","message":"Good catch! Done.","commit_id":"178ef466aa4d4ca09a6a6a4289d23c2c211eebd0"}],"cinder/volume/drivers/emc/emc_vnx_cli.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2bea6b2a740b4b76e7b378364967a3736d22b8ce","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"                % initiator_iqn, sg_raw_out, flags\u003dre.IGNORECASE):"},{"line_number":1568,"context_line":"            spport_set.add((m_spport.group(1), int(m_spport.group(2)),"},{"line_number":1569,"context_line":"                           int(m_spport.group(3))))"},{"line_number":1570,"context_line":"        LOG.debug(\u0027See path %(path)s in %(sg)s\u0027,"},{"line_number":1571,"context_line":"                  {\u0027path\u0027: spport_set,"},{"line_number":1572,"context_line":"                   \u0027sg\u0027: sgname})"},{"line_number":1573,"context_line":"        return spport_set"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_456a7782","line":1570,"updated":"2015-08-20 15:17:04.000000000","message":"\".\" at EOL","commit_id":"33a86b00931d550709e75c3c54281c3f64073663"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"778bfbef2f99ae9460808bb09719f28d237a282f","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"                % initiator_iqn, sg_raw_out, flags\u003dre.IGNORECASE):"},{"line_number":1568,"context_line":"            spport_set.add((m_spport.group(1), int(m_spport.group(2)),"},{"line_number":1569,"context_line":"                           int(m_spport.group(3))))"},{"line_number":1570,"context_line":"        LOG.debug(\u0027See path %(path)s in %(sg)s\u0027,"},{"line_number":1571,"context_line":"                  {\u0027path\u0027: spport_set,"},{"line_number":1572,"context_line":"                   \u0027sg\u0027: sgname})"},{"line_number":1573,"context_line":"        return spport_set"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_7dd37a60","line":1570,"in_reply_to":"fa1b9901_456a7782","updated":"2015-08-21 02:44:53.000000000","message":"Done","commit_id":"33a86b00931d550709e75c3c54281c3f64073663"}]}