)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5dd2d344e12bec43879d5d49861d67662efec71c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gorka Eguileor \u003cgeguileo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-18 12:57:52 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix backup list all_tenants\u003d0 issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a user with admin role lists backups specifying all_tenants\u003d0 in"},{"line_number":10,"context_line":"the request, it will not behave as expected, it will return backups for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa1b9901_3a2ee8fa","line":7,"updated":"2015-08-24 20:09:05.000000000","message":"\"Fix backup list all_tenants\u003d0 not filtering for admin role\"","commit_id":"728ec144f2a25f101c813cf36c8da84211032b29"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dce90def17e5f093a797fde12c0ea3b51cfb02f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gorka Eguileor \u003cgeguileo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-18 12:57:52 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix backup list all_tenants\u003d0 issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a user with admin role lists backups specifying all_tenants\u003d0 in"},{"line_number":10,"context_line":"the request, it will not behave as expected, it will return backups for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa1b9901_a1bdced8","line":7,"in_reply_to":"fa1b9901_3a2ee8fa","updated":"2015-08-25 10:58:03.000000000","message":"That\u0027s too long, but I\u0027ll do what I can","commit_id":"728ec144f2a25f101c813cf36c8da84211032b29"}],"cinder/tests/unit/test_backup.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9a7aa94780f83b8077d05dc68918cec3d9d354d4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from oslo_utils import importutils"},{"line_number":23,"context_line":"from oslo_utils import timeutils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinder.backup import api"},{"line_number":26,"context_line":"from cinder.backup import manager"},{"line_number":27,"context_line":"from cinder import context"},{"line_number":28,"context_line":"from cinder import db"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_1a8f6424","line":25,"updated":"2015-08-24 20:06:50.000000000","message":"Probably should use \"as backup_api\" here.","commit_id":"728ec144f2a25f101c813cf36c8da84211032b29"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dce90def17e5f093a797fde12c0ea3b51cfb02f1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from oslo_utils import importutils"},{"line_number":23,"context_line":"from oslo_utils import timeutils"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinder.backup import api"},{"line_number":26,"context_line":"from cinder.backup import manager"},{"line_number":27,"context_line":"from cinder import context"},{"line_number":28,"context_line":"from cinder import db"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_060db03d","line":25,"in_reply_to":"fa1b9901_1a8f6424","updated":"2015-08-25 10:58:03.000000000","message":"If it were for some other API I would have done it, but we are testing backups and it\u0027s the backup api, so it\u0027s implicit.","commit_id":"728ec144f2a25f101c813cf36c8da84211032b29"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9a7aa94780f83b8077d05dc68918cec3d9d354d4","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                                              volume_id\u003dvol_id)"},{"line_number":550,"context_line":"        self.backup_mgr.delete_backup(self.ctxt, backup)"},{"line_number":551,"context_line":"        self.assertEqual(2, notify.call_count)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def test_get_all_wrong_all_tenants_value(self):"},{"line_number":554,"context_line":"        self.assertRaises(exception.InvalidParameterValue,"},{"line_number":555,"context_line":"                          self.api.get_all, self.ctxt, {\u0027all_tenants\u0027: \u0027bad\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_daafac7b","line":552,"updated":"2015-08-24 20:06:50.000000000","message":"Maybe split these into a BackupAPITestCase class?","commit_id":"728ec144f2a25f101c813cf36c8da84211032b29"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dce90def17e5f093a797fde12c0ea3b51cfb02f1","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                                              volume_id\u003dvol_id)"},{"line_number":550,"context_line":"        self.backup_mgr.delete_backup(self.ctxt, backup)"},{"line_number":551,"context_line":"        self.assertEqual(2, notify.call_count)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def test_get_all_wrong_all_tenants_value(self):"},{"line_number":554,"context_line":"        self.assertRaises(exception.InvalidParameterValue,"},{"line_number":555,"context_line":"                          self.api.get_all, self.ctxt, {\u0027all_tenants\u0027: \u0027bad\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_c62fb89f","line":552,"in_reply_to":"fa1b9901_daafac7b","updated":"2015-08-25 10:58:03.000000000","message":"Good idea","commit_id":"728ec144f2a25f101c813cf36c8da84211032b29"}]}