)]}'
{"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9e36e50738b4e1d62692734ff8ea3453731a2c31","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"                           controller or not."},{"line_number":1282,"context_line":"            :return: Nothing"},{"line_number":1283,"context_line":"            \"\"\""},{"line_number":1284,"context_line":"            LOG.debug(lun, iqn, address, port, readonly, status, active)"},{"line_number":1285,"context_line":"            portals.append(address + \u0027:\u0027 +"},{"line_number":1286,"context_line":"                           six.text_type(port))"},{"line_number":1287,"context_line":"            iqns.append(iqn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_8508f62e","line":1284,"updated":"2015-08-18 21:51:15.000000000","message":"These need to be formatted into a string.","commit_id":"42f701151374ad3ae1f08ac8afa0e259107d11d1"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"797f75173618b4421e1b62cc38f522aa11afc8fe","unresolved":false,"context_lines":[{"line_number":1281,"context_line":"                           controller or not."},{"line_number":1282,"context_line":"            :return: Nothing"},{"line_number":1283,"context_line":"            \"\"\""},{"line_number":1284,"context_line":"            LOG.debug(lun, iqn, address, port, readonly, status, active)"},{"line_number":1285,"context_line":"            portals.append(address + \u0027:\u0027 +"},{"line_number":1286,"context_line":"                           six.text_type(port))"},{"line_number":1287,"context_line":"            iqns.append(iqn)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_b792119e","line":1284,"in_reply_to":"fa1b9901_8508f62e","updated":"2015-08-18 21:56:28.000000000","message":"Thought I\u0027d removed that.","commit_id":"42f701151374ad3ae1f08ac8afa0e259107d11d1"}],"cinder/volume/drivers/dell/dell_storagecenter_iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9e36e50738b4e1d62692734ff8ea3453731a2c31","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            # If there is a data structure issue then detail the exception"},{"line_number":136,"context_line":"            # and bail with a Backend Exception."},{"line_number":137,"context_line":"            except Exception as error:"},{"line_number":138,"context_line":"                LOG.error(error)"},{"line_number":139,"context_line":"                raise exception.VolumeBackendAPIException(error)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # We get here because our mapping is none or we have no valid iqn to"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_d7578500","line":138,"updated":"2015-08-18 21:51:15.000000000","message":"It would be better to format a message and log that rather than passing the exception in to the logger.","commit_id":"42f701151374ad3ae1f08ac8afa0e259107d11d1"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"797f75173618b4421e1b62cc38f522aa11afc8fe","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            # If there is a data structure issue then detail the exception"},{"line_number":136,"context_line":"            # and bail with a Backend Exception."},{"line_number":137,"context_line":"            except Exception as error:"},{"line_number":138,"context_line":"                LOG.error(error)"},{"line_number":139,"context_line":"                raise exception.VolumeBackendAPIException(error)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # We get here because our mapping is none or we have no valid iqn to"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_d7ca25a1","line":138,"in_reply_to":"fa1b9901_d7578500","updated":"2015-08-18 21:56:28.000000000","message":"Will the logger choke on this?  It should be a formatted exception message.  2.7 this could be error.message but 3.4 doesn\u0027t like that...","commit_id":"42f701151374ad3ae1f08ac8afa0e259107d11d1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"de608f0b11102b27153a5abed58894779cd81ac2","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            # If there is a data structure issue then detail the exception"},{"line_number":136,"context_line":"            # and bail with a Backend Exception."},{"line_number":137,"context_line":"            except Exception as error:"},{"line_number":138,"context_line":"                LOG.error(error)"},{"line_number":139,"context_line":"                raise exception.VolumeBackendAPIException(error)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # We get here because our mapping is none or we have no valid iqn to"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_d7dd4543","line":138,"in_reply_to":"fa1b9901_d7ca25a1","updated":"2015-08-18 22:01:39.000000000","message":"In this case it does convert it to its string representation.","commit_id":"42f701151374ad3ae1f08ac8afa0e259107d11d1"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"18d613092622b88fbe96de4d5fef38fae17260b8","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            # If there is a data structure issue then detail the exception"},{"line_number":136,"context_line":"            # and bail with a Backend Exception."},{"line_number":137,"context_line":"            except Exception as error:"},{"line_number":138,"context_line":"                LOG.error(error)"},{"line_number":139,"context_line":"                raise exception.VolumeBackendAPIException(error)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # We get here because our mapping is none or we have no valid iqn to"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_4d43d942","line":138,"updated":"2015-08-19 05:39:44.000000000","message":"I think the error here is different from the original one, which is like\nFailed to initialize connection\n\u0027%(initiator)s %(vol)s\u0027)...\n\nDo you intend to change it to this style?","commit_id":"42ec8c25b7a101ecf9ee0350ca8dda087ee7e85b"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"7d4f450fc8817a14d4bdc1241459c5cdbee068a3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            # If there is a data structure issue then detail the exception"},{"line_number":136,"context_line":"            # and bail with a Backend Exception."},{"line_number":137,"context_line":"            except Exception as error:"},{"line_number":138,"context_line":"                LOG.error(error)"},{"line_number":139,"context_line":"                raise exception.VolumeBackendAPIException(error)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # We get here because our mapping is none or we have no valid iqn to"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_796523b3","line":138,"in_reply_to":"fa1b9901_4d43d942","updated":"2015-08-19 16:33:24.000000000","message":"Yeah.  Actually I\u0027ll change the one above.  We already log the initiator_name and volume_name when we enter the function.","commit_id":"42ec8c25b7a101ecf9ee0350ca8dda087ee7e85b"}]}