)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2a4684e124063dd27c3e5d0e811c7a667f976737","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If a volume is already in a CG, currently it can still be added to"},{"line_number":10,"context_line":"another CG without any warning. We should add a check to see if the"},{"line_number":11,"context_line":"volume is already in a CG and prevent it from being added to another"},{"line_number":12,"context_line":"CG if it is in a CG already. It has to be removed from the previous"},{"line_number":13,"context_line":"CG in order to be added to a new one."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6ec92cbf4ce60e7afbfa5a57edef18ddba554a74"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_43a7c1a9","line":12,"updated":"2015-08-20 20:18:27.000000000","message":"Suggest: \"We should add a check to see if the volume is already in a CG and prevent it from being added to another if that check returns True.\"","commit_id":"5d451d459142426cd08f6b9139c697149c538a5b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bab9162ab3f32c1383d5fb72228855b43805002a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If a volume is already in a CG, currently it can still be added to"},{"line_number":10,"context_line":"another CG without any warning. We should add a check to see if the"},{"line_number":11,"context_line":"volume is already in a CG and prevent it from being added to another"},{"line_number":12,"context_line":"CG if it is in a CG already. It has to be removed from the previous"},{"line_number":13,"context_line":"CG in order to be added to a new one."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6ec92cbf4ce60e7afbfa5a57edef18ddba554a74"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_81a27999","line":12,"in_reply_to":"fa1b9901_43a7c1a9","updated":"2015-08-21 18:43:51.000000000","message":"Done","commit_id":"5d451d459142426cd08f6b9139c697149c538a5b"}],"cinder/consistencygroup/api.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"56cb2c3b51e96378e6245b94052bd7dca2e5572e","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                       {\u0027volume_id\u0027: add_vol,"},{"line_number":612,"context_line":"                        \u0027group_id\u0027: group.id})"},{"line_number":613,"context_line":"                raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":614,"context_line":"            group_id2 \u003d add_vol_ref.get(\u0027consistencygroup_id\u0027, None)"},{"line_number":615,"context_line":"            if group_id2:"},{"line_number":616,"context_line":"                # If volume to be added is already in the group to be updated,"},{"line_number":617,"context_line":"                # it should have been removed from the add_volumes_list in the"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_fe8f8e72","line":614,"updated":"2015-08-20 20:39:24.000000000","message":"\"group_id2\" is kind of a confusing name for this, since \"2\" is the original CG.","commit_id":"5d451d459142426cd08f6b9139c697149c538a5b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bab9162ab3f32c1383d5fb72228855b43805002a","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                       {\u0027volume_id\u0027: add_vol,"},{"line_number":612,"context_line":"                        \u0027group_id\u0027: group.id})"},{"line_number":613,"context_line":"                raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":614,"context_line":"            group_id2 \u003d add_vol_ref.get(\u0027consistencygroup_id\u0027, None)"},{"line_number":615,"context_line":"            if group_id2:"},{"line_number":616,"context_line":"                # If volume to be added is already in the group to be updated,"},{"line_number":617,"context_line":"                # it should have been removed from the add_volumes_list in the"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_018e6927","line":614,"in_reply_to":"fa1b9901_fe8f8e72","updated":"2015-08-21 18:43:51.000000000","message":"Done","commit_id":"5d451d459142426cd08f6b9139c697149c538a5b"}]}