)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"7e792e0bbdcb5d0f02d9e69ac9b1637725b5425f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Jinnan \u003czhang.jinnan@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-21 11:18:25 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Solve the volume error_deleting state when unmange the volume in gluster."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8fb50f01f209c37e48933c8fa92f54a265322c30"},{"line_number":10,"context_line":"Related-Bug: #1487329"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_c2de56dc","line":7,"updated":"2015-08-21 07:46:10.000000000","message":"Message title should be less than 80 characters.","commit_id":"6bdf200398b91d8c49a33e70fd9245ef9ff01275"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"9407e8013eb9932cf5aa452c30ef1c188fca6179","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Jinnan \u003czhang.jinnan@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-21 08:07:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"volume error_deleting state when unmange"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume error_deleting state when unmange the volume"},{"line_number":10,"context_line":"in gluster. Add unmange function in GlusterfsDriver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_6d708472","line":7,"updated":"2015-08-21 15:39:07.000000000","message":"unmange -\u003e unmanage\n\nCapitalize \"volume\".\n\nAlso this line is a little confusing to me. Do you mean:\n\"Volume enters error_deleting state when unmanage\"?","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"9407e8013eb9932cf5aa452c30ef1c188fca6179","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"volume error_deleting state when unmange"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume error_deleting state when unmange the volume"},{"line_number":10,"context_line":"in gluster. Add unmange function in GlusterfsDriver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-authored-by: wanghao \u003cwanghao749@huawei.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_ad9a1c60","line":9,"updated":"2015-08-21 15:39:07.000000000","message":"Capitalize \"volume\" at beginning of line.","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"9407e8013eb9932cf5aa452c30ef1c188fca6179","unresolved":false,"context_lines":[{"line_number":7,"context_line":"volume error_deleting state when unmange"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume error_deleting state when unmange the volume"},{"line_number":10,"context_line":"in gluster. Add unmange function in GlusterfsDriver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-authored-by: wanghao \u003cwanghao749@huawei.com\u003e"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_edbb34c2","line":10,"updated":"2015-08-21 15:39:07.000000000","message":"unmange -\u003e unmanage","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"512032bf165aa3b16bcafa974fb1eb8b0e2f1ead","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Co-authored-by: wanghao \u003cwanghao749@huawei.com\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8fb50f01f209c37e48933c8fa92f54a265322c30"},{"line_number":15,"context_line":"Related-Bug: #1487329"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa1b9901_795cce4a","line":15,"updated":"2015-08-21 14:24:39.000000000","message":"Closes-Bug:","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"80f7cbf88580e368bb8e9b710a9fa1eee6f3b9e3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Co-authored-by: wanghao \u003cwanghao749@huawei.com\u003e"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8fb50f01f209c37e48933c8fa92f54a265322c30"},{"line_number":16,"context_line":"Related-Bug: #1487329"},{"line_number":17,"context_line":"Closes-Bug: #1487329"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa1b9901_fc0c333d","line":16,"updated":"2015-08-22 00:32:37.000000000","message":"Could remove Related-Bug since you have added Closes-Bug.","commit_id":"6f40786e2db8ce4ee13c6e9e2d69de75f1a7a85b"}],"cinder/volume/drivers/glusterfs.py":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"7e792e0bbdcb5d0f02d9e69ac9b1637725b5425f","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        pass"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    #TODO"},{"line_number":282,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":283,"context_line":"        \"\"\"Manage an existing volume.\"\"\""},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_421b2681","line":281,"updated":"2015-08-21 07:46:10.000000000","message":"With whitespace between # and TODO.  And you need to write your name like this  # TODO(xxx): Add implementation of mange volume.","commit_id":"6bdf200398b91d8c49a33e70fd9245ef9ff01275"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"7e792e0bbdcb5d0f02d9e69ac9b1637725b5425f","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":283,"context_line":"        \"\"\"Manage an existing volume.\"\"\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        msg \u003d _(\"sync_replica not implemented.\")"},{"line_number":286,"context_line":"        raise NotImplementedError(msg)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_bd16e749","line":285,"updated":"2015-08-21 07:46:10.000000000","message":"msg is wrong,  \"mange existing not implemented.\"","commit_id":"6bdf200398b91d8c49a33e70fd9245ef9ff01275"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"7e792e0bbdcb5d0f02d9e69ac9b1637725b5425f","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    def manage_existing_get_size(self, volume, existing_ref):"},{"line_number":291,"context_line":"        \"\"\"Return size of an existing LV for manage_existing.\"\"\""},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        msg \u003d _(\"sync_replica not implemented.\")"},{"line_number":294,"context_line":"        raise NotImplementedError(msg)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    #TODO"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_3d29778a","line":293,"updated":"2015-08-21 07:46:10.000000000","message":"ditto","commit_id":"6bdf200398b91d8c49a33e70fd9245ef9ff01275"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"7e792e0bbdcb5d0f02d9e69ac9b1637725b5425f","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    #TODO"},{"line_number":297,"context_line":"    def unmanage(self, volume):"},{"line_number":298,"context_line":"        \"\"\"Removes\"\"\""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        pass"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_9d5c431a","line":298,"updated":"2015-08-21 07:46:10.000000000","message":"This way is better: \"Unmanage volume, not delete it.\"","commit_id":"6bdf200398b91d8c49a33e70fd9245ef9ff01275"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"5aea8980d23aaaf866942fcf200f9d4c33be9e1b","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        \"\"\"Exports the volume.\"\"\""},{"line_number":273,"context_line":"        pass"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def remove_export(self, ctx, volume):"},{"line_number":277,"context_line":"        \"\"\"Removes an export for a logical volume.\"\"\""},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_286ff3fc","line":275,"updated":"2015-08-21 08:35:37.000000000","message":"Please remove this unnecessary new line.","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"5aea8980d23aaaf866942fcf200f9d4c33be9e1b","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        pass"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    #TODO(Zhang Jinnan): Add implementation of mange volume."},{"line_number":282,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":283,"context_line":"        \"\"\"Manage an existing volume.\"\"\""},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_88807f8c","line":281,"updated":"2015-08-21 08:35:37.000000000","message":"s/mange/manage","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"5aea8980d23aaaf866942fcf200f9d4c33be9e1b","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    #TODO(Zhang Jinnan): Add implementation of mange volume."},{"line_number":282,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":283,"context_line":"        \"\"\"Manage an existing volume.\"\"\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        msg \u003d _(\"mange existing not implemented..\")"},{"line_number":286,"context_line":"        raise NotImplementedError(msg)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_e3ad9ce9","line":284,"updated":"2015-08-21 08:35:37.000000000","message":"Change error message to \"Manage existing volume not implemented.\"\n\nAlso instead of defining msg variable you can directly pass message string to the exception as its only used once.","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"5aea8980d23aaaf866942fcf200f9d4c33be9e1b","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":283,"context_line":"        \"\"\"Manage an existing volume.\"\"\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        msg \u003d _(\"mange existing not implemented..\")"},{"line_number":286,"context_line":"        raise NotImplementedError(msg)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def manage_existing_get_size(self, volume, existing_ref):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_4834a7fa","line":285,"updated":"2015-08-21 08:35:37.000000000","message":"s/mange/manage","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"5aea8980d23aaaf866942fcf200f9d4c33be9e1b","unresolved":false,"context_lines":[{"line_number":288,"context_line":"    def manage_existing_get_size(self, volume, existing_ref):"},{"line_number":289,"context_line":"        \"\"\"Return size of an existing LV for manage_existing.\"\"\""},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        msg \u003d _(\"mange existing get size not implemented..\")"},{"line_number":292,"context_line":"        raise NotImplementedError(msg)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def unmanage(self, volume):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_e8233bbb","line":291,"updated":"2015-08-21 08:35:37.000000000","message":"s/mange/Manage","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"5aea8980d23aaaf866942fcf200f9d4c33be9e1b","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        msg \u003d _(\"mange existing get size not implemented..\")"},{"line_number":292,"context_line":"        raise NotImplementedError(msg)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def unmanage(self, volume):"},{"line_number":295,"context_line":"        \"\"\"unmanage volume, not delete it.\"\"\""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_83e4e0ab","line":294,"updated":"2015-08-21 08:35:37.000000000","message":"How does this method unmanage the volume if we are just calling pass here?","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"},{"author":{"_account_id":8074,"name":"Jin Nan Zhang","username":"zhangjinnan","inactive":true},"change_message_id":"d71b22ca8a7e43a58d3b84a33924e3dd791f5326","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        msg \u003d _(\"mange existing get size not implemented..\")"},{"line_number":292,"context_line":"        raise NotImplementedError(msg)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def unmanage(self, volume):"},{"line_number":295,"context_line":"        \"\"\"unmanage volume, not delete it.\"\"\""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_a39d480c","line":294,"in_reply_to":"fa1b9901_83e4e0ab","updated":"2015-08-21 17:06:44.000000000","message":"I just solve the Bug: #1487329.","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"5aea8980d23aaaf866942fcf200f9d4c33be9e1b","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        raise NotImplementedError(msg)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def unmanage(self, volume):"},{"line_number":295,"context_line":"        \"\"\"unmanage volume, not delete it.\"\"\""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        pass"},{"line_number":298,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_437c88eb","line":295,"updated":"2015-08-21 08:35:37.000000000","message":"Please capitalize the docstring.","commit_id":"b64bfd93608cf3ff0ee4068615cce9cc40c4af79"}]}