)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"1b5255182b1f68d2c51e41b751f827e108b4e0cc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Encode Unicode to UTF-8 for salt and authentication key when computing"},{"line_number":10,"context_line":"the crypt hash."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint https://blueprints.launchpad.net/cinder/+spec/cinder-python3"},{"line_number":13,"context_line":"Change-Id: I19d337cf0d40d91378e1c42061bc51b6009970a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_bddffe38","line":12,"updated":"2015-08-31 00:58:41.000000000","message":"Suggest: \"Implements: blueprint \u003clink\u003e\"","commit_id":"e8e136fc71a4546b78b472b9efa240597c143b16"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"97e5efa570a6634b523f35ec08768eeebe222911","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Encode Unicode to UTF-8 for salt and authentication key when computing"},{"line_number":10,"context_line":"the crypt hash."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint https://blueprints.launchpad.net/cinder/+spec/cinder-python3"},{"line_number":13,"context_line":"Change-Id: I19d337cf0d40d91378e1c42061bc51b6009970a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_0bf01266","line":12,"in_reply_to":"da20952f_303307ad","updated":"2015-08-31 11:16:32.000000000","message":"There si a \u0027partially implements status\u0027 which might be what you\u0027re after. What you have is recognised by the various infra bots, which is the important thing.","commit_id":"e8e136fc71a4546b78b472b9efa240597c143b16"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"2adf32562a628c5f36abedef0cee49a83ef14312","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Encode Unicode to UTF-8 for salt and authentication key when computing"},{"line_number":10,"context_line":"the crypt hash."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint https://blueprints.launchpad.net/cinder/+spec/cinder-python3"},{"line_number":13,"context_line":"Change-Id: I19d337cf0d40d91378e1c42061bc51b6009970a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_303307ad","line":12,"in_reply_to":"da20952f_bddffe38","updated":"2015-08-31 10:38:11.000000000","message":"Why not using the syntax \"Blueprint \u003clink\u003e\"? The OpenStack doc mentions \"Blueprint \u003cname\u003e\". Do you prefer \"Implements: blueprint \u003clink\u003e\" because it\u0027s a link and not a name? The doc:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references\n\nI used \"Blueprint cinder-python3\" in all my Cinder commits before the blueprint status changed to Complete.\n\nI don\u0027t consider the cinder-python3 blueprint as complete, since I\u0027m still writing patches to port more code. But we suggested me to continue to use this blueprint, instead of trying to change the status of the blueprint.","commit_id":"e8e136fc71a4546b78b472b9efa240597c143b16"}],"cinder/transfer/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e3b0738d89c315822b8f380562b096e47aa77cda","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            salt \u003d salt.encode(\u0027utf-8\u0027)"},{"line_number":106,"context_line":"        if not isinstance(auth_key, (six.binary_type, six.text_type)):"},{"line_number":107,"context_line":"            auth_key \u003d str(auth_key)"},{"line_number":108,"context_line":"        if isinstance(auth_key, six.text_type):"},{"line_number":109,"context_line":"            auth_key \u003d auth_key.encode(\u0027utf-8\u0027)"},{"line_number":110,"context_line":"        return hmac.new(salt, auth_key, hashlib.sha1).hexdigest()"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_09d68bc5","line":108,"updated":"2015-09-24 19:13:55.000000000","message":"nit: Since this is the same code for salt and auth_key a method could be used.","commit_id":"d548495e9e1ec2ad995060112308fbf8da79c809"}]}
