)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"3590f19941aef1c95fb13270f5461afa1759c5b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Default value max_limit is initialized before a value is read from"},{"line_number":10,"context_line":"the config file. Default parameter values are always evaluated when"},{"line_number":11,"context_line":"the “def” statement they belong to is executed. SO parameter"},{"line_number":12,"context_line":"osapi_max_limit is always used by default even it\u0027s set in the"},{"line_number":13,"context_line":"configuration file."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa1b9901_b952db33","line":11,"updated":"2015-08-25 15:17:06.000000000","message":"SO -\u003e So","commit_id":"eb1f9a9059b407246376db5e8e3f98b622a80109"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"3590f19941aef1c95fb13270f5461afa1759c5b6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the “def” statement they belong to is executed. SO parameter"},{"line_number":12,"context_line":"osapi_max_limit is always used by default even it\u0027s set in the"},{"line_number":13,"context_line":"configuration file."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1414667d30e98b56c5eb1b09b802bab823b37e2d"},{"line_number":16,"context_line":"Closes-Bug: #1487510"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa1b9901_447072a4","line":14,"updated":"2015-08-25 15:17:06.000000000","message":"We need a docImpact here since it is touching config.","commit_id":"eb1f9a9059b407246376db5e8e3f98b622a80109"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c12c559c8f90864e4834908f1ae3ac98ad5f6910","unresolved":false,"context_lines":[{"line_number":12,"context_line":"osapi_max_limit is always used by default even it\u0027s set in the"},{"line_number":13,"context_line":"configuration file."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"Change-Id: I1414667d30e98b56c5eb1b09b802bab823b37e2d"},{"line_number":17,"context_line":"Closes-Bug: #1487510"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa1b9901_be64f3b8","line":15,"updated":"2015-08-25 19:09:35.000000000","message":"-1: We don\u0027t need DocImpact, you are fixing a bug that the docs already say it works as you are making it work.  So the docs are wrong now, and once we merge this patch they will be right.","commit_id":"b64c7b8a3c0386c375023474a18c8f1822b892cc"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"fd9dd241705d6de695d818a83feb7c507394b5a6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the config file. Default parameter values are always evaluated when"},{"line_number":11,"context_line":"the “def” statement they belong to is executed. So parameter"},{"line_number":12,"context_line":"osapi_max_limit is always used by default even it\u0027s set in the"},{"line_number":13,"context_line":"configuration file."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1414667d30e98b56c5eb1b09b802bab823b37e2d"},{"line_number":16,"context_line":"Closes-Bug: #1487510"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_257e19e5","line":13,"updated":"2015-08-26 18:38:55.000000000","message":"So the default value of \u0027osapi_max_limit\u0027 parameter is always used even if it\u0027s set...\n\nI think your sentence is clearer this way. If you submit another patch please change if you agree.","commit_id":"e894b3dd9285a1fb711aee63eb96be1cfe44375b"}],"cinder/api/common.py":[{"author":{"_account_id":17718,"name":"Lallana","email":"gaozhiqiang2@huawei.com","username":"Lallana"},"change_message_id":"a4dcd1235f651d0e2302f08a65e7a79d6ec5da8c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \"\"\"Return marker, limit, offset tuple from request."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    :param params: `wsgi.Request`\u0027s GET dictionary, possibly containing"},{"line_number":76,"context_line":"                   \u0027marker\u0027,  \u0027limit\u0027, and \u0027offset\u0027 variables. \u0027marker\u0027 is the"},{"line_number":77,"context_line":"                   id of the last element the client has seen, \u0027limit\u0027 is the"},{"line_number":78,"context_line":"                   maximum number of items to return and \u0027offset\u0027 is the number"},{"line_number":79,"context_line":"                   of items to skip from the marker or from the first element."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_ec2cf34b","line":76,"updated":"2015-08-26 03:42:05.000000000","message":"Should have only 1 space between sentences","commit_id":"e894b3dd9285a1fb711aee63eb96be1cfe44375b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7f4020d08683f13701b25dae1a25bbf3d3d295ed","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \"\"\"Return marker, limit, offset tuple from request."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    :param params: `wsgi.Request`\u0027s GET dictionary, possibly containing"},{"line_number":76,"context_line":"                   \u0027marker\u0027,  \u0027limit\u0027, and \u0027offset\u0027 variables. \u0027marker\u0027 is the"},{"line_number":77,"context_line":"                   id of the last element the client has seen, \u0027limit\u0027 is the"},{"line_number":78,"context_line":"                   maximum number of items to return and \u0027offset\u0027 is the number"},{"line_number":79,"context_line":"                   of items to skip from the marker or from the first element."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_dce9961b","line":76,"in_reply_to":"fa1b9901_ec2cf34b","updated":"2015-08-26 08:41:21.000000000","message":"nit: That is correct, it should only have 1 space before \u0027limit\u0027.  But not enough for a downvote.","commit_id":"e894b3dd9285a1fb711aee63eb96be1cfe44375b"},{"author":{"_account_id":17718,"name":"Lallana","email":"gaozhiqiang2@huawei.com","username":"Lallana"},"change_message_id":"a4dcd1235f651d0e2302f08a65e7a79d6ec5da8c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                   present we\u0027ll default to None."},{"line_number":85,"context_line":"    :max_limit: Max value \u0027limit\u0027 return value can take"},{"line_number":86,"context_line":"    :returns: Tuple (marker, limit, offset)"},{"line_number":87,"context_line":"    \"\"\""},{"line_number":88,"context_line":"    max_limit \u003d max_limit or CONF.osapi_max_limit"},{"line_number":89,"context_line":"    limit \u003d _get_limit_param(params, max_limit)"},{"line_number":90,"context_line":"    marker \u003d _get_marker_param(params)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_4c1abfc7","line":87,"updated":"2015-08-26 03:42:05.000000000","message":"Multiline comment should end up with a blank line","commit_id":"e894b3dd9285a1fb711aee63eb96be1cfe44375b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7f4020d08683f13701b25dae1a25bbf3d3d295ed","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                   present we\u0027ll default to None."},{"line_number":85,"context_line":"    :max_limit: Max value \u0027limit\u0027 return value can take"},{"line_number":86,"context_line":"    :returns: Tuple (marker, limit, offset)"},{"line_number":87,"context_line":"    \"\"\""},{"line_number":88,"context_line":"    max_limit \u003d max_limit or CONF.osapi_max_limit"},{"line_number":89,"context_line":"    limit \u003d _get_limit_param(params, max_limit)"},{"line_number":90,"context_line":"    marker \u003d _get_marker_param(params)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_fc87ba5e","line":87,"in_reply_to":"fa1b9901_4c1abfc7","updated":"2015-08-26 08:41:21.000000000","message":"?: That\u0027s not correct, PEP257 doesn\u0027t mention it.\n\nBTW, that\u0027s a docstring not a multiline comment.","commit_id":"e894b3dd9285a1fb711aee63eb96be1cfe44375b"}]}