)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a1c6b8a6355f7fa052a68930173ebbff34179656","unresolved":false,"context_lines":[{"line_number":2618,"context_line":"                      resource\u003dcgsnapshot_ref)"},{"line_number":2619,"context_line":"            self.db.cgsnapshot_update(context,"},{"line_number":2620,"context_line":"                                      cgsnapshot_ref[\u0027id\u0027],"},{"line_number":2621,"context_line":"                                      {\u0027status\u0027: \u0027available\u0027})"},{"line_number":2622,"context_line":"            return True"},{"line_number":2623,"context_line":"        except Exception:"},{"line_number":2624,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_868756b4","line":2621,"updated":"2015-08-26 02:31:01.000000000","message":"Sorry for not looking at the code earlier.  So this is different from deleting just one snapshot.  What could happen is that you have 10 snapshots that you need to delete.  5 were deleted successfully but you got SnapshotIsBusy when deleting the 6th one.  You don\u0027t really know when you get the exception.  Setting it to \u0027available\u0027 will be a problem if some have already been deleted.","commit_id":"0bb175727c0811571ddb2000474157cea0805993"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"043313452d9e24ea88adcc4194181822996eb4ef","unresolved":false,"context_lines":[{"line_number":2618,"context_line":"                      resource\u003dcgsnapshot_ref)"},{"line_number":2619,"context_line":"            self.db.cgsnapshot_update(context,"},{"line_number":2620,"context_line":"                                      cgsnapshot_ref[\u0027id\u0027],"},{"line_number":2621,"context_line":"                                      {\u0027status\u0027: \u0027available\u0027})"},{"line_number":2622,"context_line":"            return True"},{"line_number":2623,"context_line":"        except Exception:"},{"line_number":2624,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_a211c45f","line":2621,"in_reply_to":"fa1b9901_868756b4","updated":"2015-08-26 16:43:32.000000000","message":"Did a little more digging. It looks like if delete_cgsnapshot fails in the driver, the snapshots will not be deleted in cinder because model_update doesn\u0027t return successfully. BUT, they more than likely will get deleted on the backend, which can be a problem","commit_id":"0bb175727c0811571ddb2000474157cea0805993"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"5a23ed3429548a54b6501ad28d3ebd55d06a30e9","unresolved":false,"context_lines":[{"line_number":2618,"context_line":"                      resource\u003dcgsnapshot_ref)"},{"line_number":2619,"context_line":"            self.db.cgsnapshot_update(context,"},{"line_number":2620,"context_line":"                                      cgsnapshot_ref[\u0027id\u0027],"},{"line_number":2621,"context_line":"                                      {\u0027status\u0027: \u0027available\u0027})"},{"line_number":2622,"context_line":"            return True"},{"line_number":2623,"context_line":"        except Exception:"},{"line_number":2624,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_2518a3d2","line":2621,"in_reply_to":"fa1b9901_868756b4","updated":"2015-08-26 14:14:37.000000000","message":"That\u0027s very true. In that case would it be best to put all the snapshots back into available state as well? Do you still think it could be beneficial to have the manager catch SnapshotIsBusy?","commit_id":"0bb175727c0811571ddb2000474157cea0805993"}]}