)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"7435521d13413d9b107124824ec91492289d939b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update name_id and provider_location for migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In host-assisted migration, Cinder framework currently only"},{"line_number":10,"context_line":"update name_id and provider_location when driver doesn\u0027t"},{"line_number":11,"context_line":"implement update_migrated_volume interface."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will break drivers which implement update_migrated_volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_5ddfc268","line":10,"updated":"2015-08-31 00:44:40.000000000","message":"Suggest: \"...only updates name_id and provider_location when the driver doesn\u0027t implement ...\"","commit_id":"5b83f32748a74355009140cd3d4b4e596e6fd218"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"887ae957c17c2878ea2b0a7c20e1649d02486c06","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update name_id and provider_location for migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In host-assisted migration, Cinder framework currently only"},{"line_number":10,"context_line":"update name_id and provider_location when driver doesn\u0027t"},{"line_number":11,"context_line":"implement update_migrated_volume interface."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will break drivers which implement update_migrated_volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_b8df0c39","line":10,"in_reply_to":"da20952f_5ddfc268","updated":"2015-08-31 02:06:27.000000000","message":"Done","commit_id":"5b83f32748a74355009140cd3d4b4e596e6fd218"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"7435521d13413d9b107124824ec91492289d939b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"update name_id and provider_location when driver doesn\u0027t"},{"line_number":11,"context_line":"implement update_migrated_volume interface."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will break drivers which implement update_migrated_volume"},{"line_number":14,"context_line":"without returning name_id and provider_location"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This fix will update name_id and provider_location if driver doesn\u0027t"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_1de5ca36","line":13,"updated":"2015-08-31 00:44:40.000000000","message":"which -\u003e that","commit_id":"5b83f32748a74355009140cd3d4b4e596e6fd218"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"887ae957c17c2878ea2b0a7c20e1649d02486c06","unresolved":false,"context_lines":[{"line_number":10,"context_line":"update name_id and provider_location when driver doesn\u0027t"},{"line_number":11,"context_line":"implement update_migrated_volume interface."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will break drivers which implement update_migrated_volume"},{"line_number":14,"context_line":"without returning name_id and provider_location"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This fix will update name_id and provider_location if driver doesn\u0027t"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_58e910e5","line":13,"in_reply_to":"da20952f_1de5ca36","updated":"2015-08-31 02:06:27.000000000","message":"Done","commit_id":"5b83f32748a74355009140cd3d4b4e596e6fd218"}],"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"996465c42930b6708569f2c0b90ba84722dd12a4","unresolved":false,"context_lines":[{"line_number":4012,"context_line":"                                               new_volume, \u0027available\u0027)"},{"line_number":4013,"context_line":"            volume_update.assert_has_calls(("},{"line_number":4014,"context_line":"                mock.call(fake_elevated, volume[\u0027id\u0027], fake_update_error),"},{"line_number":4015,"context_line":"                mock.call(fake_elevated, new_volume[\u0027id\u0027], expected_update)))"},{"line_number":4016,"context_line":""},{"line_number":4017,"context_line":"    def test_list_availability_zones_enabled_service(self):"},{"line_number":4018,"context_line":"        services \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_abbd8fb8","side":"PARENT","line":4015,"updated":"2015-08-29 03:55:35.000000000","message":"I have no idea why this line is removed.","commit_id":"30cd678b57a5d8d87f06b2dc9a2707e04b1b806e"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"1d5ed9ab185c664da30793cd23903b11a4a6d239","unresolved":false,"context_lines":[{"line_number":4012,"context_line":"                                               new_volume, \u0027available\u0027)"},{"line_number":4013,"context_line":"            volume_update.assert_has_calls(("},{"line_number":4014,"context_line":"                mock.call(fake_elevated, volume[\u0027id\u0027], fake_update_error),"},{"line_number":4015,"context_line":"                mock.call(fake_elevated, new_volume[\u0027id\u0027], expected_update)))"},{"line_number":4016,"context_line":""},{"line_number":4017,"context_line":"    def test_list_availability_zones_enabled_service(self):"},{"line_number":4018,"context_line":"        services \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_564b372a","side":"PARENT","line":4015,"in_reply_to":"da20952f_abbd8fb8","updated":"2015-08-29 14:28:38.000000000","message":"no need to remove, will add back","commit_id":"30cd678b57a5d8d87f06b2dc9a2707e04b1b806e"}],"cinder/volume/manager.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"996465c42930b6708569f2c0b90ba84722dd12a4","unresolved":false,"context_lines":[{"line_number":2726,"context_line":"            # Swap keys that were changed in the source so we keep their values"},{"line_number":2727,"context_line":"            # in the temporary volume\u0027s DB record."},{"line_number":2728,"context_line":"            # Need to skip \u0027metadata\u0027 and \u0027admin_metadata\u0027 since"},{"line_number":2729,"context_line":"            # they are not keys of volume"},{"line_number":2730,"context_line":"            model_update_new \u003d dict()"},{"line_number":2731,"context_line":"            for key in model_update:"},{"line_number":2732,"context_line":"                if key \u003d\u003d \u0027metadata\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_abc10f56","line":2729,"updated":"2015-08-29 03:55:35.000000000","message":"I do not think you skip metadata or admin_metadata.\nYou have put them in the key model_update_new[key] \u003d ... as well. I do not think we should skip copying metadata, because model_update is supposed to decide what is changed for the volume. If we swap all the keys, new volume is supposed to have them all.\n\nIn fact, I am wondering why driver.update_migrated_volume can return metadata or admin_metadata? Which driver is implementing driver.update_migrated_volume with metadat returned?","commit_id":"489ded9f7de77c22d7c09c235de8ca763e4f6132"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"1d5ed9ab185c664da30793cd23903b11a4a6d239","unresolved":false,"context_lines":[{"line_number":2726,"context_line":"            # Swap keys that were changed in the source so we keep their values"},{"line_number":2727,"context_line":"            # in the temporary volume\u0027s DB record."},{"line_number":2728,"context_line":"            # Need to skip \u0027metadata\u0027 and \u0027admin_metadata\u0027 since"},{"line_number":2729,"context_line":"            # they are not keys of volume"},{"line_number":2730,"context_line":"            model_update_new \u003d dict()"},{"line_number":2731,"context_line":"            for key in model_update:"},{"line_number":2732,"context_line":"                if key \u003d\u003d \u0027metadata\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_96230fa7","line":2729,"in_reply_to":"da20952f_abc10f56","updated":"2015-08-29 14:28:38.000000000","message":"It\u0027s my fault of wording in comments\n\ni meant to have special handling for \u0027metadata\u0027 and admin_metadata, i will change my wording in next patch\n\nfor why I need to special handing, see attached log file in https://bugs.launchpad.net/cinder/+bug/1487952\nin the log file , you will find no \u0027metadata\u0027 and \u0027admin_metadata\u0027 in volume object.\n\nEMC driver returns \u0027metadata\u0027 see: https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/emc/emc_vnx_cli.py#L2264\n\nafter someone added following:\nbefore people add following\nmodel_update_new \u003d {key: volume[key]\n                                for key in model_update.iterkeys()}\n\nEMC drive\u0027s host-assisted migration failed with \"KeyError: \u0027metadata\u0027\"","commit_id":"489ded9f7de77c22d7c09c235de8ca763e4f6132"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"996465c42930b6708569f2c0b90ba84722dd12a4","unresolved":false,"context_lines":[{"line_number":2730,"context_line":"            model_update_new \u003d dict()"},{"line_number":2731,"context_line":"            for key in model_update:"},{"line_number":2732,"context_line":"                if key \u003d\u003d \u0027metadata\u0027:"},{"line_number":2733,"context_line":"                    if volume.get(\u0027volume_metadata\u0027):"},{"line_number":2734,"context_line":"                        model_update_new[key] \u003d {"},{"line_number":2735,"context_line":"                            metadata[\u0027key\u0027]: metadata[\u0027value\u0027]"},{"line_number":2736,"context_line":"                            for metadata in volume.get(\u0027volume_metadata\u0027)}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4ba9538f","line":2733,"updated":"2015-08-29 03:55:35.000000000","message":"Is this line necessary? If metadata key exists, of course metadata volume metadata exists.","commit_id":"489ded9f7de77c22d7c09c235de8ca763e4f6132"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"1d5ed9ab185c664da30793cd23903b11a4a6d239","unresolved":false,"context_lines":[{"line_number":2730,"context_line":"            model_update_new \u003d dict()"},{"line_number":2731,"context_line":"            for key in model_update:"},{"line_number":2732,"context_line":"                if key \u003d\u003d \u0027metadata\u0027:"},{"line_number":2733,"context_line":"                    if volume.get(\u0027volume_metadata\u0027):"},{"line_number":2734,"context_line":"                        model_update_new[key] \u003d {"},{"line_number":2735,"context_line":"                            metadata[\u0027key\u0027]: metadata[\u0027value\u0027]"},{"line_number":2736,"context_line":"                            for metadata in volume.get(\u0027volume_metadata\u0027)}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_566817b9","line":2733,"in_reply_to":"da20952f_4ba9538f","updated":"2015-08-29 14:28:38.000000000","message":"check https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/models.py#L119\n\nno \u0027metadata\u0027 and \u0027admin_metadata\u0027 existed in Volume object\ntheir correspoding keys are \u0027volume_metadata\u0027 and \u0027volume_admin_metadata\u0027\n\n\nwhile self.db.volume_update(xx, xx, xx ) only accepts \u0027metadata\u0027 and \u0027admin_metadata\u0027 in model_update\nsee: https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L1730\nso i need this conversion to translate 2 keys","commit_id":"489ded9f7de77c22d7c09c235de8ca763e4f6132"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"996465c42930b6708569f2c0b90ba84722dd12a4","unresolved":false,"context_lines":[{"line_number":2735,"context_line":"                            metadata[\u0027key\u0027]: metadata[\u0027value\u0027]"},{"line_number":2736,"context_line":"                            for metadata in volume.get(\u0027volume_metadata\u0027)}"},{"line_number":2737,"context_line":"                elif key \u003d\u003d \u0027admin_metadata\u0027:"},{"line_number":2738,"context_line":"                        model_update_new[key] \u003d {"},{"line_number":2739,"context_line":"                            metadata[\u0027key\u0027]: metadata[\u0027value\u0027]"},{"line_number":2740,"context_line":"                            for metadata in volume.get("},{"line_number":2741,"context_line":"                                \u0027volume_admin_metadata\u0027)}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_6bb777f5","line":2738,"updated":"2015-08-29 03:55:35.000000000","message":"Indentation error.","commit_id":"489ded9f7de77c22d7c09c235de8ca763e4f6132"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"1d5ed9ab185c664da30793cd23903b11a4a6d239","unresolved":false,"context_lines":[{"line_number":2735,"context_line":"                            metadata[\u0027key\u0027]: metadata[\u0027value\u0027]"},{"line_number":2736,"context_line":"                            for metadata in volume.get(\u0027volume_metadata\u0027)}"},{"line_number":2737,"context_line":"                elif key \u003d\u003d \u0027admin_metadata\u0027:"},{"line_number":2738,"context_line":"                        model_update_new[key] \u003d {"},{"line_number":2739,"context_line":"                            metadata[\u0027key\u0027]: metadata[\u0027value\u0027]"},{"line_number":2740,"context_line":"                            for metadata in volume.get("},{"line_number":2741,"context_line":"                                \u0027volume_admin_metadata\u0027)}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_76a3db00","line":2738,"in_reply_to":"da20952f_6bb777f5","updated":"2015-08-29 14:28:38.000000000","message":"Sorry, I did not found pylint/pep8 error from this line.\nwill apply it if applicable","commit_id":"489ded9f7de77c22d7c09c235de8ca763e4f6132"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"7435521d13413d9b107124824ec91492289d939b","unresolved":false,"context_lines":[{"line_number":2840,"context_line":"            # Swap keys that were changed in the source so we keep their values"},{"line_number":2841,"context_line":"            # in the temporary volume\u0027s DB record."},{"line_number":2842,"context_line":"            # Need to convert \u0027metadata\u0027 and \u0027admin_metadata\u0027 since"},{"line_number":2843,"context_line":"            # they are not keys of volume, their correspoding keys are"},{"line_number":2844,"context_line":"            # \u0027volume_metadata\u0027 and \u0027volume_admin_metadata\u0027."},{"line_number":2845,"context_line":"            model_update_new \u003d dict()"},{"line_number":2846,"context_line":"            for key in model_update:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_3db44e33","line":2843,"updated":"2015-08-31 00:44:40.000000000","message":"correspoding-\u003e corresponding","commit_id":"5b83f32748a74355009140cd3d4b4e596e6fd218"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"887ae957c17c2878ea2b0a7c20e1649d02486c06","unresolved":false,"context_lines":[{"line_number":2840,"context_line":"            # Swap keys that were changed in the source so we keep their values"},{"line_number":2841,"context_line":"            # in the temporary volume\u0027s DB record."},{"line_number":2842,"context_line":"            # Need to convert \u0027metadata\u0027 and \u0027admin_metadata\u0027 since"},{"line_number":2843,"context_line":"            # they are not keys of volume, their correspoding keys are"},{"line_number":2844,"context_line":"            # \u0027volume_metadata\u0027 and \u0027volume_admin_metadata\u0027."},{"line_number":2845,"context_line":"            model_update_new \u003d dict()"},{"line_number":2846,"context_line":"            for key in model_update:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_18ef18ea","line":2843,"in_reply_to":"da20952f_3db44e33","updated":"2015-08-31 02:06:27.000000000","message":"Done","commit_id":"5b83f32748a74355009140cd3d4b4e596e6fd218"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"69db6bf65981a51bdd0ec0bda05d92ca5cd0435d","unresolved":false,"context_lines":[{"line_number":2821,"context_line":"                               volume_status):"},{"line_number":2822,"context_line":"        \"\"\"Finalize migration process on backend device.\"\"\""},{"line_number":2823,"context_line":"        model_update \u003d None"},{"line_number":2824,"context_line":"        model_update_default \u003d {\u0027_name_id\u0027: new_volume[\u0027_name_id\u0027] or"},{"line_number":2825,"context_line":"                                new_volume[\u0027id\u0027],"},{"line_number":2826,"context_line":"                                \u0027provider_location\u0027:"},{"line_number":2827,"context_line":"                                new_volume[\u0027provider_location\u0027]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_4b2dc58d","line":2824,"updated":"2015-09-11 15:26:10.000000000","message":"model_update_default is redundant, code can be simpler without it.","commit_id":"dac5c32e00cd3ca6a12de697287ad1453f9beaba"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"fa8a2a519992e3c180d957ac7aea6862dcf30006","unresolved":false,"context_lines":[{"line_number":2821,"context_line":"                               volume_status):"},{"line_number":2822,"context_line":"        \"\"\"Finalize migration process on backend device.\"\"\""},{"line_number":2823,"context_line":"        model_update \u003d None"},{"line_number":2824,"context_line":"        model_update_default \u003d {\u0027_name_id\u0027: new_volume[\u0027_name_id\u0027] or"},{"line_number":2825,"context_line":"                                new_volume[\u0027id\u0027],"},{"line_number":2826,"context_line":"                                \u0027provider_location\u0027:"},{"line_number":2827,"context_line":"                                new_volume[\u0027provider_location\u0027]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_846843bc","line":2824,"in_reply_to":"da20952f_4b2dc58d","updated":"2015-09-14 02:09:30.000000000","message":"Hi Zhiteng\n\nCould you please elaborate your comments?\n\nI use model_update_default to provide the default values\nif model_update is not None, model_update_default will be updated according to model_update\n\nThanks\nPeter","commit_id":"dac5c32e00cd3ca6a12de697287ad1453f9beaba"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"ce5641289f7817d7ee1e6051f3b18cda92a27c49","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                max_cache_size,"},{"line_number":251,"context_line":"                max_cache_entries"},{"line_number":252,"context_line":"            )"},{"line_number":253,"context_line":"            LOG.info(_LI(\u0027Image-volume cache enabled for host %(host)s\u0027),"},{"line_number":254,"context_line":"                     {\u0027host\u0027: self.host})"},{"line_number":255,"context_line":"        else:"},{"line_number":256,"context_line":"            LOG.info(_LI(\u0027Image-volume cache disabled for host %(host)s\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_ce6c039f","line":253,"updated":"2015-09-14 15:27:57.000000000","message":"\".\" at EOL","commit_id":"9c5bc023683613e98f4e76d90496c1dc11506a86"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"07ba8a78c5d2c19ef23b4c3d2c8ee3222073afc4","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                max_cache_size,"},{"line_number":251,"context_line":"                max_cache_entries"},{"line_number":252,"context_line":"            )"},{"line_number":253,"context_line":"            LOG.info(_LI(\u0027Image-volume cache enabled for host %(host)s\u0027),"},{"line_number":254,"context_line":"                     {\u0027host\u0027: self.host})"},{"line_number":255,"context_line":"        else:"},{"line_number":256,"context_line":"            LOG.info(_LI(\u0027Image-volume cache disabled for host %(host)s\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_40ddb46d","line":253,"in_reply_to":"ba15a1d1_ce6c039f","updated":"2015-09-16 16:14:41.000000000","message":"Done","commit_id":"9c5bc023683613e98f4e76d90496c1dc11506a86"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"ce5641289f7817d7ee1e6051f3b18cda92a27c49","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            LOG.info(_LI(\u0027Image-volume cache enabled for host %(host)s\u0027),"},{"line_number":254,"context_line":"                     {\u0027host\u0027: self.host})"},{"line_number":255,"context_line":"        else:"},{"line_number":256,"context_line":"            LOG.info(_LI(\u0027Image-volume cache disabled for host %(host)s\u0027),"},{"line_number":257,"context_line":"                     {\u0027host\u0027: self.host})"},{"line_number":258,"context_line":"            self.image_volume_cache \u003d None"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_4e0f93e1","line":256,"updated":"2015-09-14 15:27:57.000000000","message":"\".\" at EOL","commit_id":"9c5bc023683613e98f4e76d90496c1dc11506a86"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"07ba8a78c5d2c19ef23b4c3d2c8ee3222073afc4","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            LOG.info(_LI(\u0027Image-volume cache enabled for host %(host)s\u0027),"},{"line_number":254,"context_line":"                     {\u0027host\u0027: self.host})"},{"line_number":255,"context_line":"        else:"},{"line_number":256,"context_line":"            LOG.info(_LI(\u0027Image-volume cache disabled for host %(host)s\u0027),"},{"line_number":257,"context_line":"                     {\u0027host\u0027: self.host})"},{"line_number":258,"context_line":"            self.image_volume_cache \u003d None"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_a0d2905a","line":256,"in_reply_to":"ba15a1d1_4e0f93e1","updated":"2015-09-16 16:14:41.000000000","message":"Done","commit_id":"9c5bc023683613e98f4e76d90496c1dc11506a86"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"ce5641289f7817d7ee1e6051f3b18cda92a27c49","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"                image_meta"},{"line_number":1060,"context_line":"            )"},{"line_number":1061,"context_line":"        except exception.CinderException as e:"},{"line_number":1062,"context_line":"            LOG.warning(_LW(\u0027Failed to create new image-volume cache entry\u0027"},{"line_number":1063,"context_line":"                            \u0027 Error: %(exception)s\u0027), {\u0027exception\u0027: e})"},{"line_number":1064,"context_line":"            if image_volume:"},{"line_number":1065,"context_line":"                self.delete_volume(ctx, image_volume.id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_ce03a3b7","line":1062,"updated":"2015-09-14 15:27:57.000000000","message":"\".\" at EOL","commit_id":"9c5bc023683613e98f4e76d90496c1dc11506a86"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"07ba8a78c5d2c19ef23b4c3d2c8ee3222073afc4","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"                image_meta"},{"line_number":1060,"context_line":"            )"},{"line_number":1061,"context_line":"        except exception.CinderException as e:"},{"line_number":1062,"context_line":"            LOG.warning(_LW(\u0027Failed to create new image-volume cache entry\u0027"},{"line_number":1063,"context_line":"                            \u0027 Error: %(exception)s\u0027), {\u0027exception\u0027: e})"},{"line_number":1064,"context_line":"            if image_volume:"},{"line_number":1065,"context_line":"                self.delete_volume(ctx, image_volume.id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_80cd0cb9","line":1062,"in_reply_to":"ba15a1d1_ce03a3b7","updated":"2015-09-16 16:14:41.000000000","message":"Done","commit_id":"9c5bc023683613e98f4e76d90496c1dc11506a86"}]}