)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"bf402fd43d7c57bf48b199cb4bd50b057ba49f0c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"create() API in cinder/volume/api.py does the authority check"},{"line_number":10,"context_line":"in cinder/volume/flows/api/create_volume.py."},{"line_number":11,"context_line":"This creates potential for disclosing information during error checking"},{"line_number":12,"context_line":"prior to user authorization being checked."},{"line_number":13,"context_line":"This fix will move authority check to create() itself, so that"},{"line_number":14,"context_line":"it is done before proceeding with the rest of code flow."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_d2b9dc7a","line":12,"updated":"2015-08-27 22:03:40.000000000","message":"I am confused as to what you did here.  This message suggests that you were moving the authority check from cinder/volume/flows/api/create_volume.py but you didn\u0027t make a change to that file and I don\u0027t see that there was code to do that there.  Can you please clarify?\n\nThanks!","commit_id":"7f83dcd222bb6442b9eff689ff696cbd476718a7"},{"author":{"_account_id":10345,"name":"Anna Sortland","email":"annasort@us.ibm.com","username":"annasort"},"change_message_id":"30ab890178ab7e7e5657399ea09def3f55921004","unresolved":false,"context_lines":[{"line_number":9,"context_line":"create() API in cinder/volume/api.py does the authority check"},{"line_number":10,"context_line":"in cinder/volume/flows/api/create_volume.py."},{"line_number":11,"context_line":"This creates potential for disclosing information during error checking"},{"line_number":12,"context_line":"prior to user authorization being checked."},{"line_number":13,"context_line":"This fix will move authority check to create() itself, so that"},{"line_number":14,"context_line":"it is done before proceeding with the rest of code flow."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_0cb2a706","line":12,"in_reply_to":"da20952f_d2b9dc7a","updated":"2015-08-28 17:19:19.000000000","message":"I left the check in cinder/volume/flows/api/create_volume.py per comment #4 in the bug (https://bugs.launchpad.net/cinder/+bug/1472031/comments/4). \nThe check happens here: https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L350","commit_id":"7f83dcd222bb6442b9eff689ff696cbd476718a7"}]}