)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"11a0399cd8ea435fb981693f8e394cc985a71d39","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the snake case conversion of the corresponding model."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For example, we have volume_type and volume_types methods in db.api,"},{"line_number":13,"context_line":"only the later is corret since the model name is VolumeTypes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We also have consistencygroup_ methods that should really be called"},{"line_number":16,"context_line":"consistency_group_."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_683add9a","line":13,"updated":"2015-08-31 18:27:42.000000000","message":"\"corret\" -\u003e \"correct\"","commit_id":"dfc37afda2f5811cec095aa71a44ecbf553eba85"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1b5ea2e1e6f1252b74c47b22e9b45fb015b660ac","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the snake case conversion of the corresponding model."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For example, we have volume_type and volume_types methods in db.api,"},{"line_number":13,"context_line":"only the later is corret since the model name is VolumeTypes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We also have consistencygroup_ methods that should really be called"},{"line_number":16,"context_line":"consistency_group_."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_903df82c","line":13,"in_reply_to":"da20952f_683add9a","updated":"2015-09-01 11:35:01.000000000","message":"Thanks, fixed in next patch.  But really?  -1 for this nit?","commit_id":"dfc37afda2f5811cec095aa71a44ecbf553eba85"}],"cinder/backup/driver.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9e39b2e7628e678ab6f6ffb17223e4a6f1ffc679","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            # to have the encrypted volume type, provided it still exists."},{"line_number":192,"context_line":"            if dest_vol[\u0027volume_type_id\u0027] is None:"},{"line_number":193,"context_line":"                try:"},{"line_number":194,"context_line":"                    self.db.volume_types_get("},{"line_number":195,"context_line":"                        self.context, src_volume_type_id)"},{"line_number":196,"context_line":"                except exception.VolumeTypeNotFound:"},{"line_number":197,"context_line":"                    LOG.debug(\"Volume type of source volume has been \""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_588c547f","line":194,"updated":"2015-09-01 16:33:43.000000000","message":"why is \"types\" appropriate and \"type\" isn\u0027t?  You\u0027re not getting multiple volume_type objects, you\u0027re getting the one you asked for based on the id?","commit_id":"2cfa4fd052e3f61848173b1033452864cf681853"}],"cinder/db/api.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9e39b2e7628e678ab6f6ffb17223e4a6f1ffc679","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                                                  qos_specs_id)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"def volume_types_qos_specs_get(context, type_id):"},{"line_number":492,"context_line":"    \"\"\"Get all qos specs for given volume type.\"\"\""},{"line_number":493,"context_line":"    return IMPL.volume_types_qos_specs_get(context, type_id)"},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_f8ce88b6","line":491,"updated":"2015-09-01 16:33:43.000000000","message":"same note as before","commit_id":"2cfa4fd052e3f61848173b1033452864cf681853"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9e39b2e7628e678ab6f6ffb17223e4a6f1ffc679","unresolved":false,"context_lines":[{"line_number":305,"context_line":"def _sync_consistencygroups(context, project_id, session,"},{"line_number":306,"context_line":"                            volume_type_id\u003dNone,"},{"line_number":307,"context_line":"                            volume_type_name\u003dNone):"},{"line_number":308,"context_line":"    (_junk, groups) \u003d _consistency_group_data_get_for_project("},{"line_number":309,"context_line":"        context, project_id, session\u003dsession)"},{"line_number":310,"context_line":"    key \u003d \u0027consistencygroups\u0027"},{"line_number":311,"context_line":"    return {key: groups}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_d8cdc4b8","line":308,"updated":"2015-09-01 16:33:43.000000000","message":"meh... yeah, ok.","commit_id":"2cfa4fd052e3f61848173b1033452864cf681853"}],"cinder/quota.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9e39b2e7628e678ab6f6ffb17223e4a6f1ffc679","unresolved":false,"context_lines":[{"line_number":891,"context_line":"        # NOTE(jdg): set inactive to True in volume_types_get, as we"},{"line_number":892,"context_line":"        # may be operating on a volume that was created with a type"},{"line_number":893,"context_line":"        # that has since been deleted."},{"line_number":894,"context_line":"        volume_type \u003d db.volume_types_get(context, volume_type_id, True)"},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"        for quota in (\u0027volumes\u0027, \u0027gigabytes\u0027, \u0027snapshots\u0027):"},{"line_number":897,"context_line":"            if quota in opts:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_58ba140c","line":894,"updated":"2015-09-01 16:33:43.000000000","message":"You\u0027re not getting \"types\" your getting a \"type\"","commit_id":"2cfa4fd052e3f61848173b1033452864cf681853"}]}