)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"e707004c2aa64c363ae9d06d215f957aca37070f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove wsgi functionality"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since oslo.service contains wsgi functionality we can remove it from cinder."},{"line_number":10,"context_line":"Related oslo.service Change-Id: If8840168f10cc3561f4f01e6d456d6b4fd1de8b5"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iea8af7b4a569fedc99e126524f18f98097c95a6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_acf3ee9e","line":10,"updated":"2015-09-08 16:53:28.000000000","message":"Suggest: \"The change where the wsgi functionality was added to oslo.service can be referenced here:  If8840168f10cc3561f4f01e6d456d6b4fd1de8b5.\"\n\nAlso though, I am concerned this doesn\u0027t have a bug/blueprint. I see that its a relatively simple change, but it is removing over 700 lines of code.  If it should actually be a blueprint and not a bug it\u0027s going to have to wait till Mitaka since we are into the third milestone now. Just wondering what the rest of the community thinks. Thanks!","commit_id":"fa80bb81ebdde76ec816ded3f795bc4fac40f04d"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"11745a5329a0a8fa4b0a83cc203ff6e8a0755215","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove wsgi functionality"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since oslo.service contains wsgi functionality we can remove it from cinder."},{"line_number":10,"context_line":"Related oslo.service Change-Id: If8840168f10cc3561f4f01e6d456d6b4fd1de8b5"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iea8af7b4a569fedc99e126524f18f98097c95a6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_cd908998","line":10,"in_reply_to":"da20952f_acf3ee9e","updated":"2015-09-25 09:48:27.000000000","message":"It would be convenient to track the progress of OpenStack projects consuming wsgi functionality from oslo.service in a bug. It is a common practice when a new oslo library is graduated so the same should be applicable here too.","commit_id":"fa80bb81ebdde76ec816ded3f795bc4fac40f04d"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"43a7b9cd2e9cc10d3b289ff869778be282237aea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"referenced here: If8840168f10cc3561f4f01e6d456d6b4fd1de8b5."},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements blueprint: move-wsgi-server-in-oslo-service"},{"line_number":14,"context_line":"Change-Id: Iea8af7b4a569fedc99e126524f18f98097c95a6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a29b11f_69e4910c","line":13,"updated":"2015-10-20 12:36:04.000000000","message":"Blueprint link is broken","commit_id":"7bc3df70e5ade4a9a47dc27e52eb408a1aaa59e3"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"46ca22d1351b3d8fccd8aa1a39d61b83c6a38f85","unresolved":false,"context_lines":[{"line_number":10,"context_line":"referenced here: If8840168f10cc3561f4f01e6d456d6b4fd1de8b5."},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements blueprint: move-wsgi-server-in-oslo-service"},{"line_number":14,"context_line":"Change-Id: Iea8af7b4a569fedc99e126524f18f98097c95a6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a29b11f_909c8110","line":13,"in_reply_to":"3a29b11f_69e4910c","updated":"2015-10-21 08:56:31.000000000","message":"Done","commit_id":"7bc3df70e5ade4a9a47dc27e52eb408a1aaa59e3"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e6ba9f4c05bf5fdcbc3d9f6aa5049487f0e84ea6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"referenced here: If8840168f10cc3561f4f01e6d456d6b4fd1de8b5."},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements blueprint: https://blueprints.launchpad.net/oslo.service/+spec/move-wsgi-server-in-oslo-service"},{"line_number":14,"context_line":"Change-Id: Iea8af7b4a569fedc99e126524f18f98097c95a6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a29b11f_20b73cf6","line":13,"updated":"2015-10-21 18:30:40.000000000","message":"Good for reference, but we need a Cinder blueprint. Then the proper format for linking to it is something like:\n\nImplements: blueprint move-wsgi-server\n\nThis will also need a cross-repo link to make sure any necessary oslo.service changes merge before we try to pick this upL\n\nDepends-on: [change id]","commit_id":"38d19ba6f9b79d72cb73e7427e3b26deb8b51be8"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"a44f279bf300f55a1c2acc29171cda598eb1ffad","unresolved":false,"context_lines":[{"line_number":10,"context_line":"referenced here: If8840168f10cc3561f4f01e6d456d6b4fd1de8b5."},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements blueprint: https://blueprints.launchpad.net/oslo.service/+spec/move-wsgi-server-in-oslo-service"},{"line_number":14,"context_line":"Change-Id: Iea8af7b4a569fedc99e126524f18f98097c95a6d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a740942_528846c5","line":13,"in_reply_to":"3a29b11f_20b73cf6","updated":"2015-12-11 15:55:38.000000000","message":"Done","commit_id":"38d19ba6f9b79d72cb73e7427e3b26deb8b51be8"}],"cinder/tests/unit/wsgi/test_wsgi.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"8f77e764f24ef6615648a0ef111fd708704b23f3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            mock_stdout.buffer \u003d six.BytesIO()"},{"line_number":48,"context_line":"            application \u003d debug.Debug(Application())"},{"line_number":49,"context_line":"            result \u003d webob.Request.blank(\u0027/\u0027).get_response(application)"},{"line_number":50,"context_line":"            self.assertEqual(b\"Test result\", result.body)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_router(self):"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_6c8494d3","line":50,"updated":"2015-10-20 15:45:38.000000000","message":"py34 does not seem to like this. \"TypeError: string argument expected, got \u0027bytes\u0027\"","commit_id":"7bc3df70e5ade4a9a47dc27e52eb408a1aaa59e3"}],"cinder/wsgi/common.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"e331dc9bae9fb39140941fc2bd6ed8bfc03fc825","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        :returns: None"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        \"\"\""},{"line_number":176,"context_line":"        CONF.register_opts(_options.wsgi_opts)"},{"line_number":177,"context_line":"        config_path \u003d config_path or CONF.api_paste_config"},{"line_number":178,"context_line":"        self.config_path \u003d utils.find_config(config_path)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_c2db781a","line":176,"updated":"2015-09-25 09:37:16.000000000","message":"Why not call wsgi.register_opts(CONF) ? Thus it wouldn\u0027t be needed to import private module from oslo.service.\n\nhttps://github.com/openstack/oslo.service/blob/master/oslo_service/wsgi.py#L49","commit_id":"fa80bb81ebdde76ec816ded3f795bc4fac40f04d"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"1fa95c311cf2d64f070ab4b81be24a0c4d601381","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        :returns: None"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        \"\"\""},{"line_number":176,"context_line":"        CONF.register_opts(_options.wsgi_opts)"},{"line_number":177,"context_line":"        config_path \u003d config_path or CONF.api_paste_config"},{"line_number":178,"context_line":"        self.config_path \u003d utils.find_config(config_path)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_f2da0578","line":176,"in_reply_to":"9a1a9d01_c2db781a","updated":"2015-09-25 11:52:54.000000000","message":"Oh, I see, these changes weren\u0027t released yet.","commit_id":"fa80bb81ebdde76ec816ded3f795bc4fac40f04d"}],"cinder/wsgi/wsgi.py":[{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"4c56118779ad4eac904b98db57e48f4fe848a656","unresolved":false,"context_lines":[{"line_number":41,"context_line":"         version\u003dversion.version_string())"},{"line_number":42,"context_line":"    logging.setup(CONF, \"cinder\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    rpc.init(CONF)"},{"line_number":45,"context_line":"    return wsgi_common.Loader().load_app(name\u003d\u0027osapi_volume\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_48ebb078","line":44,"updated":"2015-09-03 17:17:38.000000000","message":"wsgi_common no longer has a Loader() member now that the import has been changed on line 30.\n\nThis is causing gate-cinder-pylint to fail. The job is non-voting but this should probably still be fixed.","commit_id":"f4ba47d30d9712afdfce03c3261a1c39f29467a6"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"e158fcbdd8fd11ecd29ecd6ccacc42103cd40dc2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"         version\u003dversion.version_string())"},{"line_number":42,"context_line":"    logging.setup(CONF, \"cinder\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    rpc.init(CONF)"},{"line_number":45,"context_line":"    return wsgi_common.Loader().load_app(name\u003d\u0027osapi_volume\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_39798693","line":44,"in_reply_to":"da20952f_48ebb078","updated":"2015-09-07 14:26:29.000000000","message":"Done","commit_id":"f4ba47d30d9712afdfce03c3261a1c39f29467a6"}]}
