)]}'
{"cinder/tests/unit/test_vmware_exceptions.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2f1b9622b073707e5486231c184101f7cbbfc715","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_invalid_adapter_type_exception(self):"},{"line_number":30,"context_line":"        ex \u003d exceptions.InvalidAdapterTypeException(invalid_type\u003d\u0027fake\u0027)"},{"line_number":31,"context_line":"        exp_msg \u003d \u0027Invalid disk adapter type: fake.\u0027"},{"line_number":32,"context_line":"        self.assertEqual(exp_msg, six.text_type(ex))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_invalid_disk_type_exception(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_597944fb","line":31,"updated":"2015-09-03 18:11:06.000000000","message":"I\u0027m really not a fan of asserting on exact text for logs or exceptions. Can you remove the ones that don\u0027t have arguments (the static text ones) and just validate for the others that the string you pass in is in the exception message?","commit_id":"8a6456cc241461609a3a5f45ee2f4e80ab3c7a1f"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"a41c56dc76dfe94d2889e57abbdfd805e52c7f5c","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_invalid_adapter_type_exception(self):"},{"line_number":30,"context_line":"        ex \u003d exceptions.InvalidAdapterTypeException(invalid_type\u003d\u0027fake\u0027)"},{"line_number":31,"context_line":"        exp_msg \u003d \u0027Invalid disk adapter type: fake.\u0027"},{"line_number":32,"context_line":"        self.assertEqual(exp_msg, six.text_type(ex))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_invalid_disk_type_exception(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_69c235eb","line":31,"in_reply_to":"da20952f_597944fb","updated":"2015-09-03 18:34:07.000000000","message":"Removed this test module.","commit_id":"8a6456cc241461609a3a5f45ee2f4e80ab3c7a1f"}]}