)]}'
{"cinder/tests/unit/test_vmware_vmdk.py":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c21d022c1649edfe7e09f80bbb9ace84c2b5a743","unresolved":false,"context_lines":[{"line_number":2445,"context_line":"            context, self.IMG_TX_TIMEOUT, image_service, image_id,"},{"line_number":2446,"context_line":"            image_size\u003dimage_size_in_bytes, host\u003dself.IP, port\u003dself.PORT,"},{"line_number":2447,"context_line":"            data_center_name\u003ddc_name, datastore_name\u003dds_name, cookies\u003dcookies,"},{"line_number":2448,"context_line":"            file_path\u003dupload_file_path, cacerts\u003dFalse)"},{"line_number":2449,"context_line":""},{"line_number":2450,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_copy_temp_virtual_disk\u0027)"},{"line_number":2451,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_get_temp_image_folder\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_7717b151","line":2448,"updated":"2015-09-15 03:55:01.000000000","message":"Looks like duplicate codes in here, could extract those codes to a singe function?","commit_id":"e784f2885a349332978e5f6b49f81b08cc9d1507"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c0e1f5276538cfa4da303e7f431c28f0eee17aa8","unresolved":false,"context_lines":[{"line_number":2445,"context_line":"            context, self.IMG_TX_TIMEOUT, image_service, image_id,"},{"line_number":2446,"context_line":"            image_size\u003dimage_size_in_bytes, host\u003dself.IP, port\u003dself.PORT,"},{"line_number":2447,"context_line":"            data_center_name\u003ddc_name, datastore_name\u003dds_name, cookies\u003dcookies,"},{"line_number":2448,"context_line":"            file_path\u003dupload_file_path, cacerts\u003dFalse)"},{"line_number":2449,"context_line":""},{"line_number":2450,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_copy_temp_virtual_disk\u0027)"},{"line_number":2451,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_get_temp_image_folder\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_6007ea1c","line":2448,"in_reply_to":"ba15a1d1_7717b151","updated":"2015-09-15 05:57:48.000000000","message":"Done","commit_id":"e784f2885a349332978e5f6b49f81b08cc9d1507"}],"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0852399ad8b71c1a4496b5e5489739645c5e8463","unresolved":false,"context_lines":[{"line_number":822,"context_line":"                  {\u0027image_id\u0027: image_id,"},{"line_number":823,"context_line":"                   \u0027path\u0027: upload_file_path})"},{"line_number":824,"context_line":"        # TODO(vbala): add config option to override non-default port"},{"line_number":825,"context_line":"        cacerts \u003d ca_file if ca_file else not insecure"},{"line_number":826,"context_line":"        image_transfer.download_flat_image(context,"},{"line_number":827,"context_line":"                                           timeout,"},{"line_number":828,"context_line":"                                           image_service,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_ac6d2e9b","line":825,"updated":"2015-09-08 14:24:41.000000000","message":"This doesn\u0027t look right.  What if no file is set and insecure is purposefully set?  I think this logic needs to be reconsidered.","commit_id":"4b11d72d12a862c16dadf95eb23c943983c1b342"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c239cdc20f4f4e3d3fb20131e746ee0b3ad29265","unresolved":false,"context_lines":[{"line_number":822,"context_line":"                  {\u0027image_id\u0027: image_id,"},{"line_number":823,"context_line":"                   \u0027path\u0027: upload_file_path})"},{"line_number":824,"context_line":"        # TODO(vbala): add config option to override non-default port"},{"line_number":825,"context_line":"        cacerts \u003d ca_file if ca_file else not insecure"},{"line_number":826,"context_line":"        image_transfer.download_flat_image(context,"},{"line_number":827,"context_line":"                                           timeout,"},{"line_number":828,"context_line":"                                           image_service,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_87528567","line":825,"in_reply_to":"da20952f_ac6d2e9b","updated":"2015-09-08 15:08:06.000000000","message":"Then there is no certificate verification as documented here:\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/vmware/vmdk.py#L120\n\nIf vmware_ca_file is set, then the certificate it points to is used for certificate verification.\n\nIf vmware_ca_file is unset:\n* vmware_insecure is true: there is no certificate verification.\n* vmware_insecure is false: the default CA truststore is used for verifying vCenter certificate.\n\nAdded a comment to clarify this.","commit_id":"4b11d72d12a862c16dadf95eb23c943983c1b342"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"52f8388969727e0a3b8217063df0d6f12f04576c","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        # is used for verification. We should pass cacerts\u003dTrue in this"},{"line_number":829,"context_line":"        # case. If ca_file is unset and insecure is True, there is no"},{"line_number":830,"context_line":"        # certificate verification, and we should pass cacerts\u003dFalse."},{"line_number":831,"context_line":"        cacerts \u003d ca_file if ca_file else not insecure"},{"line_number":832,"context_line":"        image_transfer.download_flat_image(context,"},{"line_number":833,"context_line":"                                           timeout,"},{"line_number":834,"context_line":"                                           image_service,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_0d8d4131","line":831,"updated":"2015-09-12 20:00:20.000000000","message":"i think you can optimize this line as\ncacerts \u003d ca_file or not insecure      \n\nif ca_file is None, it will go for second condition which is \"not insecure\"","commit_id":"e784f2885a349332978e5f6b49f81b08cc9d1507"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"c26c2b3a206314e1714a18bc65432ac3235adb63","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        # is used for verification. We should pass cacerts\u003dTrue in this"},{"line_number":829,"context_line":"        # case. If ca_file is unset and insecure is True, there is no"},{"line_number":830,"context_line":"        # certificate verification, and we should pass cacerts\u003dFalse."},{"line_number":831,"context_line":"        cacerts \u003d ca_file if ca_file else not insecure"},{"line_number":832,"context_line":"        image_transfer.download_flat_image(context,"},{"line_number":833,"context_line":"                                           timeout,"},{"line_number":834,"context_line":"                                           image_service,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_a02bb793","line":831,"in_reply_to":"ba15a1d1_0d8d4131","updated":"2015-09-15 10:18:24.000000000","message":"hi vipin, any thoughts on this?","commit_id":"e784f2885a349332978e5f6b49f81b08cc9d1507"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c886b360314f84002987fe2f90601532f860ff56","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        # is used for verification. We should pass cacerts\u003dTrue in this"},{"line_number":829,"context_line":"        # case. If ca_file is unset and insecure is True, there is no"},{"line_number":830,"context_line":"        # certificate verification, and we should pass cacerts\u003dFalse."},{"line_number":831,"context_line":"        cacerts \u003d ca_file if ca_file else not insecure"},{"line_number":832,"context_line":"        image_transfer.download_flat_image(context,"},{"line_number":833,"context_line":"                                           timeout,"},{"line_number":834,"context_line":"                                           image_service,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_fb08802f","line":831,"in_reply_to":"ba15a1d1_a02bb793","updated":"2015-09-15 10:41:50.000000000","message":"Nikesh,\nThis is not an expensive operation which would gain by the optimization (if it is really an optimization). IMO, either way is fine.\n\nThanks.","commit_id":"e784f2885a349332978e5f6b49f81b08cc9d1507"}]}