)]}'
{"cinder/volume/drivers/san/hp/hp_lefthand_iscsi.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"06bc718c5c80b8c8d327464fd4629cb46e605f14","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    def update_migrated_volume(self, context, volume, new_volume,"},{"line_number":201,"context_line":"                               original_volume_status):"},{"line_number":202,"context_line":"        return self.proxy.update_migrated_volume(context, volume, new_volume,"},{"line_number":203,"context_line":"                                                 original_volume_status)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":206,"context_line":"        return self.proxy.manage_existing(volume, existing_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_deb91517","line":203,"updated":"2015-09-08 22:39:06.000000000","message":"Since we are making a call to the proxy, it could be the cliq version of the proxy.   We would need to add the cliq version of this as well, or we\u0027ll get an exception saying the method doesn\u0027t exist if someone configures the cliq as the proxy.","commit_id":"2268956157142d697131b45df4a4a6fbd5856a76"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"af2fcdae9a03761fa43edae372b250e41a621e59","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    def update_migrated_volume(self, context, volume, new_volume,"},{"line_number":201,"context_line":"                               original_volume_status):"},{"line_number":202,"context_line":"        return self.proxy.update_migrated_volume(context, volume, new_volume,"},{"line_number":203,"context_line":"                                                 original_volume_status)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":206,"context_line":"        return self.proxy.manage_existing(volume, existing_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_9ee07dce","line":203,"in_reply_to":"da20952f_deb91517","updated":"2015-09-08 22:49:16.000000000","message":"Done","commit_id":"2268956157142d697131b45df4a4a6fbd5856a76"}],"cinder/volume/drivers/san/hp/hp_lefthand_rest_proxy.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6d143e31e991158a7f99b129460a0c7d27a5ffaa","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        name after the migration has completed."},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"        \"\"\""},{"line_number":818,"context_line":"        LOG.debug(\"Update volume name for %(id)s\", {\u0027id\u0027: new_volume[\u0027id\u0027]})"},{"line_number":819,"context_line":"        name_id \u003d None"},{"line_number":820,"context_line":"        provider_location \u003d None"},{"line_number":821,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_aa29778b","line":818,"updated":"2015-09-09 01:18:12.000000000","message":"\u0027.\u0027 at EOL please.","commit_id":"1149a9f948ea69bfa70f8dbf2988e5f6bbf29de9"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"e7cbad78da25a656e960e00b261ed3497e15f422","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        name after the migration has completed."},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"        \"\"\""},{"line_number":818,"context_line":"        LOG.debug(\"Update volume name for %(id)s\", {\u0027id\u0027: new_volume[\u0027id\u0027]})"},{"line_number":819,"context_line":"        name_id \u003d None"},{"line_number":820,"context_line":"        provider_location \u003d None"},{"line_number":821,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_2fea3075","line":818,"in_reply_to":"da20952f_aa29778b","updated":"2015-09-09 20:13:53.000000000","message":"Done","commit_id":"1149a9f948ea69bfa70f8dbf2988e5f6bbf29de9"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6d143e31e991158a7f99b129460a0c7d27a5ffaa","unresolved":false,"context_lines":[{"line_number":827,"context_line":"                volume_info \u003d client.getVolumeByName(current_name)"},{"line_number":828,"context_line":"                volumeMods \u003d {\u0027name\u0027: original_name}"},{"line_number":829,"context_line":"                client.modifyVolume(volume_info[\u0027id\u0027], volumeMods)"},{"line_number":830,"context_line":"                LOG.info(_LI(\"Volume name changed from %(tmp)s to %(orig)s\"),"},{"line_number":831,"context_line":"                         {\u0027tmp\u0027: current_name, \u0027orig\u0027: original_name})"},{"line_number":832,"context_line":"            except Exception as e:"},{"line_number":833,"context_line":"                LOG.error(_LE(\"Changing the volume name from %(tmp)s to \""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_6a0cbf3b","line":830,"updated":"2015-09-09 01:18:12.000000000","message":"\u0027.\u0027 at EOL please.","commit_id":"1149a9f948ea69bfa70f8dbf2988e5f6bbf29de9"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"e7cbad78da25a656e960e00b261ed3497e15f422","unresolved":false,"context_lines":[{"line_number":827,"context_line":"                volume_info \u003d client.getVolumeByName(current_name)"},{"line_number":828,"context_line":"                volumeMods \u003d {\u0027name\u0027: original_name}"},{"line_number":829,"context_line":"                client.modifyVolume(volume_info[\u0027id\u0027], volumeMods)"},{"line_number":830,"context_line":"                LOG.info(_LI(\"Volume name changed from %(tmp)s to %(orig)s\"),"},{"line_number":831,"context_line":"                         {\u0027tmp\u0027: current_name, \u0027orig\u0027: original_name})"},{"line_number":832,"context_line":"            except Exception as e:"},{"line_number":833,"context_line":"                LOG.error(_LE(\"Changing the volume name from %(tmp)s to \""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_8ffb3c47","line":830,"in_reply_to":"da20952f_6a0cbf3b","updated":"2015-09-09 20:13:53.000000000","message":"Done","commit_id":"1149a9f948ea69bfa70f8dbf2988e5f6bbf29de9"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6d143e31e991158a7f99b129460a0c7d27a5ffaa","unresolved":false,"context_lines":[{"line_number":831,"context_line":"                         {\u0027tmp\u0027: current_name, \u0027orig\u0027: original_name})"},{"line_number":832,"context_line":"            except Exception as e:"},{"line_number":833,"context_line":"                LOG.error(_LE(\"Changing the volume name from %(tmp)s to \""},{"line_number":834,"context_line":"                              \"%(orig)s failed because %(reason)s\"),"},{"line_number":835,"context_line":"                          {\u0027tmp\u0027: current_name, \u0027orig\u0027: original_name,"},{"line_number":836,"context_line":"                           \u0027reason\u0027: e})"},{"line_number":837,"context_line":"                name_id \u003d new_volume[\u0027_name_id\u0027] or new_volume[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_4a077b18","line":834,"updated":"2015-09-09 01:18:12.000000000","message":"\u0027.\u0027 at EOL please.","commit_id":"1149a9f948ea69bfa70f8dbf2988e5f6bbf29de9"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"e7cbad78da25a656e960e00b261ed3497e15f422","unresolved":false,"context_lines":[{"line_number":831,"context_line":"                         {\u0027tmp\u0027: current_name, \u0027orig\u0027: original_name})"},{"line_number":832,"context_line":"            except Exception as e:"},{"line_number":833,"context_line":"                LOG.error(_LE(\"Changing the volume name from %(tmp)s to \""},{"line_number":834,"context_line":"                              \"%(orig)s failed because %(reason)s\"),"},{"line_number":835,"context_line":"                          {\u0027tmp\u0027: current_name, \u0027orig\u0027: original_name,"},{"line_number":836,"context_line":"                           \u0027reason\u0027: e})"},{"line_number":837,"context_line":"                name_id \u003d new_volume[\u0027_name_id\u0027] or new_volume[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_6f97c8eb","line":834,"in_reply_to":"da20952f_4a077b18","updated":"2015-09-09 20:13:53.000000000","message":"Done","commit_id":"1149a9f948ea69bfa70f8dbf2988e5f6bbf29de9"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"6b3255a2d91db4aab60a1cac2fc90f912f7d5607","unresolved":false,"context_lines":[{"line_number":820,"context_line":"        provider_location \u003d None"},{"line_number":821,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"},{"line_number":822,"context_line":"            # volume isn\u0027t attached and can be updated"},{"line_number":823,"context_line":"            original_name \u003d \u0027volume-\u0027 + volume[\u0027id\u0027]"},{"line_number":824,"context_line":"            current_name \u003d \u0027volume-\u0027 + new_volume[\u0027id\u0027]"},{"line_number":825,"context_line":"            client \u003d self._login()"},{"line_number":826,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_302595c1","line":823,"updated":"2015-09-10 14:10:05.000000000","message":"You can use volume[\u0027name\u0027] for this.  By hardcoding the \u0027volume-\u0027 prefix, you might be overriding any value the user may have set in CONF.volume_name_template.  See https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/models.py#L135.  CONF.volume_name_template defaults to \"volume-\".","commit_id":"370659254e17ea663bd29f5a63a8b31b8af13c33"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"223b4315aadd22091ea4d960fd2a99b1b00df0f6","unresolved":false,"context_lines":[{"line_number":820,"context_line":"        provider_location \u003d None"},{"line_number":821,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"},{"line_number":822,"context_line":"            # volume isn\u0027t attached and can be updated"},{"line_number":823,"context_line":"            original_name \u003d \u0027volume-\u0027 + volume[\u0027id\u0027]"},{"line_number":824,"context_line":"            current_name \u003d \u0027volume-\u0027 + new_volume[\u0027id\u0027]"},{"line_number":825,"context_line":"            client \u003d self._login()"},{"line_number":826,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_e000a204","line":823,"in_reply_to":"da20952f_302595c1","updated":"2015-09-10 18:04:44.000000000","message":"It seems the volume parameter that is passed into this method is a dictionary and does not have a \u0027name\u0027 property (possibly a bug?  other methods get the volume object itself which has \u0027name\u0027 accessible).  I will update it to use the CONF.volume_name_template instead of hard-coding \u0027volume-\u0027 in the next patch.","commit_id":"370659254e17ea663bd29f5a63a8b31b8af13c33"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d537faaafa269b252508e65cd4e8200b7b608041","unresolved":false,"context_lines":[{"line_number":820,"context_line":"        provider_location \u003d None"},{"line_number":821,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"},{"line_number":822,"context_line":"            # volume isn\u0027t attached and can be updated"},{"line_number":823,"context_line":"            original_name \u003d \u0027volume-\u0027 + volume[\u0027id\u0027]"},{"line_number":824,"context_line":"            current_name \u003d \u0027volume-\u0027 + new_volume[\u0027id\u0027]"},{"line_number":825,"context_line":"            client \u003d self._login()"},{"line_number":826,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_47d131fa","line":823,"in_reply_to":"da20952f_e000a204","updated":"2015-09-11 20:19:47.000000000","message":"See this patch:\n\nhttps://review.openstack.org/#/c/219566/","commit_id":"370659254e17ea663bd29f5a63a8b31b8af13c33"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"6b3255a2d91db4aab60a1cac2fc90f912f7d5607","unresolved":false,"context_lines":[{"line_number":821,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"},{"line_number":822,"context_line":"            # volume isn\u0027t attached and can be updated"},{"line_number":823,"context_line":"            original_name \u003d \u0027volume-\u0027 + volume[\u0027id\u0027]"},{"line_number":824,"context_line":"            current_name \u003d \u0027volume-\u0027 + new_volume[\u0027id\u0027]"},{"line_number":825,"context_line":"            client \u003d self._login()"},{"line_number":826,"context_line":"            try:"},{"line_number":827,"context_line":"                volume_info \u003d client.getVolumeByName(current_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_b0176553","line":824,"updated":"2015-09-10 14:10:05.000000000","message":"Ditto","commit_id":"370659254e17ea663bd29f5a63a8b31b8af13c33"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"223b4315aadd22091ea4d960fd2a99b1b00df0f6","unresolved":false,"context_lines":[{"line_number":821,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"},{"line_number":822,"context_line":"            # volume isn\u0027t attached and can be updated"},{"line_number":823,"context_line":"            original_name \u003d \u0027volume-\u0027 + volume[\u0027id\u0027]"},{"line_number":824,"context_line":"            current_name \u003d \u0027volume-\u0027 + new_volume[\u0027id\u0027]"},{"line_number":825,"context_line":"            client \u003d self._login()"},{"line_number":826,"context_line":"            try:"},{"line_number":827,"context_line":"                volume_info \u003d client.getVolumeByName(current_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_540b5324","line":824,"in_reply_to":"da20952f_b0176553","updated":"2015-09-10 18:04:44.000000000","message":"above","commit_id":"370659254e17ea663bd29f5a63a8b31b8af13c33"}]}