)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"b3e7d1288a6e0a1a999241ce83a3bdb6cf91a0b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liyingjun \u003cliyingjun1988@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-09 15:16:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes updating only volume type is_public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When updating only volume type is_public, error will be raised: `ERROR:"},{"line_number":10,"context_line":"Specify either volume type name and/or description`. Fix this by adding"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_66f5d2c9","line":7,"updated":"2015-09-09 08:36:56.000000000","message":"s/Fixes/Fix","commit_id":"9b294516a81b9b230c61cc0be0853a46b917d01d"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"b3e7d1288a6e0a1a999241ce83a3bdb6cf91a0b1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes updating only volume type is_public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When updating only volume type is_public, error will be raised: `ERROR:"},{"line_number":10,"context_line":"Specify either volume type name and/or description`. Fix this by adding"},{"line_number":11,"context_line":"check for is_public as name/description do."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4b7ece238f76d9acb7f0555c180c6336f6cf1830"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_a629aa39","line":10,"updated":"2015-09-09 08:36:56.000000000","message":"s/Fix/Fixed","commit_id":"9b294516a81b9b230c61cc0be0853a46b917d01d"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"b3e7d1288a6e0a1a999241ce83a3bdb6cf91a0b1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When updating only volume type is_public, error will be raised: `ERROR:"},{"line_number":10,"context_line":"Specify either volume type name and/or description`. Fix this by adding"},{"line_number":11,"context_line":"check for is_public as name/description do."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4b7ece238f76d9acb7f0555c180c6336f6cf1830"},{"line_number":14,"context_line":"Closes-bug: #1493616"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_a6b76af4","line":12,"updated":"2015-09-09 08:36:56.000000000","message":"We should add API Impact here. As API behavior has changed.","commit_id":"9b294516a81b9b230c61cc0be0853a46b917d01d"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"51aff5d544346e48b10847c7ff6c60e8f1c8708c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix updating only volume type is_public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When updating only volume type is_public, error will be raised: `ERROR:"},{"line_number":10,"context_line":"Specify either volume type name and/or description`. Fixed this by adding"},{"line_number":11,"context_line":"check for is_public as name/description do."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_a9b73bf4","line":10,"updated":"2015-09-09 10:16:47.000000000","message":"Subsequent lines should be wrapped at 72 characters.\nHere total 73 characters.","commit_id":"dcfd64a8321adde3cfa787cdb9ed0850eb91ce86"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d8fab334d0261ced1f0e015145caef00b335f197","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix updating only volume type is_public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When updating only volume type is_public, error will be raised: `ERROR:"},{"line_number":10,"context_line":"Specify either volume type name and/or description`. Fixed this by adding"},{"line_number":11,"context_line":"check for is_public as name/description do."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a2fa921_940f8b87","line":10,"updated":"2015-10-08 13:16:19.000000000","message":"This line should be wrapped like nikesh said in patchset 3. Thanks!","commit_id":"89eaa13af15b7a619df5f9d111cb3bfc2617575f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"e8dc0f69520f5b7bef5ba371d830d3f95509aabf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix updating only volume type is_public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When updating only volume type is_public, error will be raised: `ERROR:"},{"line_number":10,"context_line":"Specify either volume type name and/or description`. Fixed this by adding"},{"line_number":11,"context_line":"check for is_public as name/description do."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a2fa921_5759ce8c","line":10,"in_reply_to":"7a2fa921_940f8b87","updated":"2015-10-09 06:17:40.000000000","message":"Done","commit_id":"89eaa13af15b7a619df5f9d111cb3bfc2617575f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d8fab334d0261ced1f0e015145caef00b335f197","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When updating only volume type is_public, error will be raised: `ERROR:"},{"line_number":10,"context_line":"Specify either volume type name and/or description`. Fixed this by adding"},{"line_number":11,"context_line":"check for is_public as name/description do."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"Change-Id: I4b7ece238f76d9acb7f0555c180c6336f6cf1830"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a2fa921_d49c2311","line":11,"updated":"2015-10-08 13:16:19.000000000","message":"Might want to add what you are checking for exactly with is_public  to make things more verbose. Something like: \"Fixed this by adding a check that is_public is None, the same way name and description do.\"","commit_id":"89eaa13af15b7a619df5f9d111cb3bfc2617575f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"e8dc0f69520f5b7bef5ba371d830d3f95509aabf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When updating only volume type is_public, error will be raised: `ERROR:"},{"line_number":10,"context_line":"Specify either volume type name and/or description`. Fixed this by adding"},{"line_number":11,"context_line":"check for is_public as name/description do."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"Change-Id: I4b7ece238f76d9acb7f0555c180c6336f6cf1830"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a2fa921_775c0a7d","line":11,"in_reply_to":"7a2fa921_d49c2311","updated":"2015-10-09 06:17:40.000000000","message":"Done","commit_id":"89eaa13af15b7a619df5f9d111cb3bfc2617575f"}],"cinder/api/contrib/types_manage.py":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"5747823df3d0cdac83f2a425df026a125ebad44f","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if name is None and description is None and is_public is None:"},{"line_number":124,"context_line":"            msg \u003d _(\"Specify either volume type name, description \""},{"line_number":125,"context_line":"                    \"and/or is_public.\")"},{"line_number":126,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if is_public is not None and not utils.is_valid_boolstr(is_public):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_5e48a08a","line":125,"updated":"2015-09-09 02:35:59.000000000","message":"Feel this should be better: \"Specify one of volume type name ,description and is_public or both.\"","commit_id":"3e6b7a1d238dc9c4085f918fdbf557fee3fdfa24"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c024c5050966ac3bf2329d6a97683f10843d9227","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if name is None and description is None and is_public is None:"},{"line_number":124,"context_line":"            msg \u003d _(\"Specify either volume type name, description \""},{"line_number":125,"context_line":"                    \"and/or is_public.\")"},{"line_number":126,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if is_public is not None and not utils.is_valid_boolstr(is_public):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_b4d6bdef","line":125,"in_reply_to":"da20952f_5e48a08a","updated":"2015-09-09 03:47:32.000000000","message":"It\u0027s a combination of name, description and is_public, so `one of` is not accurate","commit_id":"3e6b7a1d238dc9c4085f918fdbf557fee3fdfa24"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"d89e2bb7a35a6680d92ad63055f8e940d1d05d43","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if name is None and description is None and is_public is None:"},{"line_number":124,"context_line":"            msg \u003d _(\"Specify either volume type name, description \""},{"line_number":125,"context_line":"                    \"and/or is_public.\")"},{"line_number":126,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if is_public is not None and not utils.is_valid_boolstr(is_public):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_6266f1bc","line":125,"in_reply_to":"da20952f_b4d6bdef","updated":"2015-09-10 06:38:21.000000000","message":"Emm, you\u0027re right.","commit_id":"3e6b7a1d238dc9c4085f918fdbf557fee3fdfa24"},{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"51aff5d544346e48b10847c7ff6c60e8f1c8708c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            msg \u003d _(\"Volume type name can not be empty.\")"},{"line_number":121,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if name is None and description is None and is_public is None:"},{"line_number":124,"context_line":"            msg \u003d _(\"Specify a combination of volume type name, description \""},{"line_number":125,"context_line":"                    \"and is_public.\")"},{"line_number":126,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_d2633840","line":123,"updated":"2015-09-09 10:16:47.000000000","message":"if name and description is None,  then i think there is no point  of updating a volume type with only \"is_public\" and old message is good enough","commit_id":"dcfd64a8321adde3cfa787cdb9ed0850eb91ce86"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"220c1b9aa109fae08afc81cdfa94a91f07f4d0b5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            msg \u003d _(\"Volume type name can not be empty.\")"},{"line_number":121,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if name is None and description is None and is_public is None:"},{"line_number":124,"context_line":"            msg \u003d _(\"Specify a combination of volume type name, description \""},{"line_number":125,"context_line":"                    \"and is_public.\")"},{"line_number":126,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_9871e346","line":123,"in_reply_to":"da20952f_d2633840","updated":"2015-09-29 19:37:41.000000000","message":"I disagree, I think we could be clear that you must specify \u0027name, description, is_public or a combination thereof\u0027","commit_id":"dcfd64a8321adde3cfa787cdb9ed0850eb91ce86"}]}