)]}'
{"cinder/tests/unit/volume/drivers/netapp/dataontap/test_block_base.py":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"071b73314bac1eef242d6cbfbd5cee1f9f3967fc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                       mock.Mock(return_value\u003d{\u0027Volume\u0027: \u0027FAKE_CMODE_VOL1\u0027}))"},{"line_number":92,"context_line":"    def test_get_pool(self):"},{"line_number":93,"context_line":"        pool \u003d self.library.get_pool({\u0027name\u0027: \u0027volume-fake-uuid\u0027})"},{"line_number":94,"context_line":"        self.assertEqual(pool, \u0027FAKE_CMODE_VOL1\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @mock.patch.object(block_base.NetAppBlockStorageLibrary,"},{"line_number":97,"context_line":"                       \u0027_get_lun_attr\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_f499786f","line":94,"updated":"2015-09-15 07:50:22.000000000","message":"Argument order should be (expected, actual). \u0027FAKE_CMODE_VOL1\u0027 should be first.","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c260d93b1446d2fffe88ae2f41ff181fb639ac8","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                       mock.Mock(return_value\u003d{\u0027Volume\u0027: \u0027FAKE_CMODE_VOL1\u0027}))"},{"line_number":92,"context_line":"    def test_get_pool(self):"},{"line_number":93,"context_line":"        pool \u003d self.library.get_pool({\u0027name\u0027: \u0027volume-fake-uuid\u0027})"},{"line_number":94,"context_line":"        self.assertEqual(pool, \u0027FAKE_CMODE_VOL1\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    @mock.patch.object(block_base.NetAppBlockStorageLibrary,"},{"line_number":97,"context_line":"                       \u0027_get_lun_attr\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_e47d9c6d","line":94,"in_reply_to":"ba15a1d1_f499786f","updated":"2015-09-18 19:36:34.000000000","message":"Done. Thank you!","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"}],"cinder/volume/drivers/netapp/dataontap/block_7mode.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"65cebb8b95105440241a67329a38af4df23a3e12","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            if pool_regex.match(vol_name):"},{"line_number":322,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 matches against regular \""},{"line_number":323,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":324,"context_line":"                LOG.debug(msg % {\u0027vol_name\u0027: vol_name,"},{"line_number":325,"context_line":"                                 \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":326,"context_line":"                filtered_pools.append(vol_name)"},{"line_number":327,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_087b2529","line":324,"updated":"2015-09-17 19:07:07.000000000","message":"The same as below","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c260d93b1446d2fffe88ae2f41ff181fb639ac8","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            if pool_regex.match(vol_name):"},{"line_number":322,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 matches against regular \""},{"line_number":323,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":324,"context_line":"                LOG.debug(msg % {\u0027vol_name\u0027: vol_name,"},{"line_number":325,"context_line":"                                 \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":326,"context_line":"                filtered_pools.append(vol_name)"},{"line_number":327,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_04f1b06a","line":324,"in_reply_to":"ba15a1d1_087b2529","updated":"2015-09-18 19:36:34.000000000","message":"Done. Thank you!","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"65cebb8b95105440241a67329a38af4df23a3e12","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            else:"},{"line_number":328,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 does not match against regular \""},{"line_number":329,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":330,"context_line":"                LOG.debug(msg % {\u0027vol_name\u0027: vol_name,"},{"line_number":331,"context_line":"                                 \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        return filtered_pools"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_4884bd09","line":330,"updated":"2015-09-17 19:07:07.000000000","message":"Please, change % \u003d\u003e ,","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c260d93b1446d2fffe88ae2f41ff181fb639ac8","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            else:"},{"line_number":328,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 does not match against regular \""},{"line_number":329,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":330,"context_line":"                LOG.debug(msg % {\u0027vol_name\u0027: vol_name,"},{"line_number":331,"context_line":"                                 \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        return filtered_pools"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_c4e658af","line":330,"in_reply_to":"ba15a1d1_4884bd09","updated":"2015-09-18 19:36:34.000000000","message":"Done","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8808a8352615f35c5ea7876c8c1d1cf372bb21ee","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        for vol in self.vols:"},{"line_number":329,"context_line":"            vol_name \u003d vol.get_child_content(\u0027name\u0027)"},{"line_number":330,"context_line":"            if pool_regex.match(vol_name):"},{"line_number":331,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 matches against regular \""},{"line_number":332,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":333,"context_line":"                LOG.debug(msg, {\u0027vol_name\u0027: vol_name,"},{"line_number":334,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_aa92d4f4","line":331,"updated":"2015-09-21 14:49:44.000000000","message":"LOG.debug level messages should not have _() translation. Leave them as bare strings.","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9afc7984c386928e9492948951ade9a96db0c47b","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        for vol in self.vols:"},{"line_number":329,"context_line":"            vol_name \u003d vol.get_child_content(\u0027name\u0027)"},{"line_number":330,"context_line":"            if pool_regex.match(vol_name):"},{"line_number":331,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 matches against regular \""},{"line_number":332,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":333,"context_line":"                LOG.debug(msg, {\u0027vol_name\u0027: vol_name,"},{"line_number":334,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_e9d45748","line":331,"in_reply_to":"ba15a1d1_aa92d4f4","updated":"2015-09-21 16:18:07.000000000","message":"Done. Thanks Sean.","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8808a8352615f35c5ea7876c8c1d1cf372bb21ee","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":335,"context_line":"                filtered_pools.append(vol_name)"},{"line_number":336,"context_line":"            else:"},{"line_number":337,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 does not match against regular \""},{"line_number":338,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":339,"context_line":"                LOG.debug(msg, {\u0027vol_name\u0027: vol_name,"},{"line_number":340,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_8ac030e2","line":337,"updated":"2015-09-21 14:49:44.000000000","message":"Same.","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9afc7984c386928e9492948951ade9a96db0c47b","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":335,"context_line":"                filtered_pools.append(vol_name)"},{"line_number":336,"context_line":"            else:"},{"line_number":337,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 does not match against regular \""},{"line_number":338,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":339,"context_line":"                LOG.debug(msg, {\u0027vol_name\u0027: vol_name,"},{"line_number":340,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_89c91baf","line":337,"in_reply_to":"ba15a1d1_8ac030e2","updated":"2015-09-21 16:18:07.000000000","message":"Done","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"}],"cinder/volume/drivers/netapp/dataontap/block_cmode.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"65cebb8b95105440241a67329a38af4df23a3e12","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            if pool_regex.match(vol_name):"},{"line_number":264,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 matches against regular \""},{"line_number":265,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":266,"context_line":"                LOG.debug(msg % {\u0027vol_name\u0027: vol_name,"},{"line_number":267,"context_line":"                                 \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":268,"context_line":"                filtered_pools.append(vol)"},{"line_number":269,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_a8ac798c","line":266,"updated":"2015-09-17 19:07:07.000000000","message":"Please, change % \u003d\u003e ,","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c260d93b1446d2fffe88ae2f41ff181fb639ac8","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            if pool_regex.match(vol_name):"},{"line_number":264,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 matches against regular \""},{"line_number":265,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":266,"context_line":"                LOG.debug(msg % {\u0027vol_name\u0027: vol_name,"},{"line_number":267,"context_line":"                                 \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":268,"context_line":"                filtered_pools.append(vol)"},{"line_number":269,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_8405c046","line":266,"in_reply_to":"ba15a1d1_a8ac798c","updated":"2015-09-18 19:36:34.000000000","message":"Done","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"65cebb8b95105440241a67329a38af4df23a3e12","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            else:"},{"line_number":270,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 does not match against regular \""},{"line_number":271,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":272,"context_line":"                LOG.debug(msg % {\u0027vol_name\u0027: vol_name,"},{"line_number":273,"context_line":"                                 \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        return filtered_pools"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_c8a76da5","line":272,"updated":"2015-09-17 19:07:07.000000000","message":"Please, change % \u003d\u003e ,","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c260d93b1446d2fffe88ae2f41ff181fb639ac8","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            else:"},{"line_number":270,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 does not match against regular \""},{"line_number":271,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":272,"context_line":"                LOG.debug(msg % {\u0027vol_name\u0027: vol_name,"},{"line_number":273,"context_line":"                                 \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        return filtered_pools"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_a4000435","line":272,"in_reply_to":"ba15a1d1_c8a76da5","updated":"2015-09-18 19:36:34.000000000","message":"Done","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8808a8352615f35c5ea7876c8c1d1cf372bb21ee","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        for vol in self.ssc_vols.get(\u0027all\u0027, []):"},{"line_number":262,"context_line":"            vol_name \u003d vol.id[\u0027name\u0027]"},{"line_number":263,"context_line":"            if pool_regex.match(vol_name):"},{"line_number":264,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 matches against regular \""},{"line_number":265,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":266,"context_line":"                LOG.debug(msg, {\u0027vol_name\u0027: vol_name,"},{"line_number":267,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_0a7420cd","line":264,"updated":"2015-09-21 14:49:44.000000000","message":"Remove _().","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9afc7984c386928e9492948951ade9a96db0c47b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        for vol in self.ssc_vols.get(\u0027all\u0027, []):"},{"line_number":262,"context_line":"            vol_name \u003d vol.id[\u0027name\u0027]"},{"line_number":263,"context_line":"            if pool_regex.match(vol_name):"},{"line_number":264,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 matches against regular \""},{"line_number":265,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":266,"context_line":"                LOG.debug(msg, {\u0027vol_name\u0027: vol_name,"},{"line_number":267,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_29bb2f10","line":264,"in_reply_to":"ba15a1d1_0a7420cd","updated":"2015-09-21 16:18:07.000000000","message":"Done","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8808a8352615f35c5ea7876c8c1d1cf372bb21ee","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":268,"context_line":"                filtered_pools.append(vol)"},{"line_number":269,"context_line":"            else:"},{"line_number":270,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 does not match against regular \""},{"line_number":271,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":272,"context_line":"                LOG.debug(msg, {\u0027vol_name\u0027: vol_name,"},{"line_number":273,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_aa80948c","line":270,"updated":"2015-09-21 14:49:44.000000000","message":"Remove _().","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9afc7984c386928e9492948951ade9a96db0c47b","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"},{"line_number":268,"context_line":"                filtered_pools.append(vol)"},{"line_number":269,"context_line":"            else:"},{"line_number":270,"context_line":"                msg \u003d _(\"Volume \u0027%(vol_name)s\u0027 does not match against regular \""},{"line_number":271,"context_line":"                        \"expression: %(vol_pattern)s\")"},{"line_number":272,"context_line":"                LOG.debug(msg, {\u0027vol_name\u0027: vol_name,"},{"line_number":273,"context_line":"                                \u0027vol_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_e93bf79a","line":270,"in_reply_to":"ba15a1d1_aa80948c","updated":"2015-09-21 16:18:07.000000000","message":"Done","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"}],"cinder/volume/drivers/netapp/eseries/library.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"65cebb8b95105440241a67329a38af4df23a3e12","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                msg \u003d _(\"Pool \u0027%(pool_name)s\u0027 matches against regular \""},{"line_number":1139,"context_line":"                        \"expression: %(pool_pattern)s\")"},{"line_number":1140,"context_line":"                LOG.debug(msg % {\u0027pool_name\u0027: pool_name,"},{"line_number":1141,"context_line":"                                 \u0027pool_pattern\u0027: pool_regex.pattern})"},{"line_number":1142,"context_line":"                filtered_pools.append(pool)"},{"line_number":1143,"context_line":"            else:"},{"line_number":1144,"context_line":"                msg \u003d _(\"Pool \u0027%(pool_name)s\u0027 does not match against regular \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_28af097e","line":1141,"updated":"2015-09-17 19:07:07.000000000","message":"Please, change % \u003d\u003e ,","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c260d93b1446d2fffe88ae2f41ff181fb639ac8","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                msg \u003d _(\"Pool \u0027%(pool_name)s\u0027 matches against regular \""},{"line_number":1139,"context_line":"                        \"expression: %(pool_pattern)s\")"},{"line_number":1140,"context_line":"                LOG.debug(msg % {\u0027pool_name\u0027: pool_name,"},{"line_number":1141,"context_line":"                                 \u0027pool_pattern\u0027: pool_regex.pattern})"},{"line_number":1142,"context_line":"                filtered_pools.append(pool)"},{"line_number":1143,"context_line":"            else:"},{"line_number":1144,"context_line":"                msg \u003d _(\"Pool \u0027%(pool_name)s\u0027 does not match against regular \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_d4d59b1b","line":1141,"in_reply_to":"ba15a1d1_28af097e","updated":"2015-09-18 19:36:34.000000000","message":"Done","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"65cebb8b95105440241a67329a38af4df23a3e12","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"                filtered_pools.append(pool)"},{"line_number":1143,"context_line":"            else:"},{"line_number":1144,"context_line":"                msg \u003d _(\"Pool \u0027%(pool_name)s\u0027 does not match against regular \""},{"line_number":1145,"context_line":"                        \"expression: %(pool_pattern)s\")"},{"line_number":1146,"context_line":"                LOG.debug(msg % {\u0027pool_name\u0027: pool_name,"},{"line_number":1147,"context_line":"                                 \u0027pool_pattern\u0027: pool_regex.pattern})"},{"line_number":1148,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_48b27de6","line":1145,"updated":"2015-09-17 19:07:07.000000000","message":"Please, change % \u003d\u003e ,","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c260d93b1446d2fffe88ae2f41ff181fb639ac8","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"                filtered_pools.append(pool)"},{"line_number":1143,"context_line":"            else:"},{"line_number":1144,"context_line":"                msg \u003d _(\"Pool \u0027%(pool_name)s\u0027 does not match against regular \""},{"line_number":1145,"context_line":"                        \"expression: %(pool_pattern)s\")"},{"line_number":1146,"context_line":"                LOG.debug(msg % {\u0027pool_name\u0027: pool_name,"},{"line_number":1147,"context_line":"                                 \u0027pool_pattern\u0027: pool_regex.pattern})"},{"line_number":1148,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_f4d8df54","line":1145,"in_reply_to":"ba15a1d1_48b27de6","updated":"2015-09-18 19:36:34.000000000","message":"Done","commit_id":"a1aecf498ed0d5e3adf00c53d62fe538f0f7dbc0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8808a8352615f35c5ea7876c8c1d1cf372bb21ee","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"            pool_name \u003d pool[\u0027label\u0027]"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"            if pool_regex.match(pool_name):"},{"line_number":1145,"context_line":"                msg \u003d _(\"Pool \u0027%(pool_name)s\u0027 matches against regular \""},{"line_number":1146,"context_line":"                        \"expression: %(pool_pattern)s\")"},{"line_number":1147,"context_line":"                LOG.debug(msg, {\u0027pool_name\u0027: pool_name,"},{"line_number":1148,"context_line":"                                \u0027pool_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_65fe2d07","line":1145,"updated":"2015-09-21 14:49:44.000000000","message":"Remove _().","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9afc7984c386928e9492948951ade9a96db0c47b","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"            pool_name \u003d pool[\u0027label\u0027]"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"            if pool_regex.match(pool_name):"},{"line_number":1145,"context_line":"                msg \u003d _(\"Pool \u0027%(pool_name)s\u0027 matches against regular \""},{"line_number":1146,"context_line":"                        \"expression: %(pool_pattern)s\")"},{"line_number":1147,"context_line":"                LOG.debug(msg, {\u0027pool_name\u0027: pool_name,"},{"line_number":1148,"context_line":"                                \u0027pool_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_a945ff17","line":1145,"in_reply_to":"ba15a1d1_65fe2d07","updated":"2015-09-21 16:18:07.000000000","message":"Done","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8808a8352615f35c5ea7876c8c1d1cf372bb21ee","unresolved":false,"context_lines":[{"line_number":1148,"context_line":"                                \u0027pool_pattern\u0027: pool_regex.pattern})"},{"line_number":1149,"context_line":"                filtered_pools.append(pool)"},{"line_number":1150,"context_line":"            else:"},{"line_number":1151,"context_line":"                msg \u003d _(\"Pool \u0027%(pool_name)s\u0027 does not match against regular \""},{"line_number":1152,"context_line":"                        \"expression: %(pool_pattern)s\")"},{"line_number":1153,"context_line":"                LOG.debug(msg, {\u0027pool_name\u0027: pool_name,"},{"line_number":1154,"context_line":"                                \u0027pool_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_25083528","line":1151,"updated":"2015-09-21 14:49:44.000000000","message":"Remove _().","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9afc7984c386928e9492948951ade9a96db0c47b","unresolved":false,"context_lines":[{"line_number":1148,"context_line":"                                \u0027pool_pattern\u0027: pool_regex.pattern})"},{"line_number":1149,"context_line":"                filtered_pools.append(pool)"},{"line_number":1150,"context_line":"            else:"},{"line_number":1151,"context_line":"                msg \u003d _(\"Pool \u0027%(pool_name)s\u0027 does not match against regular \""},{"line_number":1152,"context_line":"                        \"expression: %(pool_pattern)s\")"},{"line_number":1153,"context_line":"                LOG.debug(msg, {\u0027pool_name\u0027: pool_name,"},{"line_number":1154,"context_line":"                                \u0027pool_pattern\u0027: pool_regex.pattern})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_6948472e","line":1151,"in_reply_to":"ba15a1d1_25083528","updated":"2015-09-21 16:18:07.000000000","message":"Done","commit_id":"670cff22f1bb1b028b2010b04fd5976b558f9583"}],"cinder/volume/drivers/netapp/options.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a5a801d992a9fc10d1e4551afd4cc84926286a3b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                       \u0027is deprecated and will be removed in favor of \u0027"},{"line_number":82,"context_line":"                       \u0027\"reserved_percentage\" in the Mitaka release.\u0027)),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027netapp_volume_list\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"},{"line_number":85,"context_line":"               help\u003d(\u0027This option is only utilized when the storage protocol \u0027"},{"line_number":86,"context_line":"                     \u0027is configured to use iSCSI or FC. This option is used \u0027"},{"line_number":87,"context_line":"                     \u0027to restrict provisioning to the specified controller \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_351de766","side":"PARENT","line":84,"updated":"2015-09-13 06:44:43.000000000","message":"Isn\u0027t getting rid of these a back-compatibility break? What if a user already has these configured, their system working, and they upgrade?","commit_id":"8e63f4da54bd28a837f2feee115b6c3db3262a2d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c288f872531eadfc0cb963d36808d12c9b1dc3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                       \u0027is deprecated and will be removed in favor of \u0027"},{"line_number":82,"context_line":"                       \u0027\"reserved_percentage\" in the Mitaka release.\u0027)),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027netapp_volume_list\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"},{"line_number":85,"context_line":"               help\u003d(\u0027This option is only utilized when the storage protocol \u0027"},{"line_number":86,"context_line":"                     \u0027is configured to use iSCSI or FC. This option is used \u0027"},{"line_number":87,"context_line":"                     \u0027to restrict provisioning to the specified controller \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_6a1db965","side":"PARENT","line":84,"in_reply_to":"ba15a1d1_351de766","updated":"2015-09-14 03:10:36.000000000","message":"Hi Duncan, these options aren\u0027t removed. They\u0027re deprecated. We\u0027re maintaining backwards compatibility. If you look on lines 190-191, you will see both these options listed as deprecated.","commit_id":"8e63f4da54bd28a837f2feee115b6c3db3262a2d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c260d93b1446d2fffe88ae2f41ff181fb639ac8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                       \u0027is deprecated and will be removed in favor of \u0027"},{"line_number":82,"context_line":"                       \u0027\"reserved_percentage\" in the Mitaka release.\u0027)),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027netapp_volume_list\u0027,"},{"line_number":84,"context_line":"               default\u003dNone,"},{"line_number":85,"context_line":"               help\u003d(\u0027This option is only utilized when the storage protocol \u0027"},{"line_number":86,"context_line":"                     \u0027is configured to use iSCSI or FC. This option is used \u0027"},{"line_number":87,"context_line":"                     \u0027to restrict provisioning to the specified controller \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_a47564cb","side":"PARENT","line":84,"in_reply_to":"ba15a1d1_6a1db965","updated":"2015-09-18 19:36:34.000000000","message":"I\u0027ve included warnings in Patchset 2, within the code. Thank you for the feedback.","commit_id":"8e63f4da54bd28a837f2feee115b6c3db3262a2d"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a5a801d992a9fc10d1e4551afd4cc84926286a3b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"               help\u003d(\u0027Password for the NetApp E-Series storage array.\u0027),"},{"line_number":166,"context_line":"               secret\u003dTrue),"},{"line_number":167,"context_line":"    cfg.StrOpt(\u0027netapp_storage_pools\u0027,"},{"line_number":168,"context_line":"               default\u003dNone,"},{"line_number":169,"context_line":"               help\u003d(\u0027This option is used to restrict provisioning to the \u0027"},{"line_number":170,"context_line":"                     \u0027specified storage pools. Only dynamic disk pools are \u0027"},{"line_number":171,"context_line":"                     \u0027currently supported. Specify the value of this option to\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_551adb6f","side":"PARENT","line":168,"updated":"2015-09-13 06:44:43.000000000","message":"See above","commit_id":"8e63f4da54bd28a837f2feee115b6c3db3262a2d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c260d93b1446d2fffe88ae2f41ff181fb639ac8","unresolved":false,"context_lines":[{"line_number":165,"context_line":"               help\u003d(\u0027Password for the NetApp E-Series storage array.\u0027),"},{"line_number":166,"context_line":"               secret\u003dTrue),"},{"line_number":167,"context_line":"    cfg.StrOpt(\u0027netapp_storage_pools\u0027,"},{"line_number":168,"context_line":"               default\u003dNone,"},{"line_number":169,"context_line":"               help\u003d(\u0027This option is used to restrict provisioning to the \u0027"},{"line_number":170,"context_line":"                     \u0027specified storage pools. Only dynamic disk pools are \u0027"},{"line_number":171,"context_line":"                     \u0027currently supported. Specify the value of this option to\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_647bccbe","side":"PARENT","line":168,"in_reply_to":"ba15a1d1_551adb6f","updated":"2015-09-18 19:36:34.000000000","message":"Done","commit_id":"8e63f4da54bd28a837f2feee115b6c3db3262a2d"}]}